From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6262BC61DA3 for ; Fri, 24 Feb 2023 11:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CC996B0072; Fri, 24 Feb 2023 06:46:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87CC06B0073; Fri, 24 Feb 2023 06:46:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76BBC6B0074; Fri, 24 Feb 2023 06:46:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 685DA6B0072 for ; Fri, 24 Feb 2023 06:46:15 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2753F14195C for ; Fri, 24 Feb 2023 11:46:15 +0000 (UTC) X-FDA: 80502007110.15.D2C737B Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf03.hostedemail.com (Postfix) with ESMTP id 0CAA620009 for ; Fri, 24 Feb 2023 11:46:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=aA+1bgzg; spf=temperror (imf03.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 80E8A1EC0723; Fri, 24 Feb 2023 12:46:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1677239162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=OSDHzpRiPKXFuKbj/ntPOkDODEh8hWASFyXRMMoKKPg=; b=aA+1bgzgnvaLFpgSuz1deBeWtCAEBmlV7GEzr7ZA4Mp69V9HXC6O2/Ul+Pfxkyh4rVX5fc n3kDrsTIKdr7MJGhF4cuP0UpC14Urlzpbs+vc6PJC4x5S5P+o+Bmw0KsEqIkEtE1ARcMxk ahkS3utYulVNwD95M9K9ipo0UizTrH4= Date: Fri, 24 Feb 2023 12:45:57 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v6 37/41] selftests/x86: Add shadow stack test Message-ID: References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-38-rick.p.edgecombe@intel.com> <5fe0874655a7190a6ea5a070584d2603522f4395.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5fe0874655a7190a6ea5a070584d2603522f4395.camel@intel.com> X-Rspam-User: X-Rspamd-Queue-Id: 0CAA620009 X-Rspamd-Server: rspam01 X-Stat-Signature: m9ifcfamyyyhirb1euqxa3ppqayk8cpa X-HE-Tag: 1677239164-209140 X-HE-Meta: U2FsdGVkX19QfKQ3WOyf4oMBUWodjUv4Zrs4MSeF4CkI/eFfGqoT/eSJkH2tOlzEsh8Vb9F3xIw2ORYDJjm5M0pLH65ooYiJEX6r7Ctfy9PCyNaprOVBVpl1jCjgfE5rVbh3ErrVG1K7Ae3w3WHHKzCb1XrEvPYMe+iprpqijJx0EgYAiIi8T7f9MBHDeA3t1vyMYcZm0eoRulCKiDY8I43B4OhnAJQlWPrq+x7CNL5CnYyFaSJS88HhyYtiZcolzxlYVhgvks7nneuKfMMBRYcAkgeZX06Npqys4PucPB5eG2lKzvs9zg2xfH4hPoq1QEDTDrCNsYHZq3BXpQNeWpmeKBpJnuh2l5c+5U14Fw4ACF7WJBrmDjGkovEDi+p0NImL3GVTzd3dWM+zk+ZKN+lafq9gsPgAMCSfPxQ5M9P5EiQ73J84fllE7wZZq37H7pwgWspXJSd3qvnLhOnZ04m2FbJPn0yIjB1l2g3MUbKpHfeDXMCw9/r0jR8/TyN/UeYZMoj9fraJNUg4nBYj6OdG27Zxi5BA6uzQcOhy1iL28eNTo8V8OX7+U0FSxTL+hyDGKTXQoPjp38nUzalyvlh/NzvGhGjbupsxQIYfFzRC2YlJjlPFdBUngLODh/las0+6Yao/NxgTb7Enqvq/r4abLDB3hRo2xPl3/XcYQpSTgA+aeNHj32WWKv8YOxYa5tk9YSUHybwwJNRglXQSDDtb23sQlRov16gXv8rrT7YlZkW23pIEcHIqivNjYDHQtO/716dnLDbYunwXfnTqzDEIZK8THnAcoILZov1kYqYUnMzdpEVvptdcNaBUU6vwea8vXAo6e7RiFaNYH1nXS43K/1bsAAm4JQpLZUrL+OpU+B9xQvnIvFs885sq30UVy/7tU0Qrtu5oprPyAUv4ow4MDFIA2jtSWDPEGa5uoH7KgGGm+CW+OJ44az5W5kaYCNdYIpjsUE9qS4gqoo0 JkTidL/L 520YY/4p7uVHPIe9MYq4t39/yIm6TwTUBu5W1YFFLjhjET3U3+CCgDlLxhLgZhWUTVGRnofDjxMqCnlVspTVxU9/1pMIZs3KEXrpY4IRURgKjkm7PNnBchxYYtzscrCgDcCHPCooCMn4dcphM+wPUpnmyeSn3sALYM7FHKodiO0m1Muw01YAB9oyZ4QhMl0JtJEm60jTE0CMQahOrS8txGl334T3+27wfzjvPhd5gpTywbApJnGRdA1UdWWdwj3TTdSEJNCu+Y/tIPRBjFqSn+bUOFuGU9fxBoPJPSENNihw5/p91WmjHhrNMbFJHavRKQ/pLGNBjpefe8ro= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 05:54:55PM +0000, Edgecombe, Rick P wrote: > The proposed Makefile solution seems a bit unusual. What about this > less complicated solution to just make this case work? I like simple. :) > So alternatively, why not just always encourage building the headers > before running the selftests by warning if > ${abs_srctree}/usr/include/linux is not found? s/encourage/automate/ Imagine this situation: maintainer says: "please run the selftests". User says, "uh oh, it fails building, I need to figure that out first." So we should not have users have to figure out stuff if we can code it to happen automatically for the default case. If they want something special, then they can do all the figuring out they want. :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette