From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF01C64ED6 for ; Thu, 23 Feb 2023 23:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 535246B0072; Thu, 23 Feb 2023 18:11:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BDC76B0073; Thu, 23 Feb 2023 18:11:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35E656B0074; Thu, 23 Feb 2023 18:11:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23E286B0072 for ; Thu, 23 Feb 2023 18:11:33 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F36DE14044F for ; Thu, 23 Feb 2023 23:11:32 +0000 (UTC) X-FDA: 80500105224.20.EC03592 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf25.hostedemail.com (Postfix) with ESMTP id 1FBB4A000E for ; Thu, 23 Feb 2023 23:11:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FVvpdyBX; spf=pass (imf25.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677193891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMPTwn6A1SJ1IFAEdre49nDDwVXbknbqks5KCgESScg=; b=aeneTlvmAn1fFetyO7x3wcGk77aeNtbkhmqPM9J3mCVDdQdbsOzAX6+wDGLG2GaHQr7aU1 I/1rfFbpLUHf+Bq/TcweEfBUGn7qBPgT2jEClYA+OOkyohxan1OF/oQOAJkAzClOgRlHB9 1QWWKFidX1E3x+yITr2w0fq+QQ0ZYGs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FVvpdyBX; spf=pass (imf25.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677193891; a=rsa-sha256; cv=none; b=wohIV2CxaKYIOxZZOE//Q88LPWleYkkdHH+6LacVNJQ9Ufr6GnKSFl4YiPjWLlDM0Q6ea3 yuyTp7R1a5bFdlbHrSMkKzu8XdAWiL9hgw+QQRRHj5SkmJWqfESEGY5xLF8MT+m8uSxKoo /4LogO4EliiD43qxtRNIMn3gxXlfGT8= Received: by mail-pj1-f52.google.com with SMTP id x34so11227898pjj.0 for ; Thu, 23 Feb 2023 15:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677193890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ZMPTwn6A1SJ1IFAEdre49nDDwVXbknbqks5KCgESScg=; b=FVvpdyBXZvuPwD2DHr3E2e4M11bO2iyWULgET72pY/dqODfAzGkwrghbnLPa6U0gic 4XQ97gMXC2btoOwB1tfzjNrG5eKtyJHSAL4VDP/Ltpe3y80GVwWAOGyOyzo0JCC6tUO7 Z4X6WA+NRxsWEln/Jrf5a7SvdiRaQE+lgd30JiWR04CSzUr6cEUMqBsHCLqqvQI2Fhzc MPidMqO2dtPeXht9yCJGgRbt4Aga9+HvQCy8Px0ZFO0QjOFdfRvVmWJE8Rjl1P6bxYKR FKBMtSOgbs1wQCfkR6cxla4lYWVNI8CmVHOIV3Vg5tY33gCJOrjuAtXpBTZwEe80VrfK rBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677193890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZMPTwn6A1SJ1IFAEdre49nDDwVXbknbqks5KCgESScg=; b=cgSQNu4medE9Od/uoGjdwDB6hoEfxtI0UC0mphVDj6vtfadLKVQP3Rqd6e7NjUs8Nb nzcgfLtKEsPrkq4LmXYF5Sf7pPbeTAaHP/NrW8fRQ+tufhqY0JokW8mg+fG+hj/StmTZ trHH+SLIuIab4sWGMjYuHjlOmnSowgqMrCDINpJm9H+7ba/aLs00KiguvhkemsRAE5Yl K25JymQg3nBixbMS+n5v099/vjGVAOl9chETOIslOV3g1vVSxrCv76OkmtHgef0I5zaF g6pgyuop91t/h5vnj2QGJ8JJBTDmTXgYPt0dSJ75jCZtNY0w/CA2qRhMN964BgfRX0iv v68Q== X-Gm-Message-State: AO0yUKVWXVwMlkhppXjFYLa+gXorRPOOoIa4Mpoz2REYcA0nkZOSYOzx 4thBe9JMX09IOREOM8TIhPQ= X-Google-Smtp-Source: AK7set9GZqJGj4EAL6Agk48dPwa/lldbWp0ErKJKTubGj6DHDIKo/TWBCeW7Oanq/NRfGRS7Dis/2g== X-Received: by 2002:a17:90b:1e02:b0:233:af77:c075 with SMTP id pg2-20020a17090b1e0200b00233af77c075mr14177342pjb.36.1677193889885; Thu, 23 Feb 2023 15:11:29 -0800 (PST) Received: from google.com ([2620:15c:211:201:be5:a687:1e9d:ec53]) by smtp.gmail.com with ESMTPSA id i9-20020a17090a2a0900b00230b572e90csm223340pjd.35.2023.02.23.15.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 15:11:29 -0800 (PST) Date: Thu, 23 Feb 2023 15:11:27 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 2/6] zsmalloc: remove stat and fullness enums Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230223030451.543162-3-senozhatsky@chromium.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1FBB4A000E X-Stat-Signature: i111858sq5k3o9fnf9sjygtpku7bkgko X-HE-Tag: 1677193890-493878 X-HE-Meta: U2FsdGVkX18+tk0K//uhQ+nnij19yW4Mc6AXbyDrF+GDZUHEolCBg3ZPg1Vp0wxqEb4Cl0Ol9m4TT0RdmDisGwb5n2spi6Mjt6fnOOmDJtPo6LcVywfLiOB+ASWd/YVot6mb5+YD9SeLiQan9rKgVzSkffZ1eoUxQTjODGMFoKOE05Vi4YhWoxmC1C1XZk5Z9I9aneS7sg2XUBB5qn5oDt1eeDfe05HZU0CDrK4mc5vDeM2BxSzn+/1lm+iVycAji6r20k/WT6V1lkD8YxFMI7PLZBf+/l3Gri8LxuMfrWg54AvIQ3rzyVVteNH3pnqQFChc12sY4ooTVgsc4hY1G23x2BSO3hBYdGaR4vM0DKhkfI+8W53Un9mTqesKHTLPVIii78HSPntXuzTg/dU3ay7Otz+PtIh/3tzZXx1Sd1XSV0G682jbBBwpg7TpygTbNioqz4XmNiVmHnx42DXqwGIk7IJ5vxLOfpFYG4Zk9UKlpiLY83/k1GF/iQr2Z+iCbuk2tKMUYEjeC+ZTPDIaBO48jFnYiEEFJzVWVQ1lMC91KdyBAMv20x7471IbGh6oUmc8BYcrhVUNQhSMpGk6TTZYswQCO0T2vHTUKlTvIGHenEqN4X6eJEXiJXgiZOKt7gIGd4m0cF+gMNVPu8QgGla9LixQ8jB3OgnbdtJl2PcXqboLac26ZSQ0RXHczGZMXngv5trkrPB7gTmICzv+f6updXuTY1L++krnu0JOUvx4b5V+DSEKDV3n+WLe3dUiECrIpqSVEZZV8/WWojmIwM0NFa15UKqZBM4JHAxTvW4Bwq86Z0JAujJltJm05nl56lPOrVX4y0tWomgBtdwp1gAYrMpei7BtreiOM2Tpt2oUBMjlspXRKG517FzVKew/4uK7G2TgWsoIh0/+qihLVXKZmr2wncK6ML46xqoaZ1y9SXY6oO0Wcw8maV1wUlqHSXHODj/MfknezZSx+gE AGTADvS/ XJZ6uyaXbwOMK4vILJxWqqZAVza9xGrpHLLoMaSDeAUF8a5CLz6AE1vLblbwuUU06aDbY9OSFTBpeg8bQRMQbRfmBnparJYCIkeF8CttK0574outZjMnyYnNzCwnb5gp6PtBzKXNTxlCwzvP8uvg6w2C8x8mPO7a2pTgRQGtlpCe31URn5dcOe27BUehnB9uOs5RdHwg5pUL/U5Ebzl8QWrsDw4Penut/1bARMvuaPUzVAw/s0KotdGOvmAp4pmh1dGfkWHynaEBO7mmLmfz6ME9xnYxj1MvIrqSUSMR8Yup4NxCf7uH7XZbRla2YQetiBnjLSaOrAabLNsG3P/Z7qkwj7N0MqkPqXJ1zGWre2T0VemwYpL+oxLVvAUpHinn71gwdxejqbw3l6fOl3fqaoi0jaE03zn8wh8MtFqoOHlTUjuMWSngiuykiDDyPIT6wnfns32W0FJMRie8XC0S4CoMM7azgtfV9zBeIvB//QEbdEWM26dmQFNOxPXmLO5waahWF2kkzvuKPr24XUEIjUI3Q4fIPirfMfO0hdZi4HJDr/mhwEG7VcF7lfKIUqy6cUmvgKXN5Uv673IfJXq1HObBqdwBCt898ckPpqvo6oruJg3quzKq3Ox8rUz68j8rSvOD7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 12:04:47PM +0900, Sergey Senozhatsky wrote: > The fullness_group enum is nested (sub-enum) within the > class_stat_type enum. zsmalloc requires the values in both > enums to match, because zsmalloc passes these values to > generic functions, e.g. class_stat_inc() and class_stat_dec(), > after casting them to integers. > > Replace these enums (and enum nesting) and use simple defines > instead. Also rename some of zsmalloc stats defines, as they > sort of clash with zspage object tags. > > Suggested-by: Yosry Ahmed > Signed-off-by: Sergey Senozhatsky > --- > mm/zsmalloc.c | 104 ++++++++++++++++++++++---------------------------- > 1 file changed, 45 insertions(+), 59 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index b57a89ed6f30..38ae8963c0eb 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -159,26 +159,18 @@ > #define ZS_SIZE_CLASSES (DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE, \ > ZS_SIZE_CLASS_DELTA) + 1) > > -enum fullness_group { > - ZS_EMPTY, > - ZS_ALMOST_EMPTY, > - ZS_ALMOST_FULL, > - ZS_FULL, > - NR_ZS_FULLNESS, > -}; > +#define ZS_EMPTY 0 > +#define ZS_ALMOST_EMPTY 1 > +#define ZS_ALMOST_FULL 2 > +#define ZS_FULL 3 > +#define ZS_OBJS_ALLOCATED 4 > +#define ZS_OBJS_INUSE 5 > > -enum class_stat_type { > - CLASS_EMPTY, > - CLASS_ALMOST_EMPTY, > - CLASS_ALMOST_FULL, > - CLASS_FULL, > - OBJ_ALLOCATED, > - OBJ_USED, > - NR_ZS_STAT_TYPE, > -}; > +#define NR_ZS_STAT 6 > +#define NR_ZS_FULLNESS 4 Using define list instead of enum list looks like going backward. :) Why can't we do this? enum class_stat_type { ZS_EMPTY, ZS_ALMOST_EMPTY, ZS_ALMOST_FULL, ZS_FULL, NR_ZS_FULLNESS, ZS_OBJ_ALLOCATED = NR_ZS_FULLNESS, ZS_OBJ_USED, NR_ZS_STAT, } }; > > struct zs_size_stat { > - unsigned long objs[NR_ZS_STAT_TYPE]; > + unsigned long objs[NR_ZS_STAT]; > }; >