From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1CEC64ED8 for ; Thu, 23 Feb 2023 22:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FB0F6B0073; Thu, 23 Feb 2023 17:00:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB736B0074; Thu, 23 Feb 2023 17:00:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDC406B0075; Thu, 23 Feb 2023 17:00:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E0EE06B0073 for ; Thu, 23 Feb 2023 17:00:17 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 972F5807A5 for ; Thu, 23 Feb 2023 22:00:17 +0000 (UTC) X-FDA: 80499925674.05.E88541C Received: from out-26.mta1.migadu.com (out-26.mta1.migadu.com [95.215.58.26]) by imf23.hostedemail.com (Postfix) with ESMTP id 8390314001E for ; Thu, 23 Feb 2023 22:00:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hy1GOCct; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.26 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677189614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d26wBxNftgvIEigvlBues+H50f7ZSE9Q9ePe8CXNvAs=; b=swak4WgdO+vojOSKvXhNPuPO8j+vU0W+ETLQaOtmHrEu/fMZdx15Uckdt22mEd04hTi1eh 7rkoSLE417fOmxUpQ0+2thE9dLxykpY+u0wONa32HnsuNGQbo4Pl60aHVBDPLiw6QPMH2y sBVa9ajO0GAuzJOe4RgzwyYMHKn6ecw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hy1GOCct; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.26 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677189614; a=rsa-sha256; cv=none; b=6jyG/suCQ1lnWwqMxNsnVYtM+cpFNPFELPAMq8e8yeVWxZ+EZapRsEnWALSskyQlZzGnMf Z01oXsFQwcvLBDopFmmJ7m8q+vCVddbuu4ZI67pfXsifQlYD4LRz46gDgWFmkeRMMi58kD U8+DWuuWwKN+L46Z4u/hRNnqlHYFmW0= Date: Thu, 23 Feb 2023 14:00:06 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677189611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d26wBxNftgvIEigvlBues+H50f7ZSE9Q9ePe8CXNvAs=; b=hy1GOCctAm2u9Q/WJ7L7i8MHDrWDIM/OZ/LaaCUIlYO4NsaGcXONCLopBdR4rwr7VnKtOG kEU4fg/XS5dDhRvUcB3YGSEgEtiJmdnDYBkH7Kt/hwVXa+rSdfjo4GDKrlOZWuLKOz6aw2 R1thl8eJaTOT74Ik2v5yhyn4k7IbbkY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Matthew Chae Cc: Michal =?iso-8859-1?Q?Koutn=FD?= , Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , kernel , Christopher Wong , Muchun Song , "cgroups@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm/memcontrol: add memory.peak in cgroup root Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8390314001E X-Stat-Signature: no6dtq7gkmij7cgaefg3jyx1ppmqfkr8 X-HE-Tag: 1677189614-897632 X-HE-Meta: U2FsdGVkX19Ea+ZlchGPpwRJnfyYIKl4DQ2Oa18W/BVON8rPwoamK08UpOKd1Htva5n/waVsnFY51GKhUiv75dJ9+BX+SBm2QGol/XbItuBtlwTPcLxih/2zFuIWictL71lZJgSh4O1AXiSssYS5843yRtwXre7VmzA9LKedCn1eHJ9CLD7C7DD9JFoBD6uaTiYIFtVYfinXVE3/epFH9jfJYe4+Q9FNblgmxb0+6FyN2gXeaWErKvAgda7KrZXVU3dR3mZkk/kb6fZg//Xv7EHrEXQZ9bDfCCqnA3tJkz7NJgbQf82Q5CG0ecbk8hcZjJZb5j0q1Ey9KWxDiefzk+sog9AKBPj31vq1dmDW3YRGltwIfAy/4FztG/8AIv21qoW01FMQAAlmLSmQjpHpNYgYuNU9P1JdC8u7UIa+fbA2w3jpYf0Kxzs5g7xOq2IDk6b+LD80tO0kn5mNeabsehrZ8DVgjg6Bwl1V7hmimoSYx5ThVbmr1IG2qVtoXK+rckrAIRpKQPdhTiiD9M+OytSgA+ZF2rYp3wUbaGBrZ4z9lc65JoNo7IKajB+FSRYkwubEct9o1PKh3ea78BuPSRRPF6osHCAUIgftx9iAQ1Vm1xzmDNxTQemJDaC/F8PcU8fgwRE/a5QqKQLwBpxuLVIw/pqTcBFYkXjNYcCwHVBbXlm3ikxMGGIRhg0Vq7EhPoDKb1rqWaWSG2Aatw9NcedMbCtKk61ATH6618ah6KM6movAOjPUQlgSMTVBXQCDn6DwnvmFinPT34DHIXw0OO5d95z+13aYOwKKfaU0dfUqleMLlindF5jn3lTvFAfUnWdZ5DtW3Xbaf2y9vhZu85o+/w21rJXlyi0VRtnu+lLDrLtAGfajCzlNOILjS1WM3N2ECMX9iUEROgeQIorVpAhkeCXH08/yJj8pTONol1lVhf+gvC7pqD4G5do8NWCKZK8zAAPGGnd701RV7mD z33WZaf0 pbXrRoG0zcNqt2lnuczn8ZdS05JKS1R1TOFoLUeqhMn2/neZ3dq8SqyHqxD03e5AfXLTtvzgfkLNYFCD/w0VwSLiMi50AE6kbwdafehXupwEbiiXGQPOn1/G4Szt0MlKN5byGlold/7zP99naTo9lsUWB/7L78usgMLzUk/IbuSd/QGVRhdtK62P94uMJIrOphI6v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 07:00:57PM +0000, Matthew Chae wrote: > Hi Roman, > > I'd like to get the peak memory usage recorded overall time, rather than at a certain time. > Plus, I expect that the systematical way might have better performance compared to userspace sampling. I'm not necessarily saying to do this in userspace, you can try add a new system-wide counter (new /proc/vmstat entry). Obviously, it might be easier to do this in userspace. My point is to do it on system level rather than cgroup level and record a bottom of free memory rather than the peak of used memory. > If I understand correctly, recording the bottom of available free memory might not be helpful for this. > Am I missing something? Why?