From: Roman Gushchin <roman.gushchin@linux.dev>
To: Matthew Chae <Matthew.Chae@axis.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Shakeel Butt" <shakeelb@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
kernel <kernel@axis.com>,
"Christopher Wong" <Christopher.Wong@axis.com>,
"Muchun Song" <muchun.song@linux.dev>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memcontrol: add memory.peak in cgroup root
Date: Thu, 23 Feb 2023 14:00:06 -0800 [thread overview]
Message-ID: <Y/fh5sQEcM9hPt4Z@P9FQF9L96D.corp.robot.car> (raw)
In-Reply-To: <AM5PR0202MB2516BD45CFBC033F9EA3B0A4E1AB9@AM5PR0202MB2516.eurprd02.prod.outlook.com>
On Thu, Feb 23, 2023 at 07:00:57PM +0000, Matthew Chae wrote:
> Hi Roman,
>
> I'd like to get the peak memory usage recorded overall time, rather than at a certain time.
> Plus, I expect that the systematical way might have better performance compared to userspace sampling.
I'm not necessarily saying to do this in userspace, you can try add a new system-wide counter
(new /proc/vmstat entry). Obviously, it might be easier to do this in userspace.
My point is to do it on system level rather than cgroup level and record a bottom of free
memory rather than the peak of used memory.
> If I understand correctly, recording the bottom of available free memory might not be helpful for this.
> Am I missing something?
Why?
next prev parent reply other threads:[~2023-02-23 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 16:22 Matthew Chae
2023-02-23 17:30 ` Roman Gushchin
2023-02-23 19:00 ` Matthew Chae
2023-02-23 22:00 ` Roman Gushchin [this message]
2023-02-24 8:23 ` Michal Hocko
2023-02-24 14:18 ` Matthew Chae
2023-02-24 15:02 ` Michal Hocko
2023-02-24 15:45 ` Matthew Chae
-- strict thread matches above, loose matches on Subject: below --
2023-02-21 14:34 Matthew Chae
2023-02-21 15:07 ` Michal Hocko
2023-02-23 14:20 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/fh5sQEcM9hPt4Z@P9FQF9L96D.corp.robot.car \
--to=roman.gushchin@linux.dev \
--cc=Christopher.Wong@axis.com \
--cc=Matthew.Chae@axis.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox