From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB96C61DA4 for ; Thu, 23 Feb 2023 23:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64C7E6B0074; Thu, 23 Feb 2023 18:53:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC896B0075; Thu, 23 Feb 2023 18:53:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C42B6B0078; Thu, 23 Feb 2023 18:53:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E8E56B0074 for ; Thu, 23 Feb 2023 18:53:36 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0628E802B3 for ; Thu, 23 Feb 2023 23:53:36 +0000 (UTC) X-FDA: 80500211232.20.B878B72 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf07.hostedemail.com (Postfix) with ESMTP id 302A640002 for ; Thu, 23 Feb 2023 23:53:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I9t8BJKs; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677196414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j1I60B2Lt/0FzuWu/7GjmsvEbAqwqUGpYps2gfO1SLc=; b=hgI+YILBnp07anvpf7ExoyCg9xe/nZaCpbK3sx74KReLjYbM+i8PI0OAYz6sIM1l6IFW3c lqQ39b/CpXOaebNzrv3/cOQZ68QeGkRsbK166EZxS9HQtYpBHpzvGxNMRzWx/P4GrOrRlc P73lztzFC4FEjEqWabLW0YTfVSHyV4o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I9t8BJKs; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677196414; a=rsa-sha256; cv=none; b=U0HQ/j9GqjMv5L9J3XaLbMmWCHQGGJ9ahBh3fAsRM1Ca6oRzGPMi8LHuhT7m+IHLJASvDy 0dNkr8jxpZhIqUJj+YBjMydSx91Q8hvUFrC0CeetZumTiHUBodwQcgqFdt7FfcMNlKCLjC bKdQLG4USpoIBvZgFlf44LPMLwFI4m4= Received: by mail-pf1-f181.google.com with SMTP id cb13so6852056pfb.5 for ; Thu, 23 Feb 2023 15:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677196413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=j1I60B2Lt/0FzuWu/7GjmsvEbAqwqUGpYps2gfO1SLc=; b=I9t8BJKsBwcmztPZYHnnr99l2QXIa43BpfQNtIwNKfNzbqaGF6y23VKayPuxikMDFg eY3kxv/xCIf/JsqpXCGKvTEHJ/05M56W0UDDc/wsusEHox39ydixgyeWyitCPUiySgzI OEqRPNxlNOT5AEbCuW/qQEGs9qSh4VkiLtGpmsFtc5mQrCEtWJSoTkyrnTR5CDFzTw7w H1TVFjPA+S8z2rOOoJMpVbqZBkVfSRtcl0c9myBs7E9QtuZFoj0L/c1HyZyxZvF6xPm6 Er1uXF0IFrnGKTJBxFXKzVCEvp/+BcSxiG80whP73tQJABGTLFDS4NIVAsxCr8rKnecb 7frg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677196413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j1I60B2Lt/0FzuWu/7GjmsvEbAqwqUGpYps2gfO1SLc=; b=NrET1ItTrz6GG7wIbGkBB8sBmGHBscQMXiIapo/Ktcd2SQYgRDZ6wN6Vuk5Ts4Krtz MzWF+seqNkH+EEkVkfNmYZ8w/P28NgRai4tFcD+TjJb2vA+BHI375NLW+7vwdJTN9fH0 /JCgLnDxLNftJ4zgyS6AAHcAlxBv0kcopwsn5xCHAdCfW5p7ntxElXGobkyF6S3xme0M iAXshYIsaLJywO7F5qCFSrYza/gmercslAdexeATnrku+q8E2JNn030NB6tWNaGtxNdv RsQhr3xWRpxDwGqVrYs0KwAP+1vAl6IWQLhmQvNHAyKK9LUFVNS8ltdVSZCM8mpnfj9B kg5g== X-Gm-Message-State: AO0yUKWbNl4EVcnEcKyeCCM4WaTizdSr61yq/u79Jb7Aj5rAYGF8dKf0 Jx9uOqByYsieeBhFcslaC+g= X-Google-Smtp-Source: AK7set8hLPjTBMwY6wWJMSOibdZqs8ygHjZPLL8d2LbLUa09dRVU8AoVW/sQbi17vTSpC9R8/I2S4g== X-Received: by 2002:a62:8494:0:b0:5a9:bf42:fcc5 with SMTP id k142-20020a628494000000b005a9bf42fcc5mr15718796pfd.0.1677196413079; Thu, 23 Feb 2023 15:53:33 -0800 (PST) Received: from google.com ([2620:15c:211:201:be5:a687:1e9d:ec53]) by smtp.gmail.com with ESMTPSA id e6-20020a62ee06000000b00580fb018e4bsm5394832pfi.211.2023.02.23.15.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 15:53:32 -0800 (PST) Date: Thu, 23 Feb 2023 15:53:30 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/6] zsmalloc: fine-grained fullness and new compaction algorithm Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230223030451.543162-1-senozhatsky@chromium.org> X-Rspamd-Queue-Id: 302A640002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gqfss7haniig3bkse8g1qrej6tfyh79c X-HE-Tag: 1677196413-584328 X-HE-Meta: U2FsdGVkX1/yf8pU7cLFZiQfntrhv3w6BVQq7slOJ298bAdy+MAWT1XyMzkYQbZTuY6A1CoUBrSpgKzIuYOQ5ZTzaogKkwQeqUl45yjI6H+m+OzZJAoJOb/FFRx0iAib04YsITm6QMfGgSMvYSz5Mp3weGWHz5Pjh7q9i3ZARbMsZu2AOVXsotbFk/nsmH0DjuHKsN8nopWJb6H+6gBZA+zW/RCH+3Br5uaWp9foRVRyG087k7Oo7KVBUn7VHZaNf719Fu+NgpJnPLjZYvDcKHMdIz0tzgL568bSjbof4t9fmaoYd0Huvbp2zI4laKmJLNMIFYSwaWcMhN2um31iP1BIAdylT438DQq0K95oda4+OiJCI4J+hHhpILUpaxHL+q+XjKEVfytQxctkgUfllMxpZLT4EmCXNMQP5K9MmuUr+98OYV0WT6/QeA3aBTZFIgzxCrqIGS6oEVPfPGdhQkT3jTa+6kSieHzj7vCdF20lMwzfv3koBNZaK4PQ0x5exWMVFtenxWBwV/9TOiIJi41BBNP43j6ZYJcr4jEzX23kxVEQOsJbEcLszMMSAWi5Z3kfCV5M+dvF1+ggBkfVJv1sjfnguCT/HM7Sypm/uLXPtmzu15BdAc1O54ufaqNTZrtJS6kfZD0bho0P18Owr46M5IJIErTkpjHGvdoPOcUffmQs+MrX1KdtE+KyNWUhzli62BvNNCl2NISm2x3rOdrXi84u+fa8KG+gDHXAGVVRA/yw2JmBlW/KhaACeEt3Cjj9/3Fp9BVxRp0ZLqRZua1eAD5IavcSDA1W3PemYmeJAj0qTRauvLLeOUyPkCH5nsIqBDiOMgHKei+PdKtMQjLK7PgHojQ4fm/f1oUwZgdP1fK2ngWPSbLpm3syfwjn2zYbEBTRXZkhDwLH0ZsF8wkfNubP6eiaIkUlgKyCuq4qUh1rZ/uqf9BP76TMKe+CczULeW5f6EFoOB2+iHq p+EY0Tdm Z/aZAI8SD/u7RVNKVnNAMietInqVB52sNnWU5Ex6QgJF2DPxwMwdbj1xOCs8XoTNaGL+aqKssjfjz7Izy/Vv4Au6KpxkAf1j+pIVwsfUTfnR+/GzpSSG27H9pNOshB+oaLEDZVpOf0MGYFpOgbcIGkSFjYJYy4HSdexjt/NFvVVaHtK1fnbbZcmobXa9ZThCPptAwOHh33lg4HzSakvO7EwpDguzFiQHOn8qVmMRQcvfZv7SJm84akcgqWkVZWmlIf11zHyNw6fm9ttmJiiFrat7QLYQ1Uxvlsxayz6oaU9+KBXqHB0Ymu9QsovZ2E7fdubgrJZu/EQiiMwuQAKJxk1khV8YCmUpQNNy53aXw7XICMRtBADUc4Ag8Zaitt7WkoqsIDlwcZ7faahMd+ybtQlrbhAyDtwynDS5GlESq0HU8q4YdV0qqGVcriojOSQh5KAQaqTJKdKE0inmiEdL+oqcHFR95zwsL7r7kFt9tHxoHmz7DXwHWaYhFHCSXFmrDnlDxiOySwWek3UlxXIMi+RxmX0hPbLdtxNzkNOqfIgHwuKMXJrPIJiKYRQAZ3f5XfYS2+uUi2grgiZ4kVUYjvBU9KN0/6nNZeAM6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.017792, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 12:04:45PM +0900, Sergey Senozhatsky wrote: > Hi, > > Existing zsmalloc page fullness grouping leads to suboptimal page > selection for both zs_malloc() and zs_compact(). This patchset > reworks zsmalloc fullness grouping/classification. > > Additinally it also implements new compaction algorithm that is > expected to use CPU-cycles (as it potentially does fewer memcpy-s > in zs_object_copy()). > > TEST > ==== > > It's very challenging to reliably test this series. I ended up > developing my own synthetic test that has 100% reproducibility. > The test generates significan fragmentation (for each size class) > and then performs compaction for each class individually and tracks > the number of memcpy() in zs_object_copy(), so that we can compare > the amount work compaction does on per-class basis. > > Total amount of work (zram mm_stat objs_moved) > ---------------------------------------------- > > Old fullness grouping, old compaction algorithm: > 323977 memcpy() in zs_object_copy(). > > Old fullness grouping, new compaction algorithm: > 262944 memcpy() in zs_object_copy(). > > New fullness grouping, new compaction algorithm: > 213978 memcpy() in zs_object_copy(). > > > Per-class compaction memcpy() comparison (T-test) Just curiosity: What's the T-test? > ------------------------------------------------- > > x Old fullness grouping, old compaction algorithm > + Old fullness grouping, new compaction algorithm > > N Min Max Median Avg Stddev > x 140 349 3513 2461 2314.1214 806.03271 > + 140 289 2778 2006 1878.1714 641.02073 > Difference at 95.0% confidence > -435.95 +/- 170.595 > -18.8387% +/- 7.37193% > (Student's t, pooled s = 728.216) > > > x Old fullness grouping, old compaction algorithm > + New fullness grouping, new compaction algorithm > > N Min Max Median Avg Stddev > x 140 349 3513 2461 2314.1214 806.03271 > + 140 226 2279 1644 1528.4143 524.85268 > Difference at 95.0% confidence > -785.707 +/- 159.331 > -33.9527% +/- 6.88516% > (Student's t, pooled s = 680.132) What's the different with result above? Did you just run two times and shows they are consistent or this is new result based on different testing? Anyway, this is really nice improvement. The comment I had in thread are just minors. Thanks, Sergey!