From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA470C64ED6 for ; Thu, 23 Feb 2023 23:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2314D6B0074; Thu, 23 Feb 2023 18:51:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E0616B0075; Thu, 23 Feb 2023 18:51:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A7EC6B0078; Thu, 23 Feb 2023 18:51:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE7426B0074 for ; Thu, 23 Feb 2023 18:51:06 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C2634140CF3 for ; Thu, 23 Feb 2023 23:51:06 +0000 (UTC) X-FDA: 80500204932.23.7FE9007 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf15.hostedemail.com (Postfix) with ESMTP id DC4E5A0002 for ; Thu, 23 Feb 2023 23:51:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y8X1mBI0; spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677196264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5IdfJE8AvP5t+Iu3xidru+ELJWM2yxeVWcyHiD78toI=; b=vk2lgfaoTgwZCeciVSLIwgjZgqlLoPA5QiYkKlxny1V61bSoupjQz3OTeeecWLrfjBA9jX JKc1pTV411lpVGdlpOiVy1VulZTXHgfn2LZDsBZTYQKv9IWUPi7S5NijuYPD12deoV8UZ7 RcwRCUJGLh14dAyWDAjJy2LPutkAH0A= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y8X1mBI0; spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677196264; a=rsa-sha256; cv=none; b=uo//W4i/I3rbTYNZ3Ipnfevs9WW15HvVEAk3DhjLE1GoK1zmEwqDYPVNQO8iaEkp/6oCex Z2y+pFcq79lIQ1rsHO38oxUxphtl34wqed3cVbJtkQwX6yrZqZ1AxXSUrutja75qoke3TV tx5Jn4kK3/i8IecJ7dOy5eIZJXrOs9M= Received: by mail-pl1-f170.google.com with SMTP id e9so9923261plh.2 for ; Thu, 23 Feb 2023 15:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677196264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=5IdfJE8AvP5t+Iu3xidru+ELJWM2yxeVWcyHiD78toI=; b=Y8X1mBI0vnw77UgdAQb9BDMxKwDzZJHNi9poxgJfxJpv6bfef55B+T2EYwCLJgKwUx edxmOF0z3PjK8afqi0NqGbfvppkYw/pO+nEpxyDO4LhUbtUAZH/AKKKhNicMn3f2XmJH EW71MwM1YtvbKrJcYfDmJ1NrF/5NVVr8D6ptYyhFlzHnjCVvsezWrk5RteFw16kLjO01 wLVHKZ+JyM+BI1XvoqHFZrze96Ieo7jRZQnaC+aY/aeOdd2w4RYUV80EpkPq8eG1gNWN 0sLBOGJWIu0ccS+ok6DULbnVFjehSqLmCC3IhXh4ibe4ZvQ/iM8ZUMHpYjFm9z7PcxFR XepQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677196264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5IdfJE8AvP5t+Iu3xidru+ELJWM2yxeVWcyHiD78toI=; b=LLxvNa3e1CGw4C8oFYfRFnOle9mTRC3OHRM2UuNRdc9vX34XXYYC8fGs2cg5WCnrFR wwaJUuxiwUh8CWrS4zlcTZTZY/fsWa0KV5HxZZznwpubFECgija34KGVPzqwqxA0YcXn EKf0U4ZD7M5WoAoL6ucAb6zsCDS7TXQKrva8PXR4j+RKF9S1QHgp051nJLJWY8KaiY74 CxWjO/4zvmAszCAc08Z0S0Qx5N3s3zqk7jrO7R1T52Tpke+RwQPVK9VA5r9CLbqYr2Ct C3sfvY21WOmSJiuplW73eySCkgGt87j0TP7SCVGkuxvM6xWr4kCCCM9HUVF9hPU0IyLK qHuQ== X-Gm-Message-State: AO0yUKW378WjpKO8lkTqLw9uhPSoOwv39cTGdgW3QdijwUVKKY+ALKGh QoI3nF/6HMNqSQh+aHSN2p0= X-Google-Smtp-Source: AK7set/x1UtpmPStjTvqQISFJnvoWw0VqkAy7Uz37AwqJBrUKr4JcpCfcgF7uo9jBDigq6igDvbqZQ== X-Received: by 2002:a17:90b:3b87:b0:236:6e4f:bc1e with SMTP id pc7-20020a17090b3b8700b002366e4fbc1emr14609910pjb.49.1677196263764; Thu, 23 Feb 2023 15:51:03 -0800 (PST) Received: from google.com ([2620:15c:211:201:be5:a687:1e9d:ec53]) by smtp.gmail.com with ESMTPSA id q14-20020a170902b10e00b0019a8b057359sm2137413plr.130.2023.02.23.15.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 15:51:02 -0800 (PST) Date: Thu, 23 Feb 2023 15:51:01 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 5/6] zsmalloc: extend compaction statistics Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230223030451.543162-6-senozhatsky@chromium.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DC4E5A0002 X-Stat-Signature: cru6enijmwccx1qickjgymujxh9zari5 X-Rspam-User: X-HE-Tag: 1677196264-882623 X-HE-Meta: U2FsdGVkX19KxMihY/YX094tIv1a/ar/A/XGtUQB3Ls6NXkeFxOD+JYjLxlgZNju0dJ+T4NPE435dZQYLz4p2z+nK1plqAjOtvsrxjoWQmx+RCLXfKfJZa1KZgzOKoVxaKwL92Thl/g49jBD/jxQYvFm8HXstIPXl/r2Dc9Vv3wFI8kIf4UrurbU65lrqOxPBTnGb3+AxmcmOgW9BDvsZg6rxx+ASh+76/pMD+Lobqvk0ryDnGF1t57OgmnP4v9tmVnzTz3sOpIEO7IRT7tgsHzjBlzH9mu8x0T2iUI5jdDuXKljLn4HuVNCv1J0mMGmrC34HyLh23TiEb8RC2AQwzMsJitBOjGq82SqrHyWSDB5up5sK1wrUJsZTnPJqyY0UQtrtjNz0+XHIi1JvuCy0oX+sj5N2ouaQKR/SWYIZ/7U+msSmDcZ4SvMvS7ihxTcPcfduS0LgfTfz21WRkW2FEWwr1nn9vDDrqdJtnR23Iaaw3Hm2cQz4TF+dkjRIFivFmq0E7M/R8SggKH5zSpU7DhY3nSFrq+SEzjU6a/byUkzSXkBjsqK2jQCu0KKyp8EWtiBEURx+YmW52YVLKxHYjg48bdXUV2K7yxNasq/q5vPI893Qi7evGv+hpJ5LSDjyXh6Oj2ALuiPjO+ZTlDd9d+9cHS1HCRSh9vI5kaAk5JkvtiBi2NilwGE/7fOO21qHQrtZasHkfnOluYe+VU5IZzds/eKpLUrmx9AnU8vHrAIzamYT4Ylmm4pWPndXsZY+EQSt+qtkyGXlMGa7BOrSRr9B3zslL+JvfbQrESKZrl5lLCCfDmuM5jzPMEMXvNsRP1FdDobs85/xX+9PlHTfTTjd7iw6eTdZ9oyzTzN9Ybf7UvlLUvFtxnxRJSk4hAE7l++AEJbTDIEbDxUEhIcWWDJnjTRPlk0ZtmwQMnKx7MpOJMqilW/vK7dl8K7h4jpUKnH10G+Pktp3X4tVjC Qk/88GdE HhztL+IR18od3iylaAJPaSfINJS7o4Nf0V8TBYrndCoAXMtHErKLWBgd41reL8y7zRjGE3U4tTHafTvK6B8/LVeY6bKzQMBVm+Hc73dnHITc9DwJffO5XHVOhPEMi2pxlm4GnNg2xeJzU936KCCkCRAOokpVQfq2HOKHCNlyBtxilS5NpTBI8xH1v9oa0JzRC1rw+Yvjrrhm/jOp8AusErdotW6HKg4bu63lhP1MB6grQTG/Q0+pEzxJmlPbb1hBsZzaQp53ioKrw/Lu+EG1GrY2s8DySd0yzuBZW29XMACq86jUhNAAnWGmHfw9um43Vz0cYfS4SvQ/QCp5QMny8PZ/rH8oJ+CrGduiZH0yrXf0V2iKfYPgOd7xF/8f2f2gMWG0pIi9ZIN0pzvEIddp81QXM7AFt2ymB1I6tVCe4VsHB4VIfrdrdRiJDrNTM4K2Eh6LbBi4hs7/gCMc6nSYrzNef4SvlgB7aDafSJthDayktA3Oi8sfrf4Xmd+Je3FymRRI02f24b1exYSQNO51Y1A/1AhUhJDFfFS0rtjnhzpc+jjNERXjwx/Fh8nTG6v8PurKZRbkDOx6u4VTpzNyc6zJJT0ios7oiT3Wzbxiy8gzudzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 12:04:50PM +0900, Sergey Senozhatsky wrote: > Extend zsmalloc zs_pool_stats with a new member that > holds the number of objects pool compaction moved > between pool pages. I totally understand this new stat would be very useful for your development but not sure it's really useful for workload tune or monitoring. Unless we have strong usecase, I'd like to avoid new stat. > > Signed-off-by: Sergey Senozhatsky > --- > include/linux/zsmalloc.h | 2 ++ > mm/zsmalloc.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/include/linux/zsmalloc.h b/include/linux/zsmalloc.h > index a48cd0ffe57d..8b3fa5b4a68c 100644 > --- a/include/linux/zsmalloc.h > +++ b/include/linux/zsmalloc.h > @@ -36,6 +36,8 @@ enum zs_mapmode { > struct zs_pool_stats { > /* How many pages were migrated (freed) */ > atomic_long_t pages_compacted; > + /* How many objects were migrated during compaction */ > + atomic_long_t objs_moved; > }; > > struct zs_pool; > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index eacf9e32da5c..f7e69df48fb0 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1815,6 +1815,7 @@ static void migrate_zspage(struct zs_pool *pool, struct size_class *class, > obj_idx++; > record_obj(handle, free_obj); > obj_free(class->size, used_obj, NULL); > + atomic_long_inc(&pool->stats.objs_moved); > }