From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCC9C64ED8 for ; Fri, 24 Feb 2023 00:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EF4C6B0072; Thu, 23 Feb 2023 19:02:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09F6A6B0073; Thu, 23 Feb 2023 19:02:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA94F6B0078; Thu, 23 Feb 2023 19:02:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB5906B0072 for ; Thu, 23 Feb 2023 19:02:00 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7CEE31C02D6 for ; Fri, 24 Feb 2023 00:02:00 +0000 (UTC) X-FDA: 80500232400.14.1FA4A6E Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 9915C40012 for ; Fri, 24 Feb 2023 00:01:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ijuWZ787; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf12.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677196918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TMHhbasob2jSJMP/rGP1hDEEoG8ZFc7G7t1EubUYEX0=; b=Kku1SAOBUmLeKKnaX2oHdMrz5uVxCurJiBF3Tfa7Clc6qH6Wp08YsobHKkVdhcXbbJpBaI c88P2JdrBW7V1wm8oAiZl6327JFlcMzNh7TDN9qTawPbspbeItT/AsP25rZ49pvYGHvWTn UhS/rQmfacMy4o3pI9UuuIEhcBKzKrU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ijuWZ787; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf12.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677196918; a=rsa-sha256; cv=none; b=ilkI/gSCZZW9Bcu6AgePZ3i1BU4gqJJzWAqU+T1yCfwaZX5x0kslK2vy21Nip+8ft5m59y e16wbipsBlC493QpP3tbma7Tc0mjcKYvVl2Q4D1+w/jGXGn1OMSRn4Nb/L2W8Lanm5SzRV vXjExRlwsWQfk+LDUaHcbtdBe/vc0VA= Received: by mail-pj1-f49.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so987131pja.5 for ; Thu, 23 Feb 2023 16:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677196917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=TMHhbasob2jSJMP/rGP1hDEEoG8ZFc7G7t1EubUYEX0=; b=ijuWZ787xsPczHm+2IPL0kdpsJnnO6WgrXtCTnEU8sqXZAlC42+8Q6CHnUW41arU4Z 40OIaR/LiIGdgB2dGUzMU78KNnqu9Jo8KmGCijVzEzziE9xjRhV6Ze5jKN5aRkUzCAks xsTlKDcqire4+XuV8KWC/z1Cez6EpwyeLQKRypvU0l7tD/z0Uo0V1laqYxoY/O2JTam1 hQZgEz66f4mg12m+04IKWCzexaG9Dt0/wqol5vTtyK2ZIADbPQVD0V4/OC1q/y8mz+s/ 8yCkhbw57rjSfb/6zadsBXbkRymIVrqON4mJ4y/fvCjrJZ4kv38btnz0WMshfRLzRj8y J5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677196917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TMHhbasob2jSJMP/rGP1hDEEoG8ZFc7G7t1EubUYEX0=; b=SvEVH1RaeZeymBzscwaGefJvWpiMAp8OixKgxq4FV903O1IijJSXmji+1XdalrxZNm nFDGyJGLou7iS/TT6eqEI1Ug5MxryYiaPT8gaLXlXjq7ErJrQvPPQX7HnB780Olz+oVd DMyFuxeFm8WcLRZeeaMBaRnhQgEJWsmXTFmuwrot1UUpVjewPa/rJC0FOhY0D+lygkfj 3L60LKu3Jj96VBSEXPtQu4Wx0UqK6u4L94rY0peE9OEGAzVZy+xnZqroTZMznTPoSzB1 SM2//UEw4W7+5ADGWS4Gl3fSEUBbNs/hRST/XNYS/wYrtJh7/UD5DkfOsV9ocIa4CVcf ebPg== X-Gm-Message-State: AO0yUKXYzERkVpriqWU/dAKwMDNvxWxzWMZ7Mh0r9FD7JP+kUcFQQjoG IpyabXz1VLP7RssQJauvuhA= X-Google-Smtp-Source: AK7set+1TU+Y/nrHwjPjSqa5LAOOY1ljlAWlCuAYO/R2cpD+1SKIHBov8wRTZSD0fHm/hd8+iJAk/A== X-Received: by 2002:a17:902:facc:b0:19a:b67a:5bd7 with SMTP id ld12-20020a170902facc00b0019ab67a5bd7mr13717890plb.57.1677196917466; Thu, 23 Feb 2023 16:01:57 -0800 (PST) Received: from google.com ([2620:15c:211:201:be5:a687:1e9d:ec53]) by smtp.gmail.com with ESMTPSA id p15-20020a170903248f00b0019a7f427b79sm7998765plw.119.2023.02.23.16.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 16:01:56 -0800 (PST) Date: Thu, 23 Feb 2023 16:01:54 -0800 From: Minchan Kim To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org Subject: Re: [RFC PATCH 00/25] mm/zsmalloc: Split zsdesc from struct page Message-ID: References: <20230220132218.546369-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230220132218.546369-1-42.hyeyoo@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9915C40012 X-Stat-Signature: e3qd4c3hjc4yynjjhy4uf3orsakak7ki X-HE-Tag: 1677196918-869663 X-HE-Meta: U2FsdGVkX19DdHkYTRhHslNBNV/0QuuY8ZwDkQuHcmGtr4LnN6HqMZ+bQ6xwfV/VdPlcin7rCmgL+rkjbvtxanzyR0UicJSvOuKmPC+qgX2ZrKXmFi0NhExtijX1u28e9/z6iONoAlNW639h+yOCOO0YKG3O7RH/wfJU2IdIfRP2AFYkemHGQXrTFbHxnHILkEY06n50Ov/MD2UFT6Ia/p3d9QLnP2UYUPK6TicGRtvEZmAiavN7BwlFH9SoEyWByHwkQVjFfHbwppnLLPEYtXDgzSXmWh+fIhnUZTvfOJY/Bhk3WT0BJKwOQno84rCwm/VS+P/EkpfaYssW3ULMquFsnbrnJMImcu9F0GZ1uVrJIKgFIDJ7QBkZy3nHheCIGRJZqlMJ+ue4KeI4rwL3fv+UfAQve6beBRlYYNNsYupnoH83OsqVHu5Jh0iKMoPwaZ5qRu46A3pp/Wt6B/g4uYHg4X9MfSZkhEkfQ5/IIISTj65RgivfDj1zYe+g27QMhqAZ9fcdiOA9GIzwuYL2ludt5qxUuGUPjJguv2hmoXRlyjjq3oVQ9THEQ6sOWJomcEPSsWZ2pRS2b/7Bnw9JFLNVN378tV+JrBB/EDmCpKoV3ctvHSPgF3alpRHzX8DcOzO1sqIzBZdbiTvoi509k21vtzx05g8PETKIU/neXpDNVR5GAef/+d5Nj19aY0jpRlxyD8FOH2t9zQPM5ow86HskCXzIqKHBO0KWPem9I5CRB7gDIRhxfg6mr1Tuc3AKa4v0hRj8u64kp21FqTkpu5J/EoBvQkwK2btZ2exYdgx5cxU/lSfDePfV0nrMVoKt7dhoD/EOcuh0MVuWa2+x9DtgEokjAlmtrSfp7HfiUSQIJAs5cYwcwOTl1TJol1IOQkmA+Tz5rkNrV5jdJp5ry9KeYxrCvZl2UeUQGmV/53zMysqz+LrzMUKLvW/aWi0UtWimSp8H+J/LgyepQ2u h5rJLmAS p6jQRSq9jgNXcZEFa7N9X9gVMgGLIBLu2hxkJm3ki2SH4+Js1TfZcnTAQYpjvEjZ3rMhj+aQ8krxgCpQGhQD+wMmwc6OwUCx3KYBfZ9BPLSVDmiiUle3jgnSMFPr7DSJq8k4cDGY70jt5iRFdsYZpP/kcnrXsW9TR/HLqcSL9GIo+YMappOaRKzbVzikbaQOHch74MLKA4NJnGLUzydvWFSB7E8sqbtiVRk3cK8xRCHwaBvvFSylMroXoHe31UlS4f2oei+MSKkGmfDQD+8nWEKvrhJKyHmqVTeclUwgb5CIgKDHkTcpMS/IIXQ71SWhiQ2iFdxybzquFoLtKLqzI4WbsmpSmD+QXQKu922ul7W4VrjJhP9eLXhPxPJYgzUxNHAFyehHW5Owpbasi1BhJzDoKTBOV2F6Dr+X22MsP6n29C3w9JFK31w0Lxiu54iDMvwpZwZdCm4wRuLAKNUjLWXalyJ4oiN78VtJ6xodQ1HJUE6+g6WPfwuKwmlJ5ZAnLGGg+nVVBL2dDMUb51lYvHdzIXgqzF2HSl/1zEKzVhiXzmnxt3CS1IA5gpWfkfpbEZXs2Qh2nUH/dfyP686GYfmm/TCAbjhaaLZRT+MpbFVF79j5sVbLM3mcTshf+RRfacQpapeFaD2pxlbnaaazgwaHT2ROxbe7TJxmjzPyIQzdBLuBOb0bcGukdjdOfKyazsprtxekxbAnAQ4MlrmNWmnXrVnlicqp1MerWF3GqdU5JW3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hyeonggon On Mon, Feb 20, 2023 at 01:21:53PM +0000, Hyeonggon Yoo wrote: > [Maybe not the best time to send patch series, but just wanted to > get some early feedback from zsmalloc maintainers] > > The purpose of this series is to define own memory descriptor for zsmalloc, > instead of re-using various fields of struct page. This is a part of the > effort to reduce the size of struct page to unsigned long and enable > dynamic allocation of memory descriptors. > > While [1] outlines this ultimate objective, the current use of struct page > is highly interdependent, making it challenging to separately allocate > memory descriptors. > > Therefore, this series introduces new descriptor for zsmalloc, called > zsdesc. It overlays struct page for now, but will eventually be allocated > independently in the future. And apart from dynamic allocation of descriptors, > this is a nice cleanup. > > I have no strong opinion about its name. I was thinking about between > zsmem and zsdesc, and wanted to be consistent with struct ptdesc. > (which is AFAIK work in progress) I wanted to have the chance to take a look zsmalloc folio stuff but couldn't set up some time. :( Thanks for the good work, Hyeonggon! I will take a look once when I am available. Just FYI, Sergey was doing some changes in zsmalloc https://lore.kernel.org/linux-mm/20230223030451.543162-1-senozhatsky@chromium.org/ I guess this patch would conflict with it so may need to rebase once they were merged. Anyway, Regardless of that, I will review this patch as soon as finishing urgent stuff. Thanks.