From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6531DC636D6 for ; Thu, 23 Feb 2023 12:14:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9D36B0072; Thu, 23 Feb 2023 07:14:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8594A6B0073; Thu, 23 Feb 2023 07:14:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 748566B0074; Thu, 23 Feb 2023 07:14:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 663E56B0072 for ; Thu, 23 Feb 2023 07:14:58 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 381681A0B36 for ; Thu, 23 Feb 2023 12:14:58 +0000 (UTC) X-FDA: 80498450676.09.F87A442 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id 4B27AA0013 for ; Thu, 23 Feb 2023 12:14:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=j11osJlh; spf=pass (imf25.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677154496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fP9xV6lbjH9d0Me/zzCK1TZbbkYDahLeZPZJbYSqzJg=; b=Wyj5GfptnQwx6BUZ+Sa0I30haGQhx1aRlTDlxWNL5bH0e9gQ0MYcfCWlWlxQH5NZxwumv6 b6eI+fkepYboU7UsIqPt5qigBhhP8FBE4vmb+yMT25ZcVuK6hmd5qaoaUarcLmgJjIA8TZ Dwne02h1QiAa+fIa0lvOA6uIrIyi9ME= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=j11osJlh; spf=pass (imf25.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677154496; a=rsa-sha256; cv=none; b=fTijzT8l50bE56hthyF62WkHKfIz0OfMWd9/1k9O+DRnNh/nGGZwjfpMNQGns0Id3UCNWy rMw6EJ+1JLE+8CC1QD2knoqe3REBq9fWMWVVEStv2pa7rrSaFcQbCUXkxEo3jgcYKwgYpv xzm8jtKJGak7IlxuvHFmclZ1gNAsDKg= Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31NBrllM031044; Thu, 23 Feb 2023 12:14:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=fP9xV6lbjH9d0Me/zzCK1TZbbkYDahLeZPZJbYSqzJg=; b=j11osJlhFMpbcNoFcAEqcHR3XdbnHaC0KrVkEPEu2l5fWGAMFhbAcKPlmOgnm64hxjeh bqi2M7c3tJAgis1EFipOAhq9GRcMqMgoNhMs8imphlHiUrmQfOiup/YI1hI/sVJxv+GQ i5wvWLMSM3aEIx3bVT6Cj4h1Kr2T5wSELedjSt55YUF2MPXvkGTn/cVDIjjXKEFhPttE w8n0SzThox9jwO9LD4eCd6CfZy2JBerJuJIntaSC1A9IRxE7gEV2k4gnS97UAyiIN8Ca wHsj5Qx9mN9yEuW8jKnLN073OhKzuCR8MjQPHrSrbiZAmTSsEFvzaT1gnmFvFxe7LilG rQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nx7p00g1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:14:27 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31NBtBG3003887; Thu, 23 Feb 2023 12:14:26 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nx7p00g0f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:14:26 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31N6xENL001655; Thu, 23 Feb 2023 12:14:23 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3ntpa65193-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:14:23 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31NCEJb044957978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Feb 2023 12:14:19 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BF4832004B; Thu, 23 Feb 2023 12:14:19 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 40BA620040; Thu, 23 Feb 2023 12:14:18 +0000 (GMT) Received: from osiris (unknown [9.152.212.244]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 23 Feb 2023 12:14:18 +0000 (GMT) Date: Thu, 23 Feb 2023 13:14:17 +0100 From: Heiko Carstens To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, linux-s390@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Gerald Schaefer Subject: Re: [PATCH v6 12/41] s390/mm: Introduce pmd_mkwrite_kernel() Message-ID: References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-13-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-13-rick.p.edgecombe@intel.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: sFRj-Cxjvl2O7RQZgpFdtfpFrv0tJ-hN X-Proofpoint-GUID: H39IN__vQKd3uO65pvL406ZakvY6b_il X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-23_06,2023-02-23_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 clxscore=1011 suspectscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302230100 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: krbf9w3e48wqkb89p83oswzzuuqo34ah X-Rspamd-Queue-Id: 4B27AA0013 X-HE-Tag: 1677154494-381635 X-HE-Meta: U2FsdGVkX1+rhFsJmkGD74Myhw2RWGAsphzI2tke3XGzOSfTY4Ox00WG6qvb3MCgdDlt37JpHtDczEEAnwL7QVuYFub73XTGtKGgTIFrRsRP1Ehuixx0eLmGpvKvtm8FjggNPSxOHYIL05q+VMw/hxbluARi2duq8VxFlcc7OlDFQiBsX/diHvfeNdrO4D2w2NSthePky72IGwVCyaJJnuDF4McA2/kRLKrRvSCx0AaDpUhge7kFW1kmCVHiZHXR+A8tp0ATWxhTjWpbVYXptvsBbuu0658zcsfF3lMezcndVqgXkiFBmrRcPgzeAO1+2JvrK3eFF83AmEAP8/HOqGXltgUE0WLTMyBNLqhED99yKl3tJv78iTQxKX86o9dUsqnVYd0TwV80sWYUQ2qCruuJWfPKr01IfDql7FeDDQn2R86rKC7dHi/5gFo3H2vtE+HCGmYoLzzjq+VNyOvFzEdbcJbSVMhS4SscvR6e+jzjVAz909Yex89ISDZ/FZrXooBMt/axVsdY7feab2vYaipmmeyB6tGsiQ4fvyxCNwPB/Ar00nzJhVbcNzZWEpBokYLSWGMQkz3lvpY6YvzbQ14ahI87/r09ZKM9kjVBD3FM53xdpGxNjN9eDhsusad3GfzvedqkF5ldyFvf1G1G0hPEPCkU0ruTODRVtgnNhwZ3D8uHaN8tdAuF6pVeO1r3GhTSuvqzOz4r6wj/KfGgK3z0u3ZbD3tZh1R/zJbqZVMKZykTuWxgLakryzlCXcbWiJlbvtGhPg8LAk4QRsNDrqHf59Z6/lQRz+pZNKL7VqYBeWt/WS6Qi50Yc57fCW3zY7dyaGu9JWYANS1fZyKfyiIM2jip5gdOg6Uzly4FHIzHcIT6vxu6cYdTrRYX18AuI5LAPX1602W/qAZbusnUaKR8+jeWzHCrhf2T0D3D7hlZXDp4ouky4Ccz7yB9vphzLY/NDnCY3aeXucbRwdJ S9nkT40j KyrYYAowFt15YB2nWZjI5zDE2Dxat2H0ue8UJB1R/owCfi7p/pm49vyuePzlXjlC1i2IX27VSFW2ZYPPotvI4Qy47xIL8DguBs3vNdjOV0nujF12lJWTxZoMxozdzBfcoRhX4fZblEiUUxgJR2wbct9mlZIQSYR74i0ZgFEsJoX9PNpO8b0kON9qY//Rw+MtgfuLxFtIWce1Yb4s+vKGWAjX53VD+/XStH727W92kdpubxqVHacUJRD57IMukjA8mkxWE6xLyFmSKoBqVo7werfkCTi1Rb4Yzt+FiMhnBpzj9muR76Tz17ZR4z7XQnjcE5w2QcalY+3ToVHte4mhGMdTqFkMXpIAClIMkDG8LJ+zzfcNMrAPZjgUkhFkLsBvdyHhGUsFBWFIKSJycnkmERZA/kOxMAwTzCs5WAg1rmNoM0k1wz40mDepbS4JODsIqIV62 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 01:14:04PM -0800, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these changes is to allow for pmd_mkwrite() to create different > types of writable memory (the existing conventionally writable type and > also the new shadow stack type). Future patches will convert pmd_mkwrite() > to take a VMA in order to facilitate this, however there are places in the > kernel where pmd_mkwrite() is called outside of the context of a VMA. > These are for kernel memory. So create a new variant called > pmd_mkwrite_kernel() and switch the kernel users over to it. Have > pmd_mkwrite() and pmd_mkwrite_kernel() be the same for now. Future patches > will introduce changes to make pmd_mkwrite() take a VMA. > > Only do this for architectures that need it because they call pmd_mkwrite() > in arch code without an associated VMA. Since it will only currently be > used in arch code, so do not include it in arch_pgtable_helpers.rst. > > Cc: linux-kernel@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe ... > --- > arch/s390/include/asm/pgtable.h | 7 ++++++- > arch/s390/mm/pageattr.c | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) Acked-by: Heiko Carstens