From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25CCC636D6 for ; Thu, 23 Feb 2023 01:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60C4E6B0072; Wed, 22 Feb 2023 20:04:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 596BF6B0073; Wed, 22 Feb 2023 20:04:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45D106B0074; Wed, 22 Feb 2023 20:04:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 32AAC6B0072 for ; Wed, 22 Feb 2023 20:04:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 014E4C0E0A for ; Thu, 23 Feb 2023 01:03:59 +0000 (UTC) X-FDA: 80496759840.02.71D6CF0 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf04.hostedemail.com (Postfix) with ESMTP id 396A74001E for ; Thu, 23 Feb 2023 01:03:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eUM2OCcj; spf=pass (imf04.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677114238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WeVf+lvGNeVYubOJ3KmhlwMD0qDbcIcPAA2fSn/VLqI=; b=1J5SdWW7z/zsDzeW6tKHPMVDnus3O9xhiukLKEoPPGePWzzjkszWgAZfxRrTD7yFofFz5+ 5XTV8nx2bLEz0xvnrzShEV5LYqY2yI/p4EZPLofFlgVUl54FLQlnL5vP3kztKYWuE5xpL6 SMU3acZI29lWtYhrRYLav6hvD/JHim4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eUM2OCcj; spf=pass (imf04.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677114238; a=rsa-sha256; cv=none; b=IyIaOvGuvhPnU5iRmvPBtWDNHPX/y5x8o+sWFJPo2LRnN6u3OfF8OdIEBXOL5ImNu5C9fp diXyfgQML4Bxnb5776CIuuEAe+d80xbiFTveXoWH0+CGNEZ3k0+CVAVFTLxj+eyhwri8Ms 1yDjLxqj2QQET+FOGAAdUYjFk8JbOGg= Received: by mail-pl1-f180.google.com with SMTP id e9so5996225plh.2 for ; Wed, 22 Feb 2023 17:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WeVf+lvGNeVYubOJ3KmhlwMD0qDbcIcPAA2fSn/VLqI=; b=eUM2OCcj2hc2PrhAjQULqh1Ap6c6rwgKSXbSnPKR3n7tl9VN6COEM/V7oa6XtHgc1o 8DouMvF8dGS+e5bk9wKEM24Rvk5WogEf9k+aIzh52nH7XmqZVOHxCUkjICO0qMR1aiqq gm+t9gGJBUgTjaCAGYSZk1TFzoPhhTNuIO2SgjD75/lyc0QSdTZL0r6/6vmWi4EQeXGk zbEdur62BFlMDqX9n5dSHCmpWd3rkWvwwlqPAqeA+6RGWHYsD5lhFLnvgBWjVFdr9lXu IT7v6+pbqT4CXHTmaFIEIpYFWy+GCUVd5iS5UjkKtAEBhG9aZI4Z10Iq5cqF+4ezx51z y1Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WeVf+lvGNeVYubOJ3KmhlwMD0qDbcIcPAA2fSn/VLqI=; b=riuMt+/omkCX2JZu+42nmKYfbMc30fFfnQ/ntfbFrbEGbRCeIlMDpkmhH/bh4De02r +Q+u5LvIhoqYI09gAPt+iVe/Q9WMKwbaqV/1rkBlV4Iqw+BYqlDMwbl6aGWbJz8opn6s gAatAxexTPxFkFzfj+gZfoSRKZ/dPA24fSvhjTo3/h/myvIUmncq91ZckGLjaZX187Dr JPxAKbqpWz/2kBexWcWLsvGvREo2kax4Qysco2UDmO2h0G6SZf/gE/xruJhzNEyh+atK 1XIbD+ca98K2/j9m1mAdN1pNRRbj/N3RwpI0kMUJ0k4p4VIZdUN8AtaH/DTnNHaPfAU7 wxcw== X-Gm-Message-State: AO0yUKU6iJEGWfX9frd3B84CluFiYYBbfwKgqXE6QGKwWWlp3oUpsxED zgVHUy7MINPDhHq8qKyzP3g= X-Google-Smtp-Source: AK7set8TXzXaC2/fn0bf1HEdmolAPvXAKURAvIMr8ybRUcpKdxXj2NVbwHr01MjBJ8TL++W/fB2HVA== X-Received: by 2002:a05:6a21:329e:b0:c2:b249:fe9a with SMTP id yt30-20020a056a21329e00b000c2b249fe9amr12729950pzb.18.1677114236845; Wed, 22 Feb 2023 17:03:56 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id n15-20020aa7904f000000b005a8da960fa8sm5648149pfo.144.2023.02.22.17.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 17:03:55 -0800 (PST) Date: Thu, 23 Feb 2023 01:03:49 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vernon Yang Cc: akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: fix help comment of SLUB_DEBUG[_ON] Message-ID: References: <20230222232058.66971-1-vernon2gm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230222232058.66971-1-vernon2gm@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 396A74001E X-Stat-Signature: 9rfws3hn13x94xs8rfwaknfz77jrfh77 X-Rspam-User: X-HE-Tag: 1677114238-467668 X-HE-Meta: U2FsdGVkX1+dA8FHVYY4o+4XcMw3fF93RYplhNK/CsGNATmqB+GxRX+kCB7kByujOMg5k21VVIQyivcdher3X+lTotCtj2/NcMkU70p/MxhIWfNQDQA9egTCKGnQLV4ukcYtT4LknIGNpPw34zfXAfX4EqvGJ8ix2usCA1ec04qrn/V7bLCwBQt//hhSufqMF558R/KHYqLqc9ReaHCwtRYtoLab9A6bqfd+ooY2hmX98pzqCShHrobAWxyKtN+Gs00vZQkMCgc/ZB5EzJnpBY4/0WaX/5dwXFVrcrQM9tVvNXkvm+wQKdqv1T45/Xc/2Ext32y2yPgtJ2QLfarQrsLotOQe5qsrarfY1UNLeSfTY90xwlBqXBDsmrNlnoABMPVMrjAuIbSsuvWf2wrOBKOKBFQFTwybCDJF5AVCaIzdW2Kos2wHx1jDBw3EkEtb5jsV0zi9WI8iwsdN4DNsaUaTf9eRNYERFstfLBYC+Nwv7yfkiBIxbRjAcSVORSxBAGYcTKJjscHkUnpHnxjzvuWPI7CYeCbXDjGoZEUCjj5hM+7o+ya7jFJRELvdOIhljMdET/MWWoMZglUGFSM3YXwHsjCzIM0ZMqzohdGFBlp9gc8ZQzFQC5K8eTuiREhi1dbb/aN7GGjln22Ro0C7ddjwUD5A4HjWwbwWEEzCjGPb3YZLqLu5i+hOKnA+dFGcq3WVSlWeLA2NpTKO/V+PcDstC596Q4kbBAqM6i1r3adInLr2yt4ubRK/v/pV6XVUU0KHm+LebOllj65zqDInRJCtzsXU+OK+tyrJLZpKos3WPxvZCJ6jePSNI1L2nKoFvYtyAFpuIuie65nAtYGD321ulWsObpJYXQT1WXe6j4uj0xmvAVEsJIJjH0uGX/0a1A5zJOsz9ATcCPoGtKpfXEr47+u1DJgZ91bU3gXKmR0CmjchMrHaDcla8+qPz6wZg7VonzEcw6WnZbl1yto /6lMrKXU J31CQDNYXyj/b+EkuqumcpFj8+Vo+HLSdpi7mk9zFBCgHRPFBMgb/MASAXlxhz0SLy3lTviRsFzZW/zrdvsu3zsJZMNREzJDtLFHgxCkNoG1SIc7KmJ1ub/EVA+VVuvGRZzefq3soVsjy5IP9FcF5bj5ClrpxQHpMfUx34v5p0BtSQG2OGm8Cw1nbmpxprBYmb8cmoaD7dVY5x3NGEgzRJWjgiORqz+yptDBtFaDBLdy6qKTXNjIMA9Lo6Xor5BK5bd4nUICcKXePD17V0/q5wwEzxLzMbTI86vHdAdZx3YrDy+SrM7GB8nqKoQE6NhhmHSY2T4v22Rcy5Wp7Igkr2I0PvJ98JdjPIwMwUh8es9p6kHt+mtg/mMJp5vsFshMFSI/GCHQa3fSuRAN3ggzn1jW2H/OjxDdmzUFJJIx6RoCjFAcDm5JdwnifXKyBwpJGrpLZHzLrltA6D9DKG/JM9e6JYOw2hNLjcq9HTfHh5I/o39R0XK1tMSUZdPmRWogU4V9S7KTQ80zCo6T2eEl1W5IdjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 07:20:58AM +0800, Vernon Yang wrote: > Since commit 081248de0a02 ("kset: move /sys/slab to /sys/kernel/slab"), > the SYSFS path of slab was modified, so fix up the help comment of > SLUB_DEBUG to use the correct one. > > And now the "slub_debug" parameter on boot that is support for more > fine grained debug control, so fix up help comment of SLUB_DEBUG_ON > for "no support" to "support". > > Signed-off-by: Vernon Yang > --- > mm/Kconfig.debug | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index fca699ad1fb0..732043bf56c6 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -61,8 +61,8 @@ config SLUB_DEBUG > help > SLUB has extensive debug support features. Disabling these can > result in significant savings in code size. This also disables > - SLUB sysfs support. /sys/slab will not exist and there will be > - no support for cache validation etc. > + SLUB sysfs support. /sys/kernel/slab will not exist and there > + will be no support for cache validation etc. After commit ab4d5ed5eeda ("slub: Enable sysfs support for !CONFIG_SLUB_DEBUG"), "Disabling SLUB_DEBUG also disables SLUB sysfs support" is not true anymore. > config SLUB_DEBUG_ON > bool "SLUB debugging on by default" > @@ -73,10 +73,10 @@ config SLUB_DEBUG_ON > Boot with debugging on by default. SLUB boots by default with > the runtime debug capabilities switched off. Enabling this is > equivalent to specifying the "slub_debug" parameter on boot. > - There is no support for more fine grained debug control like > - possible with slub_debug=xxx. SLUB debugging may be switched > - off in a kernel built with CONFIG_SLUB_DEBUG_ON by specifying > - "slub_debug=-". > + There is support for more fine grained debug control like > + possible with slub_debug=xxx, details in Documentation/mm/slub.rst. > + SLUB debugging may be switched off in a kernel built with > + CONFIG_SLUB_DEBUG_ON by specifying "slub_debug=-". I think this is a misunderstanding. SLUB_DEBUG_ON is equivalent to passing boot parameter slub_debug=FUPZ, and what the help text says is that "You can enable slub debugging by default using this config option but there is no support for fine-grained control like what slub_debug boot parameter provides." IOW SLUB_DEBUG_ON cannot be used to have same effect as passing something like slub_debug=F. > > config PAGE_OWNER > bool "Track page owner" > -- > 2.34.1 > >