From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE5EC6379F for ; Wed, 22 Feb 2023 12:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC2C06B0071; Wed, 22 Feb 2023 07:57:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C72F66B0073; Wed, 22 Feb 2023 07:57:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AECF86B0074; Wed, 22 Feb 2023 07:57:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9FD9F6B0071 for ; Wed, 22 Feb 2023 07:57:15 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6D2DF806BD for ; Wed, 22 Feb 2023 12:57:15 +0000 (UTC) X-FDA: 80494928430.26.F8E1C98 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by imf27.hostedemail.com (Postfix) with ESMTP id 7959D40010 for ; Wed, 22 Feb 2023 12:57:12 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TntXxiLz; spf=pass (imf27.hostedemail.com: domain of jgg@nvidia.com designates 40.107.94.71 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677070632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8RIZyLsJETVGJGmuhJEPdBBNsg/5QmP04eJhuH91Hk0=; b=CbJUxuQPgN2+Rwn9ZGhx6UQe8YnY5f0jQU1u5hsACpD4dkxC9THb6qIN0vJYbQSMqG0oN5 CkfJGgYmzFN2+WeHZ8wczWC7iDLo8P4b4TXqXaRzoyp0uCO9RGJ53pQtWywxBbBkwrXee8 +Hb/sbZa4CKg0tZaaqe3eqsGigE4h0E= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TntXxiLz; spf=pass (imf27.hostedemail.com: domain of jgg@nvidia.com designates 40.107.94.71 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677070632; a=rsa-sha256; cv=pass; b=aXMUTN3SAHjDcFA8MqvWSR50pfC/CVnHqYLC+3ttT2i8RpunsaP0UwUnkF8UVmiUnhxKDT koBVY4sOIUxROBLF+sp0cAraoEnPMt7pO+3VjVYHnzjWXd6XwMJbQFPRTUdp6RLTmiOC6s oSwz8kFr8WLDFmncIL9RT/8ck5jmKVw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMBPJsQpnyoHlZYHjWY9058c6WWqBoIBE9B2sCOhGls+noSTWj5PqGw/jThQK41ncUn/lhkj3MjSLlrhL9UW5OGjTc/mhRi0K0s2sj++Aw/z1zbN1+b8r8wI+TVYt0LJXT9GdMBSQgu8lf20VGI9krUyPzDqT6y8dNt9TEVUcOatzrw7LF+xPY+8wmfrL7sGKNRfz8+NAL6hD9jBAqdCV3wkihQnzodGaSQTM7NfcxrhqgyEbn7cWdlDmkTM47kjNxrOOzqQYcny3yh01vaBjYWV88NXKQwitfx1CdgHjW8cvM7lCFD8Gj2Sl9si6PN0DHBxB315IDEhXSKwMwlTZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8RIZyLsJETVGJGmuhJEPdBBNsg/5QmP04eJhuH91Hk0=; b=ZPqpb0Y2E0XKyFOG1uxRW0AWAx3mTE6W43449jvPttIykO6aRRCFwxjk0neHBWZU2Zw3r4QwuASfM1Hc2IT6XQP4lbMt9ga3RNe7IfFN3YBEO3XMzWnp31W5Txbg0MZO5QGi+T/psRXx3/gzxVUcPTXLOw0FMx/plseWDwnKSkS+7iax3iHcs2J8e4Z3BsHqYgmlZ7oIooEUOJmIhdCUx2urHaefzfvKuL1Cg6oWRXBHOrMNzgiJ8Elq/BLrABMJ4LLNSyAhCzYc5vVhlpsMltPw7T5OxTHdvteeoXx7VBpioduQeuDjVpdxUIecLHdXHreqBlwNxqCoR9o1wbsvKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RIZyLsJETVGJGmuhJEPdBBNsg/5QmP04eJhuH91Hk0=; b=TntXxiLzAo+Kamy6sH0IlJzfsvDL+LHTJlcaP+B3dP0AFGrcME0nXipcCynUyCXYRGJh4Y43dCasn+qINtYu6HzXGHUgA+7OVUnv7LGUiZjaNLLRQEB+FLEj5ztLxfXBv5j0mCwSwlFljuSSqx4ba40WI3S6GoP93hD0iDGllbGUGyxhCLw0A5VU12o9njw3dDkpXmbFHxMyq1S8TuNJ9MhYin1/h7KAIgRtZ5+rf0bxpX8D5x76Mm6xXji9nP5GN2wikXoeJl9I9zW1Dwbu5ZU2PYqo9D3WzB/JNeC5tXawEh/yOe3WVCS89cLgYVKQnuadOG0jNdI+Ici2SDhXYg== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DS7PR12MB6046.namprd12.prod.outlook.com (2603:10b6:8:85::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Wed, 22 Feb 2023 12:57:09 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee%4]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 12:57:09 +0000 Date: Wed, 22 Feb 2023 08:57:08 -0400 From: Jason Gunthorpe To: Alistair Popple Cc: Tejun Heo , Michal Hocko , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch, "Daniel P . Berrange" , Alex Williamson , Zefan Li , Andrew Morton Subject: Re: [PATCH 14/19] mm: Introduce a cgroup for pinned memory Message-ID: References: <87o7pmnd0p.fsf@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7pmnd0p.fsf@nvidia.com> X-ClientProxiedBy: MN2PR01CA0004.prod.exchangelabs.com (2603:10b6:208:10c::17) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DS7PR12MB6046:EE_ X-MS-Office365-Filtering-Correlation-Id: 30214c28-0ae6-43b2-15be-08db14d44f14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mUnffRxkAnIFgcgREVPBcEDe4BpYOzKadiljx/ezYgMLYMnEF1KgeyBwBX2Df9cdx7yNPgSbplJlqUBmyO/U8OG288QBNZG25lD+E/93UAym/Sb7MIxIpVpFjML+zwczjPurTmiARtZjifdbWbd4Ov0MimVJXINt8TEkpPM4n50xTNNwoWxN59vLFCnmfCgLN/hMA8D5T/T8wu/BImUHkBsLJuBG/Ywn2D7zxCUWV4SwkvBQFn1jAo2s1vRuhEbKw35drdQUq/qpntm99ie+SnGmwIs7wQOk+K9JKsvOit9MITIPnDi0QHTZqi3D77Fl5Lamw1wAPhlFilF2V3VgG5lLECUNuQYGpb/27zl2Z+FrHylC0SI8UGLrPS4gZthbRTm4J7zgANuCuo/VXiKtItsEk3WThJ+1H4KoYVyEPrqgulUHBxwQXz1I8UQAN9layhKLDpa+BOuS3MCfFbRExtuyeVmI/nrH700S9Rwx39wFZk9vp4VDDGNViDo+pNMxoH9at2bPSHJ3juSpZ3ZLmcLXdKD3JBnhadjtTCPtF4Rqcsn/qZel49EVCGrQn9SsH9a3KdkHmVlIIEhGYRX141KfajPJUPyA3xlR38BQEAg0dWmdruFJDGLpDgiPjQDvZ2xZtnbYGl8vm7aCqyU5YA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199018)(2906002)(66946007)(36756003)(5660300002)(41300700001)(4326008)(83380400001)(8676002)(66476007)(2616005)(66556008)(4744005)(7416002)(8936002)(38100700002)(186003)(26005)(6506007)(6512007)(6486002)(478600001)(316002)(6636002)(37006003)(6862004)(86362001)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jxVfF1kOMeS/g14MOy5OpOXJHRwehC+lwdB4BrqjN/vfL3A1HJAqUmVts092?= =?us-ascii?Q?yec6Cd8w3UkfZG2wqtQTfW91DjD5SP+wX0NYHBg4caT5WCJxPV1r4ZMYYVth?= =?us-ascii?Q?Cb4GQ7stK2Bzg1eg/BUZ58eao6vu/zvUVxDLZojYuIGQA0z+ttzlJeN8BKB9?= =?us-ascii?Q?1DX8ZJU9GCaG0AUZ/rIIhit7FhEIVhucxy+Z3dLkEZv/QKQtUNKjqByQOsN/?= =?us-ascii?Q?ueEHTAXRrlA11EtqbgI70eJC3tGKmDDkB4eEljUjhaZcet0+RqmlaB5lJ+Eq?= =?us-ascii?Q?4EpxhhwoaEkJQyj3yxxFmcbdFo2kc2Brlwb23UkKpac4tR2h0ZQTMZnKDMX1?= =?us-ascii?Q?knDY+YNk7gSCaOLeU6IWAqRmF7hA7mKASP3eDGF4u9sDkYYdqBx7gImqPgPn?= =?us-ascii?Q?7ZXGalucaoaD+q4B9k1EUTHgtMwj7TZEDRKNLImBKK+M0njIAivfhsXx6SV0?= =?us-ascii?Q?1F5y8LW6dP+Ft4T6MlA7zePOk8tzWS/yzzLMwr3uaGCi25UOm12DhS+BJjSU?= =?us-ascii?Q?Abw1X0uU35YTpvyiwg//c0Zh5mBYhTocYLXwTaUmFbK5+3DV6U07svuX9a9z?= =?us-ascii?Q?jwSf0c9CR3228EilO/o6khAyqGVaNkTRDLTANL/DwAJHHdtzBqtn+kMWUFsb?= =?us-ascii?Q?NjiCDfB8fOv85LkOTQsYr5Hy8YYWwmgz6FY20pjpKTX98w7o7jbB+ttBxMjO?= =?us-ascii?Q?CgJIgpiigW60MWEr6NuL+ft3aKHr+xZ5/LnQ1KVurCm9/KOUHIFJ/UY/Ka8h?= =?us-ascii?Q?k+6KKRTVk52w4rAxV2P76vEn4Jg4+GZIE3O0lZEedivlNhfnT+y0MGQlO2Dl?= =?us-ascii?Q?dJ9g2wzdai+GdE+j6833wXRVzg+bwgWznTpg9GJzzs7I30IEAekJYVtbUNU0?= =?us-ascii?Q?/hfNdI9nSHO7hqQwtfZX/8Pzn8BomuVQ4aCnIgT7fhUUOteSVSvqaeu303v2?= =?us-ascii?Q?5p1KOn5y0bhD9PaHflA+MgYuzYfP0ovAjvzh09V5ob60W+cXNJDwS0ShyNdJ?= =?us-ascii?Q?IPb9or2cHcaaXxK5+vFSVQ1T9+7EIwOLd6MBrqXZ6K7sRM6j28aMuFOLuaX/?= =?us-ascii?Q?SzjCE7JG0eSIgUQAvon5YcSk7D3q9nt/KGZ/i8krPSoNMlI6g1R5+Y78HpEu?= =?us-ascii?Q?RioEOU9lWzexvKF+hCqRFrDfMh2GslB4HqU7Gce1j1xYnCM5dr0j/T2N7RQU?= =?us-ascii?Q?bfl/Qe3m2ksUOYIoqlUFt1iTaUYJvId98fbXeXyus0zXT1xVGIhT5CXPnWem?= =?us-ascii?Q?sSssSFkY9CPRfpf56qJyAOYRInhSmsOIA6ch/V1nBUwrqCRMNnim5J/RaprJ?= =?us-ascii?Q?5QEzg57jT1vFIV21GcOyj0ahR51RmZ+yFZ//VbWPqJ6bfAmd6nLNu+Lw6qRa?= =?us-ascii?Q?X6yLSikMvhjv60fdF/35KS3zyTk0Cg3C6GXJVHuZYdhyVfKC4l2KG6j2OHXq?= =?us-ascii?Q?PawuCVkR6FWVc5S6QJ6qw45Zjb0Xm1FwhEb5E/f+7B4QBPWXP+hp89sV/sW2?= =?us-ascii?Q?JKSugwW90PCdPmLufhn8rv6g8xeLF/KdPDKAKX5tBp4XVL7BZSENtrPpIJV0?= =?us-ascii?Q?2zPLRtVvj2oiUeifP0XmNRdxHU8h/XQYhUmKi5tK?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30214c28-0ae6-43b2-15be-08db14d44f14 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 12:57:09.6645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VaU42E7bGTumRqyB/MpNaUoCWSgngUZJiRRmTMedmP/npvjv4Ab9rPrUWu+vsLSC X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6046 X-Rspamd-Queue-Id: 7959D40010 X-Stat-Signature: rjmxiemegf13q3hgqmzm7b4jqf6g88yo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677070632-534197 X-HE-Meta: U2FsdGVkX1/re5WqQbqGU4qAffzW6BPqvOr2Itje2nRzjRsxkpDrtcVqe6NPqERIJEMi+ECEWYqzQZo2msG9akNe9DTa+/vlZHGipYbTU52LKE7NEEYKJV+jcCiCWWz6grqfQop4wuEf5+UAU/ECOemrPKlc4HTx5rOAEBfdtiog0Z1unLAHTEyrtgfv4J5h0wW75MyAU/uTQ3onCREVSWfQM2k7yE+kt0eGdeQaRT3RClhhgU3SfuUess1LugJtaJvnNZYHWm6c6/IpC9JhA1yHdUpedngz9RnVuptGKU7AsRGIKTznW1/0b9jwK3jPcv96mSRNezlr42Ocf4foeqClrvthLr2EwNyerZ2VjeKbk7O+TMfPm956jgtgHKKARutFudjlyUveJUbDKNsac5S5vhBlObnZSDAK3pbVgzkgu+bt0LmCGdVeuDV5cw9XiZOEcXiebiuSkH0I3LCIDgmtYF2iMIRZ65sHRi5f+dDX8KgzXlfhlQajBCPC4iNYd4Urf+KnaQ9SKPuroBKDGGMFedd2nKVlFl2OQWGaVjDwlbNX0VBfLwpv7RasqbG2aVEtJgy+PIbQOrFW77oQMx9fUaq9JKPKMy7NssNxCAi+x5wvOsOQWzzlFWgkmvqnZ2UcfhiTMsW1pJfMcuSLVJQSmmWybJaU0BAkQiyzfd1TsI8T5l7A6gUZ6fJm7q311rejXtcWLnyDt/GrSAXh1dTE63NN7baX00Y8foULwDM3xwOH+9o+bH6KyNWTZYlmLV9C4v04BCjYB90q13upwNgDe5g2kcdKboK/fPXJwSyQ2oObTVClYgYKG3da9Z+iPYd4udJn0oyJpR4xqhso0x+TYLEjlGWo2mY6iEq1R5cWoWUmrgeznqJOVZkm8PQK5UA147mKkbGHbMounyPM8MxVLhBRwOhMSFImbUn8YbJfp8qDDnJK8VOMP3LOG+nwLvKrzusCfHCBEDd4FHM bj4pDx4g pddafdYOmtY4+KqJHnY7mPDdZldGCoCFW5QVen3VwATZtkZkPovgbQ4Lf5ndSobPnuV9Kv3UPBLJOIp9pyxYvODiXhIPZhbjRpaRVvsdhN3LmB/F0QPj/z97H1qXYUnbZIUyRVxB3WQVTQWN6XNM+ivBpWi1PTAUuVyoMKeEQVZA+do99PBGw9B5ffmyfqdOSwEMD1aPaTgxknBavP82wKdo/je3PTygMXY8mqXAZLzZ+kR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 22, 2023 at 10:38:25PM +1100, Alistair Popple wrote: > When a driver unpins a page we scan the pinners list and assign > ownership to the next driver pinning the page by updating memcg_data and > removing the vm_account from the list. I don't see how this works with just the data structure you outlined?? Every unique page needs its own list_head in the vm_account, it is doable just incredibly costly. Jason