From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0183C61DA4 for ; Wed, 22 Feb 2023 11:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8DBD6B0074; Wed, 22 Feb 2023 06:25:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3DEF6B0075; Wed, 22 Feb 2023 06:25:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D064D6B0078; Wed, 22 Feb 2023 06:25:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BDE1F6B0074 for ; Wed, 22 Feb 2023 06:25:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8D4B780C58 for ; Wed, 22 Feb 2023 11:25:25 +0000 (UTC) X-FDA: 80494697010.25.BB6DE48 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf15.hostedemail.com (Postfix) with ESMTP id AD913A0012 for ; Wed, 22 Feb 2023 11:25:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OhuRhu8x; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677065123; a=rsa-sha256; cv=none; b=P37Oj2cL5FCHz9IStRNQRCw6XGlfPobPIDxAz0/viMEKBykeCKxmGdlfGATglrDBdhxo3W PbdkWflU+lZrIBwNg4GqOHcSamO3VrBXOopoKVL6qz8FoQKHlna+UjFJnf69UULvlQe4RI wihrjEj3/M9D+MrzEBXxis+GUHfTPAI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OhuRhu8x; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677065123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hO7PfBRfir+KLtGVIIsYXsFaRSKKrOVmPKpnJ6eH2zA=; b=MZfOZbznbLTOM5oAX/TA7mfKz9mm2MX3WcfUY2zgNUG5ANLylMxuy7Mu1vHa5r8sYhhbgm NKkmIDuKxkdkqS091WllVuOIVEQTELPSWfUO2RBPAMIKG0nUCzQ7NNe7tfOXEfrHkzuNNE q/fko/Eglph3A3PBtLbsN0yO0c/UKk4= Received: by mail-pj1-f45.google.com with SMTP id il18-20020a17090b165200b0023127b2d602so8031170pjb.2 for ; Wed, 22 Feb 2023 03:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hO7PfBRfir+KLtGVIIsYXsFaRSKKrOVmPKpnJ6eH2zA=; b=OhuRhu8xoNNQgB+WaFOdA5zJcIxSZ+Iom4AX4wjkvNc+903l3GFDs/VI2vEVABEbXH soqezrWLEvgU/PAD0+DMOfaViE7KiNmn9k7WDl2a29Y/f7M8LQRJjk6R7efPZc5GQ71e ecIKGah9g35O0TmKzUKqZTpwYoY2V7SJF4aV4IP2Gov3QF2/jmdXLxO6JMCBlFrg9Jl+ 4p1NiQuUQAgYb4f5rG9bTLhnNouHSfZ7C3czL4UOyyF9jFZKucor01o+G9EXLLzXk2Hl oTwvLu0JJL90PeqH+tEF/uEdvrVNPccdgGNdpUgW+9KOiOep+0xfMtFXSVQNNsFEnNY4 qXyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hO7PfBRfir+KLtGVIIsYXsFaRSKKrOVmPKpnJ6eH2zA=; b=x6ttSaD7BjDjkgZUQw1tfES8iD7BYczwDzzpy852I4BWXsD4azxNgC52tBFnmRDHQi kTPzf+dRBmCapEoJMYNmTsM5SIRaj678++KUROUmFTFDLWvKa04BsH90aDItBt6rwFne o7N39PVvdxsp7fAvGQbUdVR4dE5o8+y+jLmjAmTisLlcfZ9gQB3NNvuoKLygDNdUyz2K Lqhj1H/nSycBzgUzO2ZOnOSrYRzyM4NO4adp/2YtVsPXxjN4uh8GbUz5KFuyxryUmlhO KjpC+tpi5GRiRf47QK7So6GQyWXsNUce8bbod/DuzXnWp+FA0++IhT1E9dyouEMkr0np 7vaQ== X-Gm-Message-State: AO0yUKUaL/+tG3J4U1TnfeKK6EgNwLmrBqbIqlg7x45JdsOr1BfdLcMl kSb+Hqbb/Ed/PmjU7oTWBak= X-Google-Smtp-Source: AK7set+zhBNyBRgU2wVAGKr0Mpvlz66l+wzqzKarV7qvYBWiudhZ/AYgXgddmX8Xt+M70kTrHrM50A== X-Received: by 2002:a17:902:c404:b0:199:3524:ee93 with SMTP id k4-20020a170902c40400b001993524ee93mr11048176plk.53.1677065122368; Wed, 22 Feb 2023 03:25:22 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id e16-20020a17090301d000b0019aa8149cc9sm5681613plh.35.2023.02.22.03.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 03:25:21 -0800 (PST) Date: Wed, 22 Feb 2023 11:25:16 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: slub: make kobj_type structure constant Message-ID: References: <20230220-kobj_type-mm-slub-v1-1-5ae49b96d9aa@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230220-kobj_type-mm-slub-v1-1-5ae49b96d9aa@weissschuh.net> X-Rspam-User: X-Rspamd-Queue-Id: AD913A0012 X-Rspamd-Server: rspam01 X-Stat-Signature: hqn5hpaqsnqtwqmkudypb8sr8awygw1b X-HE-Tag: 1677065123-332894 X-HE-Meta: U2FsdGVkX1/z8fHm6k5nei98DMsggYmqmh5rSrbq8wymQzGis4JaQ//fy83T69eN8MIX/SBbJmpGRjaMwjU/igpBke8MSqxWkp9ZdHrxi717JDH1EjoGEgOfrLQ5DccNcPRbgW+teQdSUQEQkmk0e8ni3ww1OcLCiosIdyx7C6FGu6BOt64OYxvWD9UKHANT9dnBPIeccSL5wsV2wS1dbn/FnwJ/0TPZpR8ob+QTxGOGQS75ObhC+Weo5k5CG6THdJEZ7R/uxYbPpxKlPy2ooqv5E0ilP/YDJXnDhFIbgNYH4L8Oq1A91k0xtcSsJVSbWkxKdtnp85K47dGavPkGNj+6eJtNd2JQ8x5qGdCO0Ai1Px4IBzPcXF17ZB5L5uPW7irCFIF3fhySL8Jmy/CfgtKDHGgMTPZIugEquGPlsz1coNiFvMqrycInvdv/xXSoZOsuQqq0c3fIg/+RXl0UzGwLxFEFdoDDni0U7IrOrdwdED7EWZiK1WZC/5iiaI1lYZps3lrVYqXFLbckvDcNsNuf7c7Mg6siXR1YcYetfvnqr/A2kEYJmh5wYbQtlLVWjGyT4khNLaRvegey8x3TeCWBl+q+rtwn787AYb4FstHJ9RJiP3IZM/gifPSiNKLqlXx5/D3ii0VruO1oMHUhv8B0jOzSagDyLsfErJi5s5dW9Vx4P0IRPAk8UBY2G3HuZErPqfoF+DoNvwwKBhM5iwOPdF4Gws2fhaw08niAkdzGv/B0fuLNoyEMx3fFqQwyrKD49gaYjw1LgtdDNlOqLY3KzEhaZ1EBoagSNV9ZiDJiizfiLAG8sTkAP28eZbQWWPXTQ6uz9WC1/fp7cp5VcBOLWhqMkFfPDZkDhcHWoGVMR69TcOtb4SEquNRQ8Ewxt84HnNqPni0OpSRyQ3gCKdqieRMae5yW64hBRlzyhea9zX39PIyGosBwLVgQFP5jixa15l39MlOyTNRo4R9 CJwIMJrR k+o0VhzUFhQMCAc7FAfuZ4FDfPr4U/FwK7+GHwlyx71KeF5eU0BtKkDx4wB8GLJAhCDDpUfDGIFZgmgxUwnoKcwM20dDZEB9f8ReKV7s6zBwnz4G2csonBTsGEqg8S0Nfdu6jupzlOcitu+xhsw0dybrK1X+0z+OtPwPYSYYXUtyZGdb1nRV3fAZ4qCz0AUC2WXM3lFfe7iCmpOmMiZfoOp4Is8F5R2dDljWJiTa4aHkCL8JaeDZw/hW25fATOqaQQLTxzjCHKpcWyAhd68j6PiR/zlY9Jy6oHjRi0OnAzregsoAFkJxSYy48odo4lmZDNan48vh4FyZoi5pMLcTnzyJjJ6nQCKID+i0nloA3gTxN75Dy9PTJPQGx62ZOHnhdnBsl89dRW2Zkv8dtCXvfmvX4a17BDj6kSC8sfH5cbGPWUgqZtzx8LcNVaqm5l1IVBiTyRLJPjosv5jwxoGNmVJjfWqi7LgB8awkFxL+10bDGAgD5x56qHiWpk1fnuajs1TSZTGCnlGIWHrLDfljpvuC7oUB6PaVBAIYPKAPDc49KrEiaWVupdFd7PSz71iWf+X6Bfu+kSwTa96kJWxKxj9GCaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 20, 2023 at 11:25:28PM +0000, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > Signed-off-by: Thomas Weißschuh > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..be710dc4dc3e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = { > .store = slab_attr_store, > }; > > -static struct kobj_type slab_ktype = { > +static const struct kobj_type slab_ktype = { > .sysfs_ops = &slab_sysfs_ops, > .release = kmem_cache_release, > }; > > --- Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f > change-id: 20230220-kobj_type-mm-slub-02d25836de84 > > Best regards, > -- > Thomas Weißschuh >