From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AFFC64ED9 for ; Tue, 21 Feb 2023 18:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFC536B0071; Tue, 21 Feb 2023 13:07:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAD356B0072; Tue, 21 Feb 2023 13:07:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9746E6B0073; Tue, 21 Feb 2023 13:07:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8872A6B0071 for ; Tue, 21 Feb 2023 13:07:40 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 45E6A1A084D for ; Tue, 21 Feb 2023 18:07:40 +0000 (UTC) X-FDA: 80492081880.26.08A02D1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 19C8B14001D for ; Tue, 21 Feb 2023 18:07:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GgT9u5As; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677002857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+VHgVoH4rhQlbOR9gyRg+OIINMKrgOyHyhfXdy7NEHY=; b=JlgvctEOTRCMFOOtW7DM/UXsitj+hhFrkE28M4Z+djyFcYQPwlLMgOBV2mTd+r7mjP31US zCJMF1x4C8F8O48S3IYlCAA8PBTPPWUSegqOvW4PNwtiahsyd7cqK8rjmpQ6pFhS8QUBr1 L8fPDnLyb5yF3AKFHG49dBaSwzFEtAg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GgT9u5As; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677002857; a=rsa-sha256; cv=none; b=Sjn4XMV3ZAF6xJG0T4AWp9ISWRkdUfQYTQDZLS01zFNc+e+o7KYGW23GLcTmXegTskXneg zlRiVFeNfi/RTxA0+YfmANFWVu5Ltgtgk+vWG1P4Ne9rtvD6BZhtPxkH+r+nWMVjriT91j LrykO3+DRocN3U45xcwukHf5x0sHqkw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E55C561172; Tue, 21 Feb 2023 18:07:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DE90C433D2; Tue, 21 Feb 2023 18:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677002855; bh=inZczsHsYNaB8VKdgJwc3kO+Gw7OxcbGlqiKZIegzf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GgT9u5AsvrvQUMJGcCHyMcQV1lZHxpzuCak/p36lArw5KxSKkV7KRrw2x7+30NoTI qJqOILMqrZnuwLysM2/BOEq4ArVad09Rh/Pn/sO/iTNEwAefTYJh3F5vvM/cZm/KFI YvFj/0MSG0w5kJ8HPYjYBg0BjqRu3U/fhuJr19/lFsYcJLCsWIICa6YF4nM41oT+Jg 72n3gv1hRI7yQB8kAgByQlH2U0wMe8qzlQNKOVm1KeOHkfBDRkHZTnBVh0yuSH7jcU adu48etsnWkEfy9kTGEPPmCpSqjQryhyLwCs8H36LaUWN+h14n8pb7l1FpWwKmkhlG cJPwmbGbm5X2A== Date: Tue, 21 Feb 2023 11:07:32 -0700 From: Keith Busch To: Christoph Hellwig Cc: Keith Busch , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue Subject: Re: [PATCH] dmapool: push new blocks in ascending order Message-ID: References: <20230221165400.1595247-1-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 19C8B14001D X-Stat-Signature: yfrnxb7h3t8etsmgrdk5kkaocp7bnnxr X-HE-Tag: 1677002856-356900 X-HE-Meta: U2FsdGVkX1/52aqsZCx5IiS7aSa17qm6tA++A0A0set0GBU66cikmWdP/LGHQ3X158yze2zvIk4c12ej3eHj9O7AcLO11DWbNyELbW9kG/HBgpcEqgFtnGFwlVNnDHMGl3eEVttRhdFMDasA8gPwwg69CmNRs5tILRRsLm1xpdiXqB9u+QofXflkps5wHy/JsD/tCwsfGbD5Tkcgjrx+ZOac/v9IdKDrMs+4WRepwlMSB/hbSf6Ghu9cpnwit5Dgc/Q4r/2+tfFJaJXdhd49evQqMWw8Q5h4/H9UhwFsvzxhkBethi5gAmtFJW6OT9yQ5tMsGw0sOzTlFLSTmWa6x+jh/2Mv5VxHR2sZucQKQd5DqRwsxh6GnuHjTKhF7Hf/BRVv5pW/hCwG89uH3k5qt7qgZUtWvu93wNhmJojGyqftV2kLycMqXUNgTJHkvz2GiB9CKOZqd6C4qWZTmd7FNmfda+4hSguA8f7itS140tuDO7iKh9FSpAhC57j0gapZD+tUR3Tb50aShoBEhrqtTxKD7tgELNO81Aks+R759cH3e+YlR+N82houJapmfavWdqnw/8y60sr64ilc5dBQvRwb+cc5j8ZP5lrhUeB+czlilI/5piiwhQQhlSj/7iCxggVlK2sBqKFO9JKifai7gN7xgzwF58AZ+6/Hp9NDZF42myI394s05OipDjsHW8+Shql7tmAcr9uHWeEJ2me2fI7eNmehbTRl3TpCqjBkt5828CliIxDwqhfc+UzBEq2ykzR9nrfApRukReKZobPYqrhOP0g8TKEtqOhxk5hwQgDlLKHMXgwB752y0A0ofRZJICdD4EQAboc5anqxDYmXZBQi39I5BMEfw5SrXKMLyGwHS8kkRGtBES6x4M70FnEYnA3fSnbFM+GqiybmHsDaEWE6sew7Yjnub9W1jLhz8f7NIl+6dFzcLdKcldL2LABFbE3QHv+Ap/pnhBUv9lD ljpG6FEw d7Es0HlFkXo0WAYiBmFvIVzkUUlQjIxeejcQlXJTf39aUEU2ZvviJ1l1sdwVAKVsIhp/1FGucdkNVSuBzxXGWx0mENgtq008KnZgRM50VAUexZ4BbjUuPXLntSHcmijqg6BD4joDroeDh70sqKf5b2kwHkSp4Po/XBOEpfvU2jCXY9+VB3oYBizO1taC61fTSj89Xb0WFo7ONAn6DGGxwmNLXlwi9Dem05EKpdhmILs8dyoP3wWSo43mi2sGUUPfZsxGJA5kamzWcdiXEWh2EGCpbkwtHGni0fF2VaLFCpo5K6eIDQy+HtEYDhZK/1qVR94M6jlzYkhq7WQVmIkMarMdWjQQPMgo/caEWhK5qXq/gtQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 21, 2023 at 10:02:34AM -0800, Christoph Hellwig wrote: > On Tue, Feb 21, 2023 at 08:54:00AM -0800, Keith Busch wrote: > > From: Keith Busch > > > > Some users of the dmapool need their allocations to happen in ascending > > order. The recent optimizations pushed the blocks in reverse order, so > > restore the previous behavior by linking the next available block from > > low-to-high. > > Who are those users? > > Also should we document this behavior somewhere so that it isn't > accidentally changed again some time in the future? usb/chipidea/udc.c qh_pool called "ci_hw_qh". My initial thought was dmapool isn't the right API if you need a specific order when allocating from it, but I can't readily test any changes to that driver. Restoring the previous behavior is easy enough.