From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33B9C636D7 for ; Tue, 21 Feb 2023 18:02:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D4E46B0071; Tue, 21 Feb 2023 13:02:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3845A6B0072; Tue, 21 Feb 2023 13:02:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 273B66B0073; Tue, 21 Feb 2023 13:02:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1A9EC6B0071 for ; Tue, 21 Feb 2023 13:02:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E914B12020B for ; Tue, 21 Feb 2023 18:02:41 +0000 (UTC) X-FDA: 80492069322.05.61E2F18 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 5CFD810002A for ; Tue, 21 Feb 2023 18:02:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=e3+WDgzi; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+d64aa7d7aa21187b0365+7121+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d64aa7d7aa21187b0365+7121+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677002559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1XB4oCS6CHHF0AIEzch0IHKDTwchheWarRHgnJZhslg=; b=YHXLToNwTkUX8o2qBCHRkYykwO5n9hKmMt1AgCJj8nKqK/yrlRyQkau4aMd3R+OrROxJuH zdREc/EmHjQ3h6rdqHARo981sMRUGrNPEdSKjuhGWj0hFedkj7j5E863PxtAZZPt6/bCkC GOR/LmBNWbf9Eos4M2hpCBrbT0DkHNs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=e3+WDgzi; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+d64aa7d7aa21187b0365+7121+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d64aa7d7aa21187b0365+7121+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677002559; a=rsa-sha256; cv=none; b=oE7XQZz2tUsdrBsciXS5kzsM4y73BiJu3NfK3L/9HYM5tmlHQQ+ZBm8WTtAbpaqcgNyrhq 3iOvu0tscHj/7c5sxjOMI8ywZMiD9Pi2BhuOYSoz2SnhhSMEGBAg6KOGBcj6LqXo2uam2o 46IrOdnTJ2EkDv5euyKeMd+AeSihyy8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1XB4oCS6CHHF0AIEzch0IHKDTwchheWarRHgnJZhslg=; b=e3+WDgziFd2vucgPtJlq9tlxAk 045GDm/UXJAGGlM2fMgRzWLxRUyowENiA7FUDIJJQi12/IMQBEpHtgQ+5ckTMIbfrJbIzcQXIbB3F 7OP1k8wASWRGAM0zIMmsCHr7BZhB2B30V7fF/i7hPRVCnhhKPh5OodqwKQxG0MC/pzLl/gUypTsFE +B2b4Ce5d/u7mrDc6MFX3m7+iFYuowfG/IEjMOwIFjb5jrFwBqwe9/lgu47QMk6lYu3jHHJT79Nji 50V30WNu1TLguiGQq1kAkKWf8A6v1gma9mWJazLehIy75R3mfCIFy3gEtY+9DJ3bw0hEhu9yATrKy /emGxfjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUWyI-009GfE-31; Tue, 21 Feb 2023 18:02:34 +0000 Date: Tue, 21 Feb 2023 10:02:34 -0800 From: Christoph Hellwig To: Keith Busch Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keith Busch , Bryan O'Donoghue Subject: Re: [PATCH] dmapool: push new blocks in ascending order Message-ID: References: <20230221165400.1595247-1-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230221165400.1595247-1-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5CFD810002A X-Stat-Signature: ttcz8yd8yi6bdkoz5eeddrpyqowg7m37 X-HE-Tag: 1677002557-282858 X-HE-Meta: U2FsdGVkX18Wmx27yEgmzxaGuHrm7x0zkYlI5aZWa2HpsZK3IpF9D931V2esKN1aXBsJF7dU0vycM//Nv1hqSNJILKKrud4z18Txd5Ao+f7ybggrI6jv0VoV8SLFqpwa1zj923KqWsBS3H3sqe4cooErx/pw+BaCiIBY4Tlrb2GO/Pi1DcDer/txvURoA3Q+jQCeFiAtJhcHmgbirciCfbmOKKKvnl7Qz1imaSnUqtE2jU4puZEYe1/CUmBlPmCbhZ8jjkz4cESuzQpgLLRkCbNr2HdzcLEAltkoN/Fk+m/eofq5lf0BcVDUb55RlOmqXfkdQYbfYYz4Alj+aNJULwo0wz3/hcWcXoWocGg4CUi4zgMAP2+BfGUDYgFtFoF/UYw6+9JynXMFd9z7C4bxx4gMEMyg4OSCMyL8xX6xuEQ/pbO+jZgh7Xa3CEG+OtFpMSRyKmzC53GVCa6qYiF+D/ijJ8g2BnDkcxOYPILbnnosfEAAGBsCpKSi1AT2ZqlVRhUFkT4xoHqbehmfYr+l5OnAC3YkZNVLa8TqCwnEnlM4OzjYvuCW1WPZwk5kpOfV1O9/sspc1sAnIMkBdBph9EIxKa3oDrgibBOqV0Xu6dbSQmXvGHet/qykmvsUYwbnkaahdvplqbmi1htEwOJS3QF8UHQ5BM9IJ828krmZ3YKOBWhASO4EWSlNnPnVOfu2ek0MHixgx2sxNqpXxHat3BHMouUXIwtjoPxOrCcjmJdCSygSIHRIkAkcS4YrbKAnYYNWLstNYphShWx64Sa7MWZbzFlNbxrq0ihtDaVQwb4D3Ze6iDwjMlZHjwfNXDyFxt7tdJ3S+3BIg9TjwmjDWbT5Szy+Op1gAn/+tQ83wvWOw0AII1OySm2a0kcG2r9Dljzg4sC6yLwPupKHwdhyFD7D6Rlu7QMS3LtGnTmVkTHjKegGYIDTrXqUeLVbZ8EyyeUhol9EffxBGfcggX0 FnNIfSQ9 +zWxxhJ3HhiHM8wuCJBl/hQzTC9zSXWl4JYjQcFfbuqKA4NSmyfKWkrKqtZjRN6P0tG2zrwvLK/ZiS3Of7/mvD3NKlN9OWP2fb2tTrYnP/w+v4U43UU6WcIzrhO1dQqgt2VvxjpQMAOr1kJf5f71mJxvozLmuFDm10bUGVzEKg/1IOOpFWvBlENEKt3GQpZs9aCGxbvvIt2zqOjkovsZ3c6KUiPY0Q0ChkfFGjyOtUTsHwtVKNPjNoSUVZpUOY+vImc+kznOSMB1r5Byhu2zcgGXkvmNHx2vwBU9uRj1/1u9DQgtqPnG8lcGsDt6irRgD/EbId1PLKk0guIfZ277+iz4a1TPpzIj75kGJb/vQMTQ/YI3gB64Dwnte6/R1cHsG4EWpkgl7pylA1Z+km5MoqU9ZEM2x4nuh+BMJUtvRaPkw6oobLDRe8cWflL8dAoBbkXcfNedIH2mbrBE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 21, 2023 at 08:54:00AM -0800, Keith Busch wrote: > From: Keith Busch > > Some users of the dmapool need their allocations to happen in ascending > order. The recent optimizations pushed the blocks in reverse order, so > restore the previous behavior by linking the next available block from > low-to-high. Who are those users? Also should we document this behavior somewhere so that it isn't accidentally changed again some time in the future?