From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE792C6379F for ; Tue, 21 Feb 2023 11:38:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8B726B0075; Tue, 21 Feb 2023 06:38:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3B546B0078; Tue, 21 Feb 2023 06:38:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C032D6B007B; Tue, 21 Feb 2023 06:38:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B057C6B0075 for ; Tue, 21 Feb 2023 06:38:20 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F8E2141344 for ; Tue, 21 Feb 2023 11:38:20 +0000 (UTC) X-FDA: 80491100760.23.E22E76B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 9FD65120011 for ; Tue, 21 Feb 2023 11:38:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ddBXGxVW; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676979498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lc55WDFRFvw1Vqs+va6mBFAzuHzoJKokLr1Q4rpkAYA=; b=YuUVc2d9Z/joTv2Bmrh33VE4VEPaje8g847c7bDbIDeMbSCDbauT9CfW+0YdmitImRzxcD KkqjGQ4rDkfac+cWELdDDQAwz17vC4eApZ6g0acRL+HfpZeCCClM4AUdTYc1asSyhYvd13 qImx59lslHvCS3IS5aWwKRp3PLqRlTY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ddBXGxVW; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676979498; a=rsa-sha256; cv=none; b=c9uuyMwkif6Ag4XdZR2IvTj/u45PiFHF4+qKXkTO2iUbF7+HHSxOQasZbhzsf0qCLKMa7w b3PKAI5BKliVP7t+kqsPZpensDEv4Br1bm1e98ioIpOKD9RrXUQcbosbVwMXd8SWmIXNmc I6Hp+J2HXKnaTxfqujtLBA8QfBQHYpI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676979497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lc55WDFRFvw1Vqs+va6mBFAzuHzoJKokLr1Q4rpkAYA=; b=ddBXGxVW76oo7vw3LZmsC9afSD8/WQgj3HeNZrvAeLkjXrLOJyQGgBjpAua32evz6i2ypi +BZK0cPEfnGJ/naetcqmn4KWplw9YoWF1aiffgVKiq6wZpwh2JnNwXb+zD8vsEkcJsnhdS cf3hlTQAosprc72Esf2wLY4XGXhiIww= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-P12RHNW_OgiRhzsFU9gIjw-1; Tue, 21 Feb 2023 06:38:14 -0500 X-MC-Unique: P12RHNW_OgiRhzsFU9gIjw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC11A3C16E88; Tue, 21 Feb 2023 11:38:13 +0000 (UTC) Received: from localhost (ovpn-13-7.pek2.redhat.com [10.72.13.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0224C492B05; Tue, 21 Feb 2023 11:38:12 +0000 (UTC) Date: Tue, 21 Feb 2023 19:38:09 +0800 From: Baoquan He To: Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, hch@infradead.org, mcgrof@kernel.org Subject: Re: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: References: <20230221060723.26291-1-bhe@redhat.com> <20230221060723.26291-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bgo89jszbe3rh4as9itpowzbudkg3yj9 X-Rspamd-Queue-Id: 9FD65120011 X-HE-Tag: 1676979498-685061 X-HE-Meta: U2FsdGVkX18unZd8Kuo4iBgNHTV9JqWvPc8yKBxlvUfCSy8T03f3u0liMtA8/syHvJjVfknLVKkQRQwFV8ocOMXAGgmnN4nkb4AH4JwzBUoDgyRSv+sp4/b+FMM7Jq9x3gb2ag8uCWanSPgQDe/OeGkSM9oC8iYV9eATSqSnmJaCcfD8OWeRlXhlEM947hnefpgnEu7QM2nbUD6dabTxadSizaJMeX5F052GZyWJ6r68SQaDN399PyOeFh0B/RqDL9bh0Gr2fCx9GNPMPNin2A4og2QpW15myVlLQDR1d5TvxxZNKPfLcQ10BGrgo/lTx4v/yNli+xnXBj26iZ8j5wKdSftlwc46F2fOohk+gLl8pTnYAY2rxdT+vZzWHDUeBI6ZTlvFsyM1JIwMyoigc1ntWYJU/y5R49pzOjrxIlrtjxcE+c2zRmq8kVkzq4MgQPCREFjakCVwicXRTje9wLOUm8+t0DTtEM8oGvulMllKhei7I9cv2WvgDZoODJB2mp6TlZkjg9Wzj3CIrB58I6VwdfFbx7mgNIt/TJz38qEi9R8UFM+ExVbw/Bg0f0zHXVF85Wp4DFo9eEfUeC8hxRqVe/yjlE4f4egzj7coDiad3r+bGwLJ7ILsPuTmBPbS/HZFvcQ5MKOK97j3ltXrpscj4zUeF1RaM0KSdjsha26P//m7DsX0KZqkcWP7T56jPSqrhGngAJzOGbg7wPuscm2qtRvmz/IDiKFxaD+FDApo43y3YviDuB/NDSJSluL/b8gE74u+unxorTheJ0DJd9N33mLwY0OW7AAqAClrxPH9kc01QfLewvThnl8z6pw03D+MpoVdnKPrIh3xAL1ixQbgPcaZorZ4mvT/sGpAq9kygBHmanyobOal01+9BuW5/BjApXOARf7ckKg5ainFHn1FScgfGA/6EtBNJwjX/5t9F7vbkqLyMydJL4uB869IibrvUGtAHxhWb6nvPV/ +LT37XmG grn1xZfEg+cUZgRq9XtC/aF6DSOcoU7p/7cOCbkUv+ofCl2RbufwVbCjJyf82yKl8w6kHtEVWMjx46y2asf+XydVk1ALnozmoocWQEOyx9SHuO03TbE+8OtgPoLsaYM2UYR8FZkYSpDN5lViusesUjU5fvfdOjTteAh9b4lupR0pPmO4XdL0PEFU7KGFTpMXJjK4z+0E5jIreekZ+6TxVlsY3RKJRpBUcLA4avw3g9CNmraUfDDs9X1MKCOQYKsWrCnRNul56ezwknim6pYQubv0LF90629VpZR5HkWruoDqvfCDhl5HNI/Yxk8nkPRcqWzka2Fx+IYdXurgFqTVMRTnrkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/21/23 at 11:03am, Geert Uytterhoeven wrote: > Hi Baoquan, > > Thanks for your patch! > > On Tue, Feb 21, 2023 at 7:36 AM Baoquan He wrote: > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > > extension, and on ia64 with its slightly unconventional ioremap() > > behavior, everywhere else this is the same as ioremap() anyway. > > > > So here, remove the ioremap_uc() definition in architecutures other > > than x86 and ia64. These architectures all have asm-generic/io.h > > included and will have the default ioremap_uc() definition which > > returns NULL. If any ARCH really needs a specific ioremap_uc() for > > Please make it very clear that this changes existing behavior. > At first, I had completely missed that. Sure, I will update log. > > And of course the documentation should be updated to reflect that. Makes sense, will do. > > > its own usage, one ioremap_uc() can be added in the ARH. > > s/ARH/ARCH/ Will update. > > > arch/m68k/include/asm/kmap.h | 1 - > > Acked-by: Geert Uytterhoeven Thanks for reviewing.