From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F60AC636D6 for ; Mon, 20 Feb 2023 17:50:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CDB16B0071; Mon, 20 Feb 2023 12:50:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 986C76B0072; Mon, 20 Feb 2023 12:50:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843AE6B0073; Mon, 20 Feb 2023 12:50:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 717576B0071 for ; Mon, 20 Feb 2023 12:50:22 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2987B1608C2 for ; Mon, 20 Feb 2023 17:50:22 +0000 (UTC) X-FDA: 80488409484.10.442E4C0 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf24.hostedemail.com (Postfix) with ESMTP id 8D6FA180009 for ; Mon, 20 Feb 2023 17:50:12 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=FoUfwnLM; spf=temperror (imf24.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0B28A1EC04DA; Mon, 20 Feb 2023 18:50:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1676915410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=bwxrmMj2mOhFOpUwjeGU/UbbKBMLtBWO125onjebAs8=; b=FoUfwnLMKo9IrSqAIx2RAzvNDd5eyrw8LvSXPxUE5AtEjEvDoUz+Ph+r6XA3M4OnRXT2Vc 7X41bpF9uMgZUtI+rf8WMPC75kqv+dLhNZbzPKL8j+SmdveIJ7IGVQdYFnjzvyMBY4V/Fe GZb2+MVxxdDfLbQVYOzAi6Ota/RbFJU= Date: Mon, 20 Feb 2023 18:50:09 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh , Jarkko Sakkinen Subject: Re: [PATCH RFC v7 13/64] x86/cpufeatures: Add SEV-SNP CPU feature Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-14-michael.roth@amd.com> <20230220162647.czmii5swwsz2wdhy@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230220162647.czmii5swwsz2wdhy@amd.com> X-Stat-Signature: gymehbahbxyrcy5p8qk6m86arkdnx1d8 X-Rspam-User: X-Rspamd-Queue-Id: 8D6FA180009 X-Rspamd-Server: rspam06 X-HE-Tag: 1676915412-340422 X-HE-Meta: U2FsdGVkX19GUz9D3JKxtJWvQmziqB4isF+ZXu3xs/DT/sZ7kaqMmN1NEeHCzAMn+F8Y8oQ+ktTjWrwxFm8TByJza7QOHY+dBKjZTO6A9oHemOGE1RJIpOlgNBhxsAtoMO1bNjQFvd1HKRyYMItim1pJ666BzA8420K/c/AcesroS8crb/H+cggb9eqDFpKOObVtIkBoFmvAyPuMqzhZXX7HFCM5VKlKEVt9+gV5a0mpqnWpOngHv+NVFoczRgEcpwyM9DuG4GHJ3vlwpn7fDKY64sJNVsUlFEMiiXJaXgbFMYIWV6iGwlOhqAjmvt8jUjbWUip/OVFeX5NfieTk2gjMRAUt3gFj+y+YQo4OWAGGSugWccl0IEaU9Nxnx364GYY3VK8b0aI/lRMVfqwq/9OFKKqyjMG4Avi4HpUDdh2Ihurem0gZFGKqMzVhUQIJ+5Gy+LzsoeCxPSOS7yf0Fe3LYmIaAY+5OPvwcofSEb1dL6kjQ11PS8Cl56L5CBeXTSxjOf0apGFfNVSU5qxCpuHvhtHSCEzTrk9KUuIo3r8xZ0kgDsQ/Qx02XciEY9OkJ6RBoJYELilSMrTaZUQVr6NprKnW7HdFnrCqGjg/i8xxUqI8+dzxI1fuR90LYiz2c9W6IWRY72D3/Xnr8iFp7hNt4lsB11ZoEkYceiSMlO1Xvlhys/V0UR0ULKHzipv4bki87SuV37mKYq/4+/eSn2hvM6/LIUWTzX9fkc6fTCXCcb61fccmKMsBEwy2OZQq0kHIc0XUGLoCug481D0DXxGSs6jAnPZ3Z/+BV9zVNaOjP4lgt0iZZNFSC/rtpeGTGtvIkir9+zHU9y/nvr1j594WpSMqDunQIZob7uSv1E7kkIQhnZLgf1GRpbpmvp6MmmuNatL0+VNvY4pZ9VHmrAv1uCf3jmShkSoDIGX4atHKgFu8K02MwBDx+t6N5tDEVvAVFuITLu623WznMa2 sxxJNYg6 KXhUioPupuontpIc5TnvFp2N+lRO2yX2UiRHMxp0EjAEF7L1TTcIVsOTBEltHHBd+2I8V1reqau5EVfx2Ffj7Q6OqDc8Wud856iSgO4Pdi8YUvA6/Fxlo/RpC5ULCCTJkZDg6hsNHag1M/mOB8sHdO7eQDxQJG0Md9qXvJWJ7b84Xl3m5o8rTOVaHu3p5Qt3O5arR7yjODjjYb/cX+FMB8o5u/ux0/yRhVrH9ypolo260cdpbwBVsu76JxDruTzhDknukjScBYElDrJsgO/f8As2Y2DkMpIeP1zdMoPtn1urWffelPf6xCM8Q5d+4ZaKJ+ao1mY3Dy/yOttZsLvYzfQiJqHrydTCGs8laJOEcnM5jBQqehlQ+ir4bE8WHHSGj7GJM8FwwaNZ7u4tggGcNrvQAQHYDKqee8vgemv/P/bTLlbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 20, 2023 at 10:26:47AM -0600, Michael Roth wrote: > On Wed, Feb 01, 2023 at 07:39:32PM +0100, Borislav Petkov wrote: > > On Wed, Dec 14, 2022 at 01:40:05PM -0600, Michael Roth wrote: > > > From: Brijesh Singh > > > > > > Add CPU feature detection for Secure Encrypted Virtualization with > > > Secure Nested Paging. This feature adds a strong memory integrity > > > protection to help prevent malicious hypervisor-based attacks like > > > data replay, memory re-mapping, and more. > > > > > > Link: https://lore.kernel.org/all/YrGINaPc3cojG6%2F3@zn.tnic/ > > > > That points to some review feedback I've given - dunno if it is > > relevant. > > > > > Signed-off-by: Brijesh Singh > > > Signed-off-by: Jarkko Sakkinen > > > > I read this as Jarkko has handled this patch too. Is that the case? > > Yes we shared some patches via an internal tree at some stages. In the sense that, he took Brijesh's patch, then he did something with it(?) and then Ashish took it from him and then you took it from Ashish? This is how I'm reading this SOB chain at least... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette