From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C4DAC636CC for ; Mon, 20 Feb 2023 13:17:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 395976B0073; Mon, 20 Feb 2023 08:17:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F8526B0074; Mon, 20 Feb 2023 08:17:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1989D6B0075; Mon, 20 Feb 2023 08:17:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 066826B0073 for ; Mon, 20 Feb 2023 08:17:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CB8EBAAADF for ; Mon, 20 Feb 2023 13:17:26 +0000 (UTC) X-FDA: 80487721692.29.D9F9A61 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 238CDA0011 for ; Mon, 20 Feb 2023 13:17:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M9BtoYtG; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676899044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6B9E2VJMuiWphf49PlWByqoMtz/BIwv4fEWcmDkWbYk=; b=Kzzlpmyh0o3/hjWIUS7KF6gPNNUk9/IadnQIihR9qBGB7KBqgPmJ2xupLzj5nQwv7SDF7A g3NsRyetWHo6+WYSbzZ+hyMV1rXZDBM9W/v994vyYpmUxErqpCMxLQU4e9rrznuX441PON XCXN93tmgHFK+AYCh89LFu67SWPMXHA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M9BtoYtG; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676899044; a=rsa-sha256; cv=none; b=NPcddeLXDzODL1/wZ/eoLuJ5w3lv+xqb585ioN91q4KyVajpmljrsmufOWpLPxz8tqbZG+ z57LfmeTc/25GqOf4Airx7KTxGLtEYUIT8EIBo/p6Nt4YcNwm+2F05O8ChgH1JVIttje6D 5ZF52MG183kQxSF3I4b8WqwHFe0hAHQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1075E60E9A; Mon, 20 Feb 2023 13:17:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A67ADC433D2; Mon, 20 Feb 2023 13:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676899042; bh=aK7/lUghxm4/K4b3qdHBRELpUECkYr5KgsvOJsR33WI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M9BtoYtGS9YW5yEB2JEa3aa8s6ESdelGXK0wIU1H3CSL3CBNJo7vI8UxqlaqACUsn L5sVLnGybMby7WPQfTY++XUywqOAGJkGrDqEAtrn7/QK7vXPAQD6QA/vMzzX49sayi ccKIXEUZTGD1iJnU1vhLBYKjT1y0FAF73P5qkt7mbKn1Y+kBovNBGTHnLTRuOetIns pjtcebUcDfQSgmBQOQAcKZr89qfiTHbISXe5YShBeubnZgtaMcFhogz067Uuf/Gzft 0x29Cuf9IUNBPczhjAlNJ3AtNA7QbxPxppYrHwA3qgJZRLOSGVxzInUOwN25T3dVEZ 9Djarp8mtAA+w== Date: Mon, 20 Feb 2023 15:17:02 +0200 From: Mike Rapoport To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v10 3/6] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs Message-ID: References: <20230202112915.867409-1-usama.anjum@collabora.com> <20230202112915.867409-4-usama.anjum@collabora.com> <05962e92-9d14-eaf9-2e0b-d683986c9d7f@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 238CDA0011 X-Rspam-User: X-Stat-Signature: 4qtwkjbswwycytm9iuwsygcyhyjzgm7t X-HE-Tag: 1676899043-813918 X-HE-Meta: U2FsdGVkX1+hrpMEC34qV1Zk0APG06b488Te5N8XfaG2z1TjMk3EY7CZQQQX/l+g/TuAw4nA5vt/oNuer7Amvt8HtfPUd4Jgd68E5W0X7B5ARlqdpwy3IeRNckqNSrvarhuRPjmOFqWJtPmh6dfcC5OESYXFZc7zGhYMnm2r8ejOCRAI0+76Ks1/4yLRvQY5+BX4SQ+IPgL+FqkouMlAIgf+TYj99jCzBLrwlfLzO/ljk5PdXAuHZKVrbB5oBwCLbTddYlvqxdhgrmSg7zFiFRBsOXNDj/Bxq+WnB9husW49UASrbzfcUC2cdm82eR+Qyp4Ie7YqE9QY3+2lfklb++0bKhtqhAGyaUxr+UQv7HWmiQymw4UHBturGdpaO/IIXfdnk3itxFw1+zv8CgOEJMNuUAajH+RNa3/oQq0RMaeH+NgG4KOvs42QugKjaRx8J5X+lGw0Zc7uNfgjMyp3L+Dt7cBAZJxcsZ7DelUoahDrl+EqDoYLFueroXll01732YAW5Cf+DPoe6XKAX7+ipL5go4731Dnn09h8MVj2gROZUBMUPHOiicm/UpBBf7nGlWYY/ZHSppUu6o9jr5ExfV7z56dn2cv69n5B+C2zmLbGcruV5bi+e5Q+w4QpiiMQg3yx9kKphBvnrkk431+01csrrKr/NLggAqQIA9aNY3/Lwtk/6oWKCcjQzBJRzB8z/mHt5NvYJB8s+uDBplwW/euwXObPi+ruiQKBL3dEFbq42T3I5kvOS8YraI4P4+6pkTFOZGJS3kk24shhEvrsvkXu3r5P7XsV/EPfWoNVkeNAtMVBmpx8h1ZmKFiGBqCxRBLpMkHh9gAYGfEtkQwaKbRBA1CmggkVrQ7843mFLC6afNBtervO65hauub/xFyuccJauJnkDCoMzHCcYGUeLl8bZzRLMNQ/sjWEeNmv385fSx8AOrpCDY3LGcqDTwQ7stOwqraVjLXZRe+sbi2 ige+uVGx lL1Y80mX+srgAv1c2usBT5s5EZR5x8pgaKZeTOL51AeiMDqDKfClGPQbZMF0wJYfrMoDXvEwbM0Sk3fohCrWGGSJpz9Pl/ZQ2X45mxoimq9kjqJgb3bUJVEl360yeVdTZtFB8zW/8FO1jYDX4C5VqfOEI9zhhXlohxApY4ijT0ZSYWoZdhaU6OVyfQGX3S6WeUkACiD8IF1V5KQKgDeA+bkg0js0p55qBBMokeUYbrZluIyAad3l0C2INoWVQBM+sNufLuwHrcrCJsiWf2OOYviJ+iBN0QLp0mhnJVyZhnDjXUYszrCnZvPZXJzuy/xl4N0OtroZ5tzgwASd5N4tETKTNi0Sxo1o3Uj1s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 20, 2023 at 04:38:10PM +0500, Muhammad Usama Anjum wrote: > On 2/20/23 3:38 PM, Muhammad Usama Anjum wrote: > >>> +#define PAGEMAP_BITS_ALL (PAGE_IS_WRITTEN | PAGE_IS_FILE | \ > >>> + PAGE_IS_PRESENT | PAGE_IS_SWAPPED) > >>> +#define PAGEMAP_NON_WRITTEN_BITS (PAGE_IS_FILE | PAGE_IS_PRESENT | PAGE_IS_SWAPPED) > >>> +#define IS_WP_ENGAGE_OP(a) (a->flags & PAGEMAP_WP_ENGAGE) > >>> +#define IS_GET_OP(a) (a->vec) > >>> +#define HAS_NO_SPACE(p) (p->max_pages && (p->found_pages == p->max_pages)) > >>> + > >>> +#define PAGEMAP_SCAN_BITMAP(wt, file, present, swap) \ > >>> + (wt | file << 1 | present << 2 | swap << 3) > >>> +#define IS_WT_REQUIRED(a) \ > >>> + ((a->required_mask & PAGE_IS_WRITTEN) || \ > >>> + (a->anyof_mask & PAGE_IS_WRITTEN)) > >> All these macros are specific to pagemap_scan_ioctl() and should be > >> namespaced accordingly, e.g. PM_SCAN_BITS_ALL, PM_SCAN_BITMAP etc. > >> > >> Also, IS__OP() will be more readable as PM_SCAN_OP_IS_ and > >> I'd suggest to open code IS_WP_ENGAGE_OP() and IS_GET_OP() and make > >> HAS_NO_SPACE() and IS_WT_REQUIRED() static inlines rather than macros. > > Will do in next version. > > > > IS_WP_ENGAGE_OP() and IS_GET_OP() which can be renamed to > PM_SCAN_OP_IS_WP() and PM_SCAN_OP_IS_GET() seem better to me instead of > open code as they seem more readable to me. I can open code if you insist. I'd suggest to see how the rework of pagemap_scan_pmd_entry() paves out. An open-coded '&' is surely clearer than a macro/function, but if it's buried in a long sequence of conditions, it may be not such clear win. > -- > BR, > Muhammad Usama Anjum -- Sincerely yours, Mike.