From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFFAC05027 for ; Fri, 17 Feb 2023 23:10:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CF6D6B0071; Fri, 17 Feb 2023 18:10:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37F096B0072; Fri, 17 Feb 2023 18:10:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 246456B0073; Fri, 17 Feb 2023 18:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 150456B0071 for ; Fri, 17 Feb 2023 18:10:17 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE5411C60BE for ; Fri, 17 Feb 2023 23:10:16 +0000 (UTC) X-FDA: 80478329232.24.7C7F2F8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id AC59940003 for ; Fri, 17 Feb 2023 23:10:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H1XeHiT7; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676675414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CGZu08oXDZinWgYTxC2ziQUKz+DJaWr3MxzidFt17Ys=; b=Qsb67gUxStWsC40ZAV29wrfiDfu8FXfePg+eh8wvViBtWCk3G3DhNA52eyMjg1on+zD46t xv1nuxphH6vdUY85/WAl7EBYWyO+2IuyD4zhjN6rqhCc7gU//NboTZ+IkE4I4E1X0bd6cm y/uIv4+04C3jNYKYddptdzGK68X44/E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H1XeHiT7; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676675414; a=rsa-sha256; cv=none; b=EUZl9dDYxDrZsSVfc8dBUgKcIx35SuXhgGD4zTTayVOVcRMYbuFEx/uo52QAvU+ViBLMO4 Dp+/qq8HeKst3BPdAvyWN4K1/01RMpx6iLZ6RXOUuZyhxtDblV+nlbEeYRWB/7rLPKD7KD LBuk6PThgmYD5VCEW5mI1Hjo6LAm4aY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676675414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CGZu08oXDZinWgYTxC2ziQUKz+DJaWr3MxzidFt17Ys=; b=H1XeHiT7a0YVAUM/CHna8+8OvlOcSlatKWCDbezZNglKdBLaIJb7/liVVTC3ubidXjUtuA MXm6giSiieFz6rnSxfObmHmvaravSP8ss7vAdSJKbaBV5ePd6t3ORlxiqXSHppHiZckzGn dfu3Zx5z1TlMBMl79+86m0RVtX0cBXE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-38-niNKcG64PECVMWhkUFOe4w-1; Fri, 17 Feb 2023 18:10:12 -0500 X-MC-Unique: niNKcG64PECVMWhkUFOe4w-1 Received: by mail-qk1-f197.google.com with SMTP id b9-20020a05620a118900b0073b328e7d17so1085655qkk.9 for ; Fri, 17 Feb 2023 15:10:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676675412; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CGZu08oXDZinWgYTxC2ziQUKz+DJaWr3MxzidFt17Ys=; b=2/ua1i3T5LAMOvbisGB7IIogpmM5yc+dz3y1rykPS5SWGcxeQwONaIuOQ7DB91Gd0T nY1EnmWvlpgmsTl02Erfrw7d+8CQYE35LBFW/iewFu8y6nxqon+9p9HuzSM7XsDoV0vm EAdSYRqhKcLoUJ2TxWYW/xgV0//t4ejCFyO9Jau0ttRx+BUIjg3e0CQOGSJHBtTOLmh0 LDQ5gUonLD3mkHVkgcl/XgZbSmf184OazgDX76A3mNuLHRsrSievzLdij1NtPkDAsOuI 98vDyOpVrHOIjgDtb0bT4E3MgIRlmJcP2Y6WbaodgAIqgvYTZcH2sihJUJefavf4RDuZ EsrQ== X-Gm-Message-State: AO0yUKU0Wmb89gT/pHegHyoCnLmWaEpPVESxYZPPCPQycs6IpVsoyDFA LVPEfcIJvFQW7aRjmkWW0Jvn/R3paCX4Vz43a/JpPzR2Dz/IzIYTgeKThBQWrbIHh/UKli0kuFP BgLL7n1ICtZ8= X-Received: by 2002:ac8:7c44:0:b0:3b8:6c6e:4949 with SMTP id o4-20020ac87c44000000b003b86c6e4949mr5624132qtv.4.1676675412184; Fri, 17 Feb 2023 15:10:12 -0800 (PST) X-Google-Smtp-Source: AK7set/jd0yWr5rGW+fJEsGAE+BODNIqGlr9Io2xy0/HUvUVCFax+BOqcbBuzORJHRZlS9CEMLBAAw== X-Received: by 2002:ac8:7c44:0:b0:3b8:6c6e:4949 with SMTP id o4-20020ac87c44000000b003b86c6e4949mr5624097qtv.4.1676675411888; Fri, 17 Feb 2023 15:10:11 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id d1-20020ac84e21000000b003b82489d8acsm4022408qtw.21.2023.02.17.15.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 15:10:11 -0800 (PST) Date: Fri, 17 Feb 2023 18:10:10 -0500 From: Peter Xu To: Muhammad Usama Anjum Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Mike Rapoport , Andrew Morton , Andrea Arcangeli , Nadav Amit Subject: Re: [PATCH] mm/uffd: UFFD_FEATURE_WP_ZEROPAGE Message-ID: References: <20230215210257.224243-1-peterx@redhat.com> <7eb2bce9-d0b1-a0e3-8be3-f28d858a61a0@redhat.com> <4f64d62f-c21d-b7c8-640e-d41742bbbe7b@redhat.com> <456f8e2e-9554-73a3-4fdb-be21f9cc54b6@redhat.com> <427298c4-0da9-059f-02ff-c5147d317c87@collabora.com> MIME-Version: 1.0 In-Reply-To: <427298c4-0da9-059f-02ff-c5147d317c87@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hp833754jab6xdzqabfjbj36j95nyydk X-Rspamd-Queue-Id: AC59940003 X-HE-Tag: 1676675414-980071 X-HE-Meta: U2FsdGVkX18Oqy5aa1fKSl/WM6puMSL9OjM5lgmHzFVLGnj2QE4CsGxtLvu3lDcKZkTk7iyxBxgEwBTDjbbLVEWS5InlpM+K95QDR741FIPLHzIj2scJ8k4B4GkSwExy6KbxROU0y5nzXcutwpnGfg2Sh0ODqwEjxXb/JgtNno2miIqY3G86/2p41yTEDMX+wa2Zi+Fn6PSsl2H1vfC0Wth3ZjaV1lAZy0tDnjQ7MfqOKm/VUAj4IHFJk1bAWv3H8heO/l3RIiQpPW+uV6xbbhyEgOo2zVqxEumLK0MrPNyck/0CCKZs5wv+TFl0GQl5stZpl5xyGEtZXbOGACLAxlThlw4x3bCdHbCNpNYh9uilL9wiEdl9TGpZoz0Be+bJIttWf3ZayTWMoQ6kudOLrVMT189qW5Lj2C2zNJ429SZm7Xgx0pGn9wBpRmkGhcY/MDvXcP69QBSheVrwMMq9fniqrINq0wFDwNXrQlcK2H+0ypoPHxALj4KwlC0a7F+qyQs1qry7urflcPqqeVEbESVO5niUho3jVR3ar5Jh7nkqcURxehfEEoZddblTuo3ZLhz5a1GaOeEIQYvzLfZMZved0kPjcaUIQqOoBRob8t3zfvNggs7mB/YeCN16fdgpBZewCAexqNXyqwxXTGuLnAsH9GMLCTQrwKh7otPsfUI1WtpG9v5BndhvjNwgNLX6JG12ys8xMNMbKj2y/g+wGp22wkp2XflxjQXzkROehvwY6ZG/mUoQqVCD0gUe9KOS034CIxOIgBwWV/aHUHnrXc9dJjUvClct5NG3XG8VRd5MU/0ptr28HiAKHVpSlvAOWz7IMtrqn08iWHUJSTqS6phwU8Q6lYHrkus8Ppg8ONRXBjIXMDkMOM/vn2l9DDDzb4c3+LmmobPMluDMd605UzupR0YAHJBCX4IfjEDYnLm80GdlZYoxpJhox0wfCEYgA8XztNWp6TNGH/WORPs 1ztbmMlq 9/mKYlOaVpKbEfE18Do5ytxA7tIFeiou3qSCUyCtmbyoCNJPNh4ydJTBqlr7i9R2M12KK7RN4SGUGZobvZBDUTfmrkVJlwePiXKwD/WbyOkx3m5eIQf5ekuJ2+w91EtompXBN5gKy7fA/PSOXWaNXXFA9OdJ1/j9TsfkrGROeqQgKlbbum76LV3lUERAuugMj339c5qEp+xgWdt9dc1Xv6IzYESk6GBLMbZ3FCQnRD2oXymlf3cLkx0GwVIGU6t+QdchkJrhNIwMyYHWKwdOz4inSYfvJ7+Y60Yt9N8wsPcYBzbvpnvWerFy47cI02YslQvcsX6nXyieT8Hrw0Y999gd+mHawBZCDQ+13Aa861GaBaWI4ZzoZ0Prb0pRhnlHlvcb0MIJHfrN4MVjMbU5E6X7D8dHohs5lp6ngEv1mWEm78kJ0WeEUPOrK+TY5mn2zo3TPzSh9fkccgHqHc2xArdrn6Abkijznk2egq/1SFE7IQPWeivj90nDZYWPJtA+ANmW4ZD2sdasyXfT7Zes/tLnk7ZP/KOneWYlxqoA8ROI7BFYF6rsNpOKoZIu+qNkIDb/j9FkgWNvUCV3J108JAsq9jFkU01QX71AzM2jBhhOMtEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004232, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Muhammad, On Fri, Feb 17, 2023 at 05:31:19PM +0500, Muhammad Usama Anjum wrote: > I've just ran my single threaded selftest [1] over an over again to get > some numbers. > > Without zeropage > qemu has 6 cores: 26.0355 Did you count in the time of read prefault? Or did you not prefault at all? > With zeropage > qemu has 6 cores: 39.203 > > 33% worse performance with zero pages > > Definitely, there can be better benchmark application. Please let me know > if I should write better benchmarks on my end. > > [1] > https://lore.kernel.org/all/20230202112915.867409-7-usama.anjum@collabora.com I'll have a closer look too next week. Thanks, -- Peter Xu