From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3313DC7EE2F for ; Wed, 1 Mar 2023 16:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C41E26B0071; Wed, 1 Mar 2023 11:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0F06B0072; Wed, 1 Mar 2023 11:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE0C86B0073; Wed, 1 Mar 2023 11:17:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9E6856B0071 for ; Wed, 1 Mar 2023 11:17:14 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7736CA0CB4 for ; Wed, 1 Mar 2023 16:17:14 +0000 (UTC) X-FDA: 80520833988.03.B0177F1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id A149B40025 for ; Wed, 1 Mar 2023 16:17:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GHNhxO3v; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677687431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4yRxsyjEc1VgxQqaMv5T8Q6fGJDXSNJgN02dz9+RN8=; b=e9CP5fHrhfkf6FAkrrUccwx8g990X5EuEmgCdHM1G3ERr+abL5XjudH5t/RLLHsh5SvYyX 9BrI9kzo34T/NhoTKes8z+py+m1/aYK8GFPqsJd4Eqk8YlpHTJz4EWdwOuiJfn/QTmXqgq s35jtHei+HCwEsWSQGQua/Wn5TsbFm0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GHNhxO3v; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677687431; a=rsa-sha256; cv=none; b=iaxKydL2V3ctk7hfHXA7LEeU2UA8MuLSRQaMG2OMlz0i4owsMtMz0/TSoPtRRmlwhxt9Xn dsgyEmGYU/I2i1/U5S/QqW0F4SSqAmfL+lnKQFNiAh3E1q8aHQfbgSZ3gpPvI5ev4RMLp3 5erGpAbAG4N432/jo5/OXxBg7flKIdM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r4yRxsyjEc1VgxQqaMv5T8Q6fGJDXSNJgN02dz9+RN8=; b=GHNhxO3vzlp8y2VXNOy0x836JG lAg6k6Oj7mWyKYzCebVyBGkYX04FkPUFpo+cl2nn9dSW79eGp0YfxE4EgANWEMzA4HpZwebmfKtkX sUwBEJl8RlMrijtGzbxjFFvuZE8SU8AmbOOqAiIvu9RUVIovi3lfPjpH729tDT79KoVFfygWE9Jcl Pe52lcIKRTKbzibHDbHPxScrJ8fDWPCbP/ZRVcDib6Sw6nUCWsj1td4rvfsmYDGpmz64u9CvEQp+Y cP44Y+8YvfjwPIZKM+0tCqtX5cDiTL52++ELhMAuISaQpviFnjpnoVF6X9Hj8nLH4P08eI/ok2zjn fYJqc/pA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXP8b-001jj8-QL; Wed, 01 Mar 2023 16:17:05 +0000 Date: Wed, 1 Mar 2023 16:17:05 +0000 From: Matthew Wilcox To: Geert Uytterhoeven Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org Subject: Re: [PATCH v3 22/34] superh: Implement the new page table range API Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A149B40025 X-Stat-Signature: z1h5fyhf9kkpb83gzfprkpsub1azxcq8 X-Rspam-User: X-HE-Tag: 1677687429-515607 X-HE-Meta: U2FsdGVkX1/9Cp2EmatazNtsU9f2fuEInmWHrMkJZTLFdH4Hb7/PWK9Y3i6ti+8xjXrfNj5BY2UeiRASWX3/AFxHjGHTRdDW+X0Wt2zbrLBS0KI+sMkdiinwOMaima5hVAc+4YXiKWugDTvX9NbDp7uSIf/PtxsgqVqHEfgABrHPanqtSHmvlpFbfnKK9IH3thI1xq/EJXTZ0mSbIwiAynRJlHddWjRF1mDTCzEgrb91J+S7q1dxHs4L+lcbsF3s3ybh/oPTix9jVTCrnvuKXqQbg9xFvo9tZilGgbtnRJFk/4ra8BTE/eoJ/EWIf36x44R2nU3O/5289moA55sK/5XplXrVW/+fRCYPBOFMEMEISHKcdwMXNwgZrdPmUQ4KdUn6CuSSktFjrKVwjhi/ZpggGIzLgOuUPRRZrKRrvHwnQ0iA+6vamJmC+gJ/ZsEsbOKC3nwJj8Z7nvIeIA4IwpURk5KpB6nrn4ZrfYYOfGNgVg5cBqnZIS1XOAwdG2o6YcnJuqeUtXz4VTmCll4PFkKaRGCt0TEjSgWv2q4KzWmK/dK094uNpELPQT7lwTMGInpfWjFpZTPw+NwMzTZ2OqKAOwJBKbQF03TTgd2DS/kEFQlh5IXswja388Dmr2IQvNnbeQCmkN2UKUhNixByvlLGSCdAXwnY2FZqFtz3Qz0+4W3KzI6se99mIq5tAY81dm5Fe3kZwDaNEypkNKTPyBCGfkV4eis7UTztO8/72wZ6SYp9jquGf6qvGBIQrJGlzMF/P6EorM7WvX2dvOVO2tHRmlKRblua2uG7u21wyKodNdoGLXJxp6w3sb5bLwyTwakGcjXTUWh3wH7xCoLVNzMOKSkEM+RPcQzKz8UFUCjc0lnpot/eiScjWlUiNcBekxRASti3w1t8OB9Dq2xETGUCZYUvKWTeTwRL2TTqpvjjurQPVbvtBdu7Uc8mHlZtNX1I6OYIUMdDi+sTsiy uUcYafzQ Iq3i69y4bNNzjcTo28mOVL8deiclii2pfgzu2Xv8dXrEB2mNnTLi71r/a6W8lEY6O8krBtcp20+b2mI8dzYou+4oqYqmw+Qotx1dfM0JA0RsKu0F6QFCEAisTJH+2RaZYcIX2hI1O9K/ny37TiVx51S3o2Mcox69bbmCSQ+yidrO7CJfkBlDURcY/BkCgThLIvDuszocI8+QaqqJiFRgpLBRZjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 01, 2023 at 09:06:16AM +0100, Geert Uytterhoeven wrote: > > - } else > > - __flush_purge_region((void *)addr, PAGE_SIZE); > > + } else > > Trailing whitespace. Please run scripts/checkpath.pl (on the full series). Thanks. It's pretty noisy and I don't intend to clean up many of those warnings, but it did find some legit problems. I'll squash these fixes into v4. diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h index bf1263ff7e67..45e5282f406c 100644 --- a/arch/powerpc/include/asm/pgtable.h +++ b/arch/powerpc/include/asm/pgtable.h @@ -45,7 +45,7 @@ void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte, unsigned int nr); #define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) #define update_mmu_cache(vma, addr, ptep) \ - update_mmu_cache_range(vma, addr, ptep, 1); + update_mmu_cache_range(vma, addr, ptep, 1) #ifndef MAX_PTRS_PER_PGD #define MAX_PTRS_PER_PGD PTRS_PER_PGD diff --git a/arch/sh/mm/cache.c b/arch/sh/mm/cache.c index 93fc5fb8ec1c..9bcaa5619eab 100644 --- a/arch/sh/mm/cache.c +++ b/arch/sh/mm/cache.c @@ -169,7 +169,7 @@ void __flush_anon_page(struct page *page, unsigned long vmaddr) /* XXX.. For now kunmap_coherent() does a purge */ /* __flush_purge_region((void *)kaddr, PAGE_SIZE); */ kunmap_coherent(kaddr); - } else + } else __flush_purge_region(folio_address(folio), folio_size(folio)); } diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index d5c0088e0c6a..0c30b0eb6c57 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -924,7 +924,7 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, } } -#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1); +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) #define pte_clear(mm,addr,ptep) \ set_pte_at((mm), (addr), (ptep), __pte(0UL)) diff --git a/arch/xtensa/mm/cache.c b/arch/xtensa/mm/cache.c index 65c0d5298041..27bd798e4d89 100644 --- a/arch/xtensa/mm/cache.c +++ b/arch/xtensa/mm/cache.c @@ -254,7 +254,7 @@ void update_mmu_cache_range(struct vm_area_struct *vma, unsigned long addr, void *paddr = kmap_local_folio(folio, i * PAGE_SIZE); __flush_dcache_page((unsigned long)paddr); __invalidate_icache_page((unsigned long)paddr); - kunmap_atomic(paddr); + kunmap_local(paddr); } set_bit(PG_arch_1, &folio->flags); } > > + __flush_purge_region(folio_address(folio), > > + folio_size(folio)); > > } > > } > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds