From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7632BC64ED6 for ; Wed, 1 Mar 2023 16:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEB226B0071; Wed, 1 Mar 2023 11:36:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9AA36B0072; Wed, 1 Mar 2023 11:36:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A62106B0073; Wed, 1 Mar 2023 11:36:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A8EF6B0071 for ; Wed, 1 Mar 2023 11:36:05 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55057120874 for ; Wed, 1 Mar 2023 16:36:05 +0000 (UTC) X-FDA: 80520881490.04.3B40C1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 45C8314000F for ; Wed, 1 Mar 2023 16:36:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q5+f4ebb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677688562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BmFrL1c4Km34O7ZeENxkp+Gs1wwGRzXM7cGLVLqZHJk=; b=HBUincbmZs0wZtV7SnKhthk8lu+IgoJqPN46cOOf+w4oRdj23ICE3v438Evza59su1G7DQ y3tG3ZFEUTlqxIrZMDAcFuGZZtwW189y+gGQnj2dHBabHixsv5S4jDuAk3ZCRCXL5Wbn6i ZjPuZoAqgt4Qo1hLS5hFm4DAziFIiv4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q5+f4ebb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677688562; a=rsa-sha256; cv=none; b=HkqTG73U4O0/YpouIjWYj/K4P06mWdt3dCLJDuwidaqO9FYkGV6NKBv+o+ZzYELdOZhqCA hUZHQNVZHnqS81H6/h3c/7sQIT4JAe6wSGYSV9PXRuI5VL5rA4zWYrL+6xByLCC4WknWQ+ 6VGDIrxs8NuNyVDPLrekc5tga2Jn3PA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677688561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BmFrL1c4Km34O7ZeENxkp+Gs1wwGRzXM7cGLVLqZHJk=; b=Q5+f4ebbXPuRvIF3MfXEMUDbSjSdBWgPiXq8nf0BwDz48k0fGclekswaf0225iWeFQS1Ry 6Cr9e55vDS/8ZCoCXJgBu7gmFL8qUrejoo82xgDD77Dv8nvr6SOrv26VrGBBLXQbxirJUF aQJmBs48QJWe/6pdwBF9z5kaQ65RtA8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-434-UYGWB7sTOZmZLazwugqIPg-1; Wed, 01 Mar 2023 11:36:00 -0500 X-MC-Unique: UYGWB7sTOZmZLazwugqIPg-1 Received: by mail-qt1-f199.google.com with SMTP id w16-20020ac843d0000000b003bfe50a4105so3850242qtn.10 for ; Wed, 01 Mar 2023 08:36:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677688560; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FkL7Uhy+cPKcXOPgtSYv7QM09B2YNOq91Gba4VHb6zU=; b=HgA2Wtk75/cz2b5OTInYbB2rBu55VbszMiI3yIbwbMorNMnqUVmKZABD2u6J3N+VuR YmP+VdfpcHkB9KbsZZ0e0ifpHbYa1p+mxqo0f7gkjWhwCa+mh11zwHnVlZpl8ed3WCZ8 xgPuZ8VJIVBD0VRp1brOIJY2s3e8mqlT2pcCPSZqfpiWIlF1Afu4q1wyXss7Ha70m0T4 mYMOwaLhCoyEXeVsHmcQyYcCWGhapAwy4902VTqTyRKi/4JqHvpEUbEP04EXCJwZmXsE LLJbe04DRsc0qcH3WNPzK6UWozlmwYnJQUp9gisZ+eOIzX7x7BJRcZxSFVk7p0bpluO2 Djdg== X-Gm-Message-State: AO0yUKUThf7UtU1KMEDF+KHGMe4VeZUGxhs0HinA6vLLkSfUe/CS/r4p YmlEmtqfkYOn+eE10Edbbq1NMzjQL5zUDjviIR9X8YUHcb+H6vMnsJz0OHwNnePjgXCxcp/Bdtr XQQ9uk6tYvGM= X-Received: by 2002:a05:622a:1993:b0:3bf:be4b:8094 with SMTP id u19-20020a05622a199300b003bfbe4b8094mr14665371qtc.0.1677688559664; Wed, 01 Mar 2023 08:35:59 -0800 (PST) X-Google-Smtp-Source: AK7set8Cwi0eHdFAagaPGBeMs1+so6LN11xdXVXyv7QqXkjJci2aBg5qckwzm3APFdKOk2Zt7BkRJA== X-Received: by 2002:a05:622a:1993:b0:3bf:be4b:8094 with SMTP id u19-20020a05622a199300b003bfbe4b8094mr14665328qtc.0.1677688559357; Wed, 01 Mar 2023 08:35:59 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id o26-20020ac8429a000000b003b64f1b1f40sm8613002qtl.40.2023.03.01.08.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 08:35:58 -0800 (PST) Date: Wed, 1 Mar 2023 11:35:56 -0500 From: Peter Xu To: Joey Gouly Cc: Catalin Marinas , Andrew Morton , Lennart Poettering , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Alexander Viro , Kees Cook , Szabolcs Nagy , Mark Brown , Jeremy Linton , Topi Miettinen , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-abi-devel@lists.sourceforge.net, nd@arm.com, shuah@kernel.org Subject: Re: [PATCH v2 2/2] kselftest: vm: add tests for memory-deny-write-execute Message-ID: References: <20230119160344.54358-1-joey.gouly@arm.com> <20230119160344.54358-3-joey.gouly@arm.com> MIME-Version: 1.0 In-Reply-To: <20230119160344.54358-3-joey.gouly@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="+HtziZPaMlI7+HbK" Content-Disposition: inline X-Rspamd-Queue-Id: 45C8314000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: xompubo78p4n34nunxj8gz895k34zktq X-HE-Tag: 1677688562-850471 X-HE-Meta: U2FsdGVkX1+wsCC0BSK/6HveVEEWW38J4wZEsmxWjXuC3Oy6y/aYWD3y/uoGTYzF2eZreAUEIjGK2IrV+C6J6oZwgl6Nt4sS5ZsSKhrp4iLCem7mnCE1UFXE/17MlDxd1JQ+gJQzBFZE4xfWclKVHOMF3g2wmP2VuFOwQbf603nh8pqR42XbjN9p61Ooo1lU6ysK+XUfPNkpd1rgkw91ZD41nzVXrLpDHeOvU7EuD7vWgiJ3SL9Vz5hJnpoYU0Z1HpkYanRL/WFO8zKI9AHVmjrjY0FfX2YbL1ggoV2vFl9kSU+o6aw79RCiYUn2axe9umXc4Y3twrsH6hzpvKkP/AQMIEW1F7UYDLU5f80EtDl7Di0DIMaLT8YKQWqqru0cCBVNkMDIrCn5VlXfg5taKBEYZzOYcx/ZV7rxk95+PUWExLnDVTzUTpzLKXoHCXtu093p6y63HRBz0VBgmmdD+eRWLYIsemR0NZhy1Tr4ibGy21Zm1xQV7eklhuHTNb9p1ruhKFLVxUyGMIECgxXTJVl3Yf+1kTk0xfr+8q+yGqsl0/d52hfnzffpdEyKIfnduPir8Q7QKz2zmkrSKs1u2kyYH0wCIAJJBnKjFxuCQUpxY9EcOhKczv2fWWy0hAmc+JWEg0wAWtJFWvZCTUsalmtwvfeb4KpKSRfVm/aF0hfQIIW7VJ9wrzD7q5sKwJn/09Plde3QBqNZCBbWzUP7eSCQCKDFCLPh/BTtEs42R/2dXykIQ7Ofa+hFQgmSxkovN+0EFskEx3rHg2ZfM5YypX/E7WcpL554x30M3y/s7Ua3CBbiNl5OT/ikvogXv+0Gw+W2oI5wXIO2p7XjZwcI+hZ9pwoaPfq8kD0XgEydFq1UFQfIJC688p6hmeVKS0/fpJogAw4Dja4N9OwwIr+vN5xUZukFBQ+3u0dLfvCHS/nVCaBUXY3G9CCgocMrTiJl20e03lv0qZwYCXh5cRn jwbXBOuX EEytLkciAe9IgDo/nub1R7VMGSTmUfwRUfYtsHHEuFOMumAs4KppWbZyXrr7Q46gXS+v51z+Au8zPjUB/5K3TrwmGnD5IOMrU9Lri08uF2IGr6iVQAZBIruFA44hM/ygy9l7s3Y/Q+TPFdEBYxT09DhMepH5HsJyTDzzssyQcS0We1szI1ttGh2SFOBk69TA9jh6lBgu6EoLsB2t+LyiHYmxWuvA6SWTAHLDDpvP/SoF9Ry2tmpIjp9Gg+PQSPoL0c8jxJA/aFMuYkUXqwBXOLmIZd+5SUmY+QfRciOwsZBzy3aDU2hSJ+J4Z4EgbdFgBhSsReQTTjdExi0E6G4Nif6s9UBGEiA0A5DqCUshS8uWFlaGf4NOHKiyo8Xd40VDyEq9bIVKpKMCsclhRHTv5iV9eegyZ4tF8Ii2XnxMEEcLEioeu07Ccti1FQvxFSYnIxO2wPC1uxnrwiFxz2dtvSJSTZmMWq3AYnDTOMK9UrSqKaYvgT+14Sy9gLfct/ECpILoJBWTqi2hAIY5krlNIJ2nmdWWSxMkqEnkPD4qLnpx+iev+yA/Vhb6UL7BCt4c4sEp+/z9SySQMessIU4sAp8vqInx77eh62Wy2OA5EgSanmjZmQO7vGGXhFeFn6pw9S2CTPdRE6cMFOAixZAaBY3srHimckKlfqgpeIETeCB93lQE85WthdZyylA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --+HtziZPaMlI7+HbK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Thu, Jan 19, 2023 at 04:03:44PM +0000, Joey Gouly wrote: > From: Kees Cook > > Add some tests to cover the new PR_SET_MDWE prctl. > > Co-developed-by: Joey Gouly > Signed-off-by: Joey Gouly > Signed-off-by: Kees Cook > Cc: Shuah Khan May need to sync prctl.h into tools/include/uapi? Otherwise selftests/mm build fails here. There's also one compiler report. A fixup attached which works for me. Thanks, -- Peter Xu --+HtziZPaMlI7+HbK Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-fixup-kselftest-vm-add-tests-for-memory-deny-write-e.patch" >From ce8e17c244fcc743c7006316dd431c5650480756 Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Wed, 1 Mar 2023 11:33:34 -0500 Subject: [PATCH] fixup! kselftest: vm: add tests for memory-deny-write-execute Signed-off-by: Peter Xu --- tools/include/uapi/linux/prctl.h | 6 ++++++ tools/testing/selftests/mm/mdwe_test.c | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/prctl.h b/tools/include/uapi/linux/prctl.h index e4c629c1f1b0..759b3f53e53f 100644 --- a/tools/include/uapi/linux/prctl.h +++ b/tools/include/uapi/linux/prctl.h @@ -281,6 +281,12 @@ struct prctl_mm_map { # define PR_SME_VL_LEN_MASK 0xffff # define PR_SME_VL_INHERIT (1 << 17) /* inherit across exec */ +/* Memory deny write / execute */ +#define PR_SET_MDWE 65 +# define PR_MDWE_REFUSE_EXEC_GAIN 1 + +#define PR_GET_MDWE 66 + #define PR_SET_VMA 0x53564d41 # define PR_SET_VMA_ANON_NAME 0 diff --git a/tools/testing/selftests/mm/mdwe_test.c b/tools/testing/selftests/mm/mdwe_test.c index f466a099f1bf..bc91bef5d254 100644 --- a/tools/testing/selftests/mm/mdwe_test.c +++ b/tools/testing/selftests/mm/mdwe_test.c @@ -163,9 +163,8 @@ TEST_F(mdwe, mprotect_WRITE_EXEC) TEST_F(mdwe, mmap_FIXED) { - void *p, *p2; + void *p; - p2 = mmap(NULL, self->size, PROT_READ | PROT_EXEC, self->flags, 0, 0); self->p = mmap(NULL, self->size, PROT_READ, self->flags, 0, 0); ASSERT_NE(self->p, MAP_FAILED); -- 2.39.1 --+HtziZPaMlI7+HbK--