From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169B2C64ED6 for ; Wed, 1 Mar 2023 08:55:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F4B76B0071; Wed, 1 Mar 2023 03:55:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A3CA6B0072; Wed, 1 Mar 2023 03:55:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345BE6B0073; Wed, 1 Mar 2023 03:55:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2204D6B0071 for ; Wed, 1 Mar 2023 03:55:53 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E1B5581480 for ; Wed, 1 Mar 2023 08:55:52 +0000 (UTC) X-FDA: 80519721744.07.026A2DB Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 03738100002 for ; Wed, 1 Mar 2023 08:55:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GHJuevaQ; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677660951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PME0vYl4W7bdOakpW6RwisA55LnP676psaYUNk5FkU=; b=XfD1X80sRelSIcrcREi3JvJnpMJd9Y8RcBcPni4x6KeuWu+OMiVR0Uoy4QzdJ4MU/klPHv LLTseSPE3kbTCtPxTvMygHBBYe2fcG9VyBcPD0YeGO7M8RRmpfuuKBJ/7tTJfDvjQ6Dim5 tRo3j0N67RdPw6Q7Wqvi5nsUo+Gw6Sw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GHJuevaQ; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677660951; a=rsa-sha256; cv=none; b=T3rCEVnbohsT3+61A6RflTeZdFo1ha5ZShXTBmKVVJ0Vslo22inm4p4agYycGG91smD+gv u4pgx4Gh3yzNZbfG0noGdB81OEu8C5l8XyA9bu3qKYRikKh9ZzkL1gT+zqYn7TMooxTg6+ o1JDXh/DtzhFUGAXlMAzSDWz/bAKtWQ= Received: by mail-pl1-f172.google.com with SMTP id a9so3130263plh.11 for ; Wed, 01 Mar 2023 00:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3PME0vYl4W7bdOakpW6RwisA55LnP676psaYUNk5FkU=; b=GHJuevaQRHYZJVJJ5LVZYB1oPKi95eeUiUaCrbzC5beBXqOU/ZAg9gZ/nt9NGjQA+8 ktMGhQsR6KCRleV581Qvc4Ai0pjdNMqZnXYcrDF5otbpcAa0euJiA3j68ZC6mPEVyt1v j5lzjl2JEQ8f8lccLipZe4h43WHcODIItDUkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3PME0vYl4W7bdOakpW6RwisA55LnP676psaYUNk5FkU=; b=gTHnOLsWdqDe5sawg6suGMpbq3UV9nHfSrWivcYfH8JHhq6Xwzyoli/sf9G2YHCO78 5KNcm36gM3pwLvop4MsUjy5MzQet6sZbfqXjbWg4cKYLyEyrpa0FilMKUT8ttTAGh0ye uAjfsYmonsiM1OZhX/FaXNeJs4g0CQPZiCGfhJjlP1Vx2UQ05B9C0kYrBI/dhi82nG50 VCfnsFLjoOjTgzjTIJUSvMe4XfxndIbxKiedSSIDAV8v3jambGY/VSAohTDl+Z8h2cc0 KtcnHrB84uD6K/JUUZ8XKgIEXRQ/mBKa/ckWv6cjV1U7UNkTJ/npejNabdMINvW2dGWr PQpg== X-Gm-Message-State: AO0yUKVdTPDSxu34OpTTSbm8WlAi5BKqTSIP+5f3TZWkcih9gcidkUTs LSfXj3z2x7DGp527CYN3w+9mbA== X-Google-Smtp-Source: AK7set9IWfcyD+xbHaCV5vyOBZLGwnnkWv0tyY+6e3P6CXhbUECiB9tCdBHFEjQFeqblj2I3GCQEcQ== X-Received: by 2002:a05:6a21:3391:b0:cd:2952:7b69 with SMTP id yy17-20020a056a21339100b000cd29527b69mr7845624pzb.52.1677660949699; Wed, 01 Mar 2023 00:55:49 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id d7-20020aa78147000000b005ccbe5346ebsm7318876pfn.163.2023.03.01.00.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 00:55:49 -0800 (PST) Date: Wed, 1 Mar 2023 17:55:44 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 03738100002 X-Stat-Signature: 75gtobh6u8dksb61cqi64kk74ny7inxg X-Rspam-User: X-HE-Tag: 1677660950-531919 X-HE-Meta: U2FsdGVkX1+EwSIGL2J7hFzAc7vp35BYS61dQFjigo+XPVbqszK4c+PXJrc5f5GujQtte3BuUuKzJckGrSB+/42OBv1gOipgT/rGL+VwHa8pZTclDiciywKToY/Y3txKOYajzYQSnRTwdHPtywZErpBeBcjyQzApXSQqT1DroVFBTGf4Q4FpZausxTpL4c7bKKPWUoM0iJLIXscnsAX9kXIM/BUv1HciWorH7NhYuTOpBdGip/QLcdaNNwcmD6CIf4Ue/AjmAgrAwNOhdwVu6WVOQdbS+E9BGdTTjyk/Ugn8AOSGe8Yi7C4JqZwlp2RMeseuXB3Sgo3tsZCy4RktVlAMOiB0gTLGwXVSsT9yEiRh8DuxeErovMsEFLyA/nXWNMjrPC6POqKkp2RDjhM74zezXvff481a8Uq02f0xrZq71Zi6BvTS/q/rsUEhLVyPFWbO5AIyABFbkrCX8D3mXb2tz3KguvEEp8oIWvJiM7GDaY5O2g328EoB888cCKjVw3Fz/L6kk5lvrGcDl+mpQdxAndPJR8+6AgJlP4/QWvrNisKBM/92sGpPYQLsngWA1Be/XrPVi7WZcIHln/JL2mIBKU2z0DNj21bsbL3ogPfcQqfbt3tQFmMirnZ/DyKLFJRD3DZyWPzUCa2UGB9y4wDAqA63r1r3TL2lnVWXp6VlSv56zMk0/dpkJcdIX2LXvP92Sagl5L4SUqP+g3Q1cHibZuUzt7f9ktW5xwEu6olLoy6ZIt89kXXhHT8UcydxIPvTmx6RupK5xA5jeD6AWC8zuW2i29pAf18QjUSXMFzN2Jfv8mK5vy0vcgMc7KYdtsQ3t0c8exkTHrY1n3IjMhnWm4WidzBJbc3GZ8Pfamc5NDGxMmVT9flJEi1sSHnIcXOhUn7eI/GL+2VSysnKAwOPwGXyiKG93HF9c3FfWgWnZYzHate66iy8tT69FuDB3Com5cUjzhXolw0bxEt GXJr5qb0 wZMbKrURuhAdD+4oB1p9avjgpD8Ss8+QyPNre02Rt6Tp1hPlpuAT4Gz/WgJs0c3A+XgdyA7PqAbAPNgN1fKhfP8cCbTeeA/ZjlES94AV0SRfln2hcOlolX0+VP+sJjLZtZBJzq8lWZk4A8+B9tChhIc+A92gkfdlXrABSTd6v05sNQcinrFPhcWHxtrT9bPomzwEIdrXV+fbRq3mULKhCTzt9+uQobYHfEEQN8auqkxVr1dZBKz+OFM6qt0Itm/t7sJbhb5sECylLsoHZbgRl+T+0XhBQfDVXyZIDjHZHnM4OTCeanVwwaWqyn2lBY7/6K9lAvoz/qF8vwaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/28 14:53), Minchan Kim wrote: > BTW, I still prefer the enum instead of 10 define. > > enum fullness_group { > ZS_EMPTY, > ZS_INUSE_RATIO_MIN, > ZS_INUSE_RATIO_ALMOST_FULL = 7, > ZS_INUSE_RATIO_MAX = 10, > ZS_FULL, > NR_ZS_FULLNESS, > } For educational purposes, may I ask what do enums give us? We always use integers - int:4 in zspage fullness, int for arrays offsets and we cast to plain integers in get/set stats. So those enums exist only at declaration point, and plain int otherwise. What are the benefits over #defines?