From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27894C64ED6 for ; Wed, 1 Mar 2023 05:00:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532346B0073; Wed, 1 Mar 2023 00:00:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E0376B0074; Wed, 1 Mar 2023 00:00:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3813A6B0075; Wed, 1 Mar 2023 00:00:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2598E6B0073 for ; Wed, 1 Mar 2023 00:00:41 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EC51B1210C3 for ; Wed, 1 Mar 2023 05:00:40 +0000 (UTC) X-FDA: 80519129040.15.13369C6 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 0E686C000B for ; Wed, 1 Mar 2023 05:00:38 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=H+L6jwMS; spf=pass (imf10.hostedemail.com: domain of error27@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677646839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u6tN4t92Y4qGgMiu8AHY6Saz3I11oSn1OtStmVFvLag=; b=yxeD9O3laTqoToR5CmOyya7W048GY4m07Yj60dj5Wc8ApwcjO1lvWdE7sr5E4ICvNhY4r1 1Omjrj5S2kKnJfqlZS2yAHfsDUnhfF39FAAdWa39tam6090RyS64qJ5GMyH36udsL9G3vm iUN9XzUxt7ZOURxxnr+NDmdWmuvHCPg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=H+L6jwMS; spf=pass (imf10.hostedemail.com: domain of error27@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677646839; a=rsa-sha256; cv=none; b=UGeglW5D+sfRESXC7pD8/ZrsDFqklueTU8lOaBPWbARdjWZY5SFQGmCMrvIa1fhIH0JdnM Xq2EZxzvRgCNWNzCJYorq1sli4JWeSAWgoEXgJsWjL3ty/2P4GsgITMobuoSVNGHu/TSBQ w83Oz7QJwd1mXaemXRD/lsmcKk7wZFU= Received: by mail-ed1-f48.google.com with SMTP id eg37so48872600edb.12 for ; Tue, 28 Feb 2023 21:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677646837; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=u6tN4t92Y4qGgMiu8AHY6Saz3I11oSn1OtStmVFvLag=; b=H+L6jwMS9o3dpRn+pHTCZBiVPFosZP8sF4htkBp6F7ZlXMJn67HNMI9BWRaloaKvRy F/aA8ZwqZghSyj1Q7gNysvLGNtQgjCv0CLS6RjGVGPwGjbabYR+tgvTqvPOqmb0nq48J nJ1aLD1jaB3EErHHnnY5BDtq+NvPEgmZHj1mAL2IaUbushceJ0SIai/XIF2Mv5jPTBVG iLXiy2sKpyDDlZc51ZutzuUl9ALtjDYixs9LHSrBPZrr5TjVbmqajrYMm+t1rlmsrUhK MiHaXV3YDYhwPmcWtuIYJGUxsHG3gOBQt7C2d30/0RhTsr810PCvA9nPcj9IWhtuBx6j my3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677646837; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u6tN4t92Y4qGgMiu8AHY6Saz3I11oSn1OtStmVFvLag=; b=U5KdG10BEv90L+QlVv5h/YVvBUrnVebtXbj5niHj9uPRuR+5dslXoa3WSkL4MLJ2xb ywnobjsCOLPaL2PAHmwaLltdZMy/zveZROhdQj3PtsoIas1NTnsoi/m3a47Sy2ENTWTu HRheENaKnyq6z2stWl269iRrumrOKlUEPijFxJW/mK+QlKsTXebsXq8uO8eOdY5Vd61o NeXcbhu3DYvQ17x8ZUIGz2ODPDDx2asaEl3r10reXFrJX3QcVcfvCj0jYNt7BDnwgl3E 3FWbEkCjrIDq+PTkCJZ9IH+gAJwWa8WCWna2fluy9PtejDUDjBf+iHyBxkxLFzejToHl 9zYg== X-Gm-Message-State: AO0yUKWr2FNga+3L+7glLXSAAmCQebQs8/4N4ukkiWXCSMNdyadsXFC2 3hg6Zwd3XjWgAxkvj221+mM= X-Google-Smtp-Source: AK7set/kvCrA4tvNCNl0azoKo9wM48fBCa9n1J6HCUveUyJIRze73/W2wisqy+KW4ozadASFmLtDzQ== X-Received: by 2002:a17:906:d84:b0:88d:619:15fc with SMTP id m4-20020a1709060d8400b0088d061915fcmr3573692eji.21.1677646837640; Tue, 28 Feb 2023 21:00:37 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b008bda61ff999sm5296248ejb.130.2023.02.28.21.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 21:00:37 -0800 (PST) Date: Wed, 1 Mar 2023 08:00:33 +0300 From: Dan Carpenter To: Suren Baghdasaryan Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ammar Faizi , GNU/Weeb Mailing List , Andrew Morton , Linux Memory Management List Subject: Re: [ammarfaizi2-block:akpm/mm/mm-unstable 82/99] mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505) Message-ID: References: <202302281802.J93Nma7q-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0E686C000B X-Stat-Signature: w9ufuktcb64wnssdr7nu91rjbh6cyqkd X-Rspam-User: X-HE-Tag: 1677646838-643057 X-HE-Meta: U2FsdGVkX18WT00HQuVWZJeXNMjGU2cpl4jH+gXyG6+H/WY8LUScjSCqrbcHgkmzD4PgMs8ErvDkKePQmbloAgMu3/BsLX2B4G9yBtARUlIvQ40OcD5egQSBcZktq8tsXUlNmczbjc6cnr+BvclnBDijxS9OijW/yjundYhm+l4ZvCWXXFBsZxHsK+xk+1OCCMRCTGWjqNMOTSl7TCuYlL4SWNHBprt4yNUIIylVrlzkrSTDJjDQqktvM5pE/pL1dEdmdeF1MduBfmp4W14f15Bgzs4vKHv6rocQ1A2i2k2Pcl2zOD0NFxYqrMit6bOuY9uYnVYgOUTEZWS9d0HTs6zqOb9378wwt1oqGb9cwRyzA2ystEpgXNqTLhozlZNtr1h8N58rUW8Y7GnL7hJnX+2HDtDgjMGDRSKi1808n+39pXE6xTHvhXMP2l079xUNrMLG5xbpGvGuAtl55iVbJisFQvoXo9biH52kUMlBMfVQhWz8dNQ4XLX7/iueCWaRYgDV3EGJjLzkJFeZZIlOVpGMxAAlSQKcXHq/29X5BlGgpTxtG39obUqMIiNjpdDjPPaJ0ArvyUAbJ6mmd8lHrFFbA5wEpl3usZjpg1xYn1AxzuXPhZ26XX9ipw7148gsuublphoSkXR5FUqXCNOvIzidDId697tapE1MnxiNP6loiwwdR+1gT6A0QFsZx/w7R9pufz3vPPOawVogr11x9QkPBBy1tMO1pNq+yBPkiFUeZXzXcgqOMsQHtpKOU18fMwVo+LPpcvtszn+lTSBZhsFKQmBA1pCunBKCY5CbhoA68qgU3PJHFNF7TUuMEf9/gjp7Oq9HVPwjGVsqy4yH2Tv5J8JPutZOgVWQ2plnE6at/QDE3eFGSOQe9u+W6tKTuEx1plqcEsepbDhZb1I5SYDsjV4XMKsqg22UdANHrAdBRkrBy0mA/lzxmU5jh5SURQ5G7bVEm2QiMR3kx7T 7owU/lnB LCrmzk3Is8UTs8OzRLPdgwKe/U1vi9W4uvAWEbIUzNlO3hW/ADAuruHpfBl3QqydC4mrpQ3bezBakufyQVY8QN/PSQeX9XyLQquq1i4v1U6rlV2H178gnzCxew4/AJlNrEXXnGQlZBjzicwGpgjKQsh102OAxlE7y9x5GFMj8BGzw7sff+RtJzaVON0yTzrDeO2uBhsEgS2maqTVPo0157+xVubr0sS4268o+jMP8mm/tqj+UDAvh1CBgTfOs1Yk7m+UsszKE0VO1jNCgROtm/vDdFZvZxNuvASWp+ritTH0GpoyIO9IfVz7CyckuTD9cV+/lqBDdbyqITbqh+mtrEMPZT6P5AInUMPEvThydOIxgI8yLWsd3aK9NoMMWwM/JA6PIMKdn0cgkCIJ88oyjfllNApRASlNtDTLYhS/sOSsURlc7mhJmTl6qZYTVuA0ggHFTR9barfNyXgMB5UV8Te/SSeN4JwL5GKqap6qWoOexOG0S9E5IoxdFnXNLdC7cONY0rt5DkY02VojKSRHZkneNdR7oH4YKpW/InO982z+mBfCL2GqCJROnKAe3wCM2pIiZqlVTMf5V4T/7mnJyew6zxJIVBfiF9sJEnOGmKxd4g5gqI7m/PR77FlBHLeGi5+3u2TM9DYXE63OtlBTJYmQm3mlHiBGp3PvRQ425Janipg0l925sBQdRL8z+9Ua9D+C8E5A+g6SHS2Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 06:28:36PM -0800, Suren Baghdasaryan wrote: > On Tue, Feb 28, 2023 at 10:04 AM Suren Baghdasaryan wrote: > > > > On Tue, Feb 28, 2023 at 6:24 AM Dan Carpenter wrote: > > > > > > tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable > > > head: 61edd3b68c3185673c9b05dfe48038692964c73b > > > commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them > > > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/202302281802.J93Nma7q-lkp@intel.com/config) > > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot > > > | Reported-by: Dan Carpenter > > > | Link: https://lore.kernel.org/r/202302281802.J93Nma7q-lkp@intel.com/ > > > > Thanks for reporting! > > > > > > > > smatch warnings: > > > mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505) > > > > > > vim +516 mm/mmap.c > > > > > > 440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp) > > > 440703e082b9c7 Liam R. Howlett 2023-01-20 504 { > > > f517f7ae341d93 Suren Baghdasaryan 2023-02-27 @505 if (vp->vma) > > > > > > Check presumes that vp->vma can be NULL. On my other system (with > > > yesterday's linux-next code) vp->vma can never be NULL. > > > > I think the check here is not needed since vp->vma should always be > > non-NULL. I'll double-check and will remove it if that is confirmed. > > Fix is posted at > https://lore.kernel.org/all/20230301022720.1380780-1-surenb@google.com/ Thanks! regards, dan carpenter