From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF1AC7EE23 for ; Wed, 1 Mar 2023 03:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05FBF6B0082; Tue, 28 Feb 2023 22:47:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 010626B0093; Tue, 28 Feb 2023 22:47:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E41576B0095; Tue, 28 Feb 2023 22:47:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5C996B0082 for ; Tue, 28 Feb 2023 22:47:11 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5C78A1078 for ; Wed, 1 Mar 2023 03:47:11 +0000 (UTC) X-FDA: 80518943862.21.325392E Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf09.hostedemail.com (Postfix) with ESMTP id DE6BF140006 for ; Wed, 1 Mar 2023 03:47:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VOEtrUmx; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677642430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CKaH6/REh8ekLOwaOfXspdYFMio8EvWqkz99kuz6IQE=; b=q4xtvU4LJ4+ifsCv0y5TAoP6+3FF/x7NUrA0HapPHIjt3EwA/bzlxZDC/OOV+bM2J1gqrG YSaUNIsDXeySRPuApNiZpgsOdxXGS09CEDopRJhsmTGSf94YAr01VNfRsXDeSZqFKSz9Tx M8F3tcscuvQgcIaeM/uiRLUyjdAEi2s= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VOEtrUmx; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677642430; a=rsa-sha256; cv=none; b=wWrDs7Os5NBTibsGvldPGlGrNpOWYns/95p6eQNSRnSdznvMp4+UgS5ZKT0CsT4XFhZKjx J6hXE+IqS8kBRZjMGltHxJx1oVsCyS2QfYCIVP3hGAHPRWiW+DkjxSMjVk2KVMMa8Q1OKM UPNVortukDDzdJ3b3/5DjobzFK+DaNk= Received: by mail-pl1-f177.google.com with SMTP id y11so8513640plg.1 for ; Tue, 28 Feb 2023 19:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CKaH6/REh8ekLOwaOfXspdYFMio8EvWqkz99kuz6IQE=; b=VOEtrUmxmdEdwI97eTsL2Q/5ZOlXccqm5SRwKlGdhKwWWqUpcfNjF6TJ/wec7+3UUb mQpFLbS8BhEQSan8xb7d/M7cKeGn2diTQO5LGUES6dqE2cf4DidOCe6k99fGHhOVL9gA AwMMTMOEmN8PvsmZPetjn9grZOo2cjkCtssYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CKaH6/REh8ekLOwaOfXspdYFMio8EvWqkz99kuz6IQE=; b=HlFZ7T2TqucSsNtbQtOVKAm7xFmA/BgV09T6JGItWk6jVmsxl8Z4ZWTuMT91phyp65 7yIw4rsL92KZzyTcORGvsPpcy0fg0bmh9eMxYwXjv8T/h+R8bKawCh7VjpGLPprrW7Td bmhSauXtmzYuj+fwEnWj1qm3Q/gutuNLxTAt6cJHfGGYGLU7I1n94jBp+8dL5a4uaqjl NGQ83epQ7l8opdR5BBYAUd6Th7FPiBzYFelH/iG4jzJQK+hGSuTxmLw47j+w8Wa1NvWE SUFMq3Y/Y933SyeNPMgp7KjbPKu6cQIfPIBZa48tr99yNrq34PdhV0tVeNhfSTBYpsEx KuHQ== X-Gm-Message-State: AO0yUKVCRWZaB5aEuvSCcHrNXNurKscbqpKoaGzf292GusRjCEAnE0aj DhNadKiIQzAMFCO86OHPghXglQ== X-Google-Smtp-Source: AK7set9Hb5hlwN0O5/09KWBEa+JZ33qHhguPe+JmIMOBDRTQ16JU5ENHH/Ajl41Tyc/StXo8G0r8HQ== X-Received: by 2002:a17:90b:4b91:b0:22b:fd64:c48e with SMTP id lr17-20020a17090b4b9100b0022bfd64c48emr6063712pjb.14.1677642428676; Tue, 28 Feb 2023 19:47:08 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id t12-20020a17090ae50c00b002376d85844dsm6799915pjy.51.2023.02.28.19.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 19:47:08 -0800 (PST) Date: Wed, 1 Mar 2023 12:47:03 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 4/6] zsmalloc: rework compaction algorithm Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DE6BF140006 X-Rspam-User: X-Stat-Signature: qie77pbsnurnxhyghiqcstukq5m9m5d8 X-HE-Tag: 1677642429-732333 X-HE-Meta: U2FsdGVkX18FDhjponqPYq0/2J8HSMjsyzIT4Xe6pbk2nqcdJFTS8FcXW4hohPY5oJ4QisQ9TgiHaH3tWhlC6Azj9tkGP4icvMCmcruMPyPnturCYBPWgJLQmdJkEr+zTCBPnJN9IyReZZPtw/3FWOjmrWTd5luymrHT9Sto5eCkfai/V7VkdS2V4Dp6jw5GImmLBwYvYrjXHuFCAB9oFGkuVRf2sJykHvg0/BU0Vhys8MeQTc8ykU2UrfowQWDnkJw74dvVJXGPTxkO9Er/ZtzzJ0F5YvR4gurX2rDHFxhVo6hZAE75My4LtQm+GFrIiu2xMQl6f91aBzIRbJ+9o0upC0aP/oElqvrRX4y7Y0klvndxOlAfJ5Wyq1Z8mfO2p198M6AwVuHgXD6JDojEjlYBoKM0tdXwyhZYkYP6WbJQgV4b/Q3rsoopbCC/fMMD5Lbt4oc7w3G9QEOJAn926wtojqBuad62N9ZP1KNnLmJUIZvt+iUkgr3svXf7+0libzQePi/cRBieXTcwInFjFNgD31L0t56ZoeimcmX8Epqu182nuN5VucrushZ1Sdfsoez2AK49IDwZGWtNRWULTIXqQcEdLavRPS5TG458ZcbI0tmqTHKzvSUhBvUXr/hs4Jk2Aks88Kd4zibp7x0fsofzBF3r7TnCgYoJhfiRyDMMsrsTfdXH3APv0bu9jj2zeJVcm5AOBk/O4fXgqVhrO1r9XfbbEVKzTJLymideUbBwLnThdLtTQlO2ErrI0aOY3pLhtTLoaKiUgODwR2u2ixtxzFmozCwY58bsctzLO85entvBsx7qSoAwFj94RYb8uIZG8bvKnEoSG3d85FOTB4vwGDbAnmZK5fVbTTWScDTikbAmhMRF1BchrbAGcqUiaqoNEMfIVyJdHkmNW3wzhZjQhBJUF3BydEqdcGb5tXAP7P0cWzwyrvS+6EEN52GchA6i2yrqN//3xANWKF2 lxFm2irp qacdHeaiowsaPxf+rJa4a3QQReVJNylVLDRq3GZ4uNwq6dBbWZ9uPq+47XAqD3bwb3/8IGU2SpXbuMgFUqV2OnRjCE8bddkOEwXyCroRKmPyHsB9QltJ9JwaDWHkoZYV6cXOPkvuNLJjT/MeovivKA/f3+ZS/bh/QoJ6ovutGpVhHxNzZJbMBCOj/TYRMnV/LCX0xffpmFmsAR/7OqHm7WjfsCFNg0Jm1P92K6UgJIgy8vA05fjLvNAIph73Os2z2s+kHFvQK2Irl/FyDfIlezjRSOmAfk8wpFN4cH+xdpC659P2Lngl03b/qrAh5zU9/AoLIVJN5cygnjF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/28 15:14), Minchan Kim wrote: > So, how about this on top of your patch? > Looks good. Let me pick it up. > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index eacf9e32da5c..4dfc910f5d89 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -2223,40 +2223,33 @@ static unsigned long __zs_compact(struct zs_pool *pool, > * as well as zpage allocation/free > */ > spin_lock(&pool->lock); > - while (1) { > + while (zs_can_compact(class)) { > + int ret; > + > if (!dst_zspage) { > dst_zspage = isolate_dst_zspage(class); > if (!dst_zspage) > - goto out; > + break; > migrate_write_lock(dst_zspage); > cc.d_page = get_first_page(dst_zspage); > } > > - if (!zs_can_compact(class)) { > - putback_zspage(class, dst_zspage); > - migrate_write_unlock(dst_zspage); > - goto out; > - } > - > src_zspage = isolate_src_zspage(class); > - if (!src_zspage) { > - putback_zspage(class, dst_zspage); > - migrate_write_unlock(dst_zspage); > - goto out; > - } > + if (!src_zspage) > + break; > > migrate_write_lock_nested(src_zspage); > - > cc.obj_idx = 0; > cc.s_page = get_first_page(src_zspage); > + > migrate_zspage(pool, class, &cc); > + ret = putback_zspage(class, src_zspage); > + migrate_write_unlock(src_zspage); > > - if (putback_zspage(class, src_zspage) == ZS_INUSE_RATIO_0) { > - migrate_write_unlock(src_zspage); > + if (ret == ZS_INUSE_RATIO_0) { > free_zspage(pool, class, src_zspage); > pages_freed += class->pages_per_zspage; > - } else { > - migrate_write_unlock(src_zspage); > + src_zspage = NULL; > } > > if (get_fullness_group(class, dst_zspage) == ZS_INUSE_RATIO_100 > @@ -2264,14 +2257,22 @@ static unsigned long __zs_compact(struct zs_pool *pool, > putback_zspage(class, dst_zspage); > migrate_write_unlock(dst_zspage); > dst_zspage = NULL; > - } > > - if (!dst_zspage) { > spin_unlock(&pool->lock); > cond_resched(); > spin_lock(&pool->lock); > } > } > + > + if (src_zspage) { > + putback_zspage(class, src_zspage); > + migrate_write_unlock(src_zspage); > + } > + > + if (dst_zspage) { > + putback_zspage(class, dst_zspage); > + migrate_write_unlock(dst_zspage); > + } > out: > spin_unlock(&pool->lock); >