From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EECC7EE23 for ; Tue, 28 Feb 2023 01:25:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C4A86B0073; Mon, 27 Feb 2023 20:25:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775236B0075; Mon, 27 Feb 2023 20:25:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D8A6B0078; Mon, 27 Feb 2023 20:25:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 558746B0073 for ; Mon, 27 Feb 2023 20:25:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D4EF1204AA for ; Tue, 28 Feb 2023 01:25:49 +0000 (UTC) X-FDA: 80514958818.07.29A2CD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 772271C000F for ; Tue, 28 Feb 2023 01:25:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xg1djx+z; spf=pass (imf18.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677547546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FFEwA9kY84tW3dttxCqkP+VYgbPWxlOn01davvWjfhw=; b=gJWfJIrVCQCSQ4IMzXAIXqLPkrmlel42sCKC5nsilLdo0mE8mNTA+YOJrrpt2qmFAyaSdo WMjmN9kqRAdOxcosmduxhMCwZm1rfuhauT/SHlScMS83wLheWNqptrSJjHxaNL54W1G94b cRlxap05WvgpTpQoNxohOOFTMwMU0vE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xg1djx+z; spf=pass (imf18.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677547546; a=rsa-sha256; cv=none; b=iXQaPzbsU0XpHBQH0gY0XhUKKHRwEmBdzWJ1N5jzR/bSaM3TZfHjFTSLEf76L2xyc09pTG w9PWACaqjNXv86EBpZl6huxNeUWpJeQ/4DBYrLA9xjLGt/ET4YcZ5UaTrW9qDiKnxp7jK4 d5ReH+ylkxeuAc6BLJyprWcZj5iJjkg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66A1B60F83; Tue, 28 Feb 2023 01:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 640A6C433EF; Tue, 28 Feb 2023 01:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677547544; bh=kmjqpySMhE16uFWHoYoNjT55OARJoXTSrw91rhPkC5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xg1djx+zsnCP1WarW2dmdsY73vCUduoAuuLQRd+ITn9BZDhj+v11d50C0+lqDQwl2 ey8geH/KKNwFgPtESRt/iW/nggiHrWaqlw1hxCNNvdRRkf1wvzKPa+jpZkeC7siU16 CttMYv4mIYaAWCYztCa0+UImhtGn4oXH78tV+EuaYljFZ1yv3BR9/ZAyEM8sqkhYsH scwuWIsdTH3UJREcUlm/gQ8eoYXa6bDKMVObQGY8FcYI0Ev4SdmQDsgeakmC9/ngde mrGaGjdiu9hlZysBoVkkbITZ8OzTL+4fZ+Jrfr6ND9r4AsgZFGxLw7fCUX6OGtp+6U 4f2OTpaq/qyGQ== Date: Mon, 27 Feb 2023 18:25:41 -0700 From: Keith Busch To: Andrew Morton Cc: Keith Busch , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue Subject: Re: [PATCH] dmapool: push new blocks in ascending order Message-ID: References: <20230221165400.1595247-1-kbusch@meta.com> <20230225204239.21f1e1ab9c9523f803d9624c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230225204239.21f1e1ab9c9523f803d9624c@linux-foundation.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 772271C000F X-Rspam-User: X-Stat-Signature: fxakxkczbzxp6dx5imhmamrw9g4mxgz3 X-HE-Tag: 1677547546-258577 X-HE-Meta: U2FsdGVkX1+18VV3OYFSQnyeN3y3vzrcWf/PmD+CUX6ArS6DSTAjRqCk8wZpFvwpnVeP0bWlc/T92yTZmx4Hm1B3laHQCi6atAuzIeeaeC6/WNdDNwlg8wnzZ5uE8ktmY7ldURIK+QKhJmWSt9jnYHN4CMJ5IG5g+MkUqwzwmjvCldnOEHYQVpCbE+pzSkjLqws/CMt+3n2QB7Q5hEiTnPOUHIS6mf1ZoJps3jMRUNwCrZqiFEqOAkEnXTvEevPHSYu+/zwa7yZdf9EaFnMFxIDBO4qt6iufMmRxpKGCKi9AL38Y7TmPBq8HfLQFG6ogt/61dTxG/VM+UsXe7LZLxJV50usBSLZ8XvVagXfcZfQ9ecSmZH4QzdlLW9/OO6mnVHe8RZViVK6BWfX8mq8mOh+JW1hvTLroaDHYh0+HVr/dz7g6GihA3GIyMcmgWxlmHF785qa0q1luEq5s8RQheVmad0/jTIwQqVON6s+SauiouJeM9kqUqUchCZofPZnf714pBhlHQbauI4Isou1QSK34npFARkcmb3/6UPEvZWp/aPtF0hzYUUJwbjzUOWYPCUMQ6MVu88o8AMkiEuZor2KQYYoiJhLFjDOx5WlJ8GZ/kmhNZax3C+9fAO4YXrbdGm/jNYN2JIWSeFaejLMODle9+3mTm077bro6SK0ErKH6ilrOq+yxZ4X3eQ/8zOZozafYwYiad8SQiTcrYl8LRiPr5ccA0r7JWuFbs53K8PUl1RnuY6L8KyXDuNssjfmUV14M4+k8g+BK4lM+QCFaQi3vJKjBYllP0LEl8iEOIuW3yPF4sCldGyAdVoj1w1S5OisNl7k96jfWuG0e4KqyM58g/dWwwuIY6lx1O02xHQrNyti2oprgrglwIMXthn/U8zatK3J7moqickpaG/xuKhGHpOtE05mRp3aBe4sSe69USQwgcVKpbjnxmb4JXfFAp3wdUaiL7zLHwZuKrFw jq7Vfy8J wefN0abBX7ae2CYcqnZGAYqAmFg0wBGios1pu++Z+vuL+mk0Z36l/qSqJB/BGrxhXl0Xxp9RpWAj3Y3FkrwdJ6s/11w5amoycqxvBzIz5PuF9M7HhAqxxi9kww88/I2oUK+BWcMR6PfrOBbWG2VY8b8X5zxcMSrO8tI57QZdKA26BPcDzGWjHzPs4P2PpZumTuL6Y8nsowGZPiCaAPvqZWS0iwv6D9rzS20p1hgCiUl1aQtyIEyPIFFMPwqzjqAtBJkhBTDCFttYphEJzcc88lHY5EaM/drc+MLAHsg0qWvMdIFncduKixQO2WLVeXumQFqY1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 25, 2023 at 08:42:39PM -0800, Andrew Morton wrote: > On Tue, 21 Feb 2023 08:54:00 -0800 Keith Busch wrote: > > > Some users of the dmapool need their allocations to happen in ascending > > order. The recent optimizations pushed the blocks in reverse order, so > > restore the previous behavior by linking the next available block from > > low-to-high. > > As I understand it, this fixes the only known issues with patch series > "dmapool enhancements", v4. So we're good for a merge before 6.3-rc1, > yes? Okay, I think this is good to go to merge now. My local testing also show this fixes the megaraid issue that Guenter reported on the other thread, so I believe this does indeed fix the only reported issues with the dmapool enhancements. .