From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E05AC64ED6 for ; Mon, 27 Feb 2023 23:51:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7482F6B0074; Mon, 27 Feb 2023 18:50:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F88C6B0075; Mon, 27 Feb 2023 18:50:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E6FD6B0078; Mon, 27 Feb 2023 18:50:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4E3876B0074 for ; Mon, 27 Feb 2023 18:50:59 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07ACA12016F for ; Mon, 27 Feb 2023 23:50:59 +0000 (UTC) X-FDA: 80514719838.12.F86D552 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 64EA1180006 for ; Mon, 27 Feb 2023 23:50:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=h7ru2jVj; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677541856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hhWZAIlF6fKDyP0S3ixh+SYLF7C8k6DfSQC71GqLDbo=; b=04wO0p/spn+mcpxRDUlPhbOb1kVXTu3GnHIwPuHPKoyIulfKfkHro7i/QuDCKIQfuUGpec o+kUGkwXo5uy2LXlAxNc0WEL8sDKsCAky6Zvi/vGk6zcQbgVrTWqhAVcBYp9dzifvDa6vz oD7GYlsSxAH68Dq4fSudyC+e/7NZ394= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=h7ru2jVj; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677541856; a=rsa-sha256; cv=none; b=Rnj5nMzg2zXT+sLIN7+STX2ukfA1+ArwtDEwbSjOSdUzR8aq5tynD9NRNGIFeO8Gt8BH4v Az1gJjw7vGOFG+6xVlX4KtvceE86yx3DGjcufQgogzXELmOZRDbH5dVfuvc2pNKGYeZ4Bp CYV5J0jNcKh0+rMwHDaKE5outW9WI/s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hhWZAIlF6fKDyP0S3ixh+SYLF7C8k6DfSQC71GqLDbo=; b=h7ru2jVjhP1Mih+iVVS4dfvE5M khcalHp6b5AL5G5v+ZNog4NPOgDwbb/RKRbf3hwYrQ38q7lpueSts6B2JB78Z5x8tmMsbglDKDUB0 zqOT1w6Gl4DVvypUwkIty/3QOJcINRhwmPKNGkmRnJUOoL9nZHcw2sPGdceYV6x9oFMyBTVPiVXpA Z/SubpBTl/6EC7vHG480+SspytkBU7I1q9pevrl9NcEx8fMiZk3GweGr7c3HI5cRfcVWixsBquGCF kxMUkyT5QSE83ptxH1ezTjzFCiqeC/RRP8fPC+ou2Taf21tWaJEXGqC0MWzCCxW1uU6JF+aj8fptr 73EikYlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWnGe-000U9E-MG; Mon, 27 Feb 2023 23:50:52 +0000 Date: Mon, 27 Feb 2023 23:50:52 +0000 From: Matthew Wilcox To: John David Anglin Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org Subject: Re: [PATCH v2 17/30] parisc: Implement the new page table range API Message-ID: References: <20230227175741.71216-1-willy@infradead.org> <20230227175741.71216-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64EA1180006 X-Rspam-User: X-Stat-Signature: opj3wnxwhyspypx5yuz6gsh6fkxmb9ug X-HE-Tag: 1677541856-231219 X-HE-Meta: U2FsdGVkX1+egyEfYM12ONraR36ttfts8zDqLvefPdIKOcpq0oudd4Ck/2DS2eINptalSJVbe4K0/tOXzcRtyCqzCuctJN/wBlZRbLSJjJEG5P4J6f5AzdCrB5xoZv1k2f2ZpwffiLlzdyLPGNh6A6/SO7PCo3W3w5hRk+0Za/BaIvkkVJuQdnyY9iuWTaR9D5kpE4V75M5WQQk1spE9VvuwRTpMHiuqOqJcrbC3+CKKhV6Ko6FEm6vnl1QF8YfxxEvUp7sZGQoPBNGIxEdp0ai++x82p3KTcUMr+hIF4zyGfdhQJu4HdfKRkbCNtvW+WUq8Fr9QqUJ0SCGkU5PCNqVzWyRhMWuSbngwku98+XL7Mtfe2FRIbcj1lm9eWsLw9e7yQHP7y/9r8lTf8TnsSsy69Mn0dY8z7PFyPs1fDiTKej7yC0+mn0HjwyRcCH/ajp+LslZAmv7TBs/8LkcymMzfPyNtvmDPALTb0Srf9RsmHcHkv0QkYAsNJ95yqYxgAr0Hm08A4UXsMAUg1Uwjz+XrTztQtJMA85X/HXQo1LCPk82Jewyv2ztbXPn6d3QIshIVr5F4ziJfXLzlGZtVtOEI4s9lelFTF+v5vt4dF4ad3Gz4HZ+XtgiCJE/JKco9QYFVpA3PHfLM7b8Vv7CoYgfjLT2XksxQVuERhtCD64aRbKpjvV9g1E0QpqbqXq9Faw6m+RcJ1vs2x9bI7JrBd/f1cpsUCxomtjqGgqrjT3ulTzooFgx3GWdo7b/3DMCJjRJ/oY4vl+HvxE7mnD8kI/znYbDYSXOOdrnLA8w7b8QhD3jkkJki65MZuxAKehPkipfMdcCOD3Hmd+ZOvKz5Tk0XZ7V4TdNeRPXJQahiEtts1ilINxCMHsiEt2kBfP46POXlo5dU5YRFV3qBP2hK16Or/PEbmKHeHELhXFPsSC6+ERYPN4T4X85vD3iKz0u7Ox+bZyBtB8q3Eo0X4Dk lizXNRZy muf3Q+hyfyniBg1xE1c1ulYx0G6lmHyA8IgIuyfIFRaggtnN/TNykYnZLgeI/xNVPCa1A012a/9xlGcx2svVyPU69MsfRq1Q2VA4RmY+mITHsRLFqhFh9SxGverXPuJWVHHMKiRI9vIaneCNMq8XvUUO8oA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 05:49:18PM -0500, John David Anglin wrote: > > @@ -104,13 +104,17 @@ __update_cache(pte_t pte) > > if (!pfn_valid(pfn)) > > return; > > - page = pfn_to_page(pfn); > > - if (page_mapping_file(page) && > > - test_bit(PG_dcache_dirty, &page->flags)) { > > - flush_kernel_dcache_page_addr(pfn_va(pfn)); > > - clear_bit(PG_dcache_dirty, &page->flags); > > + folio = page_folio(pfn_to_page(pfn)); > > + pfn = folio_pfn(folio); > > + nr = folio_nr_pages(folio); > > + if (folio_flush_mapping(folio) && > Shouldn't this call be to folio_mapping()? For pages in the swap cache, folio_mapping() will return the swap cache mapping, which isn't what we want. folio_file_mapping() will return the swap file mapping, which is also not what we want. folio_flush_mapping() returns NULL, which is what we want.