From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5913CC64ED6 for ; Wed, 1 Mar 2023 18:35:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0C216B0071; Wed, 1 Mar 2023 13:35:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBBC86B0072; Wed, 1 Mar 2023 13:35:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAA876B0073; Wed, 1 Mar 2023 13:35:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CB3106B0071 for ; Wed, 1 Mar 2023 13:35:30 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AF39F1A0B8E for ; Wed, 1 Mar 2023 18:35:30 +0000 (UTC) X-FDA: 80521182420.27.86EA637 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 9D4B818001D for ; Wed, 1 Mar 2023 18:35:28 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=L6vDbXZp; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677695728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wf0mD7k3wd9pu1O3LZesHDQH1X0cWEqYTsQRgJAz/JI=; b=lccNB67k93AAud2YsOk6ES04DuAPqR+36pxx3z01IUDZMZMoeaGwqurP45BEdDl1cpuOvM /JELoXHLSFXV1sA6JBUl4c68Zln/Qi1nfj+hbHr0TwIfLIWSnw2V+szzqapb354X2bHOLr l1iuP+oHIp5tnmaL7B4Jrvd1KjZI/Wo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=L6vDbXZp; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677695728; a=rsa-sha256; cv=none; b=SNQtkB1Uv/BWn9zQgzg668iOgb52HqeZtsWuQnoJtMU9vWvKAaFlwH6aNuDDsa4/1LQnq+ x8QgzjJXl09U5tcT0dw2i8c43xwznqAnRH8rVjDn4nseVH78k3vFWIU1PtQI6sSxz/yDHP gkQnI16sMNtnL+8usN0K/wlN5Fo9omA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DEBD021AAE; Wed, 1 Mar 2023 18:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677695726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wf0mD7k3wd9pu1O3LZesHDQH1X0cWEqYTsQRgJAz/JI=; b=L6vDbXZpy0lNSzxUMms4I0wHVTM6awFbslQl43mrBFRtHAdGVwdgDOXZBmZfbDLIWT0uF/ ogNoBc6TqAHVS8pw8Cs4WPthRjkE8V2MB0rKjnxTIbMaraLXGeeEAURWjStIXctM8F8BiS M3Kcgdt1zp+f5/ONAGx9TSOwAM3K16A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8482413A63; Wed, 1 Mar 2023 18:35:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rmRuHe6a/2MdQwAAMHmgww (envelope-from ); Wed, 01 Mar 2023 18:35:26 +0000 Date: Wed, 1 Mar 2023 19:35:25 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, peterz@infradead.org, johunt@akamai.com, quic_sudaraja@quicinc.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] cgroup: limit cgroup psi file writes to processes with CAP_SYS_RESOURCE Message-ID: References: <20230301014651.1370939-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: f9xspzc3tf1eug9ad591s6uzub69tqie X-Rspam-User: X-Rspamd-Queue-Id: 9D4B818001D X-Rspamd-Server: rspam06 X-HE-Tag: 1677695728-493110 X-HE-Meta: U2FsdGVkX1+23fzwYt+4UCG8OiaoV/NaTenYTTsUBxWVuKMOiC3Z1ZToPk3rLf2xT8SVLQFjJA5zu7fKn+OJ8h7KjWF9J4ZaHnje6QBwV7lrKn9LS8UMhqWDPeKsBm/U89/LsATiCVGLmkxm5HjKK1epsBiGidhTxtgWodE6Q17PrX73NK5aCFCmxFKqhIyK20nmIfxHQg9hD2rt+EBvbxk/jpxpSai7O47GAdMBvzFIV7LWjZFxDUWeUKmA2wbDBmiwDuUUWQ5ON8LSZXWzSu9MklG6oKXXcsQbGi4zEp7G5AYp7qfXuwjuBE0nNcDrVwUl9wBRfTWYdXN2BfZo4ZPmA4T0CvT+ed8vc9IEVrYZbYxEh8332TVhMOqgN+qBP96S6oJRCCelFGnTh/W5rDu2g+32NT26dd34LWyv0V4VwcsIgk0H7EEwhGbp9+St48UsUhwW99INj8WFlNaD7aWMD5cEUlXLzh1iqa05iFQxePY7TNANPrW6BMn0iVJFwvlBUwUcg9L0f+VJUW5hDOwDFTVJTNOahkuELqLvhHPglibXl00wzZhVqoT4KWUOuc6U1zGmCkWLNRctdKONFkFozsZG7rkV1zNuTJlLLsV1Tvft8lsR97UOF2INy62x97rOD6gBa2p7fwiLOZ8dfM8ip71+JIF6F9gSXvc9b4NsLFBeKa94s7DbZvh5HjwMOowybQDjUWeSoYtx1cBqVVqDS7BBgvi2VrTT+dBcPJI9h85V6+R41wLWoP5MzpOYHQbCz8046FS86O9iBgTNrWaeV7pHYP36WNiwVj66PZnnea9EdwzBVFQrtuChkHEY5j1hcYz7Zn6HFvQPLY4AFzRBfjO5eQV6ylP4vTImdGrF2rz/vISKw+6v7zFQ+KYOeCJZ92xWUo6ihh5IoXgSsuatLrGvSz6Myo3PYv9+vn1mnsGAeYJtUOiAxxDMModJ2SuFgVLerfWY/Dyvk59 lDGgCsvG IYZUg9dFDA6nG3ReWDLWXBFirnbWopN6WL80GUtOOx8MnbCndXr1yQJtnHFYZ3KGo58m7uBqL5n/QMU6GDRJuOXip/7nuDLn4xg/xJdReSLqAOKHuYGBSxS7bkkz375UtKvPrqgnX/6wBinW2xJmMOBhGqkXeoskfs7/WNgozm7mTuMc+5v8YU/8PMgFLdDicei0lGWg+t+qocuQtkBd+LlICqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003192, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 01-03-23 10:05:36, Suren Baghdasaryan wrote: [...] > Yes but hopefully my argument about keeping this and min period > patches separate is reasonable? I am not questioning that. The practical advantage to squash the two changes is that in case of the CAP_SYS_RESOURCE you do not have to explicitly think about reverting the min constrain as well. I do not think reverting one without the other is good. -- Michal Hocko SUSE Labs