From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF43C7EE23 for ; Thu, 2 Mar 2023 00:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C4536B0071; Wed, 1 Mar 2023 19:53:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 674E26B0073; Wed, 1 Mar 2023 19:53:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563696B0074; Wed, 1 Mar 2023 19:53:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 487AF6B0071 for ; Wed, 1 Mar 2023 19:53:11 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 10191160878 for ; Thu, 2 Mar 2023 00:53:11 +0000 (UTC) X-FDA: 80522134182.05.2BCF0DA Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 3E5ABA0015 for ; Thu, 2 Mar 2023 00:53:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=c0q7Kppl; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677718389; a=rsa-sha256; cv=none; b=kLzqsl0kUDaXAaQPjBg9JEkSx72j6mzoEU8CMw8VSAK1oQAIdB28LX0E9jZjqOgMIPU56x JgeAhP19nYDUsU385F9OKKH0M09Zv8wDLpoji9BvPDuUoliLaZdV1z/oZSQjXsL23Fggjm DQVXQqNCkjcpGwTc2to0AFgWPVC7cUU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=c0q7Kppl; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677718389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwrMZ5I3T6uRzM3A6umaOXwCbm8OAAi/5ZzWIFWyy2o=; b=i/PzRS2XoSqgV9BL66+qnmVc80YX8HvGGhTF3Aa5r7ARMH3n7A3Y0OugNOsgw5AtO4IONz J3nhoGQI7txhH3UhyQkIHMWCORn1XX4DbtllIlraYoH7EoPsjN064uCoc3FU7NZcbv/xS0 1Rk0LXrQuUY/3+0hKVHip5KlsflDawA= Received: by mail-pj1-f49.google.com with SMTP id p3-20020a17090ad30300b0023a1cd5065fso1129310pju.0 for ; Wed, 01 Mar 2023 16:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GwrMZ5I3T6uRzM3A6umaOXwCbm8OAAi/5ZzWIFWyy2o=; b=c0q7KpplWoYrLdb1E4hjrHNFSpijbfkD5k4sqqT0x4LldOcDkUJpwG3TRM+7p1tWTy glH165cj6R4HZrDQAvGxHhBjAEutnAdw4S9yow/04ImQ5hd8QKlb4D3JBGtF3er+DAde LEn4oJEqbkMbt9WYfN94xXss9xMZjFQb8QK8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GwrMZ5I3T6uRzM3A6umaOXwCbm8OAAi/5ZzWIFWyy2o=; b=ED2pAQBK1HaNuVQO/DaaA1KxnMAqFLq+B+2dwzA+g+jI2zbH1/K5gk7srAepDOmqAX j5vB2VwEju2z2jLuIRmDULp/u3tk23fZnfm/zMsoG7AYK1h9ME8Cm+zDpOXEfs7pQbRm iUDlp+HgUpZHy/UdadOKEXKAlDQYc7USHm5V0UhyhramkNAKN/+9N/xyyu206YOLI/Py t968b4HzqlKUSeD/xXPgXQ5Qfq5iytMgrIXP1JhU5FMG7JVo/jsOOfd+J/j2pzY0gTKn ViiwW19ioe8Qgs3bIYtVVHEncuJYP3PtOpGb4Ol74UvDxK9ZcxlZOIbPvfkuD3LaUjpl tDKg== X-Gm-Message-State: AO0yUKVVXjsflt1adtjhPzLPBPITMFDMrUCuWi0dR03Qfi9SqmQr9aMN BUTpGgQ8vkLty24LBeCnqUclOw== X-Google-Smtp-Source: AK7set/izjfhBX+baQBD+A+keogk0r5KJ+0emXgJ8WYMdRTSYVl2r0bX24AaK4s6QlLzF6TZw0QMRw== X-Received: by 2002:a17:902:f7c2:b0:19a:b588:6fe2 with SMTP id h2-20020a170902f7c200b0019ab5886fe2mr309199plw.13.1677718387837; Wed, 01 Mar 2023 16:53:07 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id w5-20020a170902d70500b0019d397b0effsm5731347ply.270.2023.03.01.16.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 16:53:07 -0800 (PST) Date: Thu, 2 Mar 2023 09:53:03 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 3E5ABA0015 X-Rspamd-Server: rspam01 X-Stat-Signature: e8kxegfqm85jzf17usde7ppymxd7nmn7 X-HE-Tag: 1677718389-764928 X-HE-Meta: U2FsdGVkX1+ZAGJrgV1dGGpIAEt76X22nUU6pGmF2tWj9U0jgjZEcWSknNR+fOWp+R1fTCAZf8RoyjmeqM9a3LMHtr9J8WoFBlm9fg7Qa0diU7gh2a7YMkd+5N/PFJ9b3yOrRTwhLU/IXwJYkaQ53EKO8df062kGAgU8KxGSnTZP4JcwapWZbYdaHYgVV34BrHd6lWkOqxdvQwJxJdJ8SjWgGHM2sKy1xemeB13dmexIvsdQ8n6/KPQSKs3wUkgW9LdSmqwSvZqAxuDt674aF9qQ1hCDqJvlMxwSNdYNo7mpFRv2+PwMJkOqM2XLRaGuOBsycapAZAS+HaVVuRmdphTZscAj85DYpPcUSV+sHgwJ/5csaARqcIiNZcesXtSZsFy6J3W3HtfKOWmfL0vCVaa3QkIR46GeSPHfByqXyXHs00OmWX6sYrHyxQrm1mLsMgpwCHJ+Gm7dTKcrZBp9YfO9y5Py1I+6rMkGof8RztVbUYujqa5rJ92c5P0HeAScsuiZpFN5erTff8tl26OgtBt2Uhzv3Z5WVlHFZ/2zULiEHv2mFqTaLm8kllO7+hgI1EEfMAO5pc310T12bU6FNBrqBWx62OHQ6xfM/lEruKRHSTr6/8AMUdKaqwS41jzYtQqhbeyzzeKBXsoLAIfHvmnHV6FiUc8NKM5oUnYAqDKPkS5vOWmjVMSsXCN9SpmymBu0OQVclAihxkAL+nOrpf9h5rUBYmJgufl1XbPeyaoGsJELBBXNEp5wBObNVYnb/jLtCQt/ksBVy+UpFyYCHFRKtBtngDjAdH2oAQtSNZQOKrHRtMi7GQ4ezYXM2yipZKgA+5lcX7007aiZKOjgJ5gp+U7bPJ8jsKQAgW17/Zg30HeNb55PJ38lPMVO/Wn5dynwarZN7zcWwA8gmVluby6OFzcswUrfhkc95Qozj9wgD9DiG8eV0wgnwAeRkEC+85KsJyMKa3RT5rutZut s9Izx2hN C2/42Sr/r087/7VHvqjX21G7plqWA2u2BSmJ6yfEkTlht5BRV40trhEtpTZdPlJaaWhrr9ZapDGCmNviQVWeqHPJT6salUKOqmBz8Pnw+zNS0DLVcQG9qIbJPFMwaZWMb88hvH4Kw6dFkVR5ziB7nFwPVIzZuUv0XMp3KP7el11sXTjcIhIT7OcKK3x89bG6Ym6zuEeVb/mlgimIHXLq6/Yo4CvYo17LeqfXLNuZGIZNh13Q8i1jvmis247c4K+a8MtSs8b6x5sKwbCfKloa/nPXvbJqT/GAMq8ECAk2CwqmF5smLVBWawjJl8cWjScmtluXJfjThAdpNyic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/01 16:28), Minchan Kim wrote: > On Wed, Mar 01, 2023 at 05:55:44PM +0900, Sergey Senozhatsky wrote: > > On (23/02/28 14:53), Minchan Kim wrote: > > > BTW, I still prefer the enum instead of 10 define. > > > > > > enum fullness_group { > > > ZS_EMPTY, > > > ZS_INUSE_RATIO_MIN, > > > ZS_INUSE_RATIO_ALMOST_FULL = 7, > > > ZS_INUSE_RATIO_MAX = 10, > > > ZS_FULL, > > > NR_ZS_FULLNESS, > > > } > > > > For educational purposes, may I ask what do enums give us? We > > always use integers - int:4 in zspage fullness, int for arrays > > offsets and we cast to plain integers in get/set stats. So those > > enums exist only at declaration point, and plain int otherwise. > > What are the benefits over #defines? > > Well, I just didn't like the 12 hard coded define *list* values > and never used other places except zs_stats_size_show since If we have two enums, then we need more lines enum fullness { ZS_INUSE_RATIO_0 ... ZS_INUSE_RATIO_100 } enum stats { INUSE_RATIO_0 ... INUSE_RATIO_100 // the rest of stats } and then we use int:4 fullness value to access stats. > I thought we could handle zs_stats_size_show in the loop without > the specific each ratio definary. For per inuse ratio zs_stats_size_show() we need to access stats individually: inuse10, inuse20, inuse30, ... inuse99