From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B30C7EE23 for ; Thu, 2 Mar 2023 00:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D90C06B0071; Wed, 1 Mar 2023 19:28:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D19EC6B0073; Wed, 1 Mar 2023 19:28:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBA656B0074; Wed, 1 Mar 2023 19:28:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A90F36B0071 for ; Wed, 1 Mar 2023 19:28:29 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 76B6F8061C for ; Thu, 2 Mar 2023 00:28:29 +0000 (UTC) X-FDA: 80522071938.15.84A5937 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf06.hostedemail.com (Postfix) with ESMTP id A12EA180005 for ; Thu, 2 Mar 2023 00:28:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XbAsdWAx; spf=pass (imf06.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677716907; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U6MSs4JhTicNv1RSJUVEYiuAWhf/shzkoon291NbD+s=; b=fUGOnAteaLabqdkkShYOBrPIxE3wXaq6G8UdpdAIhSjawXo0T3HqGIDPCxcJZAh0jfrUoD xkzk7xycnQOyj3DRswZOk9KkIgozTWKp1UR34qXHeknVxQ3D0quxVhGiIcSdqTi1+SQgIJ o90sAEfrMIweCQOtXczp6wjvAwggTRs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XbAsdWAx; spf=pass (imf06.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677716907; a=rsa-sha256; cv=none; b=M7ftYgei9hIGnYPWkIz1f9UiKAleOkV0GgEyGVZHLQFtDbqt43bsL+H+R5F55Ya1Q3e+On 1NbYm/4XjvLwukHgf5gDPZidSmqmklbjw1CShI0kFET5SHXCyoBcJDOzbKPva/dVDJrmph iV04Blcq46MDjYjXjxG5zvpsQhiIBms= Received: by mail-pj1-f44.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so2142627pjn.1 for ; Wed, 01 Mar 2023 16:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677716906; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=U6MSs4JhTicNv1RSJUVEYiuAWhf/shzkoon291NbD+s=; b=XbAsdWAxXE1xxvdye4FEAafU+kg2XcJZd4UAfM2F/gMNfhKpMAlYvAEctKg1W7Zr7C aQXz4L4OAi5CdJz2p73HTOZBmcrOsWOANKBpPJYBr8hhhmX932CknmnV1rS9DHZaHP5X LYJy5/WgTvr2qn5ja3rkSy+RYR2PSbDsBD4XKOWLDk2UbQIT7ZG4CpyKNf9n7xRsLYwY FrYF8e39DEIckzd4TnGyJ48yxZsu44N15JWicwBvdLPE48Yo0EBkhgV2h5qZS5B5hJ7p qaVIiGTSjwPa0AyQIfLfxRnGyRs+nqRmwqzvUxwryjVktGv+pJCxCjAnJEMcM7AeeoDK ZLCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677716906; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U6MSs4JhTicNv1RSJUVEYiuAWhf/shzkoon291NbD+s=; b=kjN7/cmsNLW9GCIgJHS/rgpWG4s58akb1Vbthh3FG4r5YxgcCmO1RUwaqlHh14o8SR SVVk9DMzyfxU125iDb52wRjHt1ZWMkqzBRPwNm3eIOKlCV5iIC5CjTdZnecMEajJm6BZ 8m1JdoYAKIzju7y7THPsGUcaRsokWFHnHVoT6SWW0TR4k3iHapjOSubG2W597LI6Hogi Kw5zOy7gsbsJ0xAmPBedx4TGeB90MlbS+tpk5/5JAiwAdvlLahGrDfaJt7vzSHHqd2Fh TSt6BaOWo+b+eNeNidAP7kBfmp+6nkY5Ma+wAkWO7gsUeXpZu71nHODywfnAfs1ftwba jFOg== X-Gm-Message-State: AO0yUKV2qVvKmLwYj6fzl7W2J3rYj0yC1qYDLapklGMVMQmqUl7XANve YK/VC0nr9lSPUh59fk1VdOs= X-Google-Smtp-Source: AK7set+VnE3hhih39oN83eGdcDUSgVF2hYkW9hqkdwKojEI3f5njwQvRhZeRisDZPXQfLnAtJS1BWg== X-Received: by 2002:a17:903:40c6:b0:19c:d6d0:7887 with SMTP id t6-20020a17090340c600b0019cd6d07887mr7060079pld.30.1677716906532; Wed, 01 Mar 2023 16:28:26 -0800 (PST) Received: from google.com ([2620:15c:211:201:a524:71b8:ce7e:745d]) by smtp.gmail.com with ESMTPSA id a7-20020a170902b58700b0019c2b1c4db1sm8938483pls.239.2023.03.01.16.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 16:28:25 -0800 (PST) Date: Wed, 1 Mar 2023 16:28:24 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A12EA180005 X-Stat-Signature: uscfajn9nzo4ys64eaom4kf95nn1xymq X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677716907-663553 X-HE-Meta: U2FsdGVkX1/QZxTLZt4bJ5Ry3gcz9exOTe42npQ2g+7FmJ+H41t4tFOIf9K1+XpdZiqbWvvangK4DaDc9rEGBKpP5NZZJ+2sK8Akvnz2VXP3gQGiMlnIU+YoS+MnZDKV35phXumNzqIMY88jqFyMLPN+GJlkDw7ILdoBrqJuGpqaqC9VAFiY5yFuDSuIi5J6tnmomMb8U4r6ntMtUPSBol4Jm1xgBTkn+nWurhKhYp5YLc7IexSaCoH4wKK7hzlrJ/l96rK2txUrzLKy0vfer+TX5XukajF+kZ+jHB4kT4RTJHHbDrKQs+QUM7d6oSzTEH/cW20NfdapgE4dggH8/fAmFdJKBUJ4JwUIHE8QMH4Ani/30Zo+KrAVnF/jp55DvYe6q2cLXUFlJRHKN/7rgmdOEQ26/ZB3bJDoJ0lq27c4Olmm3nXe3VsIj/GqWDiwqnwcOToCwbCSRMkCvcjg2h/7fHCEzGuPPUC7FTkUdX2cYj8zQ6v1NkGcwGJ75PlOEjIfFM6cAf1EpTYjlNOi8xZI8rY4k0FjTA+7Y4EYJ+N6AMOQ1/pieJ3O30A5ciOcFj5neZaxcdsm9rocAo1nqukUHd1gd+B7m7uKfCJ/HPWQqFjB0mp9+eHj1ckU+qk5NVZMrkewC6K0CDK4Sg2fvXE2Nw1qmulU5ygfJXv7CNQmxaBVKNoAZbPzo05CK0h7L2OEMPslFf/OYyRqm9fDMToUfNLq5LWE4c1fKU1UKdhMwOp3OreaAy7y2AshDALbCMnuQqaULHM7hRrzAIMBCjJPI7msLDlmXmZWEbSOf+sE5PkeoDztcohbtrTgGEljZAsoR4fqP4LEk5Ba0DXFN2Qdg8C+rLXs1i0O9V+RyP5MaTzReCgpvTYpAYdwI0EFlwtVpyTT4nNuj2CT3OxetTc1Xyq3uhvEFDfjZFZsU8v1NRiP1tvnZBiKoe4+5sL2x/cWqk7erEL1O0ggYkh GIJMMsiS 1DlUsRGd2a2VxUYjRSwe7R1cgqYazM02aCV38yaJQe9WVcTxaB9XLSxJ3Zv+dAsKkXpuhAYMHfj8pEZVMoeUJa7Dhve3TFgLUVRcB1jkCzupiWyghzanlHH/j+9sEHQjY3oNLk35g0WeL3aj1iQiclmQ4hkZWPjMMfpDvnu8x50cdkcUvOnfo+qAI0bYPXpBG+CrLNYDLDYM14ht0IG/nc8R1cI3RnKsUrA25+2Z2RQ7CYVEUObpzMgX9FMGr8TTMRSxtGlp0CTxwSt4Uj69br1BkQ6rvBiyPadrOLBan8XxRf7RnD0F6deJPckAeI1dnSGMCIhGkeKxnbDNeCwG30e3V49t5mgN0Bu6xCXegrmCeZiWMJV0G4tQUj4KJ9fRfPTunh+i7LdPAcp7s4QhmyG1T50fpFIZe8psxEV188Q94VDnZb3+4oxtoQuLXl0kJ8LkGdwheIWK7bgf65cmVLJQJjWa0zqs9pspNjPfaq6x80VuR3KPWgFoNcjby8Fl8rAt/Rj83KuNuFnY0Yb4Dc7c34uzXH8AnsoPzHE9LfxBs8Yc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 01, 2023 at 05:55:44PM +0900, Sergey Senozhatsky wrote: > On (23/02/28 14:53), Minchan Kim wrote: > > BTW, I still prefer the enum instead of 10 define. > > > > enum fullness_group { > > ZS_EMPTY, > > ZS_INUSE_RATIO_MIN, > > ZS_INUSE_RATIO_ALMOST_FULL = 7, > > ZS_INUSE_RATIO_MAX = 10, > > ZS_FULL, > > NR_ZS_FULLNESS, > > } > > For educational purposes, may I ask what do enums give us? We > always use integers - int:4 in zspage fullness, int for arrays > offsets and we cast to plain integers in get/set stats. So those > enums exist only at declaration point, and plain int otherwise. > What are the benefits over #defines? Well, I just didn't like the 12 hard coded define *list* values and never used other places except zs_stats_size_show since I thought we could handle zs_stats_size_show in the loop without the specific each ratio definary. Furthermore, above example, the special ZS_INUSE_RATIO_MAX will be definary instead of hard coded 10. ZS_INUSE_RATIO_MAX = ZS_INUSE_RATIO_MIN + ZS_INUSER_RATIO_CLASS_SIZE so, if we want to change the ratio later, we would need minimal changes all the places instead of changing all the hard codeded definary.