* [PATCH] kfence: fix typo in test
@ 2020-12-15 23:31 Marco Elver
2020-12-15 23:43 ` Marco Elver
0 siblings, 1 reply; 3+ messages in thread
From: Marco Elver @ 2020-12-15 23:31 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild-all, Linux Memory Management List, Alexander Potapenko,
Dmitry Vyukov, Jann Horn, kernel test robot, kasan-dev,
linux-kernel
Fix a typo/accidental copy-paste that resulted in the obviously
incorrect 'GFP_KERNEL * 2' expression.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Marco Elver <elver@google.com>
---
mm/kfence/kfence_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
index 1433a35a1644..f57c61c833e6 100644
--- a/mm/kfence/kfence_test.c
+++ b/mm/kfence/kfence_test.c
@@ -665,7 +665,7 @@ static void test_krealloc(struct kunit *test)
for (; i < size * 3; i++) /* Fill to extra bytes. */
buf[i] = i + 1;
- buf = krealloc(buf, size * 2, GFP_KERNEL * 2); /* Shrink. */
+ buf = krealloc(buf, size * 2, GFP_KERNEL); /* Shrink. */
KUNIT_EXPECT_GE(test, ksize(buf), size * 2);
for (i = 0; i < size * 2; i++)
KUNIT_EXPECT_EQ(test, buf[i], (char)(i + 1));
--
2.29.2.684.gfbc64c5ab5-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kfence: fix typo in test
2020-12-15 23:31 [PATCH] kfence: fix typo in test Marco Elver
@ 2020-12-15 23:43 ` Marco Elver
2020-12-17 15:57 ` Alexander Potapenko
0 siblings, 1 reply; 3+ messages in thread
From: Marco Elver @ 2020-12-15 23:43 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild-all, Linux Memory Management List, Alexander Potapenko,
Dmitry Vyukov, Jann Horn, kernel test robot, kasan-dev, LKML
On Wed, 16 Dec 2020 at 00:31, Marco Elver <elver@google.com> wrote:
> Fix a typo/accidental copy-paste that resulted in the obviously
> incorrect 'GFP_KERNEL * 2' expression.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marco Elver <elver@google.com>
> ---
> mm/kfence/kfence_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
> index 1433a35a1644..f57c61c833e6 100644
> --- a/mm/kfence/kfence_test.c
> +++ b/mm/kfence/kfence_test.c
> @@ -665,7 +665,7 @@ static void test_krealloc(struct kunit *test)
> for (; i < size * 3; i++) /* Fill to extra bytes. */
> buf[i] = i + 1;
>
> - buf = krealloc(buf, size * 2, GFP_KERNEL * 2); /* Shrink. */
> + buf = krealloc(buf, size * 2, GFP_KERNEL); /* Shrink. */
> KUNIT_EXPECT_GE(test, ksize(buf), size * 2);
> for (i = 0; i < size * 2; i++)
> KUNIT_EXPECT_EQ(test, buf[i], (char)(i + 1));
> --
> 2.29.2.684.gfbc64c5ab5-goog
>
This patch could, if appropriate, be squashed into "kfence: add test suite".
Thanks,
-- Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kfence: fix typo in test
2020-12-15 23:43 ` Marco Elver
@ 2020-12-17 15:57 ` Alexander Potapenko
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Potapenko @ 2020-12-17 15:57 UTC (permalink / raw)
To: Marco Elver
Cc: Andrew Morton, kbuild-all, Linux Memory Management List,
Dmitry Vyukov, Jann Horn, kernel test robot, kasan-dev, LKML
On Wed, Dec 16, 2020 at 12:44 AM Marco Elver <elver@google.com> wrote:
>
> On Wed, 16 Dec 2020 at 00:31, Marco Elver <elver@google.com> wrote:
> > Fix a typo/accidental copy-paste that resulted in the obviously
> > incorrect 'GFP_KERNEL * 2' expression.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Marco Elver <elver@google.com>
Acked-by: Alexander Potapenko <glider@google.com>
> > ---
> > mm/kfence/kfence_test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
> > index 1433a35a1644..f57c61c833e6 100644
> > --- a/mm/kfence/kfence_test.c
> > +++ b/mm/kfence/kfence_test.c
> > @@ -665,7 +665,7 @@ static void test_krealloc(struct kunit *test)
> > for (; i < size * 3; i++) /* Fill to extra bytes. */
> > buf[i] = i + 1;
> >
> > - buf = krealloc(buf, size * 2, GFP_KERNEL * 2); /* Shrink. */
> > + buf = krealloc(buf, size * 2, GFP_KERNEL); /* Shrink. */
> > KUNIT_EXPECT_GE(test, ksize(buf), size * 2);
> > for (i = 0; i < size * 2; i++)
> > KUNIT_EXPECT_EQ(test, buf[i], (char)(i + 1));
> > --
> > 2.29.2.684.gfbc64c5ab5-goog
> >
>
> This patch could, if appropriate, be squashed into "kfence: add test suite".
>
> Thanks,
> -- Marco
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-17 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 23:31 [PATCH] kfence: fix typo in test Marco Elver
2020-12-15 23:43 ` Marco Elver
2020-12-17 15:57 ` Alexander Potapenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox