From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E381C433FE for ; Fri, 11 Dec 2020 13:43:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0C6823E26 for ; Fri, 11 Dec 2020 13:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0C6823E26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00F4B6B0036; Fri, 11 Dec 2020 08:43:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F02386B005D; Fri, 11 Dec 2020 08:43:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3066B0068; Fri, 11 Dec 2020 08:43:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id C4B5A6B0036 for ; Fri, 11 Dec 2020 08:43:42 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 899CD181AC9BF for ; Fri, 11 Dec 2020 13:43:42 +0000 (UTC) X-FDA: 77581119084.29.dime98_4f0a63727401 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 6392518085CE7 for ; Fri, 11 Dec 2020 13:43:42 +0000 (UTC) X-HE-Tag: dime98_4f0a63727401 X-Filterd-Recvd-Size: 4442 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 13:43:41 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id 91so9072756wrj.7 for ; Fri, 11 Dec 2020 05:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PuVM1PLYiwpp0lLPJd/iWAVvKsSsyjEYjPBnVrj9k0U=; b=wMD6kVpytcLH++f6sDjmXRdlTO8XSZw+X4pXOHG1KprjYYrcjEVEq64tHhrSvccplB BHDoRr7GLCauDzQzPbA8oxoc7SwsgdqFeKL2z90AQ0tHWzLOMhK1qqDhMvFjuzUGBEA1 f0o3OJ3aLLX//U+Qlznt1BqDdTgSdG1h+3slE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PuVM1PLYiwpp0lLPJd/iWAVvKsSsyjEYjPBnVrj9k0U=; b=L7hRlAxAEobC/84OFOiPICkRKb/yaBcRbyD+bdYwm5/0xirad+o+L1exQFF4HqvyQ7 RVOFVAXRb7+SsVJFDXm766HBDMq6coVVlf4VwbkpuSOIO0WMsKFcEtSkpyUcNygtqxUZ lI8b9SNHSkZHi2KSgQNMd5ugn5cZYmYeEp3w05Xfq7LvmZ1gLfYc4k5m8YYx+DBzYXrr 9KriN3uhjcZph15KcZUkTT6Fn9qtWiz0K4hO+m7qGKouJZGT+hqGlRDQ8vcs6lmgcD54 CDu7fJjBOc7uKS4nXeRDPyVau69SqEBilNi89IJxmH8usynwFMF0diKrM2TEIrzHff9G kNUw== X-Gm-Message-State: AOAM5318GuNc6KyxGvkRvVkayNvPcqxRi0gPsnAFEgGbXzjl7bQeKy44 kuSpQ7pPpfJj8VljaUn0z6bl2g== X-Google-Smtp-Source: ABdhPJzaF0Q/PL60zEr7ojj8DmyjE9UbD9tmjKkEpN7TWlOGZh1ZW3syyfIZNJb3wPTH5bpcN0AQ4g== X-Received: by 2002:adf:a551:: with SMTP id j17mr13894617wrb.217.1607694220431; Fri, 11 Dec 2020 05:43:40 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:fa59:71ff:fe7e:8d21]) by smtp.gmail.com with ESMTPSA id r13sm14435415wrs.6.2020.12.11.05.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 05:43:40 -0800 (PST) Date: Fri, 11 Dec 2020 13:43:39 +0000 From: Chris Down To: Andrew Morton Cc: Kuan-Ying Lee , "qiang.zhang@windriver.com" , "sfr@canb.auug.org.au" , "aryabinin@virtuozzo.com" , "dvyukov@google.com" , "andreyknvl@google.com" , "qcai@redhat.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , walter-zh.wu@mediatek.com Subject: Re: [PATCH] kasan: fix slab double free when cpu-hotplug Message-ID: References: <20201204102206.20237-1-qiang.zhang@windriver.com> <1607083295.22062.15.camel@mtksdccf07> <20201204172521.ed9f77164ff9f9fc91f35ee0@linux-foundation.org> <1607185035.22062.42.camel@mtksdccf07> <20201205170914.e380173074b2deded2ade3d3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20201205170914.e380173074b2deded2ade3d3@linux-foundation.org> User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi folks, Andrew Morton writes: >@@ -188,6 +190,10 @@ void quarantine_put(struct kasan_free_me > local_irq_save(flags); > > q =3D this_cpu_ptr(&cpu_quarantine); >+ if (q->offline) { >+ local_irq_restore(flags); >+ return; >+ } > qlist_put(q, &info->quarantine_link, cache->size); > if (unlikely(q->bytes > QUARANTINE_PERCPU_SIZE)) { > qlist_move_all(q, &temp); I'm afraid as well as the issues already identified, this also fails, bec= ause=20 `quarantine_put` now returns a bool after "kasan: sanitize objects when=20 metadata doesn't fit": mm/kasan/quarantine.c: In function =E2=80=98quarantine_put=E2=80=99: mm/kasan/quarantine.c:198:3: error: =E2=80=98return=E2=80=99 with no= value, in function returning non-void [-Werror=3Dreturn-type] 198 | return; | ^~~~~~ mm/kasan/quarantine.c:171:6: note: declared here 171 | bool quarantine_put(struct kmem_cache *cache, void *object)