From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEBAC4361B for ; Sat, 19 Dec 2020 01:14:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A16623BAB for ; Sat, 19 Dec 2020 01:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A16623BAB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 180656B005D; Fri, 18 Dec 2020 20:14:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12F8F6B0068; Fri, 18 Dec 2020 20:14:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 045D26B006C; Fri, 18 Dec 2020 20:14:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id E3BD86B005D for ; Fri, 18 Dec 2020 20:14:15 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A72702C96 for ; Sat, 19 Dec 2020 01:14:15 +0000 (UTC) X-FDA: 77608260870.07.metal49_1b0552827442 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 8A2F31814C6F8 for ; Sat, 19 Dec 2020 01:14:15 +0000 (UTC) X-HE-Tag: metal49_1b0552827442 X-Filterd-Recvd-Size: 4421 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Dec 2020 01:14:15 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id g185so4859984wmf.3 for ; Fri, 18 Dec 2020 17:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T+7JO0fqvcm6+5h6bSjGVXPOl7TTInjazBn29GTHmuk=; b=PtYstPEcHbOH1D+AC+YNjrhayBDoEFg2wBXdT6w0owWFEdICREjoN4AkyFaXIorQvO OT48L87fw5U+5Ir6+I6UT+PaSmkpzblcIiyFe36YgzZbcB4bod+vkE8xiZAUFNrW9PYH qBHY4WNARj0NYE+oAjEEbq457k99+ErpJjX0Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T+7JO0fqvcm6+5h6bSjGVXPOl7TTInjazBn29GTHmuk=; b=asN6xRz8WzgrPpW0PTe6qYrcEmw0TFSyX9tu9Ca5RJONce1asokk9M8jPWaMc26MMA hQ4CuoXCiPHi27PAoO/rh38m8Aw8mNA/RfF9ybVaHWPumSPayc6hvI1j81nTgHYV44WH tXq2SJuIjxtfLplTgjNKoiTiNi5bJGote6IhPVnwEw7xtVNqirI1f0OdRo9EmVlRI2r4 7ymvoAX3/VsGYuSj1Phb31NHycwDYZRPVXD69/XnKmG1+xTXqQQzhOogrnP7Vde4So/P l2H1U0Heu9domg9/WXpDw6ZtbKygVULdSU57LxEEygvHr1k0isa8Sq3UF3wnQD7fjcdg 3JCw== X-Gm-Message-State: AOAM533Av6I/wXUV/joltyvqw2xuCW18SG74Hc95aeFV73p7vJyYFwFp feX25LZXsHlYD9yiZhZMmLT+HQ== X-Google-Smtp-Source: ABdhPJy6i7VpViZYS+KXUGKdMsO+0KCx/6WAIZ1KyXohMOcDxHBGPU/x//9YH6ABuhtDKY5ta4ZmAg== X-Received: by 2002:a1c:3b44:: with SMTP id i65mr6403245wma.9.1608340453893; Fri, 18 Dec 2020 17:14:13 -0800 (PST) Received: from localhost ([85.255.236.29]) by smtp.gmail.com with ESMTPSA id u26sm13478332wmm.24.2020.12.18.17.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 17:14:13 -0800 (PST) Date: Sat, 19 Dec 2020 01:14:12 +0000 From: Chris Down To: hui yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: reduced code declaration Message-ID: References: <1608287569-4689-1-git-send-email-yanghui.def@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1608287569-4689-1-git-send-email-yanghui.def@gmail.com> User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hui, hui yang writes: >From: YangHui > >make code more formal. > >Signed-off-by: YangHui For future changelogs: please include a concrete description of the problem you're trying to solve. "Formal" is meaningless here. Just to add my agreement with Andrew, in my opinion this makes the code worse rather than better. It increases the scope of scan_target, which seems neutral to negative, and (if merged) would occlude `git blame` unnecessarily. >--- > mm/vmscan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/mm/vmscan.c b/mm/vmscan.c >index 1b8f0e0..1fea0b4 100644 >--- a/mm/vmscan.c >+++ b/mm/vmscan.c >@@ -2425,7 +2425,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) > { > unsigned long nr[NR_LRU_LISTS]; > unsigned long targets[NR_LRU_LISTS]; >- unsigned long nr_to_scan; >+ unsigned long nr_to_scan, scan_target; > enum lru_list lru; > unsigned long nr_reclaimed = 0; > unsigned long nr_to_reclaim = sc->nr_to_reclaim; >@@ -2492,12 +2492,12 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) > break; > > if (nr_file > nr_anon) { >- unsigned long scan_target = targets[LRU_INACTIVE_ANON] + >+ scan_target = targets[LRU_INACTIVE_ANON] + > targets[LRU_ACTIVE_ANON] + 1; > lru = LRU_BASE; > percentage = nr_anon * 100 / scan_target; > } else { >- unsigned long scan_target = targets[LRU_INACTIVE_FILE] + >+ scan_target = targets[LRU_INACTIVE_FILE] + > targets[LRU_ACTIVE_FILE] + 1; > lru = LRU_FILE; > percentage = nr_file * 100 / scan_target; >-- >2.7.4 > >