From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A025FC4361A for ; Sat, 5 Dec 2020 15:32:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 202B723107 for ; Sat, 5 Dec 2020 15:32:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 202B723107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 666006B006C; Sat, 5 Dec 2020 10:32:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F0076B006E; Sat, 5 Dec 2020 10:32:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B5116B0070; Sat, 5 Dec 2020 10:32:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 3260B6B006C for ; Sat, 5 Dec 2020 10:32:55 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0714D180AD807 for ; Sat, 5 Dec 2020 15:32:55 +0000 (UTC) X-FDA: 77559621510.29.leg31_1c04542273ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id DBDE0180868EB for ; Sat, 5 Dec 2020 15:32:54 +0000 (UTC) X-HE-Tag: leg31_1c04542273ce X-Filterd-Recvd-Size: 3834 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Dec 2020 15:32:54 +0000 (UTC) Date: Sat, 5 Dec 2020 16:32:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607182373; bh=YvwWbwUJz4IsDZPSgrDxX9tu/27SyYUwe/JZizJeblA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=mrTHi9vVfhyA42YnDVcB34yiTLBSymgeakxRNtgMdkIcHq3gM4SpZeohUcBjJiiOC KYpF6+h2Vsl0LLBEgyxzmUbbwQbICwRpvxibvUcVhMLAhJubFkIl+6gGZd9aI6V0/d UO6pX0KDAvixCm+HGsq2/Ixiff3DUqAKIhXVvLlo= From: Greg KH To: Muchun Song Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages Message-ID: References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > Converrt NR_FILE_THPS account to pages. > > > > > > Signed-off-by: Muchun Song > > > --- > > > drivers/base/node.c | 3 +-- > > > fs/proc/meminfo.c | 2 +- > > > mm/filemap.c | 2 +- > > > mm/huge_memory.c | 3 ++- > > > mm/khugepaged.c | 2 +- > > > mm/memcontrol.c | 5 ++--- > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > --- a/drivers/base/node.c > > > +++ b/drivers/base/node.c > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > HPAGE_PMD_NR), > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > HPAGE_PMD_NR), > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > - HPAGE_PMD_NR), > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > Again, is this changing a user-visable value? > > > > Of course not. > > In the previous, the NR_FILE_THPS account is like below: > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > With this patch, it is: > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > So the result is not changed from the view of user space. So you "broke" it on the previous patch and "fixed" it on this one? Why not just do it all in one patch? Confused, greg k-h