From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7997EC56202 for ; Wed, 25 Nov 2020 20:19:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB479207BB for ; Wed, 25 Nov 2020 20:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dhUspYM1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB479207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D63CC6B005D; Wed, 25 Nov 2020 15:19:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D14C66B0070; Wed, 25 Nov 2020 15:19:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDBEB6B0071; Wed, 25 Nov 2020 15:19:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id A76916B005D for ; Wed, 25 Nov 2020 15:19:35 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 64B8D363B for ; Wed, 25 Nov 2020 20:19:35 +0000 (UTC) X-FDA: 77524055910.20.stamp18_1a0289227379 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 3AB63180C07AF for ; Wed, 25 Nov 2020 20:19:35 +0000 (UTC) X-HE-Tag: stamp18_1a0289227379 X-Filterd-Recvd-Size: 4309 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 20:19:34 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id b144so5874857qkc.13 for ; Wed, 25 Nov 2020 12:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wTpG1f7I5Mn7omq14ZEE1b1D1RGafIOA8Nh3enwy9Pw=; b=dhUspYM1wMwx4g0p349xFh+cvmkFpUHO1fMAZy5dL/oqd7kSU1ym0YtWGCwe2K5BNw aVwhhCckrBdx67CbATI/FFwUOrbyBQxEavleHAqEAzxG3D9N0conr/HIspxr9fzB6SfX i43+lRwnKCGUgJA9cRAA9Ia9ro51DDhqCV8/s5EXlHTEJAjPYAn71BuXgNVEaOWGHhM5 mSZeoeXij9s0EAWe8DhLGkPD+d8qJ0w9uk4zhr+1KpPzvTLi317obMTNtjWvqw22AAjn KI0qVXs/lejTVRHvWB2yfTW87bz2pPoM76U/jKdBe6vlpVASMEZRlI5rvHT10TKYbrfB 7MEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=wTpG1f7I5Mn7omq14ZEE1b1D1RGafIOA8Nh3enwy9Pw=; b=HJ3KGy6c/HEqjPgONtysKK2R9yE+7wRs5TndoGA9X7t9rKzs1+8Zo52ljEX9rkat8V i7QSp4S3mh2xd9L45NkW/IdOmCvvNau+3rcr7NTqQDT/HxiwMw/7cVHHuPu5YYA3dfUo LVVKSBYu6Xp8cNKa8z1/k2x0ekqfR8UrkZYchbbHVwuFlhLwMAeBReInmwXzHzTZS8ea Oj+Aq52tgn5JDnfqw5MoCQvmj5NK7VhLCxDrzxy4gfnJX29oy/+DongCl/WugnGXzPFL TNJO7QuWkHIFOUytZsKLHTD1s7oXzqc2Zf3nrTEZNlvHMpi5yyXIivr0WcApwZI706xJ L1ow== X-Gm-Message-State: AOAM532TpZkTE3LaGIIwQFW0ONn/WafLJsrFXrvzZUoM9vG4O1vjmdWn VE+pAn9tjdgWojtod5CW9HE= X-Google-Smtp-Source: ABdhPJzv1jmYfISttH52Qv7X3ML12jiaN/y3FPvYZps3l/Q0JJ9ycbQ/3m35eYW3aCrzEXDwhiCBYw== X-Received: by 2002:a37:4796:: with SMTP id u144mr656941qka.235.1606335573858; Wed, 25 Nov 2020 12:19:33 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id w54sm446145qtb.0.2020.11.25.12.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 12:19:33 -0800 (PST) Date: Wed, 25 Nov 2020 15:19:10 -0500 From: Tejun Heo To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 23/45] block: remove i_bdev Message-ID: References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-24-hch@lst.de> <20201125162926.GA1024@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201125162926.GA1024@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Nov 25, 2020 at 05:29:26PM +0100, Christoph Hellwig wrote: > > I was wondering whether losing the stale bdev flushing in bd_acquire() would > > cause user-visible behavior changes but can't see how it would given that > > userland has no way of holding onto a specific instance of block inode. > > Maybe it's something worth mentioning in the commit message? > > With stale bdev flushing do you mean the call to bd_forget if > i_bdev exists but is unhashed? It doesn't actually flush anything but Yeah. > just detaches the old bdev from the inode so that the new one can be > attached. That problem goes away by definition if we don't attach > the bdev to the inode. Yeah, I think so. Was just wondering whether the problem actually goes away. Thanks. -- tejun