From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0692C56202 for ; Tue, 24 Nov 2020 21:21:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E3D020866 for ; Tue, 24 Nov 2020 21:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JkzooPxJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E3D020866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF13D6B0070; Tue, 24 Nov 2020 16:21:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC8776B0072; Tue, 24 Nov 2020 16:21:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6A726B0073; Tue, 24 Nov 2020 16:21:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 9E0946B0070 for ; Tue, 24 Nov 2020 16:21:20 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 663D58249980 for ; Tue, 24 Nov 2020 21:21:20 +0000 (UTC) X-FDA: 77520582720.25.war21_3c12e9627371 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 35EC21804E3A1 for ; Tue, 24 Nov 2020 21:21:20 +0000 (UTC) X-HE-Tag: war21_3c12e9627371 X-Filterd-Recvd-Size: 3791 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 21:21:19 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id v143so570202qkb.2 for ; Tue, 24 Nov 2020 13:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7Y3MLcmrdxWQffIhMnyKnSmG7B3ov7cDZAqFDsa+q7k=; b=JkzooPxJ8GeNrayRsu98YvwsNpW2uc9rVRoj4imwYpA6JzY+Piu1EJS2IziPBdeDkF Ow5qmzMcHaeZs2+oG1fSVsEAssWG0DO4F1vW/5P9q+2+DEbGyYUH1jozKg00Go0h3+ja YVkgi/EGLciFHd/Iul8YpgRz7FCu1kfvXaFXbSFsbyZTqz8JAJ48o8dWwKmdI5uElByj 9UjvAnbnEBhxu3Tw7tEroOvSCxNENuu6nvEC1MTUGX0lcXIIF4ARzithi6KpCvnT/fAl Mp0ipaM81mRq+veWggOWfzfqSyIb3Y60deO3bam/RyYuBfYbgPa2E9CAR1VR8pj1MpV8 kFEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=7Y3MLcmrdxWQffIhMnyKnSmG7B3ov7cDZAqFDsa+q7k=; b=Veo4zjoKooawJFt13QXi3Kwnv1PPMwrnlToVpTW2sb5NRTbxSQBKKrInNw4XJs2ad1 JWKWIFtfyYYFMR3bgreETQNrVj1FARlPkXs/vDFuDEO5tGbz8BFLfEHfodRrKKbyBn7E P2rt94GzVjfJaXMOklMirNqDUdZMD6e4nn1sScj20zzw/NkQu+PtS8hNBJm2z4z2+hdT YGighAqpnGpIEs/ZPE6qfMBET1QG7vUeSX8p3G02JyGSMUWONNoNS+65sArVgpGRo1EZ 870gu1qg8aPBr5ZienVEs1iY1v3U5Om1J4o6/ti9tYOXRFugopulMMHjUAtLA+KUkVEz W6Nw== X-Gm-Message-State: AOAM533dxfbGjrDuRqwew4Y+sMRnXDqY23Ili+X1k2l9UB08xMoZligx kg9Ct5swumyzbIC6eIC5szE= X-Google-Smtp-Source: ABdhPJx26oBT8NwtvheSnoKT8jLyoQC45bZaDNVCxy9rquKXHNVFfdT0K9nlXQGVBdDZtOMR/OxmVA== X-Received: by 2002:a37:9ed3:: with SMTP id h202mr199931qke.126.1606252879118; Tue, 24 Nov 2020 13:21:19 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id y44sm292925qtb.50.2020.11.24.13.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 13:21:18 -0800 (PST) Date: Tue, 24 Nov 2020 16:20:56 -0500 From: Tejun Heo To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 29/45] block: initialize struct block_device in bdev_alloc Message-ID: References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-30-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124132751.3747337-30-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 24, 2020 at 02:27:35PM +0100, Christoph Hellwig wrote: > Don't play tricks with slab constructors as bdev structures tends to not > get reused very much, and this makes the code a lot less error prone. > > Signed-off-by: Christoph Hellwig Acked-by: Tejun Heo -- tejun