From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C02C433E0 for ; Mon, 4 Jan 2021 09:58:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B967D2072E for ; Mon, 4 Jan 2021 09:57:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B967D2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C7C4F6B0099; Mon, 4 Jan 2021 04:57:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2CA76B009A; Mon, 4 Jan 2021 04:57:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1AE06B009C; Mon, 4 Jan 2021 04:57:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 9B92A6B0099 for ; Mon, 4 Jan 2021 04:57:58 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5D075824805A for ; Mon, 4 Jan 2021 09:57:58 +0000 (UTC) X-FDA: 77667641436.03.hands20_1216b5d274cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 413FF28A4E9 for ; Mon, 4 Jan 2021 09:57:58 +0000 (UTC) X-HE-Tag: hands20_1216b5d274cf X-Filterd-Recvd-Size: 4153 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Jan 2021 09:57:57 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1049soxo141813; Mon, 4 Jan 2021 09:57:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=tUH/XBKDyRDcd9HiEo0UluwVbqboRTkFZkKq1eMaAaY=; b=uCSf9qwkUnD2ROLKzkF6ulpI1+oT4jwBPrAzCtrVMsy7IFnIVLMg6CY5g2c4qDmD4sMv kEDYNLxePOpb1uq8OdwCxJYvWwsAocsPGwZVZ7ImLwl1SQ94Qr5OHXC6gn3/XDbxZBEN O0/+0rpE2bltMgBuBVtLVcujGZbh7djqJQuh5YX2s6CQ4o/t5BADMmyrOyF//cmiWJH3 GBLh5harfipb50DHe+eIal/8/vR22JsPG9JF7jeUl9ZCkfm+R1MMelQEl03KIEXsVTVT lL3yUbddkYgfkkelzQGdxtkJBLpTA29HukZt7bSpqO5aD6suG8dJSIoV1PvMaMA2PcS/ +A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 35tgskkjup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 04 Jan 2021 09:57:56 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1049UHdC146674; Mon, 4 Jan 2021 09:55:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 35uxnqwcqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Jan 2021 09:55:55 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 1049treJ008848; Mon, 4 Jan 2021 09:55:54 GMT Received: from mwanda (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Jan 2021 01:55:52 -0800 Date: Mon, 4 Jan 2021 12:55:36 +0300 From: Dan Carpenter To: osalvador@suse.de Cc: linux-mm@kvack.org Subject: [bug report] mm,hwpoison: refactor get_any_page Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9853 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=801 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101040063 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9853 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 mlxlogscore=811 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101040064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Oscar Salvador, The patch 8295d535e2aa: "mm,hwpoison: refactor get_any_page" from Dec 14, 2020, leads to the following static checker warning: mm/memory-failure.c:1943 soft_offline_page() error: '%pG' must be followed by one of [gpv] mm/memory-failure.c 1933 put_online_mems(); 1934 1935 if (ret > 0) { 1936 ret = soft_offline_in_use_page(page); 1937 } else if (ret == 0) { 1938 if (soft_offline_free_page(page) && try_again) { 1939 try_again = false; 1940 goto retry; 1941 } 1942 } else if (ret == -EIO) { 1943 pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n", ^^^^ Presumably lower case 'p' was intended. "%pGp". See the flags_string() function for more details. 1944 __func__, pfn, page->flags, &page->flags); 1945 } 1946 1947 return ret; 1948 } regards, dan carpenter