From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014D7C433E0 for ; Tue, 12 Jan 2021 13:24:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0D8922EBE for ; Tue, 12 Jan 2021 13:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0D8922EBE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4F3B8D00A5; Tue, 12 Jan 2021 08:24:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFDCF8D0090; Tue, 12 Jan 2021 08:24:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC4788D00A5; Tue, 12 Jan 2021 08:24:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 9D2CD8D0090 for ; Tue, 12 Jan 2021 08:24:33 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 65B953629 for ; Tue, 12 Jan 2021 13:24:33 +0000 (UTC) X-FDA: 77697192426.26.balls10_120a80327515 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 3DCF11804B669 for ; Tue, 12 Jan 2021 13:24:33 +0000 (UTC) X-HE-Tag: balls10_120a80327515 X-Filterd-Recvd-Size: 9913 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 13:24:32 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id c5so2485881wrp.6 for ; Tue, 12 Jan 2021 05:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=910ykGfQR9OTgKA6vCFnMHYhpzuWplH/2cTJtmBp2T4=; b=Ah/l+t33mmwDIGlBMFIZyKuV7qXcm9eDb12vI6vVfsUrYpUJ7a/uEpTRS1f5aK+cO/ 8eTGjuY/8GejCUk9XV0+gzotIvf8wR0G3lKhCLzwFKOPdosHO0Jg3sgDrr8NM9lhj4hZ DSlEwKVk7hsiyQHBm7B7rTp5gH6qDqjI1EK1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=910ykGfQR9OTgKA6vCFnMHYhpzuWplH/2cTJtmBp2T4=; b=gb2KFVx1tjruh8Nj8fk21Tv1gh7bWqcdnc+IEQarJF+5+KYYUD/DvM/EZNXLo2B9oO gvppwG2/LE13sJs/BGLzvsWLEiEZq6JaF58rGv0HF8EIoWpjCBErSg+6XN2L+2IUtkKH JhSeAtf75ktc8nihgtV8tE04/hKYaLVzgg/SW2/4EyMuhKrzbGAhzi5wxOnVZEYrY2Kk 4iJDnNJNocdAKSTsDS2Ngz7V7mxkVsorzndtu9cmz9VbcZkc7bFaeXwFuS9wRT3fYQuq u2x+J1DX7DUTPOjp+1qRBSe0NTMMR1VCb2oPpCATxw/9l3nyDCT6PBn2jsqw8sHR+HC0 rnxQ== X-Gm-Message-State: AOAM533qig6+twkR8vQ0A393hkFt2YmUZhWm9XMspBiriMIxDXMaVtev s4UL56YOWhK1kHsjKtGXStn02w== X-Google-Smtp-Source: ABdhPJwktpfadpAuorK6LF+XqkHpBN5jTG/nc1ar3yG4HE88ZwI4eoXbc58CgFkM+yHvg3W2YwpYrg== X-Received: by 2002:adf:ab5b:: with SMTP id r27mr1161193wrc.282.1610457870643; Tue, 12 Jan 2021 05:24:30 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j2sm5098461wrh.78.2021.01.12.05.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 05:24:29 -0800 (PST) Date: Tue, 12 Jan 2021 14:24:27 +0100 From: Daniel Vetter To: DRI Development , LKML , Stephen Rothwell Cc: linux-samsung-soc@vger.kernel.org, kvm@vger.kernel.org, Daniel Vetter , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v7 00/17] follow_pfn and other iomap races Message-ID: Mail-Followup-To: DRI Development , LKML , Stephen Rothwell , linux-samsung-soc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org References: <20201127164131.2244124-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127164131.2244124-1-daniel.vetter@ffwll.ch> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 27, 2020 at 05:41:14PM +0100, Daniel Vetter wrote: > Hi all > > Another update of my patch series to clamp down a bunch of races and gaps > around follow_pfn and other access to iomem mmaps. Previous version: > > v1: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ > v2: https://lore.kernel.org/dri-devel/20201009075934.3509076-1-daniel.vetter@ffwll.ch > v3: https://lore.kernel.org/dri-devel/20201021085655.1192025-1-daniel.vetter@ffwll.ch/ > v4: https://lore.kernel.org/dri-devel/20201026105818.2585306-1-daniel.vetter@ffwll.ch/ > v5: https://lore.kernel.org/dri-devel/20201030100815.2269-1-daniel.vetter@ffwll.ch/ > v6: https://lore.kernel.org/dri-devel/20201119144146.1045202-1-daniel.vetter@ffwll.ch/ > > And the discussion that sparked this journey: > > https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ > > I think the first 12 patches are ready for landing. The parts starting > with "mm: Add unsafe_follow_pfn" probably need more baking time. > > Andrew, can you please pick these up, or do you prefer I do a topic branch > and send them to Linus directly in the next merge window? > > Changes in v7: > - more acks/reviews > - reordered with the ready pieces at the front > - simplified the new follow_pfn function as Jason suggested > > Changes in v6: > - Tested v4l userptr as Tomasz suggested. No boom observed > - Added RFC for locking down follow_pfn, per discussion with Christoph and > Jason. > - Explain why pup_fast is safe in relevant patches, there was a bit a > confusion when discussing v5. > - Fix up the resource patch, with CONFIG_IO_STRICT_DEVMEM it crashed on > boot due to an unintended change (reported by John) > > Changes in v5: > - Tomasz found some issues in the media patches > - Polish suggested by Christoph for the unsafe_follow_pfn patch > > Changes in v4: > - Drop the s390 patch, that was very stand-alone and now queued up to land > through s390 trees. > - Comment polish per Dan's review. > > Changes in v3: > - Bunch of polish all over, no functional changes aside from one barrier > in the resource code, for consistency. > - A few more r-b tags. > > Changes in v2: > - tons of small polish&fixes all over, thanks to all the reviewers who > spotted issues > - I managed to test at least the generic_access_phys and pci mmap revoke > stuff with a few gdb sessions using our i915 debug tools (hence now also > the drm/i915 patch to properly request all the pci bar regions) > - reworked approach for the pci mmap revoke: Infrastructure moved into > kernel/resource.c, address_space mapping is now set up at open time for > everyone (which required some sysfs changes). Does indeed look a lot > cleaner and a lot less invasive than I feared at first. > > Coments and review on the remaining bits very much welcome, especially > from the kvm and vfio side. > > Cheers, Daniel > > Daniel Vetter (17): > drm/exynos: Stop using frame_vector helpers > drm/exynos: Use FOLL_LONGTERM for g2d cmdlists > misc/habana: Stop using frame_vector helpers > misc/habana: Use FOLL_LONGTERM for userptr > mm/frame-vector: Use FOLL_LONGTERM > media: videobuf2: Move frame_vector into media subsystem > mm: Close race in generic_access_phys > PCI: Obey iomem restrictions for procfs mmap > /dev/mem: Only set filp->f_mapping > resource: Move devmem revoke code to resource framework > sysfs: Support zapping of binary attr mmaps > PCI: Revoke mappings like devmem As Jason suggested, I've pulled the first 1 patches into a topic branch. Stephen, can you please add the below to linux-next for the 5.12 merge window? git://anongit.freedesktop.org/drm/drm topic/iomem-mmap-vs-gup Once this part has landed I'll see what to do with the below part. Thanks, Daniel > mm: Add unsafe_follow_pfn > media/videobuf1|2: Mark follow_pfn usage as unsafe > vfio/type1: Mark follow_pfn as unsafe > kvm: pass kvm argument to follow_pfn callsites > mm: add mmu_notifier argument to follow_pfn > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > arch/powerpc/kvm/e500_mmu_host.c | 2 +- > arch/x86/kvm/mmu/mmu.c | 8 +- > drivers/char/mem.c | 86 +------------- > drivers/gpu/drm/exynos/Kconfig | 1 - > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++---- > drivers/media/common/videobuf2/Kconfig | 1 - > drivers/media/common/videobuf2/Makefile | 1 + > .../media/common/videobuf2}/frame_vector.c | 57 ++++----- > .../media/common/videobuf2/videobuf2-memops.c | 3 +- > drivers/media/platform/omap/Kconfig | 1 - > drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- > drivers/misc/habanalabs/Kconfig | 1 - > drivers/misc/habanalabs/common/habanalabs.h | 6 +- > drivers/misc/habanalabs/common/memory.c | 52 +++----- > drivers/pci/pci-sysfs.c | 4 + > drivers/pci/proc.c | 6 + > drivers/vfio/vfio_iommu_type1.c | 4 +- > fs/sysfs/file.c | 11 ++ > include/linux/ioport.h | 6 +- > include/linux/kvm_host.h | 9 +- > include/linux/mm.h | 50 +------- > include/linux/sysfs.h | 2 + > include/media/frame_vector.h | 47 ++++++++ > include/media/videobuf2-core.h | 1 + > kernel/resource.c | 98 ++++++++++++++- > mm/Kconfig | 3 - > mm/Makefile | 1 - > mm/memory.c | 112 +++++++++++++++--- > mm/nommu.c | 16 ++- > security/Kconfig | 13 ++ > virt/kvm/kvm_main.c | 56 +++++---- > 33 files changed, 413 insertions(+), 299 deletions(-) > rename {mm => drivers/media/common/videobuf2}/frame_vector.c (84%) > create mode 100644 include/media/frame_vector.h > > -- > 2.29.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch