From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDC6C433DB for ; Tue, 12 Jan 2021 13:17:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5429F206A4 for ; Tue, 12 Jan 2021 13:17:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5429F206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91BC58D00A4; Tue, 12 Jan 2021 08:17:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87DE98D0090; Tue, 12 Jan 2021 08:17:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745678D00A4; Tue, 12 Jan 2021 08:17:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 5BD268D0090 for ; Tue, 12 Jan 2021 08:17:43 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 299A7362C for ; Tue, 12 Jan 2021 13:17:43 +0000 (UTC) X-FDA: 77697175206.24.kite27_2813e0627515 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 0BDBD1A4A5 for ; Tue, 12 Jan 2021 13:17:43 +0000 (UTC) X-HE-Tag: kite27_2813e0627515 X-Filterd-Recvd-Size: 8627 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 13:17:42 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id c124so1869470wma.5 for ; Tue, 12 Jan 2021 05:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r2Ei7fyUEnHPknZWOcRP3y5fyGhRG9BocXM6SVWCLZg=; b=HSpqfH3tnCj5BdIf8b8tZRD4P31NkNa078/+bVSugqthwJKAs9DH6s+rloG0HbsH75 bCD2PsidCVgo/A7+sTJMH2NRbUSQbbNUfAe+8qVc9cJ2GeDnXAnHWlDXubWykseo2Lrd eW4oE/lxRyoVSFjmZzaYE264ls0vBhuu8wtwXWS3iriWA0F93Tps3yLvjyfQGXbsuSlM u4nHXbuBVdDL+9e2N8eKkOJcTsIF0HbTozu6hNoZ0WOufrzpD7+za9AZJPgQRfPdJJcf QYbvwYndVQGgVbE5XSN9G2MUYPx98fviCnCNuaAmQmUlZJa/EUEVQ6N+Q14mWB8F0Onb 0CHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r2Ei7fyUEnHPknZWOcRP3y5fyGhRG9BocXM6SVWCLZg=; b=Suf+42QCjT28tdAqki+/nj8kMBEKFsF9EDzhBUKhE+ThlxAfYeYJhMzA4LWBVhGFr4 pWae9971xmei28f1XWAAEIqqPSMFYMFgjF5lL2gdZsuIqoEKKNjIEX77qC+8REoXYg4i O1YRXogucoAzyx9bVKjJ7fqqF/7vxer3m8RnFbk7tOHAMh/FveZB+xYszj6iN6atCATo 0tRD13gKPRPReTtR+J3Qv9bLH8ummaFFETc4EnT30FzC031HC1LWqbe0WJi/j44hZKxR utS0r/xt39EBZ6DAbxWJ3Tdomqb//jRXWp4a+1xNfPtiJgxOqX7h9ozowC8QTuShpdVd JY5w== X-Gm-Message-State: AOAM532ZgPb2VgO+1G81DXJHhx4eZYBtxII0gzDPnV9gurzk2/4N5REC 4EpbtrAvJV1W+xANYMG6VpKZrw== X-Google-Smtp-Source: ABdhPJyooKl17t+b1soLThNa0tuEUVCrKFbR51YfSayR5q56pNQQaP9pJ9JG9hnsgPFgqSjOIhDRww== X-Received: by 2002:a1c:4684:: with SMTP id t126mr3592828wma.165.1610457461081; Tue, 12 Jan 2021 05:17:41 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c20sm3810825wmb.38.2021.01.12.05.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 05:17:40 -0800 (PST) Date: Tue, 12 Jan 2021 14:17:34 +0100 From: Marco Elver To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] kasan: add match-all tag tests Message-ID: References: <0f20f867d747b678604a68173a5f20fb8df9b756.1609871239.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f20f867d747b678604a68173a5f20fb8df9b756.1609871239.git.andreyknvl@google.com> User-Agent: Mutt/2.0.2 (2020-11-20) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 05, 2021 at 07:27PM +0100, Andrey Konovalov wrote: > Add 3 new tests for tag-based KASAN modes: > > 1. Check that match-all pointer tag is not assigned randomly. > 2. Check that 0xff works as a match-all pointer tag. > 3. Check that there are no match-all memory tags. > > Note, that test #3 causes a significant number (255) of KASAN reports > to be printed during execution for the SW_TAGS mode. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I78f1375efafa162b37f3abcb2c5bc2f3955dfd8e > --- > lib/test_kasan.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++ > mm/kasan/kasan.h | 6 ++++ > 2 files changed, 99 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 46e578c8e842..f1eda0bcc780 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -790,6 +791,95 @@ static void vmalloc_oob(struct kunit *test) > vfree(area); > } > > +/* > + * Check that match-all pointer tag is not assigned randomly for > + * tag-based modes. > + */ > +static void match_all_not_assigned(struct kunit *test) > +{ > + char *ptr; > + struct page *pages; > + int i, size, order; > + > + for (i = 0; i < 256; i++) { > + size = get_random_int() % KMALLOC_MAX_SIZE; size appears to be unused? > + ptr = kmalloc(128, GFP_KERNEL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > + KUNIT_EXPECT_NE(test, (u8)get_tag(ptr), (u8)KASAN_TAG_KERNEL); > + kfree(ptr); > + } > + > + for (i = 0; i < 256; i++) { > + order = get_random_int() % 4; > + pages = alloc_pages(GFP_KERNEL, order); > + ptr = page_address(pages); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > + KUNIT_EXPECT_NE(test, (u8)get_tag(ptr), (u8)KASAN_TAG_KERNEL); > + free_pages((unsigned long)ptr, order); > + } > +} > + > +/* Check that 0xff works as a match-all pointer tag for tag-based modes. */ > +static void match_all_ptr_tag(struct kunit *test) > +{ > + char *ptr; > + u8 tag; > + > + if (IS_ENABLED(CONFIG_KASAN_GENERIC)) { > + kunit_info(test, "skipping, CONFIG_KASAN_SW/HW_TAGS required"); > + return; > + } > + > + ptr = kmalloc(128, GFP_KERNEL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > + > + /* Backup the assigned tag. */ > + tag = get_tag(ptr); > + KUNIT_EXPECT_NE(test, tag, (u8)KASAN_TAG_KERNEL); > + > + /* Reset the tag to 0xff.*/ > + ptr = set_tag(ptr, KASAN_TAG_KERNEL); > + > + /* This access shouldn't trigger a KASAN report. */ > + *ptr = 0; > + > + /* Recover the pointer tag and free. */ > + ptr = set_tag(ptr, tag); > + kfree(ptr); > +} > + > +/* Check that there are no match-all memory tags for tag-based modes. */ > +static void match_all_mem_tag(struct kunit *test) > +{ > + char *ptr; > + int tag; > + > + if (IS_ENABLED(CONFIG_KASAN_GENERIC)) { > + kunit_info(test, "skipping, CONFIG_KASAN_SW/HW_TAGS required"); > + return; > + } > + > + ptr = kmalloc(128, GFP_KERNEL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > + KUNIT_EXPECT_NE(test, (u8)get_tag(ptr), (u8)KASAN_TAG_KERNEL); > + > + /* For each possible tag value not matching the pointer tag. */ > + for (tag = KASAN_TAG_MIN; tag <= KASAN_TAG_KERNEL; tag++) { > + if (tag == get_tag(ptr)) > + continue; > + > + /* Mark the first memory granule with the chosen memory tag. */ > + kasan_poison(ptr, KASAN_GRANULE_SIZE, (u8)tag); > + > + /* This access must cause a KASAN report. */ > + KUNIT_EXPECT_KASAN_FAIL(test, *ptr = 0); > + } > + > + /* Recover the memory tag and free. */ > + kasan_poison(ptr, KASAN_GRANULE_SIZE, get_tag(ptr)); > + kfree(ptr); > +} > + > static struct kunit_case kasan_kunit_test_cases[] = { > KUNIT_CASE(kmalloc_oob_right), > KUNIT_CASE(kmalloc_oob_left), > @@ -829,6 +919,9 @@ static struct kunit_case kasan_kunit_test_cases[] = { > KUNIT_CASE(kasan_bitops_tags), > KUNIT_CASE(kmalloc_double_kzfree), > KUNIT_CASE(vmalloc_oob), > + KUNIT_CASE(match_all_not_assigned), > + KUNIT_CASE(match_all_ptr_tag), > + KUNIT_CASE(match_all_mem_tag), > {} > }; > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 3b38baddec47..c3fb9bf241d3 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -36,6 +36,12 @@ extern bool kasan_flag_panic __ro_after_init; > #define KASAN_TAG_INVALID 0xFE /* inaccessible memory tag */ > #define KASAN_TAG_MAX 0xFD /* maximum value for random tags */ > > +#ifdef CONFIG_KASAN_HW_TAGS > +#define KASAN_TAG_MIN 0xF0 /* mimimum value for random tags */ > +#else > +#define KASAN_TAG_MIN 0x00 /* mimimum value for random tags */ > +#endif > + > #ifdef CONFIG_KASAN_GENERIC > #define KASAN_FREE_PAGE 0xFF /* page was freed */ > #define KASAN_PAGE_REDZONE 0xFE /* redzone for kmalloc_large allocations */ > -- > 2.29.2.729.g45daf8777d-goog >