From: Michael Kelley <mhklinux@outlook.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"ardb@kernel.org" <ardb@kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"Lutomirski, Andy" <luto@kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Cui, Dexuan" <decui@microsoft.com>,
"urezki@gmail.com" <urezki@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "Rodel, Jorg" <jroedel@suse.de>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"lstoakes@gmail.com" <lstoakes@gmail.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: RE: [PATCH v3 3/3] x86/hyperv: Make encrypted/decrypted changes safe for load_unaligned_zeropad()
Date: Fri, 12 Jan 2024 03:19:55 +0000 [thread overview]
Message-ID: <SN6PR02MB415728EA80420231DF35BB36D46F2@SN6PR02MB4157.namprd02.prod.outlook.com> (raw)
In-Reply-To: <21f41af44fcc2ce52bdb40c7560fc7c9c0d56ec4.camel@intel.com>
From: Edgecombe, Rick P <rick.p.edgecombe@intel.com> Sent: Thursday, January 11, 2024 4:27 PM
>
> On Fri, 2024-01-05 at 10:30 -0800, mhkelley58@gmail.com wrote:
> > * hv_vtom_set_host_visibility - Set specified memory visible to host.
> > *
> > @@ -521,7 +547,7 @@ static bool hv_vtom_set_host_visibility(unsigned long kbuffer, int pagecount, bo
> >
> > pfn_array = kmalloc(HV_HYP_PAGE_SIZE, GFP_KERNEL);
> > if (!pfn_array)
> > - return false;
> > + goto err_set_memory_p;
> >
>
> If kmalloc() fails here, and set_memory_p() succeeds below, then
> hv_vtom_set_host_visibility() returns true, but skips all the
> hv_mark_gpa_visibility() work. Shouldn't it return false?
Ooops. Yes. If the kmalloc() fails, need to set "result" to false before
doing the goto. Will fix in the next version.
Michael
prev parent reply other threads:[~2024-01-12 3:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 18:30 [PATCH v3 0/3] x86/hyperv: Mark CoCo VM pages not present when changing encrypted state mhkelley58
2024-01-05 18:30 ` [PATCH v3 1/3] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback mhkelley58
2024-01-08 13:07 ` kirill.shutemov
2024-01-12 1:20 ` Edgecombe, Rick P
2024-01-12 15:07 ` Michael Kelley
2024-01-12 17:17 ` Edgecombe, Rick P
2024-01-12 19:24 ` Michael Kelley
2024-01-15 10:00 ` kirill.shutemov
2024-01-05 18:30 ` [PATCH v3 2/3] x86/mm: Regularize set_memory_p() parameters and make non-static mhkelley58
2024-01-08 13:10 ` kirill.shutemov
2024-01-12 0:56 ` Edgecombe, Rick P
2024-01-05 18:30 ` [PATCH v3 3/3] x86/hyperv: Make encrypted/decrypted changes safe for load_unaligned_zeropad() mhkelley58
2024-01-08 18:37 ` Kuppuswamy Sathyanarayanan
2024-01-08 19:13 ` Michael Kelley
2024-01-08 19:24 ` Kuppuswamy Sathyanarayanan
2024-01-12 0:26 ` Edgecombe, Rick P
2024-01-12 3:19 ` Michael Kelley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB415728EA80420231DF35BB36D46F2@SN6PR02MB4157.namprd02.prod.outlook.com \
--to=mhklinux@outlook.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=urezki@gmail.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox