From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5F5E77188 for ; Tue, 14 Jan 2025 18:24:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE366280017; Tue, 14 Jan 2025 13:24:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C92A228000F; Tue, 14 Jan 2025 13:24:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32CE280017; Tue, 14 Jan 2025 13:24:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9640428000F for ; Tue, 14 Jan 2025 13:24:45 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39682A0BA0 for ; Tue, 14 Jan 2025 18:24:45 +0000 (UTC) X-FDA: 83006883330.24.737AF3A Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2011.outbound.protection.outlook.com [40.92.20.11]) by imf16.hostedemail.com (Postfix) with ESMTP id 65EB1180002 for ; Tue, 14 Jan 2025 18:24:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=rhDk+SPn; dmarc=pass (policy=none) header.from=outlook.com; spf=pass (imf16.hostedemail.com: domain of mhklinux@outlook.com designates 40.92.20.11 as permitted sender) smtp.mailfrom=mhklinux@outlook.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736879082; a=rsa-sha256; cv=pass; b=rW6IGW8jLEhY6Zx9svz5kNh+FamVk8MZntGANeX0z1PyDySlikzT5HtoYFZQqxdqe7KCUU Gv7JG/k8oTfn0qOi1ra2KF/fhLdEezHisde4Mugglo8s857Ys28ieIH6l3IRrw8ImBVMY/ x80XPE4wVS9zFt23n5y9V5CTInUc7co= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=rhDk+SPn; dmarc=pass (policy=none) header.from=outlook.com; spf=pass (imf16.hostedemail.com: domain of mhklinux@outlook.com designates 40.92.20.11 as permitted sender) smtp.mailfrom=mhklinux@outlook.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736879082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZjYD03HtBj2veYzPIxRR3pEhPLJQHZVsuoTmCMFs9wc=; b=oF8/ULrazdGvhp29nyn4FU4ozV1X+qaRTJCmDsgcHVXyXBSU8EOrfLImGqYJztptPcl5VC 1q1zoi5yEf8SveECH8m0X8ibxouLawoIqM5wYmbwg7t8E3mQ2OMIQ6jJHGr8EtWKBjfhe7 mTG3lkr38T+zPqaClS7Dxv8r4g/9fhA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DehHRiSQz/SYGT7UAQc1DBs35tckFzum+7WCchKUnK1tRgZP1+wmQCakxt5TAmaMhEzo34Qt0oX3lCEdZK8o9aLKkxJtvt9ZMNosZzTio09vKqSo+ABGgcNotL2beyYw7j8pJloI6jd+0qH7Zh+wBU1DdU8us4Z8l0o2Yq8lwO5ggIBb9dQSRkn1JyuhveWclj9usmVrFJuWBnWAyS41CqyCKiWaHqwdecXYW3wAPeU6ppF/xyWbXuoD8XaS2+68wp8NbgaT7Udqxu3GY4CLNNSLZh+IYt3uEL+7gLbzlHdT1KAE77RzpuG5W35EiJ59GPcW/DVRe8ODe3cS/0y1zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZjYD03HtBj2veYzPIxRR3pEhPLJQHZVsuoTmCMFs9wc=; b=q3YVt7g9Hc7278drTvmV8w+1ns529gUj8HYqrjnyIwMH+5opHpWW2O622Uh6k31hB3HrEPvzqDsMyTtItrb6JrEiBYHNUnQ2wQGyUEKQVKLW/Ezi1DaBv7b0ru7hxx1AAxjxDGimhez1MJQNJ8zzksXgO6HvOomSXfQGUE3iOcfSv4ItW30oTMItmiQdfyF9KzTCsesaozNInqKn17DEuTSz+9+23zBfcDZ/6mOnvgTVvAHVXU/6RTlkWIie3tKMNuILbcMCrTI0z9CQ3qkmj64E07pNFJz70uRSaFLAgZrGzNyzS4cVoY45geUbKUPQW3unTklyGP4ftyG5fD61GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZjYD03HtBj2veYzPIxRR3pEhPLJQHZVsuoTmCMFs9wc=; b=rhDk+SPn9yLKCp5DeZseN3oeGMFkRFxG11kdInU9UeEhTs50sBBvlt2/smKQkR+S9E1vWJFVLmZSRUrkG1tt0F+ml/gzSC//AOj1hEv/6Dzn2iFOpVWSNGVdDfF3wHap3xUnJSavV+Vda1V7vS2cLkcAwHZlersCOpZtU3Qmm+rrFFhtf0tvEE3bLOu5jT4CqVbBaZRkKeAL6shuZFzdOUlumv5pQgyG5Eyjf5Ea/lfw9QgC4xodlPH7qxYHdXHCmaDblW7X9WdaNa1c5effD87O58faUP9suPSqfRcm9/ph7oXqS+kKz1GgiF9Y41bblGqljCzlxEV8VuqmPkVSaA== Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by SJ2PR02MB9366.namprd02.prod.outlook.com (2603:10b6:a03:4c2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 18:24:38 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::cedd:1e64:8f61:b9df]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::cedd:1e64:8f61:b9df%4]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 18:24:38 +0000 From: Michael Kelley To: "riel@surriel.com" , "x86@kernel.org" CC: "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "peterz@infradead.org" , "dave.hansen@linux.intel.com" , "zhengqi.arch@bytedance.com" , "nadav.amit@gmail.com" , "thomas.lendacky@amd.com" , "kernel-team@meta.com" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "jannh@google.com" Subject: RE: [PATCH v4 05/12] x86/mm: add INVLPGB support code Thread-Topic: [PATCH v4 05/12] x86/mm: add INVLPGB support code Thread-Index: AQHbZQqc4R3QocV35kqcNG4lStLHlbMWln3A Date: Tue, 14 Jan 2025 18:24:38 +0000 Message-ID: References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-6-riel@surriel.com> In-Reply-To: <20250112155453.1104139-6-riel@surriel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|SJ2PR02MB9366:EE_ x-ms-office365-filtering-correlation-id: a3d628a0-822d-4ade-107e-08dd34c8b4da x-microsoft-antispam: BCL:0;ARA:14566002|8062599003|8060799006|15080799006|461199028|19110799003|10035399004|4302099013|3412199025|440099028|102099032|1602099012; x-microsoft-antispam-message-info: =?us-ascii?Q?tzmrw7TV2G0jsr1mD1tyHoykXVObPG2ITvUSjwvgOt7ppghhfyiPSSJdztY4?= =?us-ascii?Q?PXqhYHNJ+sw00R/rbATFaEO3Vt40OUoV+Hz/fq1YC7InnLeT7abZnMsNzOMI?= =?us-ascii?Q?JIhXl0B6kl7Nf0nflzJhjEnLKKST5r31Ddv3qpOup4NWzsX+oXWZiEzECwxI?= =?us-ascii?Q?v9oM0kRpPxSa1+ILIgbU+DCZI/neeN6sjHTY4tMQoRBDJtJxvpYuhRKz8c2t?= =?us-ascii?Q?YqyPHQNIbxql1sP7G7Mzr2/JwXWKtDNWKr76mZV2SG0HiNbBfoaaa6KFZ9ct?= =?us-ascii?Q?bNSJhQFMPNEksSLvyY315GpKFKNivI4JDjR7HyYcAHzHFy+89nYxhjz9ZRwh?= =?us-ascii?Q?b5nDigqAlaWQuwVTorn+sbLt8Wt0loLARA9vRNursVL2agQXWmQPk1cdb9Re?= =?us-ascii?Q?s5IpVsPH4mEwPLIl/1081Gjn1jQD9osXY4AqGlFTEr1e4zlnDqzTlbcEYIEH?= =?us-ascii?Q?h2UNg0lGWSyVMD18mxfk+DZ30giE0WrviaBDHgEvWuF72tYD6k0orSfUcOHr?= =?us-ascii?Q?hqWnsaIgJzsiRqfiv6HGCROBKA3/Z43IcJ2oFUOSd1U+ntVniyiGfNntcC7X?= =?us-ascii?Q?W6D2GfIH6rV1z3FQTH/QHNl4UV3Xu3rgrKGk88HE1H7DpzRLuG9UfQ53/Tlo?= =?us-ascii?Q?s5Q18lr4iAsY1lzDi9xsg69R4OEo1DMSd63ncYY5BpEvzD/n/dZElMHfZTBT?= =?us-ascii?Q?7v3KRWb+u7MoYpW5FXAWJpzYJX5AHBgTU74n5HRKaN4AD4bmE58CP9nQKP+z?= =?us-ascii?Q?gAZ8KhrQ7CfAflWSuRzsXPXupg//3Xtu2LuPNRKh5R4LgZjf42026gV2H003?= =?us-ascii?Q?PIxuqANj7X/FICCwb81UB5sRaJwL912TZSieFUHSzJ+mBXWtNY0t6Qq+4zf7?= =?us-ascii?Q?L/0USKPYjEPsnIQjKbqCOgu3cu19WAlAwrBwM5yLoymSj28yuU7dQRqtW/81?= =?us-ascii?Q?BB6HireQnT6/i9GENx7+U3QYpCcokbXi11vytb/dvY+9xIC9yeM48N/a8aLy?= =?us-ascii?Q?c3BdaBpNcXj0/eYyuXNJNW8+SpygufAzuMxElmX8lcCgn2TwbWPsXXdWWzx8?= =?us-ascii?Q?IrGi8IPjWPiEYnxndQQBy/Fy90bBBPtffkhtXANBCTYc1zDhWt6ITsz+Wtzw?= =?us-ascii?Q?+QiPXOU2tklovAkKb1E9s9Aqtsyzx2i3RkpZQVkepdX8Ph/lZlUopqEyyCtW?= =?us-ascii?Q?ZwBxiZq2taqCaVntMGxChAw8CWjHLSZC4qnOZQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aFeh9//Ajk8sBs+nIZCVZKEmbCh8K5tKLCxOwu+BCxIz+rhntI+9czqYdEbu?= =?us-ascii?Q?xKuvLYbEPGfNK5q7yOxoYzzNoghlnnKgVGDUmN/xwWHMXvamE4vPKdhzs2hm?= =?us-ascii?Q?t17GlQm3TjvC3rqQgVl5NjXkC0QaDJonR7CIFaewQcAwck18oohDm4EpkhoM?= =?us-ascii?Q?sU97Iehi6P93nsK7gnY1FBwxqUiwJHj1/xriN+U71jKJbeBSFF3P0nWBBj49?= =?us-ascii?Q?jLFD54YXrgAqbQBszOMaXVXN92zg8POO9E8i6MwENxwRstcCBUXeFnPpgYTT?= =?us-ascii?Q?hILY5Azri2iqO2AZWfwbIEArgG95HDZxpP3E1SlsrfdNKGfQUa+w/P/0HpnV?= =?us-ascii?Q?8zGUG5oiSgVPhDMn3P8rmxuuAXK657oXaixt22dzyec0uf5C2GX9PCgRmpoM?= =?us-ascii?Q?AF8V3VD5n3v1+h0b2oFwTcgUERln5cx5UB7LuG5V+IJw9KGu9MpIyvp0z/aw?= =?us-ascii?Q?PfkhZKN4QIOfdU8PwSIOrHBOTPZJU+shmCXI1yJ1OPSgyQNDR0JSm7boF385?= =?us-ascii?Q?JjN0AauFBf61SenFtFOp7PlB2+4MZndoqo22NIVNFQ5fuFpljB8/u8JOx3X8?= =?us-ascii?Q?/oUjHeQtzVlgNjrQz0Rv3SFhWaMTnggL4UjMm64hcifho1+9XW5+nVu8/PSi?= =?us-ascii?Q?xJN98Fxcbbp8kMGjnMlKeegRm3JfcjdsPIRgZF4wkvvXFWyj4C5+Omfe5Q1Y?= =?us-ascii?Q?9gWGlwQOP/riMNQLBMTa1KLgOH8jdFQSnk1Byzrvgkh55f4aO5ZLhmb8EVT8?= =?us-ascii?Q?5Bs0/DYe68XZ0mO5LsqqaTu/XKCyFvh8AbxUomsrkoBcrjeGJ/BP7W6KxGSC?= =?us-ascii?Q?Know8k5YaSOhL2eBidcVh1IdUVJ7W+DbT1b4ClsYgGZgeVBrdQYCaP2xly9E?= =?us-ascii?Q?y2m9znSsl5k562EnPyIsugLhzmrWTHhjrWgcbSLzICS5UfHt5C4YSTfV+07G?= =?us-ascii?Q?O2MWWUtmiVkiNuhOd186bvP/R7oKtTa86XArdv99ANN2gu5YRnpuzq41vNjV?= =?us-ascii?Q?XrHdxS2tgaOvMycH6c3vNudrZ/z+sG42AhJJwvHvJOPD81OkchMDGdRjeNbU?= =?us-ascii?Q?j3NsYjwfKXLh8jS9FpyMTuM5JiggDqyk5UWVubnPk5Mzdpa9E05EtIllr3Em?= =?us-ascii?Q?xiBV+Yudju07oPntSvB/AuzxOkKjQtzAit91aTYCc1VSoa+pHfr5EfQ++1MF?= =?us-ascii?Q?PH0RmrIcP7bYeUoHdmiTBqL8FlgppUPwCgPdUWjMYIK5cvqYH2qbhtTHiEM?= =?us-ascii?Q?=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a3d628a0-822d-4ade-107e-08dd34c8b4da X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2025 18:24:38.8512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR02MB9366 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 65EB1180002 X-Stat-Signature: 1cwx41n4d6m3uhhixrpxitk33dooccbo X-Rspam-User: X-HE-Tag: 1736879082-988180 X-HE-Meta: U2FsdGVkX180GxFQQ6Kk0OqwKgIeWE7arC491KTBRJ731qydoqW7HwT5bZc6WrMGSipFC/XPYZl2EwZqTamb52bMsLdDkF4ofVKEqJDau7K9xt1JrCAgskTHsbb5OsPjl5jBGujfWo9rS+xUinotaAnC2bZRCcGEb4F5mmv3rdks3NUDEO7M9aYgAFR/ZIABHyUSFKysXQ0TGOMdue+hSwXR75bjlSwXYLOoxY/8qfDNwTbQsDFAezfBatyfiBjEtSRSXhIb0Kbgjwp8UspwuE7PHoKEt7TbAuxU2Vm7E++G8co5sekNYijh6LLjPzuZDvI0unsmhMAfsg6aj18aiv7Tn8EjfmwwPUWWNzZU5Q0L2szrGc85GkzHFwe4MSfNVKH9iiXanSNwYMgbgzlIgGqf3XdzLjZIQZSob7mJSr/kCLLoaTuIv5CKcTSGd9fCsexeOVU5WbkbwkENJ4UMHENnWIvUDKNhb6+J1nApIG2RJocNWQFPELJJ8f//3lIU6WluUr3mBJq824PVmv4jJNUTwrEOUAR/c3o/n3CY0zhSWAuWeXZKqC7xypPQrswo2yfhRDJ9sJ8rcu6mVPGBMjlnzRoWIK3ayUMnMYzJZv9D66dN/X6LXrGBF9ftuQhkTIxBE9ptXJTlXvvrAzU7/4Yvhepj9hodSXAO1ujRh5w/X9F0VVSajZm+qYAcfVcCP/cLOYVYwHStVC1uPjeKOclRppIN3of5gW0hcodHE6RCZGEE3SW+dEq04FWyz9q4HQ6/2sOD6Lxre4PNe/d4xGjMrSbXAjU7K+v9SAPgsWTyhxyT/TAl4LULmIo7SVWe9fZavQrwTUsR3+iq8mhP9UO0nGOvoeoMKnQM1rgNo+7R1XjrFTYgCkX/mnYpW9/duDukFvSe5SaNuoM+jJQt/VOl0JVty2AmJcDGc4QiHO0jgv2q810g2AoiXXG/ouSatK95v+t4i0Muc3fSVpF xMsk+38k OBVTrnpbF3QgB6D5owek1hXHbMjSvOCAJXT49bVWqrmF0FtAUiwEvSYt45xZIKNIvK3Jr8z85P6jcyVu08bfBtk0bHvPEOzU5MvpPb8mNq5wDMx52bVeTcgzI/htBaMMjO6qzOsZQC2e0dGCKWdjeIt8nWkXSBnt79qOPNy0r0dbrNaGXFA2zEAogk4A8/JFI98KCz0siOZU5rYZrgVIDCvq8g5kOygPZk8WU+sQpmK508jvbUuzCrYPouGwZEpHWGT3AzW74Odss/3elbazhc91IfpyA4dvbAwHWkmOCnhZAfQqitx6kvMdFq7xB0RPZVRCiQF820fAHItn5jZtFvhNd69KAZZAyPOucXtkYuRrsTlkoIooFgQAecFgLML1SxXibynrxegw+cW26anZm+5JmO0tB4+RQIZIdswsLeFdFI2pqZUnLVxsa9Bjgg0xqXt1Hnt+KfYi2qHjExIx8kLi6keDunubjfPHE01KRFRmyJoQbO+r7i9o3QpwHbyGRS9LlcXvV1pv1pTDmbhZlbsDJ53zQXCV9kcR+auuIHTpkLuwDmMbA7NplA2TEOe3pWYRhjip+52ms1MthoSTyv/lf4jl7Jxe3JRLU+MexCZbcxtS99j4z2NGA6OTLohVvR5zSdZgzRRQQOGw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: riel@surriel.com Sent: Sunday, January 12, 2025 7:= 54 AM >=20 > Add invlpgb.h with the helper functions and definitions needed to use > broadcast TLB invalidation on AMD EPYC 3 and newer CPUs. >=20 > Signed-off-by: Rik van Riel > --- > arch/x86/include/asm/invlpgb.h | 95 +++++++++++++++++++++++++++++++++ > arch/x86/include/asm/tlbflush.h | 1 + > 2 files changed, 96 insertions(+) > create mode 100644 arch/x86/include/asm/invlpgb.h >=20 > diff --git a/arch/x86/include/asm/invlpgb.h b/arch/x86/include/asm/invlpg= b.h > new file mode 100644 > index 000000000000..d62e3733a1ab > --- /dev/null > +++ b/arch/x86/include/asm/invlpgb.h > @@ -0,0 +1,95 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_X86_INVLPGB > +#define _ASM_X86_INVLPGB > + > +#include > + > +/* > + * INVLPGB does broadcast TLB invalidation across all the CPUs in the sy= stem. > + * > + * The INVLPGB instruction is weakly ordered, and a batch of invalidatio= ns can > + * be done in a parallel fashion. > + * > + * TLBSYNC is used to ensure that pending INVLPGB invalidations initiate= d from > + * this CPU have completed. > + */ > +static inline void __invlpgb(unsigned long asid, unsigned long pcid, uns= igned long addr, > + int extra_count, bool pmd_stride, unsigned long flags) > +{ > + u32 edx =3D (pcid << 16) | asid; > + u32 ecx =3D (pmd_stride << 31); > + u64 rax =3D addr | flags; > + > + /* Protect against negative numbers. */ > + extra_count =3D max(extra_count, 0); > + ecx |=3D extra_count; > + > + asm volatile("invlpgb" : : "a" (rax), "c" (ecx), "d" (edx)); The above needs to be: asm volatile(".byte 0x0f, 0x01, 0xfe" : : "a" (rax), "c" (ecx), "d" (edx))= ; plus an explanatory comment. As Boris Petkov previously noted[1], the "invlpgb" instruction name require= s binutils version 2.36. But the current Linux kernel minimum binutils versio= n is 2.25 (in scripts/min-tool-version.sh). For example, I'm using binutils 2= .34, and your asm statement doesn't compile. > +} > + > +/* Wait for INVLPGB originated by this CPU to complete. */ > +static inline void tlbsync(void) > +{ > + asm volatile("tlbsync"); Same as above for "tlbsync". Michael [1] https://lore.kernel.org/lkml/20250102124247.GPZ3aJx8JTJa6PcaOW@fat_crat= e.local/