From: "Luck, Tony" <tony.luck@intel.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Kefeng Wang" <wangkefeng.wang@huawei.com>
Cc: "chu, jane" <jane.chu@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tong Tiangen <tongtiangen@huawei.com>,
Jens Axboe <axboe@kernel.dk>
Subject: RE: [PATCH v2] mm: hwpoison: coredump: support recovery from dump_user_range()
Date: Thu, 27 Apr 2023 16:45:25 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083E48452A7FE8D874F5CF0FC6A9@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230427023045.GA3499768@hori.linux.bs1.fc.nec.co.jp>
> > But in the core dump case there is no return to user. The process is being
> > terminated by the signal that leads to this core dump. So even though you
> > may consider the page being accessed to be a "user" page, you can't fix
> > it by queueing work to run on return to user.
>
> For coredump,the task work will be called too, see following code,
>
> get_signal
> sig_kernel_coredump
> elf_core_dump
> dump_user_range
> _copy_from_iter // with MC-safe copy, return without panic
> do_group_exit(ksig->info.si_signo);
> do_exit
> exit_task_work
> task_work_run
> kill_me_never
> memory_failure
>
Nice. I didn't realize that the exit code path would clear any pending task_work() requests.
But it makes sense that this happens. Thanks for filling a gap in my knowledge.
-Tony
next prev parent reply other threads:[~2023-04-27 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 4:53 Kefeng Wang
[not found] ` <20230418031243.GA2845864@hori.linux.bs1.fc.nec.co.jp>
2023-04-18 9:45 ` Kefeng Wang
2023-04-19 7:25 ` HORIGUCHI NAOYA(堀口 直也)
2023-04-19 12:03 ` Kefeng Wang
2023-04-20 2:03 ` Jane Chu
2023-04-20 2:59 ` Kefeng Wang
2023-04-20 15:05 ` Kefeng Wang
2023-04-21 3:13 ` HORIGUCHI NAOYA(堀口 直也)
2023-04-21 5:43 ` Kefeng Wang
2023-04-24 6:44 ` HORIGUCHI NAOYA(堀口 直也)
2023-04-24 16:17 ` Luck, Tony
2023-04-25 1:47 ` Kefeng Wang
2023-04-25 17:16 ` Luck, Tony
2023-04-26 1:23 ` Kefeng Wang
2023-04-26 15:45 ` Luck, Tony
2023-04-27 1:06 ` Kefeng Wang
2023-04-27 2:31 ` HORIGUCHI NAOYA(堀口 直也)
2023-04-27 16:45 ` Luck, Tony [this message]
2023-04-28 8:59 ` Kefeng Wang
2023-04-28 8:56 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083E48452A7FE8D874F5CF0FC6A9@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jane.chu@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=tglx@linutronix.de \
--cc=tongtiangen@huawei.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox