linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: "chu, jane" <jane.chu@oracle.com>, Borislav Petkov <bp@alien8.de>,
	"djwong@kernel.org" <djwong@kernel.org>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: Is it possible to corrupt disk when writeback page with undetected UE?
Date: Fri, 16 Sep 2022 16:17:19 +0000	[thread overview]
Message-ID: <SJ1PR11MB6083C1CBA41CB53183600B0FFC489@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cec5cd9a-a1de-fbfa-65f9-07336755b6b4@oracle.com>

> Were you using madvise to inject an error to a mmap'ed address?
> or a different tool?  Do you still have the test documented
> somewhere?

I was injecting with ACPI/EINJ (so tweaking some ECC bits in memory to create
a real uncorrectable error). This was a long time back when I was just trying to
get basic recovery from usermode access to poison working reliably. So I just
noted the workaround ("make; sync; run_test") to keep making progress.

Handling poison in the page cache has been on my TODO list for a long time.
Someday it will make it to the top.

> And, aside from verifying every write with a read prior to sync,
> any suggestion to minimize the window of such corruption?

There's no cheap solution. As you point out the best that can be done
is to reduce the window (since bits may get flipped after you perform
your check but before DMS to storage).

-Tony


  parent reply	other threads:[~2022-09-16 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 22:36 Jane Chu
2022-09-15 22:50 ` Luck, Tony
2022-09-16  0:26   ` Jane Chu
2022-09-16  0:30     ` Yang Shi
2022-09-16  0:51       ` Jane Chu
2022-09-16 16:17     ` Luck, Tony [this message]
2022-09-16 19:26       ` Jane Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ1PR11MB6083C1CBA41CB53183600B0FFC489@SJ1PR11MB6083.namprd11.prod.outlook.com \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=djwong@kernel.org \
    --cc=jane.chu@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox