From: "Luck, Tony" <tony.luck@intel.com>
To: "Weiny, Ira" <ira.weiny@intel.com>,
"ankita@nvidia.com" <ankita@nvidia.com>,
"aniketa@nvidia.com" <aniketa@nvidia.com>,
"Sethi, Vikram" <vsethi@nvidia.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"mochs@nvidia.com" <mochs@nvidia.com>,
"skolothumtho@nvidia.com" <skolothumtho@nvidia.com>,
"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"david@redhat.com" <david@redhat.com>,
"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"rppt@kernel.org" <rppt@kernel.org>,
"surenb@google.com" <surenb@google.com>,
"mhocko@suse.com" <mhocko@suse.com>,
"bp@alien8.de" <bp@alien8.de>,
"rafael@kernel.org" <rafael@kernel.org>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"Tian, Kevin" <kevin.tian@intel.com>,
"alex@shazbot.org" <alex@shazbot.org>
Cc: "cjia@nvidia.com" <cjia@nvidia.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"targupta@nvidia.com" <targupta@nvidia.com>,
"zhiw@nvidia.com" <zhiw@nvidia.com>,
"dnigam@nvidia.com" <dnigam@nvidia.com>,
"kjaju@nvidia.com" <kjaju@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"Smita.KoralahalliChannabasappa@amd.com"
<Smita.KoralahalliChannabasappa@amd.com>,
"u.kleine-koenig@baylibre.com" <u.kleine-koenig@baylibre.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [PATCH v3 2/3] mm: Change ghes code to allow poison of non-struct pfn
Date: Tue, 21 Oct 2025 17:19:13 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083BF0885BC19E715C1A96EFCF2A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <68f7bf2d6d591_1668f310061@iweiny-mobl.notmuch>
> > pfn = PHYS_PFN(physical_addr);
> > - if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
>
> Tony,
>
> I'm not an SGX expert but does this break SGX by removing
> arch_is_platform_page()?
>
> See:
>
> 40e0e7843e23 ("x86/sgx: Add infrastructure to identify SGX EPC pages")
> Cc: Tony Luck <tony.luck@intel.com>
>
Ira,
I think this deletion makes the GHES code always call memory_failure()
instead of bailing out here on "bad" page frame numbers.
That centralizes the checks for different types of memory into
memory_failure().
-Tony
next prev parent reply other threads:[~2025-10-21 17:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 10:23 [PATCH v3 0/3] mm: Implement ECC handling for pfn with no struct page ankita
2025-10-21 10:23 ` [PATCH v3 1/3] mm: handle poisoning of pfn without struct pages ankita
2025-10-21 17:05 ` Ira Weiny
2025-10-22 16:00 ` Jiaqi Yan
2025-10-24 6:34 ` Miaohe Lin
2025-10-24 9:45 ` Shuai Xue
2025-10-24 11:52 ` Jason Gunthorpe
2025-10-24 11:59 ` Ankit Agrawal
2025-10-21 10:23 ` [PATCH v3 2/3] mm: Change ghes code to allow poison of non-struct pfn ankita
2025-10-21 17:13 ` Ira Weiny
2025-10-21 17:19 ` Luck, Tony [this message]
2025-10-22 6:53 ` Shuai Xue
2025-10-22 15:03 ` Ira Weiny
2025-10-24 10:03 ` Shuai Xue
2025-10-24 11:26 ` Ankit Agrawal
2025-10-21 10:23 ` [PATCH v3 3/3] vfio/nvgrace-gpu: register device memory for poison handling ankita
2025-10-21 16:30 ` [PATCH v3 0/3] mm: Implement ECC handling for pfn with no struct page Liam R. Howlett
2025-10-21 16:44 ` Jason Gunthorpe
2025-10-21 18:54 ` Liam R. Howlett
2025-10-21 22:38 ` Jason Gunthorpe
2025-10-24 11:16 ` Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083BF0885BC19E715C1A96EFCF2A@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Liam.Howlett@oracle.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex@shazbot.org \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bp@alien8.de \
--cc=cjia@nvidia.com \
--cc=david@redhat.com \
--cc=dnigam@nvidia.com \
--cc=guohanjun@huawei.com \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lenb@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=mochs@nvidia.com \
--cc=nao.horiguchi@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=surenb@google.com \
--cc=targupta@nvidia.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vbabka@suse.cz \
--cc=vsethi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox