From: "Luck, Tony" <tony.luck@intel.com>
To: "chu, jane" <jane.chu@oracle.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
"David Hildenbrand" <david@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Benjamin LaHaise <bcrl@kvack.org>,
"jglisse@redhat.com" <jglisse@redhat.com>,
Zi Yan <ziy@nvidia.com>, Jiaqi Yan <jiaqiyan@google.com>,
Hugh Dickins <hughd@google.com>,
Vishal Moola <vishal.moola@gmail.com>,
Alistair Popple <apopple@nvidia.com>,
Oscar Salvador <osalvador@suse.de>
Subject: RE: [PATCH v3 4/5] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio()
Date: Tue, 28 May 2024 20:30:11 +0000 [thread overview]
Message-ID: <SJ1PR11MB608318DDE821B84CE0DC4F7DFCF12@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <d710c362-895a-4d54-b320-9050525ec313@oracle.com>
>> + if (unlikely(folio_mc_copy(dst, src))) {
>> + folio_ref_unfreeze(src, expected_count);
>> + return -EFAULT;
>>
>> It doesn't look like any code takes action to avoid re-using the poisoned page.
>>
>> So you survived, hurrah! But left the problem page for some other code to trip over.
>
> Tony, did you mean that memory_failure_queue() should be called? If
> not, could you elaborate more?
Maybe memory_failure_queue() can help here. Though it would need to know
which pfn inside the folio hit the poison. So some more infrastructure around the
copy to make sure the pfn is saved.
-Tony
next prev parent reply other threads:[~2024-05-28 20:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 13:45 [PATCH v3 0/5] mm: migrate: support poison recover from migrate folio Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 1/5] mm: add folio_mc_copy() Kefeng Wang
2024-05-28 14:17 ` Lance Yang
2024-05-29 2:16 ` Kefeng Wang
2024-05-28 20:13 ` Jane Chu
2024-05-29 2:16 ` Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 2/5] mm: migrate: split folio_migrate_mapping() Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 3/5] mm: migrate: support poisoned recover from migrate folio Kefeng Wang
2024-05-28 20:15 ` Jane Chu
2024-05-29 2:19 ` Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 4/5] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() Kefeng Wang
2024-05-28 15:41 ` Luck, Tony
2024-05-28 20:19 ` Jane Chu
2024-05-28 20:30 ` Luck, Tony [this message]
2024-05-28 22:02 ` Jane Chu
2024-05-28 22:10 ` Luck, Tony
2024-05-29 2:48 ` Kefeng Wang
2024-05-28 13:45 ` [PATCH v3 5/5] mm: migrate: remove folio_migrate_copy() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB608318DDE821B84CE0DC4F7DFCF12@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bcrl@kvack.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jane.chu@oracle.com \
--cc=jglisse@redhat.com \
--cc=jiaqiyan@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox