From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF77CCF9E7 for ; Wed, 25 Sep 2024 18:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E079E6B00B7; Wed, 25 Sep 2024 14:45:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7336B00B8; Wed, 25 Sep 2024 14:45:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2706B00B9; Wed, 25 Sep 2024 14:45:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9E51A6B00B7 for ; Wed, 25 Sep 2024 14:45:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4A10D140492 for ; Wed, 25 Sep 2024 18:45:41 +0000 (UTC) X-FDA: 82604139282.07.B701F2F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf01.hostedemail.com (Postfix) with ESMTP id 300B640002 for ; Wed, 25 Sep 2024 18:45:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aXUJcLeE; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727289818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qtUVSICq4mZooJxsDpNqo/5Mi7u25/gGrNyU4++5uBw=; b=z6Tht4EMoY/n8ibK8oqHblGTXXj1MGh3LPPwD7K4f3OEvMQbHthckBeGlxyqOGIbyQEM2I mUF520I5eeFGLu9F3oFPyMN2DSM45woTKKEWcPJ1yu7KlTmdyvhSgw3Hm0fQd+vCSU8O0v wB2wOYwlBYv4daJd9tDazKZHwezLq4w= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727289818; a=rsa-sha256; cv=pass; b=ThEMGQoq2kWCdIZ6vnTnzaM9JL7Dh4DAJSFcemwqHZxzgZVHUbQpGYSoqD2DlKo4oATmpc NqOHWf6v+4COCZ76rS2ApBg9Q3DnTkq4OqAjb0iXpcarZ+dwNh8VMAGKLP5/eFKcNoTqmP 4cOeItU7iN5dEp+Uw1jkbcS8F8/BuNI= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aXUJcLeE; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727289937; x=1758825937; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qtUVSICq4mZooJxsDpNqo/5Mi7u25/gGrNyU4++5uBw=; b=aXUJcLeEYQTy3sZLnvTnMBofxFNTV2vAzUHdqewwha+NQbqvOIZwJdrh 7e7cA3BmZHVF5nLJXuTxBYskgc9bq1kLk0HO3yy0bb6qgm48gq44z7fmT eZUIAnw6jJ4jxntrVeyHPSTB/LWENutRN+W0L5MOAtMsHdXGmlop2L1Vb 7YjnZl+5zLQR2O+fEYcID3aAmRr0Zm1txLT/WQia6udHQ0kOX77gzHYTc c3wJVKzdkdDIaFY6hj6Lk5a9LDP7MldctGX0d8wenRx4u02pa3pNa6y6b OTCcTIJWfx3ffAIsHS9zzGkQRE3o8ooU/kTyohRSsrDXNW3DZ62ZVPu+O g==; X-CSE-ConnectionGUID: 8FOUsx7YR4iXkGd9Lw8IJw== X-CSE-MsgGUID: Iab4jdLkQ7Oxiomkz+5uEg== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="36940901" X-IronPort-AV: E=Sophos;i="6.10,258,1719903600"; d="scan'208";a="36940901" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 11:45:29 -0700 X-CSE-ConnectionGUID: Obs5g4WiRvC18MRoHf5Erg== X-CSE-MsgGUID: iU1orUo5Qlu9I+R/J+rFyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,258,1719903600"; d="scan'208";a="71879344" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Sep 2024 11:45:25 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 25 Sep 2024 11:45:24 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 25 Sep 2024 11:45:23 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 25 Sep 2024 11:45:23 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 25 Sep 2024 11:45:23 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 25 Sep 2024 11:45:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sgWhVbqhF6NXx/V6AZ/YtBSP7O7mvHpLrS9LSQbn3tG4EmflxgWL0Drf5YesCb4aZmtsr175vEAUGVDeHvRK5wYxYz9aupGfdp8d90Q7pl7QCHMaf05GPnMxSP5Va2P1BVxPLN3JO5oDDqxVG7BCUqRVde4YYDPEaIa+vJ8Pz76rUcYyMi6v6uav6s4Usbcg9L+vgTV0Fj0H898zAXxz4Q9k/2oXLpTOsb3PFD5Ym6Iq2enrhTNYPPs/0QTa7lfe9LpxddpahSYwrPCf/KCoh2ZhIygGaRSJcdUjazEQsv6zZjCQkJFUZA+nyRwouq+K1Z7vXTc/bwPu3KrJanbMSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtUVSICq4mZooJxsDpNqo/5Mi7u25/gGrNyU4++5uBw=; b=EKS1Juyn6QzWfH0/+ziwdUZJ+FpDGYKLnP9/+PrLX2MMub3HA2Z56a6B99OJaekf/qwjN1JOytEHlpsXXWG1E5guC4DAvdSgL24RyyEhjDMRurWxuL8AR0IkJTxP0OajZ17U8C1lct/qIfPZimgzq5hq5On/sz1FOmdP67BoPf2+Bs9S9qslnYaGI5gIfHotYxcuoa28mjgRxgaorURRbxng4pxNRvF1FUIqSpt1lowTkyOSuLos4dEUxdVp5bqTDB5mcqxOoPVWnf139VQ5F8vqkGkxH7IUsDPVBad+TnvE9KODHQBYtGDxQ8aZZEh3BsjjslteFa4rTAoFCSYDJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by MN0PR11MB5964.namprd11.prod.outlook.com (2603:10b6:208:373::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Wed, 25 Sep 2024 18:45:20 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%4]) with mapi id 15.20.7982.022; Wed, 25 Sep 2024 18:45:20 +0000 From: "Sridhar, Kanchana P" To: Johannes Weiner CC: Yosry Ahmed , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v7 5/8] mm: zswap: Compress and store a specific page in a folio. Thread-Topic: [PATCH v7 5/8] mm: zswap: Compress and store a specific page in a folio. Thread-Index: AQHbDh+BiNTld7AyzkaqOvKNL8+CcrJnU8CAgAAzUCCAACWmgIAACLYggADTBQCAAFDa0A== Date: Wed, 25 Sep 2024 18:45:20 +0000 Message-ID: References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-6-kanchana.p.sridhar@intel.com> <20240925135348.GB875661@cmpxchg.org> In-Reply-To: <20240925135348.GB875661@cmpxchg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|MN0PR11MB5964:EE_ x-ms-office365-filtering-correlation-id: e0d5f96b-dcff-438a-b20e-08dcdd92350d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?TGSeFX43oK/LRY4kenlnI6S9o6/qT2EKav4uQRPcuVuY4UDqqLLm800BywG0?= =?us-ascii?Q?lSMbqNKM+a+h85+j7hft8sTFal/YqZoucANQnImVydhx49Dx+f4BR0POmqoY?= =?us-ascii?Q?qHxaMqD30gWrqPJAYw1ymXVeVk6SvZZzzUNRUDQBqiJp/abtc6mNVb2PrmvE?= =?us-ascii?Q?1AUJC4omQw3WLIxUMWzHr+h3qe4Ja3Wqax19G4sZsODmXyFkYGYzijHPIZVh?= =?us-ascii?Q?vk6x3ABj7OMOBI9QVPllL1V4bNdK9OJ3Zkei6Di5y193xa5MX0M7PxMdgZ9w?= =?us-ascii?Q?AsOe+vKfEnoJdl9F/0yl7XxpLmP6CrTJ4/Hvx/Bp3aXaww7PswpyUwKdtWCw?= =?us-ascii?Q?y4aw7jcoMdkY/NSZg2ahiiaeTUarm6yeGw8uXUwp+2EjkdzHPn1Gauf+IeLE?= =?us-ascii?Q?bgnrqomqxhUWgWNjd6oc+FdmjhysaRp2YM4Ynih+8tJ/mDWd4F4+jS+SFi2j?= =?us-ascii?Q?6wvi8oR6NSkk0fAbo/GEoqhigmrXuXd4DsT6RVpjyCNYceaOT//CUfsVYh9h?= =?us-ascii?Q?bMEu3zjxwxCgNN+tXCx/owrfa8LD2ChjWvAaLSRMxC8UprAL9akvvXI1qvIR?= =?us-ascii?Q?YgOrp+W/KyItKZmxYtTXxpW0xzRYtcryevEFfeE6nsGXW5YE80BrP0146FtK?= =?us-ascii?Q?10c8sMaxdKRv5mWpgquq59OQaODc0fz6oAYbywqc/8k6vHXjmYgtVYfiVwch?= =?us-ascii?Q?AGDddStJqrgsQ2hkEQZbNtyIid4Vg2ZQARovls4EhjiI8d4j0An/37OT4QFS?= =?us-ascii?Q?NEkw/n0c5q89X9UuvT38eSnEDZuT7qG87+rY2C8aWhVmImFuCbYx3fdCi8oW?= =?us-ascii?Q?YgKf8GySs4T7n9QxWjE27/xEyKd7tYuFXyWZDD7KmLlN+GoHvfPtpUBrLl66?= =?us-ascii?Q?g+CgnKcOcOXnxt2niwMlwccgMbNRox3UqZnMqExG0hTn8btZ2YuCReVcFdEb?= =?us-ascii?Q?cavMaLBqbsro5juBrNoj6wW21D1H+5XK2WPEERTbavYm1g6e4I9tomxdhWdU?= =?us-ascii?Q?QsefsGOJB+/YN+PNHW/le+M8MTKlrBiJrpYiDIE8vgK9rrKf898/8VFvz2q9?= =?us-ascii?Q?eYEFIaAUwlDqIE0SUMKrdehc6PvI7VlStcbhm1cTUdNvfTsfM6qg8LH8AU3L?= =?us-ascii?Q?c150QxK6U+FAk479VocbgdQwXgANO4uTKdP0H+iaoy6g0GgvahfNDLtwHq3k?= =?us-ascii?Q?pufm+O36a39QfuqC2f56q9RBN526uuPVn4bIiv5aY7uQq5GHQD7IUaikx/eR?= =?us-ascii?Q?vmn+tsy1n4aNSCjjJk3PLDG5lzMh5Rf5lWxSDBShjK5ljHA/H7tZu2nKfqI1?= =?us-ascii?Q?9m39/K5FEJb5kqTkhK+qjrH4SeNITJoWM5ZZMfHQM2tgGw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oT7PkIurzqpfjXJn9pkJFJgkSVCu1s/GqSxC47nJ/JcDlBQuSMBLY5i1Cc61?= =?us-ascii?Q?q4OmHvGJUIbZ9wqOXw91Yp5UVYnnrIKw9UapTWCl9hBfHK6+jW7Z7Ohf0sFn?= =?us-ascii?Q?XFkYzfE4iuYc0FWqadBSTWNP25bsSy/kuGn87rCFccXw8qh+LRNOX2hYMt2m?= =?us-ascii?Q?FrwyGWo19pWX76vly+eYUlEV9/vMGNe7ltTAIgRQI6f3l2T5YKyWQj8lhRJT?= =?us-ascii?Q?WtpEilqF52E2azXYyWd2CGjnH4BvJkPFxDlMKzqNDQN6LKv2hs8nzvc7sJcY?= =?us-ascii?Q?n/0uXONCq0h2KYoMfP+Taru479d+ttDdTTnRZmjNsA4hNsaQBQasrN8q0r2k?= =?us-ascii?Q?xODdgPIGjAQnMXLjyiE5uxiYpSieVaEQgwM3CL4cU2UwXUlNXRhDAYLaqd8/?= =?us-ascii?Q?XFnjibt8JiOflQknd7VGOskk6o36ZLnUcKMrGtS9cTyoee4S+aTl85hc2eIH?= =?us-ascii?Q?R43dYHXS6Q9IYwgW59pv4fNY+P6OxXly6n9Z9sR9k0UKBkyADF5NYx/Y+dJs?= =?us-ascii?Q?wYIl5X0+oN1CH7/KFnIk7sf8xsE45HHmgXihi2hd2elJw0xErYoN3EFwVcAY?= =?us-ascii?Q?MHsEtltPBVHb++cKnpEXxwBT9Wla56p3ekNglXx9JR0OBrV94hR2DZXsA/Va?= =?us-ascii?Q?QCCN1bCra442tsB9L6gFXOqnufoAt2hFkqxXhMIIOY/EweWC0heHw806cICB?= =?us-ascii?Q?pWJ4X7vkCcItfpagvNp8q/txXdC8y7EIl88g6EeK4JJxcFIyx8feW+YBSoWK?= =?us-ascii?Q?r9vMgW3Rmxr+5Ljg5zb2LfBPsLGwBQMK8vtZdza0c2HMKfOeZpcvwC6pJRd/?= =?us-ascii?Q?a4YJtc3n6p/zrDfQtOQOUxMHkjvcInrh+JJYV8SzSexp4Y0zVukm4MLK6htl?= =?us-ascii?Q?lHHi6DMnNQDf7YBR7xBYoVGv4IWu7rwfT6tNK0MGqNQcTO76ku7V0TZ+9wMq?= =?us-ascii?Q?Nlwi+/uaNYJblEVoulyDQpzlS3j4K2pCO7CzrbudSukvDqDHMHpCoM5dHb5+?= =?us-ascii?Q?PjIFSw8TOPjjGkgXQMbwl5Gt/BFW1VPCc4bLTPWzN78geXwTHzhzgfow+p3I?= =?us-ascii?Q?gD2jjksWKA/mCBtlPwV95g4156kG0/XoatnM4dcgAGa2Y8KmK059fGzeI2pi?= =?us-ascii?Q?sNT2KThVmBKsUwjOvYFM/XLabVrQLrVDg1x8eXYb+Y7e5c49AfaEET+EFeL1?= =?us-ascii?Q?vk/Us47SXXmE2hMOH0GerLeshN18boJAfFL2qBhU5w3n1vd7zXiWwm7ZiVKR?= =?us-ascii?Q?vpccP9T+lOzPSreslAyyIspAK85AXm5U2XXWHDW6fuHPa8GRbF0904dscPJk?= =?us-ascii?Q?c0qYl4SrYtPx80NBkZrDKqiHwdi34T+hoZVfz2+w8CtzOYsSF7zBi6jtDGUT?= =?us-ascii?Q?Tn3OWujYGdxhWCwcA7Pyofb9NUKpEiYXXAGz4QBH6cW9o3yX9yhnyL8ROvDz?= =?us-ascii?Q?DNBbQRhHxai4yiGWmZrBdjYkKRDHAE02Guu7tPO+15jR+WjU5vH74Tfw+cIO?= =?us-ascii?Q?WEv33M7ugteQfgJ8/cC7ztf6viT234vQo3IvKneuNhZ1G4mqMc37+Sz6yAaq?= =?us-ascii?Q?bRegnkwX3kmcoh6KgVpVzMqZcYM9olyAEuw81whSZ7lahIW2/bEn6/8lFSPv?= =?us-ascii?Q?5w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d5f96b-dcff-438a-b20e-08dcdd92350d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2024 18:45:20.4691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HZ8ZpQr8CVfNYYTq+u0wv9FQYZDMLBlgn3QKqW+8gZIhV5qPVxEFNUuGdPOTVgf7Pv2Oj5GbEzUl1bHPsvBBvnmEl53PZQ5VgT3V/PSwJVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5964 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 300B640002 X-Stat-Signature: 3d7rw8dihp6d36q4te1upohpqoqgrq9c X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727289936-988612 X-HE-Meta: U2FsdGVkX18in9cchHqPYTJZPN7dHlBkuNZHD0Vv4T5KTjTTMdhlTDje6ufl2IhdY+gqDEqKy3CucugYUNxe7g+ouHHDSoUDcHvPObAhbA1hxeHh4C+nHu5hsLwmpVxxsZALva0hoTFD7AauDkzysiKuc3GWI2+YdINBZa/RjihBq1KERI91fArdUfje6xAaZB8va63B0K+Q2ewQKfhwN2FoW80VYEeLoLGVzDFe/nf3prmdHbIsOEb28KQrBaM3YIJpxC5eVQP809XShjM3JLdnMA7uklCvb0VeZ1VWofIrPpMjkJFRCusCqoajCMj7Gy+BKnzkHMqY7bf8IALXfUSfKc9V6tLmglk6a0kB56XupTUjt+xhVn5Hmzw7sAEEyve+26HERK52FUOLRc9XDwueL1ONSvDLwmjziw0arR0xQg5zUK02JWpAsJsPeoKYnUGMxkjzEo/UlQ0DDcipK96GCFGYgjUddnJBvMU8kuebeM1s82tV25vaxY7ZZrPKyTLEeJ6AUnOn+EDFAIJGQu51KMMkeMJJ38knsFrLDdlqbEQfdFGSlWr01Q+/6w8l4CjufwFIqv9hyuAKQhLlufuhMHn2IsVBio9YAYqiWaBea3CT6sMcTStop99bFn5sdX48FWOeG5nJ8DJd8h8hgsNuG/7HgYJvE9wcxPuhTrjQPremm2xEdF35qGvwlKWVaeVRRqRddohZ6YWdALWPyQD/6f9/YRMb/pViN1zeWWo8FFNLLmSSEpwROOyWrp+sRVUook6c8G24sB1cJUNtwO9LSyCk6jMMS5jG0L4kxCFkKLGrdwYmjsMFHHNYbeeFBGXxILCs/rHAtFcyvLND8MoQPfVjxe0W9i1P2yQtZ/rna1VY1t7eKOLGOyfeEqAlWYyObffzXOReUvKg4nDXB+jv7oAo08DSFc3rxBMAREYaRgDhP0Qx7JjdRNK84c9t5WuCF+8djkP8JeFr8+s 1EBnlWGi Vpia8aFrYisRvTN2gT85ICo33w77MdMheEHzAlkqNHXonc65wi8UVSZa1ghJ3MFi0kFN9GPM/LL3SvWg9eL5nHM65QFPETwUL6wm3lluZpJ/2rVrMcgukxwNrgY9QSiF9EQo19OKKWQLq45R/xeMMirgMZswyvkJH0s8Oe+BEGMAdhkntX7cOr3QAFaxoJzeaBl0sU8n8Gv99uykWVSCo12j8yvYAv78aijH5mahK6HFpwDQdF1XvAAiT0uYDy1xdwE9LLjFKWNxpsXlEL8uvYLgL0CrLs3lasEqlXHUrfnHLmj7PWrAz0yH3AfLXt23/427ejNeaDhXdIUdkS5o3riwOyKtEox6v8wb04q0iSHnDyq4plAG0JmgNocQ3yHmT0UeooNW9z/Cwd+D8jOXY5/36lAOKEJ96SZGQPkdY51EI5dAIMpEFlrarFwdiTgVr1oPDZINyo6KTHAea4m8C+RO0FVCk+AbHENbkFUxOSpzTwQXZedpKdqdyGY8bup+QRIr2Du6ji4W/X+kJp0k76iBAF9ZBIUO6DXnG91eF/Wa1WLZ2VpgmECz7QxUcXYNwazClg2G7QmgjgxjOEJODTFZKqdASlZHMdIEDc9IrZCKhBhrgfcuV63jfGCEDQAE5rcBRi/ae88EamSVZxI5wtbeRLoLtO6XRy0QBNqM8o/qQgBoBxaJJyLuR8qxDtm8nUFd66DiZWH/iAzvBIQn6BrMM//0UDJyArRDEHyAvOaQXE34la7rpAFG8e7/6mumzxheXmFl9TzlHCy4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Johannes Weiner > Sent: Wednesday, September 25, 2024 6:54 AM > To: Sridhar, Kanchana P > Cc: Yosry Ahmed ; linux-kernel@vger.kernel.org; > linux-mm@kvack.org; nphamcs@gmail.com; chengming.zhou@linux.dev; > usamaarif642@gmail.com; shakeel.butt@linux.dev; ryan.roberts@arm.com; > Huang, Ying ; 21cnbao@gmail.com; akpm@linux- > foundation.org; Zou, Nanhai ; Feghali, Wajdi K > ; Gopal, Vinodh > Subject: Re: [PATCH v7 5/8] mm: zswap: Compress and store a specific page > in a folio. >=20 > On Wed, Sep 25, 2024 at 01:49:03AM +0000, Sridhar, Kanchana P wrote: > > > From: Yosry Ahmed > > > I think it's more correct and efficient to update the atomic once > > > after all the pages are successfully compressed and stored. > > > > Actually this would need to co-relate with the limits checking strategy= , > > because the atomic is used there and needs to be as accurate as possibl= e. >=20 > For the limit checks, we use the zpool counters, not zswap_stored_pages. Thanks Johannes for your insights and comments. Yes, you are absolutely right. My apologies. >=20 > zswap_stored_pages is used in the zswap shrinker to guesstimate > pressure, so it's likely a good thing to only count entries that are > expected to stay, and not account the ones that might fail just yet. Sure, makes sense. >=20 > > As far as the vmstat 'zswpout', the reason I left it as-is in my patchs= et > > was to be more indicative of the actual zswpout compute events that > > occurred (for things like getting the compressions count), regardless > > of whether or not the overall mTHP store was successful. If this vmstat > > needs to reflect only successful zswpout events (i.e., represent the zs= wap > > usage), I can fix it by updating it once only if the mTHP is stored suc= cessfully. >=20 > Yeah, that's fine as well. >=20 > I would suggest batching them both at the end of zswap_store(). Ok, will do so in v8. Thanks, Kanchana