From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32D4E74ADB for ; Tue, 3 Dec 2024 21:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EBB26B007B; Tue, 3 Dec 2024 16:37:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09AD16B0082; Tue, 3 Dec 2024 16:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E078D6B0083; Tue, 3 Dec 2024 16:37:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BDC326B007B for ; Tue, 3 Dec 2024 16:37:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2A03FAE1F3 for ; Tue, 3 Dec 2024 21:37:34 +0000 (UTC) X-FDA: 82854959460.02.C754C50 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf07.hostedemail.com (Postfix) with ESMTP id 301CB40010 for ; Tue, 3 Dec 2024 21:37:15 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CCEuefTe; spf=pass (imf07.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733261844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CgoeKt/hArCOmmwNOV0/XoruRggFJfvvQxEjdPdIt38=; b=cup+v6nkBlsjo/yMGdRXgrJQ+5KmuMVj0J6LH5eudBmFE4FH1ggf+Llnrb4KF3vQGOmTwO a4eniIpjmHhEqfr6AfJ3OEcERsWEPKhm77cOC2x0wxIMSPvlIJszO0R1/ov191HvFgzZtx vS2kn8esL/2bgTseczQGdezLIsJhgV0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1733261844; a=rsa-sha256; cv=pass; b=GgMEZUZuclxm/tCC186oCDcntrifyVIrZC1ShoqLzR1+l+v2pV/49ap2ipBrWdV5svIvAt zXnOkDCrPUc9NS/jml7ACcmDz6EJdvYC5UKqJMsx/av9i2lvUdD8OlZCDinQxgJ4eq9+FJ WNvTPrZtmVlMJNVnvXbpxO8g9FQyFqE= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CCEuefTe; spf=pass (imf07.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733261850; x=1764797850; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5ID/wf7HePKp2bWYMtzVdTi63HHYf4Oiazgi9H1Kwl0=; b=CCEuefTeOhUBg+RIKeE5/AvXdlJ8WLTovOt540L6CC9zMWYQ9vXyqd2A mVxWYiVtNxMg/m/BTgW3Ren+UuXYewtFcIkUN5cakbdlnLaVfxdtb09i8 WRRPNu8PHoaPYbhZqh7AVcFNqgfA0P0PbuIbZun2aEcc6//ZnhNyGBmH1 3FI/dvtUx9s6CZj1sBnl9C+m95SCfLmz8shErxSLwNdmM0l+lLiyLeJ8d L+MatTybKqcZZyzgL2bvtBkE7oQi9qHUyKuyMz0QnsAHRM6+QEtYZQ+LX cJ45/t7blGdUYT0K+VViO4D9DXy29RDlBEap9fYcF15FmHPYwu8Au2gAC Q==; X-CSE-ConnectionGUID: uCLP5ulXTMikFE4CGv+AmQ== X-CSE-MsgGUID: 2CPogrEbQ7CjX9CJQZ0MGQ== X-IronPort-AV: E=McAfee;i="6700,10204,11275"; a="44115353" X-IronPort-AV: E=Sophos;i="6.12,206,1728975600"; d="scan'208";a="44115353" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 13:37:29 -0800 X-CSE-ConnectionGUID: Hs09YkgOTte6iejRszbNvQ== X-CSE-MsgGUID: r0c06tgpS2KTKO5X5QSh3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,206,1728975600"; d="scan'208";a="131017230" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Dec 2024 13:37:29 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Dec 2024 13:37:28 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 3 Dec 2024 13:37:28 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Dec 2024 13:37:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ix39J4m/0SHshEpp5fQQfL3w9p+9cHUXSUoolYZ6OSUuz13GzVjBkmIBTg6N0IvCWRtpvP2XQSzI8OCQxR4jyyxkOneFnQskfUbGLzlR0qD3dvJGdFWg5x1GWwMW2hpvsjSx+sYKHTkhHL075B/Bu9sPCdRaqw1jTqIhSwiE9LDMN2wkvk3TVO2ZhSm9wUAooe6IT3KMA0U2YIRpHG9ton6B5BYtyFCc9WO21owaCZzi7Y90befNIfuc3RNUeA5R4Ce+G31yRAOOcNdBluDxbNOaOGkcJs37AcLcOkP4bjAlxRSOaGfNdk0fS0CbJHHBhaKgX6jYp1IGSAq9mGPYHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgoeKt/hArCOmmwNOV0/XoruRggFJfvvQxEjdPdIt38=; b=NUtSoyP9F7XcWSJpksiKBEszScycb+n2KcJ+Uh09y5X9sKA+QCxK7M+hovYa5eW4kzXDJ1kLfS1Tefh58sZVMFshxeqUmcEOvdL2SAj8S+MiDrt4WyPvhQP0XOJBnuttAor1OlbUyBuNvt0HA+nq9N1/1Q+AsfRbMC28iDR2Q7onFVcaYQftMM8EbwMejiBOi6vd/UIOR2Nn0nvxtWBYLYRL2FHgR+2hd9zYVCMBn37g2/EjTTy23Xj6dsSv2PNANr6Hh8dJruSpZ5bNlNFkmUOoBuP8G4XGwifnuoVv1mdkm/CTwGbLXtCP00v3kioKa3Dmr4MDDpoEUcukKnm23Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by DS0PR11MB8762.namprd11.prod.outlook.com (2603:10b6:8:1a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Tue, 3 Dec 2024 21:37:24 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%4]) with mapi id 15.20.8207.017; Tue, 3 Dec 2024 21:37:24 +0000 From: "Sridhar, Kanchana P" To: Herbert Xu CC: Nhat Pham , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosryahmed@google.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v4 09/10] mm: zswap: Allocate pool batching resources if the crypto_alg supports batching. Thread-Topic: [PATCH v4 09/10] mm: zswap: Allocate pool batching resources if the crypto_alg supports batching. Thread-Index: AQHbPXWU4Gc6KD17CkKDJ7pv5ZtEYLLTYjKAgABKBaCAAIvAgIAA4a2Q Date: Tue, 3 Dec 2024 21:37:24 +0000 Message-ID: References: <20241123070127.332773-1-kanchana.p.sridhar@intel.com> <20241123070127.332773-10-kanchana.p.sridhar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|DS0PR11MB8762:EE_ x-ms-office365-filtering-correlation-id: b1666f04-3945-4f10-4085-08dd13e2ad5e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?o0E6l064dIJ/lDG1qy6wDDc/RwPLbtp1kHiu+UW53CREZ5Vdt0mmluV7Kp+Q?= =?us-ascii?Q?O4xya3ayqQi+ZEPLduWhlu0VTwtmiii1aM4AlqsjFxt2Lf4iGpkpbDMmkQZB?= =?us-ascii?Q?lRND4SfofgTiiNutwR6KPNGNmk67f3n88btAQtHF87HnAou70ftHjZ65ObQI?= =?us-ascii?Q?aPq8tkuWmnqGpUs2lpt3xgqy2DT/DWngPo3GDZ1l1TVcO0ZKHc4U28cnd9z+?= =?us-ascii?Q?NE8eSjqm1uuQRd6AgYzE2r+PppLwtE9gf8ivVRauBHr4+temGT+yHQm8Qikx?= =?us-ascii?Q?wvCVO1OQfcqaBP3KZzwbwgPAGgjFySsUwhg5hq1VTiWMsus3VtqDcFo1yaw5?= =?us-ascii?Q?y9GvhXE+iPNQAyc76A6NL2XMMaqEetvlHgf7vE5WA5YbFZO8chK2XPoEofG3?= =?us-ascii?Q?hT0nyO4T1zhnb13atF1JFG8ODRuPuwzjfP1PRd7Jzr8WQWYilx1OgE21OUYD?= =?us-ascii?Q?o2Vq9RYnN1QKsKdbLNqMGQhbyUWLoypWH7eCfOFXn0PuZHk1f6+elDyXITte?= =?us-ascii?Q?vI8l+yx/qc+aOnuk//qbVDknqdfQisOOD7O/YstjPYhCXsbkuB1qRkDKgk8J?= =?us-ascii?Q?FROFpGKg+dQxEp88FU7HBYpm/KA69mOI+VyQSfvkfRtAvOeA002Oto2DIEj2?= =?us-ascii?Q?AqQaayNjOHCkguLDdIhQIQMWHtcQUndUyrAy/fI5oL9rN7KYTmR3Ikkom6ub?= =?us-ascii?Q?LjI/+gwuDx9DFue5c46fdTdaJHAe7TcQGqylvgrQUZyVI4frtKVpcpFTZPFI?= =?us-ascii?Q?iKsnjZ3UXv6TuFlFTgKjWb6tPa/fs1Xysg9GOEsrzJcb2mgwn7NFsIufpKea?= =?us-ascii?Q?bC4ajDY5DtAI/zNJs38X3Wt87/mKSSJwXpgtFYOIpkBXIvn+DbmM59n0o9Xx?= =?us-ascii?Q?C/R+GwD2cK4RFND/6H2KSpkm7jxt5g84jmIsSg9TME2v3omvHb3AxLAOwopR?= =?us-ascii?Q?aVGRv/KIkRxP1vJSlbTUJKexGtJnouwAcZcUfWCpdlnmWvyrVNXW0IV/e8g5?= =?us-ascii?Q?VysD5CgJ53j8AiPJ3dT5cELzVwq68GgdqJluJoONvSwX8LqliSccWKdJBpG6?= =?us-ascii?Q?jxrjS6NpJCLJqVOF5nKo7PFdS/zzIT/ih9yKNaYvWLgB4sJSDVtRw8e82d6W?= =?us-ascii?Q?iSs98MNV9MwiJ0j6meup15IwAMpHZ1/gP/srOjZUZtmHred9U9dwlP9tC3bB?= =?us-ascii?Q?tBmql0rCL1uGUVpRqtgpUpsYW1dZvSCdUs0ydxyCfUTYn/VPNrMxHZ1YVk7/?= =?us-ascii?Q?twF3cJvrhgAqAec2c7tqulI7TdiB/YcBSLOU36O1ioJBdqiaNFXzEbEW77Lb?= =?us-ascii?Q?Yg8/7SQeZ6GPCFkRxhH0HtTPU+E7aDe0VhEQ62CrdV/wqU0FxfgRvzSrO3+j?= =?us-ascii?Q?3F+N3YY=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Me4/cywG3ifAbfW4S6noyVvyMyPvdVJ7iPlC30RPUENzo9MbzD5agC1wgVHM?= =?us-ascii?Q?25tqc37wCIre3e3Iqvk3xovftAAtSuYcyEh2Ug1w95d5Cft6yO3GK2LtIe+V?= =?us-ascii?Q?ccFRbAhfzjAmnV/goDLtAlDIfqz3GoY0ElJ83o7u4z+Qd9REJViy3+z5ZBUF?= =?us-ascii?Q?bXP3zUo5Kpm2XZTwSJXEpymaKjUl5sOkQk3NKcUADOr8RoRf7n7B8QdbrQff?= =?us-ascii?Q?4dluluTc1LIdsiUAK34DJE5EKY6zuWvdeT7P9Dsdi2VxQgFoDW+3cqvq9MOT?= =?us-ascii?Q?EevScmNPnzo+LajStd+ldKa2D6pnntTOZilIsf791IAVR7ly5sW0Pkn23Rhi?= =?us-ascii?Q?PIYiV28SF4zUKSAeFadDcXtra/iHGk9fNZFfGVp7snrqJDLBMNg9P0jD6uVS?= =?us-ascii?Q?1RgClUm63eDBsOUwJlml3ufi1Ta16aVMCp486bT3IsNby34VXGElj05qeI1a?= =?us-ascii?Q?4fFfr33DynfRWJeyJjr6iEAbIxZxwHfoGk6NqUv7dbFfl4UB8+K9nDZnQisw?= =?us-ascii?Q?NcY+Yd+wArR7Ec4H4u+KE6sJKWSAAfmAwENRY1NynUlQhryJbMJ5eVQIo5GZ?= =?us-ascii?Q?WcONH78vEWn3zcGSG7UOKDGEuwXskC4EVQnd40ZAPC/EFqRKxxRiFzSHPywJ?= =?us-ascii?Q?bcZwmQWwZpM/UqWcTey1DcL+SuoJn4NsJDUAKlVbbEMpWcU3w70OC64oYGfc?= =?us-ascii?Q?3tweHf8XVJ+rJeSf20Cy0Q0Pep/8jrZ3XSK28dgwlLso/ML8TX4g0a7GSQHV?= =?us-ascii?Q?c7Falmsf6KH0tcozNn3naIj6kH7WGt+VPUdDcl+jDEPmc6jRDVo99pzzCRAV?= =?us-ascii?Q?gArIJKYtsiTm0rfI0293/7PS+RAqQPp5UmzlYv1mkKtyx75uVNQPILr6RlXr?= =?us-ascii?Q?3UYhYAV2+Ly2cfdRG7okK//eAMsoNm4t6lGm83CXO/DIK0teqNvrBoxxO2/w?= =?us-ascii?Q?6NuAqbJump3JUPJ/ShPDiZyWu0i1biQk1Homp35dGsIZMmgTMIZ+KFOFl3uJ?= =?us-ascii?Q?Xq5K4WnxVBkkT2i0eJdw8glYHRXr3dJAvi5vIP0Y7Po5RfvspigfBdgI1yVf?= =?us-ascii?Q?0Yzgmd2x0JUbfbHApT3jro6cnxFktkjrXrs5HkW88kffOx0Z+o9ej4oevneH?= =?us-ascii?Q?LPXgghAatGVXok8GQUH5zmMdzxmZnjqLB3yMaMWBxhbwl2DZLHtOO2It3EMB?= =?us-ascii?Q?iazR3Zh+V+OkxlyMCXBH8OYaSZ6aHfcx9ndRqfie/kFace91WBrPIXJP4K5Y?= =?us-ascii?Q?3mmU48ELsIgq+dfF5lkuKxonRjqpmaDshmubOehvWHr9BFUE347IM7NaiUs2?= =?us-ascii?Q?JJmDAYqB9dgfgi9OC372U3Xi5DZYTzV+8Vib1IGbEM8HoU/EBqwN98LAeBVJ?= =?us-ascii?Q?7opRuBYH0X5N8lhN6u1Jsg07O1hvFs1nn8cDjJckjLPeHzWfW9gc1oX4sFvS?= =?us-ascii?Q?0W7nsX24+V27mjszvuNO44JYHaOl1w+CHpCKElN+11IMDdpgF4iQ3dKZAJqT?= =?us-ascii?Q?Uc0UsdVa7C/6JYZcLyeowJAs1AC7DLHAVZreOGO8WbJ5nQMY/yQ5PA9GEhc3?= =?us-ascii?Q?DeeVtj/F6gF25ukhJPfbucr1jyuCi59NqYK2M17mNDaEOGm1nVO5W2uE64hu?= =?us-ascii?Q?A9lmAJgY+MVe70fLooD3NFlSc33WeAOChrt6058rwgjtdABF1uxr2juHVFsj?= =?us-ascii?Q?QHoG+w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1666f04-3945-4f10-4085-08dd13e2ad5e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2024 21:37:24.8131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C2JHK8ywfySrbtSOfHldzzieddkl1f7mQuU5SxOxwqof/lR6Ekyr7m3vY/ma5U2DP01nc5GDjz8BymVMo2IpC/lQig7Jp+cjySi0YWO1c9A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8762 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 301CB40010 X-Stat-Signature: ejzs4bhe95y4to4a6y3ocdkghfmijyrg X-Rspam-User: X-HE-Tag: 1733261835-513464 X-HE-Meta: U2FsdGVkX19y/h+qnb0euMFy9EYio365iOaScwWLYimQhDDT1S0Eh9cEYoBfeEjM5/Ajzt/Y0OxWNXy8FoIEIkQvjgZjg99VfFKPhFg5tiJ44kYiXQAkA4S3Zcv+7YcBGDLbzEkpVMkNEFWeIZMn7JAzP0fCQz78Z0ZU+IGkIdjs/tv2XrNRamI21ZzNcB8d4uncTAU4XjO2dAj8Afl1oyR3lt6sKcmZXpKSePVoJb4Q13IpsUG+6faax3wc6kA/zV76CKKcjzI18GgQ/eCGVhpka5NqePVtdJmSaYSZ2YN7SKqnwcxCtBu/eNE8Fk1ScaIRseLRIxgnzh/qUc8TSQCPnaSxjJb5juaXytr28uR11cMgKUDApKjoVDaAtJi2RGriIdEGDUfT3m6GglROqlcMLSjYPH4RxvNePfdL1qusfSy89XqrNWsxo0/QtsYTIgceBbw1QGb74FhdEBwq+kob1tOXDIGyt2h0a8PWnUgh9qLAYSm5txA+mOApw67Tt2RFHBjmjBLGPKSUEAre0ZZa8WZHEm33wZeWp1gCfxjgbs8RoHQovrddT8luJag6+VpuNjuEkloBeOQ+i8YPftW1+Hr8pihwiHZxIAjtwhUgb1vs94A3xefNBMKQX9SS6iOsIRCrE60FBSl7Ckb4fomPZ7nCtPGpjvU6bnwkzhWynKlURirF0BF3LO3oLmLA1SeODHSe+IYYlqICbbz1CqaZZ9Q/JEnmSaUngTY2nDe7xTbib0a7AfYywkVg6MBBoDw5Jhppl+jS4etZ9+O3FaD6Kry16CB1KyR3sUtDMA8JoThMh6DXC20CtF8sHCM8y5Xk9nxhw8dAL4wPJNm4MqyTsYYGhcLBsgno5rQZSHe4Qmf7vPQ1flUt9n9LXb4TnOEcBvgBxtpToWjNYJsbOHWDgvCj2Bj1lelJKKYt8iCgj/lRBtPvGlzVlwHKBvuaHlg4kmwE3LH8SJ4wODT poLRh5T8 Dt1zb9yimj/YktC28apaiQ49mAoQgObgb+9YkdA0/cc4nCIt3xTjc4pCKo5nf9z+fe5Ejb41kWtyTpTtwptLE/FxOjBnBq7GeqQWihJoA3VhObal09R6kecguxFZZi3YDbSpvLih96JICCjOn8i1zQbOvkp2RND1MWgSb7dRxCXoXMVQAl62QcAEe6IdNBgRwlOpL5FK01PuplgEP1+LxmkbdFmMwOQ/7Ay3UhAyFsuafrmsWN/YZAo3YJ3b8ZE3Hl/1p87dAmBKO9Yyh97w0tEDY8Ot6re/QLccg7v9p0IpAY+RORKu+BjFwc6mcH/IYWIGGceV6xgejwmeG8R6w04wsOHI1V324zuIognU+gMyJjUE5uxLzn/rY9YQ5aG2wyn1qybF6+39XojMaUl/yyw6F5daWjVwXBUG6PE8fYkaGjb9YIT/N26R2u9nOVTo5kg5Q4puD4yU9080xa04jLfR/Fxr/vDU09OT755DvZZG2IxS595vNBM3mkmKgDU+7zgcKuPxtIeYfdE4ANQ1L7xomU12N90AvcOK/kabFK0CHKL4z+4wX3SFNBi2d940XswAvNxx6k42GAUXpGttaYPxjIQKxNPn/8sKluPxL3bmHEhlouYlRRBnU0ixbSwe1vvvYZQoyOwtA4u/Lro0ASlkXzlMxhJ3uNwpwQRHu7Wg/IwzQJ+CvuflenctzotkdiD/hSwxBkukBa1uASekK5RX83Y5AqgVM6L8EGyd/8VLXP9HKIpUv3E4zO97oHP+OkC6hrFyeqzzXeI1LYbN2mT+VDa1lXMpKR5+Wp8knAFtUP3D/ccm+WHXjBbzb5YoovEFbPKWL6O/hhpN+8cFUM8JzJlYinkEVep3oHXrcvz+dKHeRuxPBVD6XlOY/X3UrN70pOOA/1HAhDHhZKGdqba7iaZJ3cQIaR0H2DlnJ92GPcphd3AvjrLInHrf/hetlITRJ4Zmnpl9aBnOdXvX/x9DCD36F 2Yp/h3I3 sPvPbX13wE7V2l07sx7sz5cE7mirXNkhOSwvnrvZQPKYN0qquhlWmxCDsthswtTi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Herbert Xu > Sent: Tuesday, December 3, 2024 12:01 AM > To: Sridhar, Kanchana P > Cc: Nhat Pham ; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; hannes@cmpxchg.org; yosryahmed@google.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; ying.huang@intel.com; 21cnbao@gmail.com; > akpm@linux-foundation.org; linux-crypto@vger.kernel.org; > davem@davemloft.net; clabbe@baylibre.com; ardb@kernel.org; > ebiggers@google.com; surenb@google.com; Accardi, Kristen C > ; Feghali, Wajdi K ; > Gopal, Vinodh > Subject: Re: [PATCH v4 09/10] mm: zswap: Allocate pool batching resources= if > the crypto_alg supports batching. >=20 > On Tue, Dec 03, 2024 at 12:30:30AM +0000, Sridhar, Kanchana P wrote: > > > > > Why do we need this "can_batch" field? IIUC, this can be determined > > > from the compressor internal fields itself, no? > > > > > > acomp_has_async_batching(acomp); > > > > > > Is this just for convenience, or is this actually an expensive thing = to > compute? > > > > Thanks for your comments. This is a good question. I tried not to imply= that > > batching resources have been allocated for the cpu based only on what > > acomp_has_async_batching() returns. It is possible that the cpu onlinin= g > > code ran into an -ENOMEM error on any particular cpu. In this case, I s= et > > the pool->can_batch to "false", mainly for convenience, so that zswap > > can be somewhat insulated from migration. I agree that this may not be > > the best solution; and whether or not batching is enabled can be direct= ly > > determined just before the call to crypto_acomp_batch_compress() > > based on: > > > > acomp_ctx->nr_reqs =3D=3D SWAP_CRYPTO_BATCH_SIZE; >=20 > With ahash request chaining, the idea is to accumulate as much > data as you can before you provide it to the Crypto API. The > API is responsible for dividing it up if the underlying driver > is only able to handle one request at a time. >=20 > So that would be the ideal model to use for compression as well. > Provide as much data as you can and let the API handle the case > where the data needs to be divided up. Thanks for this suggestion! This sounds like a clean way to handle the batching/sequential compress/decompress within the crypto API as long as it can be contained in the crypto acompress layer.=20 If the zswap maintainers don't have any objections, I can look into the feasibility of doing this. Thanks, Kanchana >=20 > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt