From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587F6CEACF0 for ; Tue, 1 Oct 2024 17:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE3C82800CB; Tue, 1 Oct 2024 13:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C93C0280068; Tue, 1 Oct 2024 13:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A72312800CB; Tue, 1 Oct 2024 13:34:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7BDB3280068 for ; Tue, 1 Oct 2024 13:34:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EFFE514120C for ; Tue, 1 Oct 2024 17:34:17 +0000 (UTC) X-FDA: 82625732154.24.E98C10A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf06.hostedemail.com (Postfix) with ESMTP id F2F0918000E for ; Tue, 1 Oct 2024 17:34:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Kwky4kJy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727804015; a=rsa-sha256; cv=pass; b=bj0y3swUYhzoIsuEjlJF4L5vKRvxaoLszhUDQo/sxNiLqsdBmMZ57Zap11J6CGxlhLoIq1 7gDssYN2jlxNsDSUfA7+O/a6xU7eMzA9St0lteZqG0SL+Ygym3wJ9NN6qV6PIEMSHL5mPg qq/yMkrQ3+XDjUyF8d5RYt74vOHAQLw= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Kwky4kJy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727804015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1PlGn/PqLwkjPqu1Rretn3fDZ9ZNvMXXYyYh2VZs6ZA=; b=VZKoJ+gVTw4hgnR0neZPl24d7aFictW6k+B0RYYJqVpakTFU3dKsLTLSh8FMDNtJv0IUR2 aSEQS69suBXauVWMx0lNEj+hrvbBj6pHsYtOIUhPXVOtGGnWr57maS9BSFvS5lk/Nb6Z7T 6fPIzAq5IMY77OJnefx7qBEzuwGv+Vg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727804054; x=1759340054; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TZejwDYbIS+aeL9Zirdr0mNEBXLEGVAoMwzGeMipTuU=; b=Kwky4kJyC94EdEtK2jfy3exL4R6RjlQ4jtMp68Kg/TypdeULb5/ii/+b BA33KdLr01wmlQS4eYgMB1fhiKQQNmWv2l1s2CxtshUXFHOjYWeO9VObb M6nQ8w9zJr5IDvL98EzqJ7a4nZ2tiEm+NIll94lDHLGB5I6jMjpclzsnf /ZsGzCo/BwqZZC2HKphkfguiuBFi6FAFku7wSQq1Wgxtds6V8j1/Fhw8g r5Ndq9D73J2mORgcvo4PNwPxhMICd1wLs/f2DoNfUtWU5l4sMVY9WAer0 H303aLNQjajJfnk5ubChqOGT20g3+ADfcWPEfQNvmtp1v5n0vcqyGYM/u A==; X-CSE-ConnectionGUID: aiC2Hng/SGe2ieYcctUaOA== X-CSE-MsgGUID: mfsqIXKGQh6Cpx7jUfYTLw== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="44479568" X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="44479568" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 10:34:12 -0700 X-CSE-ConnectionGUID: 2Ut4jfYKTvWHU1Bjiqyaeg== X-CSE-MsgGUID: WpwC2AGHQLqnXOXuMO5vbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="78156339" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 10:34:12 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:34:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:34:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:34:11 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 10:34:11 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 10:34:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dxvZDE0a3g5z1MwtP7aS72ux/WXCpuRF9NbFAag2yu6ondOBToRfElAp9VjM7+i2gVpZ4+K9NkL8DvzAho9NVgGQeoN4zyuFzG2PxXdJ9nqIYZzdRAvesTtNkGwfzzI7Oc8UBtZlZo9F0f0U3xF0rYpDIEgQbDOsgC7jHig9cWDhoL8/V19NE960EbCiwNL4r8NG2+Fl0yolHzLlOS6CzDA3d7ZuFWihW5ZXcAx7tdfMgowK3or/hggHArxfYTbJLCvrWgv6TaQH6tVvBVLzd7m6TA8ZJayRKn+G9Bn33AOM0TtzVq5GU+GFibhQ/r0VQTIoxh7UFzyki9csPIIfWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1PlGn/PqLwkjPqu1Rretn3fDZ9ZNvMXXYyYh2VZs6ZA=; b=uTYUbJ0exKV4hHZJR9oucV+loSBJqXNAyyGYcPwRAJRq7Dft0dgW0Evf8Fy4hX/EdfjUkhGnsVhIi898R/NxRyfgggo7BBGFGOz3mBPAFxw8WMHKX+AjNLc9KzA6Pqqh6h0M2vcrkKpK68+5S0kijauSsKu8fe2IzPpAARiujyqG+vMHjlRJXMYssV6Z7XE/FZCzzJxghdFp1WuTY1B8p98JAdZ+zUSE3532K/sMbZj2EgH27I9Pm6Fbnpi0/ESmW4Eo0PVyPOZ15iBXuVI790pcRWdETE+SmW1nso2QgDMsFpDfhvKxXaLN81A1gSkQMeK8N9Hb66h3x/ZLmPTi+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by SN7PR11MB7975.namprd11.prod.outlook.com (2603:10b6:806:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 17:34:08 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%4]) with mapi id 15.20.8005.026; Tue, 1 Oct 2024 17:34:08 +0000 From: "Sridhar, Kanchana P" To: Johannes Weiner CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "yosryahmed@google.com" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "willy@infradead.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v10 6/7] mm: zswap: Support large folios in zswap_store(). Thread-Topic: [PATCH v10 6/7] mm: zswap: Support large folios in zswap_store(). Thread-Index: AQHbE8NS/mzK7ddAdUGteugGSqw7kLJxvZiAgABpsIA= Date: Tue, 1 Oct 2024 17:34:08 +0000 Message-ID: References: <20241001053222.6944-1-kanchana.p.sridhar@intel.com> <20241001053222.6944-7-kanchana.p.sridhar@intel.com> <20241001111045.GA1003400@cmpxchg.org> In-Reply-To: <20241001111045.GA1003400@cmpxchg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|SN7PR11MB7975:EE_ x-ms-office365-filtering-correlation-id: 51558153-75a2-4ad6-7d97-08dce23f4176 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?mYS3Q3Kr2HQlVNEU6itHSOACbAsiJA3/fck8qnR2ooeO6YTySTGy3jIqI+Cw?= =?us-ascii?Q?tmOnWAg7kgyU+f3g1vYtL2uWTEjSAPXBEBBAD+BtgyEYtGmflIEcpGCYBDne?= =?us-ascii?Q?n8XhhDfUf8/SNzmcs+hUEuBuxFGgzt7jh2V0esHdKmIblfAH338dW8p+GEKW?= =?us-ascii?Q?k0bTLtQO5O3ZjbwiMvVrvESBhXrrl0+KID0cEpG89q1v0aM4I3+G9kt7R5Gq?= =?us-ascii?Q?8DJGcRcXaxXDDgQJerwXfjuP6NxDuyaBBs+jZquNf1JGzx0nrL1oIe/AxZll?= =?us-ascii?Q?vyajNGOs+0tQGmDlBUfIX8AyHLNbOhaS5APRfmegqsAbFqwNMv5EPwgzQk2N?= =?us-ascii?Q?xOMXT7npf4Kus03NkStOAKMd9H/e01HZ+cU7U8km1k5Yg/PMiPp927AxEB2Z?= =?us-ascii?Q?fWUr6pJBgdb6Kj8k29GmMYdCbybEMMUlg83/Pl8npAGLATVhd35GysPJaCHi?= =?us-ascii?Q?xBCVmUh2lnNcYPAcjfQ580Uw9NHokPfR3nZsE9reC2AedFSVrgOnxh6nW5/c?= =?us-ascii?Q?LZrYyNLVYoBr5iJqqZMXZ/88opCU0/FLe68iUF1U8NqzhmTUCClbLOmvCOUs?= =?us-ascii?Q?eRFxgtCRNbX5cJ1xYuz2rqcYbvkzPKiiSkHvuRFcwQr5uHfYk4FsTFY0Y3GI?= =?us-ascii?Q?Ssl6j1fg+aRY4iC/+3KctgkI9Y7H6pt1d7ttUJlPIqprCQalfIh1SFqdtr5z?= =?us-ascii?Q?jO2AOpnxH2q1KRGHB/2JxD1VgkDOzzPs3/0XpvmEjEctG+ns2VkybpmjRT0n?= =?us-ascii?Q?852ursqfTv4nDYtAmmXJz1aRSS7s3wm+eASbVcQZUx4Kt3TOZ71hCpgKwiXn?= =?us-ascii?Q?mVDIzMF70GPLpD0gLAp5CmkiL8qzUd9I5fppf0HKheRfDXckBM8Zu1zwuZ7w?= =?us-ascii?Q?3/GR/upykMZ2ucoJIn5FR60md/thMxdkVJu+pHqxZwaTv68wCm5Rho1v104y?= =?us-ascii?Q?zBlyf87SaWh2v6d3IQ8hZD/bIL5TQt7iQ5buPRB7hRL+xE96weZoCSyKJZd9?= =?us-ascii?Q?4NfDpG7O00enMCep8pASVcSxucPEui1sDyT7yMeWD7RlzBz5F5sNoBoC6sJ5?= =?us-ascii?Q?9RG8kdOdi/lNHnU2Mxk0YNeoElEIRQKajQtZ3Euc58eFTkG5WlW5lO03q39Q?= =?us-ascii?Q?XvSYDFoySz8DAH1k+s6iPFJAjzcER0jBsKdpaILaJlJhpO2kwq6+jkwlv2XT?= =?us-ascii?Q?4k9uJ5yZHv5b5pXb0keuh2Fpy08oXOaeSHiotctIbhtoFWEa0Oec6/7jLg/a?= =?us-ascii?Q?Fn8k5ZfYFo22d1HpVWtDxGRqHjXqki3BoPKREPFm4DUUxj988lrmN7f8nQdS?= =?us-ascii?Q?FGvma0Bm8wd1x1ygPXapvVQ6+jYnVyB/R8AotY677EEivGPZwdMaAtscLIHZ?= =?us-ascii?Q?wUL4vTY=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gWjr2ql/gD5HmjSHWz8/eu5D9LCBrnt6GaetkBmgMSES9S7yk7rWNoKPVjn2?= =?us-ascii?Q?FGHuAYnf65WlKav7V2gY6Penlnmt5nDlFW58BEkX94aDju956ctIBSwnBmFn?= =?us-ascii?Q?b4Jkq21RE1mC4KCIhoagZZFTipNLFvB3m2BFEmTuAC50IUOi089/2zTaczxt?= =?us-ascii?Q?hpUuRN3TlsbgLzzwBJuHf5ghZCtUKjehUpI+khJewctbk7ccg76GQFlaSjag?= =?us-ascii?Q?qs3eZoDX52Oety1Me1hVCj1uy9h+sr85x+QM7a21Mg5hvNNRDGR4XyHxpnue?= =?us-ascii?Q?KrMavr1ri4LlBt3nI2ExljlkbGEIg4kzN+/e7kUR5lRdJm7ux5HIhrjjK1dS?= =?us-ascii?Q?vnqQ1r5rqNn2qLF9Y/X6809GtTe43fZdtkGfR4bj+CyXZ4CPus1x1/8v/n/D?= =?us-ascii?Q?AVUGPRmm5jFjoKJ5zot86+inc3LWAkKY0S33NEAN5gLtqzJkGK1tZzorEome?= =?us-ascii?Q?ggpbvBYMGFLCumk4A/pTLTFiApT48uoJwFhEtGMZY2dqqgQDlDrFCIzmEEvR?= =?us-ascii?Q?EUUU8spBbx8KuxIPpN0/9st4VB+cRgBvXu+OST8U8EZXlvIRasQI1FTRdCZ+?= =?us-ascii?Q?ol+pyBKcHO+UUc/0N6gplcmQla2+DvMnoBhr7GmjRGTlVf/XY8au/WRj0lsb?= =?us-ascii?Q?/uLsD9Tr0LuM1la4PoqEe0wuLy/TuwwajwqDN5ngw9NDUMU6gl7HEiuBZLDn?= =?us-ascii?Q?pWt46MClg46oa6nQUuG/582Tim0PSHYUZ2GN8rDG5YdQQh7lGOgZKodiPk5o?= =?us-ascii?Q?ovgmAIdto8qis473TVCqWazs6EmRsde3Oe7dnL0ArqkEFGSMg4cbg3D4Ctxt?= =?us-ascii?Q?S7zgOR2tq8Ix3IOA5DDkXQJuLzvmDc9INedxQWHntMCE/gz5sa5k272eKgrD?= =?us-ascii?Q?BHO1K5pqpsATq3/j3t04vthylO44QHPdh4hS5bjbQzUbXE9bjui4uLpEq3Ho?= =?us-ascii?Q?VugPTGvl0OmmgRfR+AKZ7ECorU5m7laiVF4N4qVOYvMkOEluz7AkzTSB0dZu?= =?us-ascii?Q?PM5WI/D8Lt+ALXJh3mw88mIdu0h3AB5PQmxi56dSzUBmtqd57ry0TbFmw8Kp?= =?us-ascii?Q?jOo1eBJb3cO+jAfRTp//R3Sa6A7Bd76Hwt3XIye6RR1wd9iz8YFWLS9e7ua1?= =?us-ascii?Q?tdVTvEXn7C6/0jVxzbUCga3klUvtd3jWE1O6uk4UjqIjYPkLIiAu10V98cmO?= =?us-ascii?Q?X4yEaZhqXf13zrnl6dLToEGjx3n34Ql7Hx10AZAl2k7EaiTiuZy0Q+1IBDim?= =?us-ascii?Q?Xhp2Zt1l9Jflfa7eWZp1VbRFFTJAFTzOYtPbPFgRtPgqAJ+oBchAheUGdRe2?= =?us-ascii?Q?dZrzH/4u9f27uCcRTpMCg2q4wFbxjiRRB0NZ/2Xbdnf6GGgwSzyzVlnIE3hp?= =?us-ascii?Q?NozmQsdIbEv5rzjV/QOIXKtBkcUGw/DbPkAMnakbUCtFQVP8ccByhuD1PtJy?= =?us-ascii?Q?s7w0MvNR1yIlAZjEvGBKBa2v/SfHrrBSOUp874lnxvaNTH6iKBNAqqM4Huzb?= =?us-ascii?Q?Ha76YlsBsGSCo8l8uFb8hEgU0KtGYdCU5L9n0CJ3jGjiqSGIk2tNXxiDtoFe?= =?us-ascii?Q?u84f/7XM9Qy3nFYWbfrjL52UV8ErQWD1NYxgg1qEZ1sqcNXBniVvuRLKJ8ma?= =?us-ascii?Q?0A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51558153-75a2-4ad6-7d97-08dce23f4176 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2024 17:34:08.8812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NEPLa30OKXZGH13jKYsFenxBY/tIAMANBsMf8MilDGujTtBTI09wr9ngmsjmAdu/K+cxPadAOXSSDTQchT5YCq48RYragWmPel0KrHMke2A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7975 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: F2F0918000E X-Rspamd-Server: rspam01 X-Stat-Signature: ho78mtz7ce4qsxdnkwm7foj9o63kbo5m X-HE-Tag: 1727804053-835054 X-HE-Meta: U2FsdGVkX19cjUe1FDeNMtmwLnRPqZU3fkkMq7V42Pv7LP9hyhQVtXRVwFrak8pea9PmaFbRmNVV3lJJ3/e75XDz4/0xeHrk3LUguP0oAfAh0NhD0RHC0yWVuChZFbqDZHIq3Yk0+F4Oq2ONivw+O4b910/ywdlQfaiaFwVXCi3ZTvnsg3YAzJ1B52hVJ3laVs0EqhDkWwSMDrjigUd/phNoNMEsi1xKQLEch1s9sSDSzTxk73qZ0WC3H5YElofJO7o4PrME6RPec/X4ogZtn6l2+uL93wUICoY8S7UaBiJc9VNeoHyU/YM3iJKkgkCKqFymg3+sQNnso0STr1wXemHvl8WZBrJXQsCVuY32ZcsaNDjgl4W3SEC2tP/PJlsfcN0pakdLETODrE+IXqDoiyLnokZZ2mVS3/Ej3Wq5V32+wEdjuy7Y19ULSDssRlhJpKDXByDHWRc6EEfoqwzHKW64GjZNOUB1c325Ftf0QZXa+IMz77f+LvFW8UudSblbOEf1Rt7KFpmJVSpYoZDA5qbf1CYDvEcvQCzSIosp4WNEI+sUWhA3WLWpBM+uDzlgo5mrPsc3mzXv8UH8lO/RoY982QnV9N+7B0hk8JtDUFW2iBjI2sqoNxR0+CxnG/TCUbqQt8WEBRlvklXlyv5RG7v5YTPq9K1apdJL1xNX5RT+SSM1X1//JythaxQoA1w5c6cUtLlA+2WZP5HXeggZ+1Fuc/Iop8IgNkx2aZCMuctKZ0L9mqcI8B6RbeuuxXumC+FnnCqOW0+zl8pwQtTWIDmXUILBLSn+4uJlc62EbxjcN2/qCgRjZibEW0OJYj4Gi1tRCIdAHBfMwripf+VSb8xn1xErgZgs28t+OaVcoNb1VDXfhavafcxxLmDPTl+nz1upAfOu7B0dEtlhHjxICzDyFjpeT6LgjZlRR2KQggTSWFC7hcW/J1e17sqej6owjyk+RlfG70QVXPwqWCu jiao0hWt 2XU/fmNe5xLAnVT7FRAwpn6ckWcwinssLO8scOqL4XO1NUKmxtgcyzRfgT43jyK7vVN+uvbglz8s4exkO1moSJL3cfHGinhtz4VoJogo4wOAX/a3B6ir6upeCMrtYNl7Smydr+vzB1No2N7g8/eT2cbXBCqbuwtzVRmlu3t5aCaOAMoGR2Au7mCZz8Z25n6a4LA5WOshIHkpOAngdJ9LXoj4JiniRjJXueAP7lCU2mzKZ1x2erPcvjYqwftNT2nKKRCc/glMx5XWbK2t+GPNWJCZloV76y0T9uZwdyNdmtqSnPTYrnEs+o0zIog4EAXX7VgauxUfJ21PXzG4zZSLuwoKs1E+dD6m2IZoPRM4l59uFcjMgrEw1wRKwtTUmU+ILmQfhYCK8gpowWxmdg9qTnM/d7oxHsLeI0oxOkQSCD1fFHRNev/Dzy07IcDJx0nbXRBDQrrJB++oA30vjGsUFSNbKJfLWGN1UALoztGDxDOFcgMaiKNdHdlcHDZahzrIqAoPUMWMTgbPTVtUakUJpigbz2RTrKSyzs5FSRZQGn39xVzTqMFGcaFsa+Q5afLDNE+IhiqMNkWpFJH5CD1+mx0oi3OXaWHHKItd7NVFnwL8X6ocVBF+/aKmVKH22e5RsKUXLWjc7zdt5h8n5Lg8anSQquJwIuAo+NwADeU/th3LzGB8vTnTlCn2gfQlucp+QQjitjf7fPnYHmYu9vgQF0AA6v6ODVN1QmD/4ImQu+hR0yaEXV6soSkaizbl/4Ay35rBfb2WfgDEQZLrKnQuO32VA8TG2jQ/UYBmWpB0jibh2onMa1Rg9QRw5ieqFJgop5aDuzrYvMtB6ryTUAYHI8gyOMH+Odllrw6ETFKX+RDKOp8eXux7tl/NRTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Johannes Weiner > Sent: Tuesday, October 1, 2024 4:11 AM > To: Sridhar, Kanchana P > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > yosryahmed@google.com; nphamcs@gmail.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > shakeel.butt@linux.dev; ryan.roberts@arm.com; Huang, Ying > ; 21cnbao@gmail.com; akpm@linux-foundation.org; > willy@infradead.org; Zou, Nanhai ; Feghali, Wajdi K > ; Gopal, Vinodh > Subject: Re: [PATCH v10 6/7] mm: zswap: Support large folios in > zswap_store(). >=20 > On Mon, Sep 30, 2024 at 10:32:21PM -0700, Kanchana P Sridhar wrote: > > zswap_store() will store large folios by compressing them page by page. > > > > This patch provides a sequential implementation of storing a large foli= o > > in zswap_store() by iterating through each page in the folio to compres= s > > and store it in the zswap zpool. > > > > zswap_store() calls the newly added zswap_store_page() function for eac= h > > page in the folio. zswap_store_page() handles compressing and storing e= ach > > page. > > > > We check the global and per-cgroup limits once at the beginning of > > zswap_store(), and only check that the limit is not reached yet. This i= s > > racy and inaccurate, but it should be sufficient for now. We also obtai= n > > initial references to the relevant objcg and pool to guarantee that > > subsequent references can be acquired by zswap_store_page(). A new > function > > zswap_pool_get() is added to facilitate this. > > > > If these one-time checks pass, we compress the pages of the folio, whil= e > > maintaining a running count of compressed bytes for all the folio's pag= es. > > If all pages are successfully compressed and stored, we do the cgroup > > zswap charging with the total compressed bytes, and batch update the > > zswap_stored_pages atomic/zswpout event stats with folio_nr_pages() > once, > > before returning from zswap_store(). > > > > If an error is encountered during the store of any page in the folio, > > all pages in that folio currently stored in zswap will be invalidated. > > Thus, a folio is either entirely stored in zswap, or entirely not store= d > > in zswap. > > > > The most important value provided by this patch is it enables swapping = out > > large folios to zswap without splitting them. Furthermore, it batches s= ome > > operations while doing so (cgroup charging, stats updates). > > > > This patch also forms the basis for building compress batching of pages= in > > a large folio in zswap_store() by compressing up to say, 8 pages of the > > folio in parallel in hardware using the Intel In-Memory Analytics > > Accelerator (Intel IAA). > > > > This change reuses and adapts the functionality in Ryan Roberts' RFC > > patch [1]: > > > > "[RFC,v1] mm: zswap: Store large folios without splitting" > > > > [1] https://lore.kernel.org/linux-mm/20231019110543.3284654-1- > ryan.roberts@arm.com/T/#u > > > > Co-developed-by: Ryan Roberts >=20 > I would change that to >=20 > Originally-by: Ryan Roberts >=20 > > Signed-off-by: >=20 > and drop this for now. Hi Andrew, Just wanted to check if you can make the change from "Co-developed-by/Signed-off-by:" to "Originally-by:" to acknowledge Ryan Roberts' contribution, when this patch is included in mm-unstable? Please do let me know if it is simpler if I submit a v11 for just this specific patch or for the entire series with this change. I will proceed based on your recommendation. Thanks, Kanchana >=20 > > Signed-off-by: Kanchana P Sridhar >=20 > Acked-by: Johannes Weiner