From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32565E77198 for ; Mon, 6 Jan 2025 17:37:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BADA66B0092; Mon, 6 Jan 2025 12:37:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5DE86B0093; Mon, 6 Jan 2025 12:37:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B1126B0095; Mon, 6 Jan 2025 12:37:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 777086B0092 for ; Mon, 6 Jan 2025 12:37:21 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 312C71C5B09 for ; Mon, 6 Jan 2025 17:37:21 +0000 (UTC) X-FDA: 82977733482.19.CC44702 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf24.hostedemail.com (Postfix) with ESMTP id 66BF418001A for ; Mon, 6 Jan 2025 17:37:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Brvd0MUa; spf=pass (imf24.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736185037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fi/mDxbXRFcfdcHv4TNi0pIJ7ffqmI386E/UQFHqRpY=; b=Fwt47HF90JsNulx1p57o08EZwKepZW07iUOvzLXhpzQDtALjqGLIwEwEqYXDYOkwtrya6e xKwA8A7wewZosZowMAjRUX4zSkLyzf94IddwmxrSjJ8ubBdUOJ9+LYjTcMWpIQ2Gc1a7gb wRXFZcQvSKF7lT/l7uqqoTXKP+T12Uk= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Brvd0MUa; spf=pass (imf24.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736185037; a=rsa-sha256; cv=pass; b=3l6XxififI+ZX+BSDJNqqf0yvzYAPXQMpwNFxK+SjKWGdEL8fLfae2S5yBtFFpJbrp4677 ZHWFO915YWOdGcIiaS025W9xB9GkMbHE7Rg4M6Kih/eDntrwOnMmyuCfe6/7izAFrKoZZR 6cGtCMzcg9NfIwhuy3fmejbrtWVbboA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736185037; x=1767721037; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0fEMsEvzO2+7YboTTJ11lC5sdOyW8HDSSjcQZuUkUrA=; b=Brvd0MUa243KxK8lruOTjnxe1eX4blWWNupQmjXlYYlRR4xfJGXHROS+ brP02OuzQ1ZjnRxVde9q9e/OydzD57t1D3CjLKKOoVEFw72HpU28np6je DBllsfkYL0Ur5YgIHDU0Ak/PUsLQgTlltfEJcqX5H6j+UgSipap25wGUm LCUdzmVUlJx00MRbpxgEKIeuzkxAJhpMIWuuknDPwKrhZnjvItwNefwIW M62PIGOwhvaCZKbEjSVwpCVpGzDRXP/6Ny9lBVfkEv6YX5DKbAav0mbOx H4SlY3JHFPQYtz0/nhOEabVAKQlkampYvUpMCBt+7NkhC8et6bnyp6NMp A==; X-CSE-ConnectionGUID: 0wVSCj+0T3+7lNNv0Ca+bg== X-CSE-MsgGUID: kdytu2lyQqabgki4yL523g== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="36037956" X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="36037956" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:37:16 -0800 X-CSE-ConnectionGUID: nw4viPx1Su2wZXy4oNRiIQ== X-CSE-MsgGUID: ldBjP2jTQ42My23yhPlZhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="102588550" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Jan 2025 09:37:15 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 6 Jan 2025 09:37:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 6 Jan 2025 09:37:14 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 6 Jan 2025 09:37:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oyIDejIE+VQ7GRTDFgag0jUDAjON6AnRp37RsZVKlBwZRs8rX0oGMhd9OP3U6WcLOsTn5ve68P7lyD9fzLMD10DafWQ9Nbd3x8cIXrVKlqNzJoGdk+BwWjKfI4VRUZVf73fts/J2Ppz30AjVs6IInJvLTPSvdK+PmfgAyQvWNAyAC6RWCEbRBucVe6tFEMmCjIQbBv5X3XzZPLGwIWuuNYrPSFzaqKD3Bs/MKoUfPexf9/zE9RlF3/khjRmXHxo8u9OwtAuTcxYyBnKsgpQMiOCf5ZL1sKIKylM0dbMS3RCOOMI7MLtsG2mapJEhbafcsw4Yr/JMrkzlvey4xJWdYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fi/mDxbXRFcfdcHv4TNi0pIJ7ffqmI386E/UQFHqRpY=; b=hRq2+Y7DQ3xB5gqulfVpn/orUIXWNRtuW+kJlWZ3vWEPgFBMLJio511SyMVzEiE+66Y/E4V4CWDhwpKDK/iIHKP9jQbT/mu0sKa8PlCK850e6CgcpHxe35B/GhS/Tr9RdjrM93dsD8whKtPMDJQ6e/WBnHA1mJt6Li4G5hlpfqpAhZSPNYwReAAkYmyUMS7GPxUqLEsVCbQOwtL7LhyZZyVZtRLp8JSPmRTNluUQZhsUM29+j6PtojkimJNfy5WA/O1W3ehAY1xbj7RYCqIkEMDrbnDeYh/PeQduQ268u0lvVZhsu02cwmduGrqYa0TJLUvR1PwPEbkH1irTTKDJ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by IA1PR11MB8150.namprd11.prod.outlook.com (2603:10b6:208:44c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 17:37:07 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%6]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 17:37:07 +0000 From: "Sridhar, Kanchana P" To: Herbert Xu CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosryahmed@google.com" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Thread-Topic: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Thread-Index: AQHbU3H2SqTrZiGQHkmN4NbyUE5ZLrL7lUYAgA58frA= Date: Mon, 6 Jan 2025 17:37:07 +0000 Message-ID: References: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> <20241221063119.29140-3-kanchana.p.sridhar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|IA1PR11MB8150:EE_ x-ms-office365-filtering-correlation-id: 4e626e5f-44da-412c-b88f-08dd2e78bdd8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7416014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?gxB/Ct60WYDhikAkUNN9uA6BmOw3llJAcFdu9JTuP5/TnhZfpc4DC79FJXQW?= =?us-ascii?Q?0/P+d6gGwQU3KOS8sHjTJ++SdT3fP699AjrQqhibiykaIl7xxOdnSrWH6Vpz?= =?us-ascii?Q?0J2ZatzW1lGLWRqYBjCND/TdOAldVlOJAXhCou77WeS9OeL6i7/Bp96a+Mbi?= =?us-ascii?Q?GoxgzawxseczUj6rGZ6QC29qlU4MB2u427Ga5aN4TNcVGNTUqa9cKMhlkMih?= =?us-ascii?Q?maoexUtgTcVdYIpiF11XHIYNTVWeCpIjgsS2V8a+ob07eD79xx6hv+D+ZqIM?= =?us-ascii?Q?u5VzkLqC6XqLD20qcuW7/wAo5BIAdjuvN6XqbAobiMuoJDr6NsknF9/tWaqJ?= =?us-ascii?Q?PUsXdZ3G6I681s80nPQhkt+34UEjFFihfMSAy74RscQTc6LDhAfHB2vbTsgx?= =?us-ascii?Q?6nXWZH4Hy/qDXeUnc67a7RoHLhuY5c1eaqMvS/dMfaqALFwpNB85Y0WL1gWc?= =?us-ascii?Q?KW4RBPvqB6x7b3ckBKGWVBzUMYkL3vb+3mZampVyF7/l3hzUbeS1w920v9Rk?= =?us-ascii?Q?NBvG7WwNt5Vdq/yH5yEpFaIUHOSvRISBEpUzM3t6SauuoKMLG3rZ888Vr7Ws?= =?us-ascii?Q?J5ZszIwDFLyNPZ9C1PRDHIVTLihOSDOOAJjWObqs6I12FbSXkYpvJFp3764a?= =?us-ascii?Q?FBCCibtimICS/GIUDmTdyN+3ENGxy6Y/fMIsJGr4QIAHY2mEDOPN22WGXVim?= =?us-ascii?Q?uxQHibq2wL+OM/pQEnPCceHhxzq9vPBTFWPtXgiBpXZCB04Kh5fMYJKFOFK0?= =?us-ascii?Q?12yQlR3poHXFAAYmRDdvsQZjMYZa/pydtzugr6+KNIZuaykyW24xEs+xPI8O?= =?us-ascii?Q?dJW+UOGPP4MhNEit3bD0Tllk91XpdlH7FzJtiguL+gMwx6lNnYDb/382SJdA?= =?us-ascii?Q?9ulRhoWob9bup4P419qM9FARFiwgMPK3GAV7YCGhnUqWr9GsH3+JlC1kCg7r?= =?us-ascii?Q?LJZN6RYdEu+bI5Zas28Roni8ycSil2I8r0ev+kd/wjCncFBExJwzgYwqc/G8?= =?us-ascii?Q?NH8tY2Q0bD7GO8GLu3Vbo0dtqDx0TQw1XF11C+Hb74TasVH7JZWeWlTro0md?= =?us-ascii?Q?3nv+ZnohLxcwSbP8d1K/Z3Zt4zsHrO+GpEqQotZm0EASJdkY3+Cgplp1yc6G?= =?us-ascii?Q?KMYy3ShKpr1EPzAQE7wAPzW3F7QXGU4Jza9+XpSA9gWBqJCX+qLaAEABR9l2?= =?us-ascii?Q?spNSX1v31zOcnGnTm6goPRFyEOkNp2D/CrbWCBWJl/SZcr89E8a35mesq5Vc?= =?us-ascii?Q?Tum12IOdiuBn2y8AP3gFlwpLbnKMwHJW2DKzWKmTLBu4NnOsVuh653f2JuDT?= =?us-ascii?Q?v421XbMtLQsVuxfHADUUKjthB6Q9zd6CqnQIKyDQACOwrXBTWw8AZ90worNJ?= =?us-ascii?Q?G4pwryLCDxZS2w8h2TEu3QZO9+zjLV3u98wHMwzNmlnLr06GXw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7416014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jaAD8/kt4yqfvK+dvv0WzQ10mfkiTan45vJlkfaTrMNQDrlGBhGB37wXe4Yn?= =?us-ascii?Q?7zrepsVVCoYmnYuTJL2sZGT4x7ea9+HU12bZBcjPCuUk6QmGofyen3pUhvI0?= =?us-ascii?Q?wJRw5LCHHggGhfRWxa6VPTQv7o/P0DsTQ48dzvIasCblhbvx8q1N29bvqmvR?= =?us-ascii?Q?rQ0vXnywowFOQBde72Xje9GsRRSWpNkyJYhs20mCEIZxDWZjWHCR79gXJaUF?= =?us-ascii?Q?+O35bInie8Z1hEZuRIGmLJfOxenS6cX5SQ2jxUx9WapX6qGK5t5P8Kqr46cQ?= =?us-ascii?Q?apMv3qAQlsSJqYEeOWY//I0pMi/ZuceTcmOyi4LpHljaWFEP+RpEYtzHOR6L?= =?us-ascii?Q?JmViGZWuZxC5A/ABD3ZM2wV1sXRY+7glQ/04hxooLjhNmlVfM1oU/TJ6CWhs?= =?us-ascii?Q?WO+TQ9mv8vTz7qrUfYRXwSG2nLrfxXS9jBVMD1gl3zmghO1KKZNYkg84by7R?= =?us-ascii?Q?riMlBajdzidyFXr8snLoOyfbCmcs2/6dVNDZF+NUCVeKO8eF4G7NqtWZfHA+?= =?us-ascii?Q?vLUp/+mzE8U6QGkNLPCjoDgwGXo1JjWkOF48THpFVCBDj/beJL0bWoq/ifWa?= =?us-ascii?Q?PklIvEn5wijY7YQjWTnpXHK38OtAauPvivrcMkVtwIDMLldfmSGPw0MBVyTi?= =?us-ascii?Q?KNFzW/ifrHFQF/bE/V6Y7srvCx6EX76lZvEOOmKL4nvJG6D2DquUhuCziEOI?= =?us-ascii?Q?h32GHaAYS2RNqSpQI58XtdX74g3KVfiO0U7+roPMawTsSlLmtMDvJ5/C/xiT?= =?us-ascii?Q?5NJ3UnmLCuO9MbxTs2yp3cVmH1WiMKs3+RZ40TXY2Dsqjf2Oi9w45Vifli9M?= =?us-ascii?Q?44wIzlPvWx9PkRi7YzIiW1WmfMihLBnhYtKFNr59Pkn3bLcY+21a7UDm+4ld?= =?us-ascii?Q?pHBNIDIzLst/k06gvOFmsBFV1Kafwt9vtBsPY9aSfiCI7I+x+7sk3iir5AZT?= =?us-ascii?Q?A3lgkcE0sjjkKg1neSMTxHTKSPpsl3almHRY2ab7RiiSU/9saghHChlzJVX5?= =?us-ascii?Q?mUNKacvQ7Zr/I+eRdeibNTl+yBXcU7uWt4dw3lJy55Ttn91Se71V0aKVKG18?= =?us-ascii?Q?wt4eVQfqD11pC/u4B/d1e+VoLGkFEWEa/gj3KuRGgkn23ntiR74ABp6N3lEz?= =?us-ascii?Q?ue03n2twpurW6UZxyiXAf7vLbJMwqKn2hYInTTCYrTpeTLz0L4GlH+nUvi8d?= =?us-ascii?Q?HvuAkiabPMJuZ1xTw3bdWeKOpPA3L6YMtp0YMABPgS8cMNzcllkwHTrzKsoW?= =?us-ascii?Q?8iVPLClrADt7Wu2AAaW3W+iekYHMzy/nLTstdX3JLxh7LhR1SxJ1wfz3W3Gm?= =?us-ascii?Q?kMLBLIkOLIbukqnZHuEu3Qbo09p9fcNSkCb/R8oS6rMowO/ojYNR50aRWk03?= =?us-ascii?Q?V2zCqI6xE1imIRrHjvoON3EA9kCORTPldNpMY/INJVeU9tGqbihNOpoRcsXX?= =?us-ascii?Q?Nu0i5TIoz1ve/sQo2jvFU0jXhno8+QP3+9KyhejK2vdLFEfmD0Qzy47PYVu1?= =?us-ascii?Q?qRqXbFWmNDhMHeGpTN9erTsQp3M3ByqffL0SFqHrynvDVgPZg2Ewtd3VWlcb?= =?us-ascii?Q?JxQ96omX4QT7pikJVyhyVF5Qf3cOkSFn+EOx6DasiBW+58qPk0EHYiQLIlGF?= =?us-ascii?Q?CA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e626e5f-44da-412c-b88f-08dd2e78bdd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2025 17:37:07.2158 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rS/x6pQuV6lATMqy4xBAx7J2nZN/DKgw+eO02Uh3ykQyczaa9hADaqbcvC+FQeGdmo2vZyPQZUDnWEqg6+r3sG6l91eXF2i0MyL9cDiUZEE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8150 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 66BF418001A X-Stat-Signature: g3s6rdo9n8ztdngpswo1yybr8wi8sjc6 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736185037-137007 X-HE-Meta: U2FsdGVkX1/GsRXvkyvu9QZ3XfIjkFGGZn9NDkpVumnp+Z9noDECXebF5FuOtWFi+SDQSjCLQJqtbwd7OxsUNLAQAwLBqmMB5/GiHkOLwMofF6XOF0gW9FONMwrejE0ItvAPUl78JR9Xr/9fje+WSJUe9XLf1JExg70eKM67ZMaegKUtS2OZQfFGz0JE8Vafhtw7rPdJxt8+r9reGcH9/q4WkF8BDjIb1Digmh1oi9BUMwZG+s4szJjipr0AkpfPtaJH3/jCuIBjfXuGRmIdGh+tjLAD+M8UbOODTgvAFvnkT6sI3pkQt5rBL4wYQJ6USRXqA3Gzq/6ZPz+sjoZRBcQk5CsvkbKnMYIYhsCqa2harNah1JYa/2CS3nB4lGPd0eVmstfoI7B7QbJYNB7rcQA234HYGq8wSf8scaCABzQW8axNM75MqyHjA+fUBdHP/E4PxSLcRVobtxehf1fXdSlE5+R1X9cX8x8AzP25EgrqP7rLkpcLKmIj9LOnChLhGWO5T4fkYxp6HqKyM0FQLYW0wpdE9XH1jO/lhgOVF6BwJNmRwTR7uLU88WQyySskoNZ9otmPmBrknM+5rddmARpNNnaiBrYyZWqbDf6PXHS6ZyTouHgcsf0BWK1g0u0aO4okr29oR2Aihs9slzRuU+tnIW8DnMm0pnF7lZ/PP7DX6idEs4Th9WWxW1aPjkMd9ue84zwWOYwWtWCDZXLVgzq4U7BM4W8qTNQcWDygXWSUvmvhVC1AK+ZO5gdVFevS86Cm+Roac1JqrVGJag3zL32Gj51cGbhZMIFwJiXTjE/er7bxWLNjWjnYmGYJfxDTthfx/1xZr/ObhAo6zWhXpHDzs6UVmykJbVUxuZKbC1PKbx5ehwQ+qh8k8WUYtFDRJr0tJj5mzN1kqFHQR3jhsFf8QW6Xy1kW64sB+XPbpSUOZplnl9jO0Q5d98oBgvh3h9cEGd89Da7MnxJoR4W VZP3nMdl mNrFFxXn9axz6Y3MXQYNeMdLRWm6WiPPJ5WhtFR3RQRSCoacj9Jy/1WK8J9FHkz9yFAnM0tzmFD0WYpG28cRNA9YR6TEWRJ4fzUDE+eIFJ5QsuzE5I386D3vifhc3Ri91cX1L2KR8pUXprlOjGsws8RBh+Se2AvkQeQ+Sj6OTAnYJh2Mljreu5XuRTzYQdeurn6BIOm7A+2MFEZg5y+vQoV7A527c/2fA55+7NtMrR9NMj+hp279L8B4I+v0xaqBX/9mC6UM11JYuTDnCidrTDkA6q+R6RsMw0FQVdAkN/yiyQculwV1J5oii2UDlLiYrpRoX/S+hVNgCViw0+79CaYFHOZYjjE4sQ4azLuTCOBodnb9evDX4H8Pr/JzH/ucmntVbuvscCgIQ56JyNWZkq5giRjXUIQrniUlqpKccFrUfMvViT0DWPmfL71EbjfSNK7Mj/DOunltMUj+Gn0JQYYh0mI4dpqZn6h3Qc0alx26UaZiyjnYQIScQyiFa0I6uUpLD1/2cm3czPV6vEVSHkF5R3HCf7M8tL3ESqssSNs05hmGXeuO4Bu51CGAZO9QRxcvy8zTzjvwDZHnn4XsUnuDfLeWnxCQf7iliqyhUXsEDnBY86UmQnXuo+YoEsYBaVdR3sITSY1yF5N0ZBevXzPpbcsmi6nSWKcH2xHIWxhodc4pM+vrZxEJEoGUzfVU+HawDtjRTxOeQtp78zMdAcyrHLpkgfRakyve0cJ+i2xOI1tfiEDKFLJPJ6xbsZrQ/HfaRk+bWDXMZKIgkEkEqmQ2B/4XVigSxq6HNenlKqNb+q8MYJwSE0K42VnfWkhBprs6OAiwo/59qTYInNnDTqkXa5orz55qlj5Gr/btfpvoBWwjhY9kCpEfNHcrMtD/VKUWdHoN8EMnaju8wt0PDJQuR9I8D5/iu5N9q5PeIh42eS9LyzDEWtfsfFDFBaqxnUs8JVOqc7pG/+1pxakjJ2rheO+Vr CZlPiI5T BS0MNhgPbhM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Herbert, > -----Original Message----- > From: Herbert Xu > Sent: Saturday, December 28, 2024 3:46 AM > To: Sridhar, Kanchana P > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; yosryahmed@google.com; nphamcs@gmail.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; 21cnbao@gmail.com; akpm@linux-foundation.org; > linux-crypto@vger.kernel.org; davem@davemloft.net; clabbe@baylibre.com; > ardb@kernel.org; ebiggers@google.com; surenb@google.com; Accardi, > Kristen C ; Feghali, Wajdi K > ; Gopal, Vinodh > Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for > compress/decompress batching. >=20 > On Fri, Dec 20, 2024 at 10:31:09PM -0800, Kanchana P Sridhar wrote: > > This commit adds get_batch_size(), batch_compress() and > batch_decompress() > > interfaces to: >=20 > First of all we don't need a batch compress/decompress interface > because the whole point of request chaining is to supply the data > in batches. >=20 > I'm also against having a get_batch_size because the user should > be supplying as much data as they're comfortable with. In other > words if the user is happy to give us 8 requests for iaa then it > should be happy to give us 8 requests for every implementation. >=20 > The request chaining interface should be such that processing > 8 requests is always better than doing 1 request at a time as > the cost is amortised. Thanks for your comments. Can you please elaborate on how request chaining would enable cost amortization for software compressors? With the current implementation, a module like zswap would need to do the following to invoke request chaining for software compressors (in addition to pushing the chaining to the user layer for IAA, as per your suggestion on not needing a batch compress/decompress interface): zswap_batch_compress(): for (i =3D 0; i < nr_pages_in_batch; ++i) { /* set up the acomp_req "reqs[i]". */ [ ... ] if (i) acomp_request_chain(reqs[i], reqs[0]); else acomp_reqchain_init(reqs[0], 0, crypto_req_done, crypto_wait); } /* Process the request chain in series. */ err =3D crypto_wait_req(acomp_do_req_chain(reqs[0], crypto_acomp_compres= s), crypto_wait); Internally, acomp_do_req_chain() would sequentially process the request chain by: 1) adding all requests to a list "state" 2) call "crypto_acomp_compress()" for the next list element 3) when this request completes, dequeue it from the list "state" 4) repeat for all requests in "state" 5) When the last request in "state" completes, call "reqs[0]->base.complete= ()", which notifies crypto_wait. >From what I can understand, the latency cost should be the same for processing a request chain in series vs. processing each request as it is done today in zswap, by calling: comp_ret =3D crypto_wait_req(crypto_acomp_compress(acomp_ctx->reqs[0]), &= acomp_ctx->wait); It is not clear to me if there is a cost amortization benefit for software compressors. One of the requirements from Yosry was that there should be no change for the software compressors, which is what I have attempted to do in v5. Can you please help us understand if there is a room for optimizing the implementation of the synchronous "acomp_do_req_chain()" API? I would also like to get inputs from the zswap maintainers on using request chaining for a batching implementation for software compressors. Thanks, Kanchana >=20 > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt