From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2ABCCEACEC for ; Tue, 1 Oct 2024 17:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57ADD2800C7; Tue, 1 Oct 2024 13:01:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52AD3280068; Tue, 1 Oct 2024 13:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 356BE2800C7; Tue, 1 Oct 2024 13:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19202280068 for ; Tue, 1 Oct 2024 13:01:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8E494416AF for ; Tue, 1 Oct 2024 17:01:36 +0000 (UTC) X-FDA: 82625649792.12.A8E3F8A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf26.hostedemail.com (Postfix) with ESMTP id AF8E7140020 for ; Tue, 1 Oct 2024 17:01:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ImowRCJK; spf=pass (imf26.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727802028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K53Cu0nu1wOcmND0JT1AG0/MBGjiw6j0DDR0Cp4HIIk=; b=IaRvM010kmN8vAd7oXDeg6U3cx0dSFBxiGotlV3vA6yvPWKAw5gkY1Um0n978q7TcxLsJs 8yLcfVYl6ZG+QVG9n1SPjw9BvB7B0bzUASA8Udi22XioUkR9VHJb1Fs/LgDmY8RGf6phTN /km2ubhVpDYynvoHkLF4JLVJ1Mo63k0= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ImowRCJK; spf=pass (imf26.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727802028; a=rsa-sha256; cv=pass; b=e5sRaJxuFRPyka4LQwEja1MJjXjpnD64Cq4vCbg5rZx+uT8+MY0ZY0jMqmoSHMZI6Ly9I3 OWjZvei1DYc3i1wf0F1/rejzFqrTCnoFfOWkx0xUu79DcL6nvh50/uI55onoKvzaam+waQ O4rQiwODDznTbn+i3GHflRA0wMyA3cI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727802093; x=1759338093; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rJk4b1aFdPsP9wcsRwxyT7mxq196KnXblyZXTVN8ulU=; b=ImowRCJKI5YS8ddB8CpKWtxRJgtVxNYxM1s127Cny0qcDtzuwXmOjMtR Pfg/a53jt9pt8Ch0AVKjJXeib2eRDaUqR1NKQJHgC+5UGkrB9KEhd8R0s wp69R5A0K0q9JmNyt1kvIZafF5qu+avfqDguHffRwfuQdajjfHQpGoTrX K5TtqzX+NIugHxy9K/04VTQf8pbavPvyw6s7KrjcqPyn3rIClxrgSxico Sf8SVBl/r6hH8RZgS1LpHVwzvJblxAMRQKRztIDW7HQlYtgH3hoV3Ecx0 deD/oXyoD5sMBxQbBTcx03k8K/OWzBIZlKCs0ZDWmXmD649ZggWCdpkk2 Q==; X-CSE-ConnectionGUID: I36pkAqOTlmVIZMtW8Gx+Q== X-CSE-MsgGUID: TZNPADutSROgNA19tbghOw== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="27082813" X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="27082813" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 10:01:32 -0700 X-CSE-ConnectionGUID: 9zz0a9GsQ/yeWEBWDPGCwg== X-CSE-MsgGUID: m5sG/pNdQNGLrL/sscmISw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="104511899" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 10:01:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:01:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:01:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 10:01:30 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 10:01:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bFq5+grG7+URSnrqzmUgFTRGJDE8U28ygUoZr5++b7s48HXX8GznWSLyYVSMawyjVsFSfQeXnYKqTM1+G3vhFgQfT840sUy5rHO5x/RI04q4x/dD8FfcIO3YNO3f21gNadH7g43A/7/OOyhFk2AobRnUjFoUHyeSr/71mNt37WQEvL332Zq1XaaUpcnw1h7w3dWvZOCIHGWV7vjSQrcDFypLrsBzQ2CAnidwRPzwstATFl1GDFQ/HxWx//2HUexTJaSLK+7HneBnDt4OMmB4Bdc1ZsqipBDnBDC5I9TbzIDxcPtbNqhp+61JCMxKFU4yQkqiqqX9VQa3GqNi8uqzlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K53Cu0nu1wOcmND0JT1AG0/MBGjiw6j0DDR0Cp4HIIk=; b=xXKQIYzkmu+vkGweZzjD07UjYWii2bz6AqYko4SNOxsf3fkO6ToGqTKxxnVHD5LlvMOuC36fXHdzMLO7mFuuYpaCXsiKlpgIqwBKJAfls0lLLwXJP9MUE+Mr2bDkL6PHfjmohEmt7WDDntD+eN30Au+cGdPTL2WsmK2A2RVqYjuhxoXbRhU29MRLf/QcI/HUjNj9sZaca5QHaAv+i9zSz7zNz7V7Im1ex4ng0KGdY4TZ6HyrqbbaNd5oJg9tNZifDdlBZt7TDlDB2POfysiYp+/1q7DLxXpMLZRzSV83U1LF7HOP5d/5DnYxFlw+AHSmz1aHZNblkl+y0kfB3GuA+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by SN7PR11MB6752.namprd11.prod.outlook.com (2603:10b6:806:264::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Tue, 1 Oct 2024 17:01:22 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%4]) with mapi id 15.20.8005.026; Tue, 1 Oct 2024 17:01:22 +0000 From: "Sridhar, Kanchana P" To: Johannes Weiner CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "yosryahmed@google.com" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "willy@infradead.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v10 6/7] mm: zswap: Support large folios in zswap_store(). Thread-Topic: [PATCH v10 6/7] mm: zswap: Support large folios in zswap_store(). Thread-Index: AQHbE8NS/mzK7ddAdUGteugGSqw7kLJxvZiAgABhSHA= Date: Tue, 1 Oct 2024 17:01:22 +0000 Message-ID: References: <20241001053222.6944-1-kanchana.p.sridhar@intel.com> <20241001053222.6944-7-kanchana.p.sridhar@intel.com> <20241001111045.GA1003400@cmpxchg.org> In-Reply-To: <20241001111045.GA1003400@cmpxchg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|SN7PR11MB6752:EE_ x-ms-office365-filtering-correlation-id: e4b71dc8-fd99-435e-9d74-08dce23aad3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?CW7nOVT/DuD7kJo+vgWtI3GCMLh3o4ZV1+54NMdn2rh1U5XAb0b09D8GXc6r?= =?us-ascii?Q?6j6mQwhpOr3L0MU+ywu69ApvZMYMZPxSHfZqhv3v5LQxC1kVe2AL5skHwKHq?= =?us-ascii?Q?V2w7dKKg05vEJJ+rVpjwPwKkWg6dBXQfksbB5tP08aYyMT3QWRC+d/mZkDUS?= =?us-ascii?Q?Olg9jA7lDunPl5jL+crTyM8SCiuuDH2o8kI+EaCyeH7DEAVY59LztxLPYxq9?= =?us-ascii?Q?trzgqzc2QVjKS7nEoRqd7bFOAshQE4kotKWQkF6VKamVmTiadR50Ad+oumuq?= =?us-ascii?Q?ALbX4Lw5aSaj9ziMb0+M/up2n3J1CXCv6IWBY4ax+9rQUoPgdcsaa7ZRFtfm?= =?us-ascii?Q?rfDZB3vQfEjUT3GIGnFwkgROF0Qqn5hIo0LgT6RsCtWldv1gQqw8W3qYodvg?= =?us-ascii?Q?r+YGbAuBdIO1BfJaG3W3tD9ip+ZxQRC/CjgPMpRsEHWxNOXMDWjLV3YWPX0N?= =?us-ascii?Q?P4GWYyw34IV0ecO2VlI6Btwcw9irMxzpH/6eWAzEm2Rbo6eBKAaSqEtZHvAM?= =?us-ascii?Q?G9VE8zmhEmGDru9qU8lCh/Ezjj9smPogrtq3RegarAmS51Riur39nGfYei9y?= =?us-ascii?Q?Pp4p06bNOjmswArcG5EpQUF5vHLldiUMofEP8By0jgjAxGjxBKNgsSqmtYfn?= =?us-ascii?Q?LtWd/e0ec0g+oKaTQTAMNwxoqPvlNyvdwaOHJgHL6lB9mXRcuktbCT43C64d?= =?us-ascii?Q?UJWS5KPQCWPB8HWMHYireM7bVdvLwMdh1AUTabXQUSoJ3LPqfXkUDx16iZtm?= =?us-ascii?Q?oNuc64wh2SfSgEfihLlqtX4uRU5lAAT5TYyKYbMxKMlz7gY/Gjva75Kbltzy?= =?us-ascii?Q?mnYPbL5q98pjLTrCnVDR/es1X5XDMqm7eEe4pTrDnS5DFNY0Di0xaRHY+EZx?= =?us-ascii?Q?HKGnJtb8k4hEtyr5KTpknmmXsxd5UT2hrSZo+i1LZGPZ2jhPKzUjL6LSI5eU?= =?us-ascii?Q?NPEv5/Kg8eOeZlV9sFdEQravk0ERhdLNbyjLoUU2AWwfHsSyTvulrO578eqA?= =?us-ascii?Q?QRQeJdtjDACqeFgMKpBOvtTm6BzuasI+orkRTWYopkK+J8n+4ruo+cOKcOsj?= =?us-ascii?Q?m3RCGLczan4+oBDNrpvgLgDjy//y9gnyJhRaPXfshXJ/qBtX3j4pZKzcO3a+?= =?us-ascii?Q?vvx5SbXul4Q+3mNk6g6xZ2jNoQagTIg/HZQhkCRrtzjMqYkl0UOW5BuGMSoq?= =?us-ascii?Q?umwM8prfy33ow3LgbCb2U+sfyyB3JLKFapJK0m9zyxdpaXX/GXVpuMMy/oj8?= =?us-ascii?Q?6fuNQ/hLKDVQYJMQ8DgRRhw/0Uk/iibSXuMm6Y+R2+SNroq4YHZfkbKGxUyA?= =?us-ascii?Q?Q4zUTr0Nzt+iHJkweDbVhSvKNppRr2kdcqv9+6gtpyZ2SM3k7R6ATCmD6ykj?= =?us-ascii?Q?cChPfyI=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yX+m6IcEyKEwPvYCLh0FZPCW8HQvF8k9guaz7RNfqDKW36AbbB+jYbnHRDp2?= =?us-ascii?Q?HCvm4hyhdwrIaMKrkcoH6VRdZeIEdvSNWVTnNAkDvS7T9ccHTOyay5XsEzWs?= =?us-ascii?Q?1Q+Gg1NG2rcbRSzrARl29g6YvSWCDXKQIvnqFrB2Vd98xI7SvbWNMXK8S/qi?= =?us-ascii?Q?8e67yS/ps/kCAtJ87t2l58IXqx03/wWOnS2oug1yJurGKnWiOdRwC2Fzyv4X?= =?us-ascii?Q?ZZeTRGvKkAp62eZMFpuB3BXqP+SV9UyZrbnMyTQQCyy0upSS9tPpotp3lKJ5?= =?us-ascii?Q?gdBscfUtqPmm6/A9bq0eVTUkdwDo/PBuDDFrJitVJAz3lqydE6HKX/A1dqBO?= =?us-ascii?Q?Pexcp8e4zb7MnzR1bVw0uo3woMHL7G3rqGfFSzqoBHJpUohsn81DjRmrr66j?= =?us-ascii?Q?SHIFQ/WN7jRc9ProlLYk6j3WoSDnFKeWucj200pB8xdiYlviTXABRKROcPSb?= =?us-ascii?Q?kCxjmXmEUKAu78qQdZ4iyK5uO6PqwER7sLpC3aC9m4793evPyD6NzvTXZwV9?= =?us-ascii?Q?8ZZiLZr6o2J+Bt0T7dD8prvJ/4hJGrzsI0K0zImBOz4slRf0uia7GQioYsBj?= =?us-ascii?Q?HylGJRjaril37hSIVNgOc2xqXcn4pvUD7tmTCr9IDs3UkfTMz4hcniB+L4Dr?= =?us-ascii?Q?SytD6p6Wpe08AJ4xXm3r7I7EixSJryiEazDB3VoPRW6cjwtHyl+PWeJXHa70?= =?us-ascii?Q?AkprW3AwhlW7ONoulsOCiviXMbgQ+++MadQ2py8nvKTPNAPNQRCSigy9gyAf?= =?us-ascii?Q?crTavdxtyDGXgjYYnC0wu6W0pSNbap4r9R3w97xSLWh/ka7FiI9H5mFpURFc?= =?us-ascii?Q?VYKDE8iFtOtWmBKiFeTeIVpOcXJi8Sw0lbJuhpjF+3FP5PTvdwi9StYvi32o?= =?us-ascii?Q?nfMF+xkJTgAsePCYfMX5gKCIYHtBfSNNLRdWbUmt0XyzMStTB4lG2lO4Lq0+?= =?us-ascii?Q?t+LZDFuUQbNQsJyrKXiYdN2uvhcoFSRIvp7Fbh2SpRNULDoky1c9/Dh241y+?= =?us-ascii?Q?0MIRHIjbjk9T/QlxaOFpfPqYbTq27iSYeUeLEW40K9em3ozWxXBD9MThi1Mb?= =?us-ascii?Q?c9agVmq4y5DiX1cikTIfOTB6gS6NlVPBCPuCmn+6Fkc8DSDJsqRUM+sniz9x?= =?us-ascii?Q?89jloQRGZeRkPuLU2DPlSlrZ5xzQr6+HUK8N0bclTjrE1orysF2ZX/+OldCi?= =?us-ascii?Q?ndMEudlrqweYjlSJwQTNjFr+PD36Ma/Tg4PmsYLNood0mu12sVFvVnl4zrB9?= =?us-ascii?Q?lCPZRks2LmpuKCrZVuq8U6SKTYcArZz+nUElSGzt5ClberFWifKQvHkauKve?= =?us-ascii?Q?4OcoqVal6WFjw+nkZzBjuPSf6LiTrIhJx8awJCZcSDbwFL6FPxy43h1rNgqK?= =?us-ascii?Q?mjwa4gV65c+iNWPaxw2Fe7XqZkq/tGH4aBWyWmK/bnGwSSNQq7rm2a7lJHba?= =?us-ascii?Q?sgWMebTwvLj5s1P1WIgp7tUKlwiB4Gzfsjy2a72bVAJfaBievL4FVz8FTKKv?= =?us-ascii?Q?rwl5OUyQDtRoWQ+RkZEBOZE9sS0BeqW3ApIuRMhzfeTi1qgjCkeBuG5r07n8?= =?us-ascii?Q?wszObrSo6qSOq3LkG6lZpvZhGDBm6GVfIWHYdopgdGvTbmF6W5hGz4hl7Yis?= =?us-ascii?Q?0g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4b71dc8-fd99-435e-9d74-08dce23aad3b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2024 17:01:22.1894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ITphs967Dc0WAAd/O1R8jf0wTx1bgEsQHgtCjTWgSBMalNEM6Tjozo/+fGzfaebc9A8ONs0Sj31yQzIGS9a+c/3wAwmXp+OHR1hDiNB+DpM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6752 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AF8E7140020 X-Stat-Signature: 3ui3nby1kr8f8emrtkibd85du9pzx9ze X-HE-Tag: 1727802092-160659 X-HE-Meta: U2FsdGVkX183xtGGbRVlww+8nxcLWVEcCri6AtIqZcXe0mLvpVxCp38fhZH2eQU0REIkveNf/Y6n8i8RCPW8wF+TFtTEWBh6m66PVhcJCPYqTM16L6I7mO9u+VQSiO+R+7Ntivtr5yMugeeDHhJEQGLbRridkVECnuCYvo4vhLJJXC6Y9UKIqU/ZhD5jdZpimkCFh+dje9u9lZgV6CKQYcRNX/C5jbhNNrqtQxf/7cRPdrOIij9DSy5MWeAbwB9IWVzjvwSrtbgRI+FxCQjR/iHAIvwbai6/93THZfhPbiC1A5p9rnBtGLbmI22KhiB6nRYiKjI60F0BP37wrqjEmjPKaNOI5O5Pv2dRABXsG7DORVtytU04flItpKCWohKW5Jwg+d2uvHzMNebk96jt8Vwq0bOTXe/3oFkCU6rf9p0tOQRHDQKgrIQcLj4+QRuS2qlKelEm9b9oZB105pzTgm1ukoBYmU+thWFLSGglxJenX+XcNJLrcl1wdHyPj5Y3A/MfjsLT7OWf5XodgzcmaeV2heyjzC3bLX/M+OP3sDAa8mcZNYylO5gi12sfLSnLiAs5ARgRE2+PGhTa2Y/7c6Z3UT70jl5GAt2FCe635mvF3J1IePwXatCuCHlJ8OveqSHbM2hVqcSlmeAHfZsc3Jal6cf6uv8HLPztwbeGDYvhwKtszUyNzAb/wejeItV//rOkdqAJNQ4DuIIiFRvqTnwEyUXyvR2bBkzNNSbLkz675z15Z82zhuZ3h9HYcs1sGBL5pIaMftULdn/hfIwjlA8xT0wlIUHu2vr/I6T5v6F8NJ4X2knWm1HnEBHOmpMLUkZKCKq7U3DUd9EZAfWhTprBs08F/YD8JBkGIXhgZl2fmMLFtphPuwXpSqJ9zs1EbfLXPHVQTzqa+WWnPzXBsbdJCpiWFHFpxR5uXDboAsdgwJuU3vrlHBWu41lyrQ020+Nt4JLc6Ym9HG8+wXJ X6fkTym0 /vMvLbyyCk9/9iJ82QqBUQprFK6y9WGGx2BFwvjr/gikLOsNIRYc8y2X3uDHN1oKGm7pf0QcjSNE5MS61m6RrAwGi9xn/WvzeFwuWVHJPMIi7EN3NeptCrqDwlbRhSTY8BniTi/PL0s7Ao0gh7U0w9zOOBVEOBiSpxi7dQA1J2SnlY16M1y+yOLciW0dfBP5dXZwl5baf/9SxtUFwaZMlyEFtifdhMhvOXc2H2EKvT6Uh7mi58rZc/CWlfSVIsmfdhg/az2/y/5WEmkuDsdm9TJXWpuJQqegjP5+6EgKMZX+40VJM/OM8pPaxql121ZVKIgwucCLAA+9kca16a4uNBAiMItOVgjaWIHwGJHko8RCdDsQb4SZbKmREvBC5ubvL3Cl0OIrqO3EnfPQ7FGj3wXCeR3ahOAZdQR8r4ZIoRc3Oe9ssZ8F04aGFGmBkw2ayBvOWOxZ4r6pbzJ8k/epk+c3Xn0ryacFi7p4OOlPTeGsi42l9tM1uUE3ekDwVZjJcxBqgfc/VtePP+byGrwM9sH89AtziVZ6nsVpxITfgaexIo6WitMg5nojzKv06qoll+dgazeX5t+ap4E1MaMW7LD5idkghvHz0xucxe8+w0JMfuYIsqD8NUbqIMtkXkrKb/sb4rJBjMDnE1P1rafHMnIF5cmGrFtxEvxctR4c2zNrDN32trG+YUSe8AOkq2dYUZsbXdWShjEXE0iRlF3CunWVFloSUaWmY+1ICeJ2kTmq+zIQ2Zgd7a10mqQaY7uAxSpOqTTpxtksAsLZXGv+UhZNNapeW1vpNJM84pAK8J/Io201zgW2GaQF1ey5R1YEoaOABPyuWdGJ7GEUMgGZe9FT5gHzoBx5IQZ81KjoFGZApxHVj4kt3tc8d6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Johannes Weiner > Sent: Tuesday, October 1, 2024 4:11 AM > To: Sridhar, Kanchana P > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > yosryahmed@google.com; nphamcs@gmail.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > shakeel.butt@linux.dev; ryan.roberts@arm.com; Huang, Ying > ; 21cnbao@gmail.com; akpm@linux-foundation.org; > willy@infradead.org; Zou, Nanhai ; Feghali, Wajdi K > ; Gopal, Vinodh > Subject: Re: [PATCH v10 6/7] mm: zswap: Support large folios in > zswap_store(). >=20 > On Mon, Sep 30, 2024 at 10:32:21PM -0700, Kanchana P Sridhar wrote: > > zswap_store() will store large folios by compressing them page by page. > > > > This patch provides a sequential implementation of storing a large foli= o > > in zswap_store() by iterating through each page in the folio to compres= s > > and store it in the zswap zpool. > > > > zswap_store() calls the newly added zswap_store_page() function for eac= h > > page in the folio. zswap_store_page() handles compressing and storing e= ach > > page. > > > > We check the global and per-cgroup limits once at the beginning of > > zswap_store(), and only check that the limit is not reached yet. This i= s > > racy and inaccurate, but it should be sufficient for now. We also obtai= n > > initial references to the relevant objcg and pool to guarantee that > > subsequent references can be acquired by zswap_store_page(). A new > function > > zswap_pool_get() is added to facilitate this. > > > > If these one-time checks pass, we compress the pages of the folio, whil= e > > maintaining a running count of compressed bytes for all the folio's pag= es. > > If all pages are successfully compressed and stored, we do the cgroup > > zswap charging with the total compressed bytes, and batch update the > > zswap_stored_pages atomic/zswpout event stats with folio_nr_pages() > once, > > before returning from zswap_store(). > > > > If an error is encountered during the store of any page in the folio, > > all pages in that folio currently stored in zswap will be invalidated. > > Thus, a folio is either entirely stored in zswap, or entirely not store= d > > in zswap. > > > > The most important value provided by this patch is it enables swapping = out > > large folios to zswap without splitting them. Furthermore, it batches s= ome > > operations while doing so (cgroup charging, stats updates). > > > > This patch also forms the basis for building compress batching of pages= in > > a large folio in zswap_store() by compressing up to say, 8 pages of the > > folio in parallel in hardware using the Intel In-Memory Analytics > > Accelerator (Intel IAA). > > > > This change reuses and adapts the functionality in Ryan Roberts' RFC > > patch [1]: > > > > "[RFC,v1] mm: zswap: Store large folios without splitting" > > > > [1] https://lore.kernel.org/linux-mm/20231019110543.3284654-1- > ryan.roberts@arm.com/T/#u > > > > Co-developed-by: Ryan Roberts >=20 > I would change that to >=20 > Originally-by: Ryan Roberts >=20 > > Signed-off-by: >=20 > and drop this for now. Thanks Johannes. Sure, this sounds good. Should I post a v11 for just this specific patch which this change, or a v11 for the entire series? >=20 > > Signed-off-by: Kanchana P Sridhar >=20 > Acked-by: Johannes Weiner Many thanks! Really appreciate the code review and comments. Thanks, Kanchana