From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525A7D65C42 for ; Thu, 14 Nov 2024 06:37:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC3296B0088; Thu, 14 Nov 2024 01:37:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B2C6B0089; Thu, 14 Nov 2024 01:37:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89DE16B008A; Thu, 14 Nov 2024 01:37:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 68E966B0088 for ; Thu, 14 Nov 2024 01:37:19 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1469A14024C for ; Thu, 14 Nov 2024 06:37:19 +0000 (UTC) X-FDA: 82783742916.04.B184AD9 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf06.hostedemail.com (Postfix) with ESMTP id A1AC518040D for ; Thu, 14 Nov 2024 06:36:43 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M1JehmVo; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731566172; a=rsa-sha256; cv=pass; b=5OSdMnFOgNBm+f+6YOPfKKYQhlB/nEU9sANheCWgT6B9xd+vybuf/cUTJ5bBjBCVdj8CfA NFl1qj7p4+SftcLTt35FqYYJsScjQUte9xX9AqUvR+z/QGMQ4pwuDINnb1uqVtAfO5vyun qfuCZfB796u1T2wTGxSDsU6PvS4ARYg= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M1JehmVo; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731566172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4XY/GPO89TFFzYxLMoRWhV0TNC0mfkWbdVAPN5/78w8=; b=VwHJDHK2EqqJnT29b3cKvYcCvM1kxL0y0/4pAk52fnM/VnqZBgEteDs3WKz05DYjIGKjHD 8DdyZ3YjKtExVAKgY4QpcXNFRXTbdq3Az6bbahoE0OLM5SodnUVhZlL7Z80G3bZtoJrmwD 4/BzSrwRDZyLZZycPi7Y4bVl/bF44uo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731566235; x=1763102235; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4XY/GPO89TFFzYxLMoRWhV0TNC0mfkWbdVAPN5/78w8=; b=M1JehmVo08WbISG3U+x1RTzNVBW4digbMqB/jLYU1B9GiS/da5FQc1KY JWInDhWn3HRsfB5DbHwmFrlFuvEQ7bSohrVyscv8ke6P7ooL9ygBFUeon UZJ7EgC85fuaIs8vhYAWhE1j1j3MbXryex7P5IvZTHCK6ukAUu3THjx9M haD8IiILqGpD17v8rTb7q6pA7/lwhX/XkRSS4YZpCDwRUxw1lvRiqGrZf 5qhOwzCJJT/A0GXIzBgEdu3BzjoPG7YrVR0l695s6hoohJMtELTCDqOWa lws5T8DYo2CiIHfap9vJj/2nmutwPfxTRxhFBmbLqBxLs9ef7LZxmM89P A==; X-CSE-ConnectionGUID: j2vrz3w3Q9ujbtIb3RVgVA== X-CSE-MsgGUID: M6wIe105TH+N1F4MoYn1WQ== X-IronPort-AV: E=McAfee;i="6700,10204,11255"; a="31370092" X-IronPort-AV: E=Sophos;i="6.12,153,1728975600"; d="scan'208";a="31370092" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2024 22:37:13 -0800 X-CSE-ConnectionGUID: WwdDsIxqTwudlqyYs8Y/vw== X-CSE-MsgGUID: sHhnbKevThCBeR6hL/WOQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,153,1728975600"; d="scan'208";a="92566687" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Nov 2024 22:37:13 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 13 Nov 2024 22:37:13 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 13 Nov 2024 22:37:13 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 13 Nov 2024 22:37:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HY1ny7kqWmhdQq4yrcQDGC6sqFryobzRbtGHioL5ogTmGlVILcrTdjrcECo6Rb9u7hLS0dV/03JA+aLpP/P+CM9AlPa2BWHM4mxE3PIJKS4ikWi8mERUIdNksImp6l2WWav5n2zN5hRA31NomBQRf/cMxTzt8LP5aT8wxqtdbRtEw2MJeFJ8kX9xom2F62u0ObRv+0pBYFP2QBWeZcS6aF/qcAScIySY9vs1LbRqwfaSffceseI23A5+Fzf4moeFik35gNu9ZAWE780a3jod5hZBTC4H4njITDgLyN/w32stkN22VzEOPPphWD812tT2tfrdRVFbXKU8CT3ValE6Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4XY/GPO89TFFzYxLMoRWhV0TNC0mfkWbdVAPN5/78w8=; b=lvdPXsBdt067ovZz3+EFkbqUD5sQlBODwrKxfggNOo6gr9d/E+jC458G+qrghesBLmsgBsWaHyN4spdIqkTTaY715CZLocRwW5jRCBQCJ9o8LxfOFQ0iJB1jxz0pKq5GyGcLBrSC7zHz8nrc/8kIWvQX3D0AUNgbmHAOy95YZ8fBj2waNpspAzjlzDSzysprefW5RF+krlsbd31cJp9IwW0ZRBWg4+24vRF87meHrRDP/V/K3mZHcbn+Rk4nN3NaboblDqgmSK8IIMhwtwcuZzHMi3Ik0egGQSxsFwR/8vqBv4NoJGxSVPIUnzv0+B1TmIrZzBBSrBmFUBkDyGjO+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5678.namprd11.prod.outlook.com (2603:10b6:a03:3b8::22) by DS0PR11MB6493.namprd11.prod.outlook.com (2603:10b6:8:c3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.18; Thu, 14 Nov 2024 06:37:10 +0000 Received: from SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c]) by SJ0PR11MB5678.namprd11.prod.outlook.com ([fe80::812:6f53:13d:609c%4]) with mapi id 15.20.8158.013; Thu, 14 Nov 2024 06:37:09 +0000 From: "Sridhar, Kanchana P" To: Johannes Weiner CC: Nhat Pham , Yosry Ahmed , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v1] mm: zswap: Fix a potential memory leak in zswap_decompress(). Thread-Topic: [PATCH v1] mm: zswap: Fix a potential memory leak in zswap_decompress(). Thread-Index: AQHbNYxgo97ShYNp0k+eAlG8E2BdYbK0sGWAgAAC9UCAAAo2gIAAydcggAAz64CAAATjwIAALQAAgAAWEyCAADkJgIAAFDJA Date: Thu, 14 Nov 2024 06:37:09 +0000 Message-ID: References: <20241113052413.157039-1-kanchana.p.sridhar@intel.com> <20241113213007.GB1564047@cmpxchg.org> <20241114051149.GC1564047@cmpxchg.org> In-Reply-To: <20241114051149.GC1564047@cmpxchg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5678:EE_|DS0PR11MB6493:EE_ x-ms-office365-filtering-correlation-id: 87743fd7-43da-4efd-4326-08dd0476c3c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?znYfHNIoQugQfFFvng3CR8tRPNO+zVx+VgcYQBW2gP8kI1J/df7Q+ZEzDx46?= =?us-ascii?Q?8T/uTDy2NUQi5GbxFGj3MMGrtUDojUXC4GCHPUtOr12k1nWU4Fvy+qml0uJu?= =?us-ascii?Q?K9pOoCY4Gz5n7RrZ9JZ7htqAQB/VPzyLszC8LOxLDbGH26tDZwcPKxgN4mm/?= =?us-ascii?Q?PAHvfhbJNhaiSC1Fwmh86EhAVwoTRiLf/vUBivpQhmqQIrbRFmySsVMPH7r+?= =?us-ascii?Q?YJTq5zGD1mn1nuRWqytu1g10i8kk6S3f3KdzE5XqQlD4f+YwWBZi5LWQbwqR?= =?us-ascii?Q?5bfuOsEgdGerVPfSGRSh4zBZY/0eoRvMpZF2KfZXt69lMUEYkZcvyRp+/DOy?= =?us-ascii?Q?WiD1XZ99khRCOF3bpG3C4pek4IyO/GzyNXpbr1iuJibHR/4pQdkXFX4Tr9ND?= =?us-ascii?Q?d3cy+S/JTepebg6yzuMIY36Cmy9nnZf9IiqWTDS5K8hkc3Ogj5OF5KvwY9Hb?= =?us-ascii?Q?FElCB7IOxqJmA7KnLv/zDGsttY+bREzeSdLZ4Js9cmhBctsR4fSi3mnveJKU?= =?us-ascii?Q?DzTrxSvKpcVFOAZdqKd3aEWq99bgC5aXQbfQ7vskx8iy55AloYOLVeRB4+wj?= =?us-ascii?Q?F3MZAmTkEtDAeNj66PgSN6FGuZgZXgoHjuIhoVII3k+jSE+iJAPupp3gRPgL?= =?us-ascii?Q?YG1NEEcmuPzYeMHTgm3csdx4440fqLmlaFSMq0VfKtGzscSlHXICpVnNjFcn?= =?us-ascii?Q?HkZzOlPWTzNqIMsM7vUaYQDI5KW36bqIAzlFNxSdIwY7i1kDTtwq7dRc/xPx?= =?us-ascii?Q?//YYGrSL8oVCcFcNC6BYqP9BKf+Slpcyekv4h7yoUOSAcH//3YBksw3jrtbI?= =?us-ascii?Q?wIFrC8kgK5RxdO78lkbYIW1VCYvnL/5Y4wLNCJa0g4/BfF/wUeC8PvdWlZh+?= =?us-ascii?Q?ALr9wkxYCDRZRoJOQFwNndamhuoRuNM3pIQshCVqDj+X6hoLRczIN/cbfgUN?= =?us-ascii?Q?iCj2EQvX0vyWF7pFwwSQcodJKRjOAXtfK7rnVibjVAvXSQFQGqlGVbMOfVpK?= =?us-ascii?Q?p7nWzHmIUGRKh3dPQhMjyD4TfYtn5skPbtBGuFkdvcRGynnOD0aQUxk6Tjno?= =?us-ascii?Q?RaewgwQTIoIklTYM9ZRsHn57/uggQOYP3nz32zFYwA69N8sMt1+7CdCssKBz?= =?us-ascii?Q?WD7oTt4h8VkrOJd4GzaV+Z0F//XAEquzOmdD6bk95riN7PRdKwuEOZ9b43gl?= =?us-ascii?Q?MMp5DNFxakYOdSnuXjd0I3bFI1JXF1174Ej3fLx+6e87zn6b9wTDkQJXBwRV?= =?us-ascii?Q?EiFVvYp6lAEEmBo9t3e0AaeAHQcc6o3urnsb6siaetDk6VTRGXTop4ypcq9O?= =?us-ascii?Q?TXM657AJGoVIu/cX+Jgf1ImMtk/JTEgZiQ+VtA7VQwVq/y8XXEgvRRIGpmYv?= =?us-ascii?Q?F3MY0M8=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5678.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mKTp3UQrVzX3xwVRpyE9TT4ovVynW9quuonbfEYdYXUQXaXr3aOFSW8TPayC?= =?us-ascii?Q?VlKuYt7Kb/+sPoHTT1tPirpsr+s0h5qsgQzEasdCuVt+p3CTge7bLgLJJlpT?= =?us-ascii?Q?+wyIHsfe9DNJwLCf2BOtlrtKGK/4U4LwpNwKQ7kAsRgLDkndF0l+gDmtGpuB?= =?us-ascii?Q?3AKnqALmd0RNMr/kLoMqE0acYqVkG6yaSowhVp76qDbQpBbxL4M3A4vsK1Dy?= =?us-ascii?Q?a47aq/iTwl/Y44+cJX4TMeHGHI/7hvBdjh3PrTu+7CuI0JP/qchJCFtlmeiJ?= =?us-ascii?Q?EuZLvA0hW+qM2d/lmjybjUbghLY7EE+N6TmRDIO9IppdyospWRh7ePttIHNo?= =?us-ascii?Q?aNBbOhpd7UZGe7OPdNJApYQGonUbZZ7qfBVnx8yAhvAfUmAw40GYF7bUq+i/?= =?us-ascii?Q?CIpCmlpDqZSoC6WM3ns5j8kK4HunDFAg53+bb/d04QcIBWz7C/F3H+3q326M?= =?us-ascii?Q?8P8pEkPcs885XC9Xa17pDUiuWjcujgPiJbjFRxjXooctueAMB+EUKoK50nqH?= =?us-ascii?Q?mfL61JB7GPYzTlV02PtHMIY2frUNjz8Dp8llGHg7vTyEK2hL0oIPxwY8/7Mj?= =?us-ascii?Q?WpQKTplCFM7jckr2li2jI4g2WLpSmKuteFhAmdvJmg+yg29xLKcsycWiV633?= =?us-ascii?Q?4g3SPqm5tyPoLSD+esYeCi3Olv20n+A0GePji9czB7bWS1wD1StbLuZwch+y?= =?us-ascii?Q?ZW+MQdsA55DwwlKjT1SQtOJOoGMU7tvgNA2WxplM6hZFN4wWmEEe1ZAbNuXW?= =?us-ascii?Q?JgQh468QlIqRt6OLAp5NOhfH+7fiD94eRpHIabaNKklpXGcmlRZ9zKt+BaeX?= =?us-ascii?Q?UgDwS9LpRtLPCul8s8J5Ol8FYXPazUmZEEv3nAXbOX26mcNfCKWm1MYeETyG?= =?us-ascii?Q?T/1g1myuBayJmY9wtYZVIGSsjEWFJ5HKPSMPp6gxgsbJ2IWSXaSIDeNyVXKb?= =?us-ascii?Q?z6/2qZ9U2OM0MycSYqYxZtaBLBOPc3ZEqzQ29pge0Xg/8RmKEc6xaRj4oOPV?= =?us-ascii?Q?c1csp7CpioL0fd4j0obKlappLBhk6P7biTYT6iRa7Sa/qOA+C1lHzo/qFbU8?= =?us-ascii?Q?WiBCfijq2POBsPvwG+dhKvdHjwKXlR7mCiE+JWXHHvKswwnd9RZF8ainOzEZ?= =?us-ascii?Q?wBvwgEECLVr+QZqbkI9oTEPHutwUrCXCHpeMeTpZOQ3nQOdugFPyvJgVlYwm?= =?us-ascii?Q?ZgxwLTGJRN/Eb01tv+G87YXbtcOkcEZ82m1V9HmxT5LAgD/DIW48+OwQhugf?= =?us-ascii?Q?E/4ps2mq08Ql55DU3TVBXnA8umRhvtaOAyA9VtXIPLXCPXNz8zJjmjfXEM1T?= =?us-ascii?Q?raU1cg6Grw/nBTkgk6FuQjVhRFEymTEMYGhcIGWzU0HbNZlA97GQfG97Y9SY?= =?us-ascii?Q?pNK2eKUAGPA3uEZBtYuCEIwfwrctrAZmyTjzG85354NTg+nS7t2x0ED9CdvJ?= =?us-ascii?Q?TmCTjjih/xLFgTUxjAdRh4d26NaHC+x+0WZ1ZAKSWAonVjLsi0AkySbhThbN?= =?us-ascii?Q?yGDDwYJQ/e5zG5GFmMKQsZamJ9wUE1RjELcfJIDLSSMD3RZHfqInaOllGsqk?= =?us-ascii?Q?3jmjJcOFuMNoq8NGotETLASHAYD6F95xx/zqtVxDnZH+lwh4uPc7SRgdbsAV?= =?us-ascii?Q?Fw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5678.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87743fd7-43da-4efd-4326-08dd0476c3c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2024 06:37:09.3283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S6ijqCn53OwI6Bq8Midvpjpb7mCIhLtwPs5oNx7qCBC/kuJ2TeYOeG8RqZJyqcSbgsMIVifU3TZYqQaJYFNYhHm1cdnqxUxqNdJtdX6wIN0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6493 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: A1AC518040D X-Rspamd-Server: rspam11 X-Stat-Signature: stc4iohajhjzg5ftfchnnkwahytamx98 X-HE-Tag: 1731566203-113508 X-HE-Meta: U2FsdGVkX1+3utZJjzixtLgzi8kz8ixsoTpGYbl0pY0RCk2qm2bkRqN0hIHqRnWYg95+kvsGGvOmLCyXPykDhrGlCNiWVy2SJYAvDfAQUcez1BMEOgyNFyidYOZubnIT4MdlEqBbMsefLu873DKpswycYa7o/dZ53hLoVpGgXmgRgc5u1mgwaxzSY7IknL1G/fKUlY7JP3godE2agLzSo4N6kRv6ih03aV92i82wJlNw24uEGRltzS9jLCiwROklr6vXTX5Y5CqFfn2P6sITRb0E6BRJxNpAhQnJjMysMSBtf2ollQH5yEznuGiwpyIP0TW240bKehPOdh+P+o06Odi7B1BjxGt9E7cL2iRLe/Cf/A3OxIif3WMwlqWU4bC+d4RTwgBXJpao9VgOMhiaOnB7qTGbscGi1nrRTlZY2EzmuBk4bROkOCcfx0YloxiUlSUSfIzx19/Uybg/WEWsvo7UPoQyOgt+VQr4nkPNhdn/9EunrkWXAlHZQsTZOYKfTf1EAgjnoepyYcoa6eub3jtElhbPgIE1/ouXC8ylm0nOvNfYWVTQd0E/n2g1+a3LroWSzz7z1co1bIpmCXMxbQrUMqKW8+E+3lyys+uPuTwb9VWrSULfNz5iA/b1edq7rTtBasCjWD5cqEpkLOLC1dTTnunoFo4HpN/2H/gXSnnIHOiILBW98w1zVEU60gGmhyeBgtXlZmY8ekdttc8VxG7+pASKdfr22UuCrUcmtHYHZqgq1ir5Vl1heDk/6AZ82NqhmS3AhZMArGIrIajpIx94byl2lNzISvLt5IoXE+F5GFp3rCJP34P2yDViazUB2lJ5FEzlmqAzNmYDIsJTTckzpKQOYF/ixHnggoWys2SMGIklpM4rtuQSq+HLboT9JlWwJlEdtqwbhLJilEUKL3f9tjD5FyQRQXlVgAdPplxocvE2kkEqPSR/rbFco8QhOUhgO8bOleRdu+TU1jH qDZWBmVr ZsYJjz6nd5MD0L5Jde3n6wJgh5GoFgyRCHTWAjXgQVstR837PQA4KO/T2mYwCq5Rr8LGpHaiStC88k7GwhMwHuZpGAqFsYcu64Wp8VUpquud5R6bSLxBLzYU5NwJaY3+P2EOeBJNWHEmn0b/PVAgaxN8ktLuOyJw+TZtoJa9rJqfcSYuzlAT2NHlbZsy/y9gRJedsKufy45s03jefvozzaiYa/k3bfkLl1qF9hCylRz5H0qnZT9j8DpFGBrZbMJFwDd97q0cBaC9HDWMWMBGsGgPUlXqRkwwVXiRhNVc1xEnKYZxp+vpEXjtRC0UBTLEhW5KmbyCo09xyTdDswfSlCv1c4C0yKhHsIrAzxhEV1j9TB+3zrSOt/dXpMvwtPMVwcfeJl1SfCKMnUMkICq7Z3TZK3Prw1qEloMxBSTFH2wpIRZ7L2n+ZumAafH0wZDBodV3xqgZYpNOOqpA9x8UAG5agRkSmzQxrV0Ll8kNQ68wsBamnySl9BvlUppkwDyPEaWiXZ3mwSD1jLiujHXviJwTeU7y66JnTjgEVMacgltHaHL7rBGvaG39SR+IoB08BWhZSWMbo3xPmwGn2H0FnjDoom1kgIZTFDwlfhy5MOcUdjdPKaLCXLbPIADJXDPTAkcJuNUljrthBIA8QxOleVLVwgK3nG9LMgKVirpG4y0/Adl2tG6ju11pfzjlO4wdILfdh3tN1uGEZPk5RD24D3/u8gsL199UMbZOiXXjakSCg8/n9cJuZUONkviDicSkTzAgKLW6xS5+V/7pfPQWgGNJmc+ivyEVY96eY0T7pTJZsRzEOWfPbDSCHZZKz5HHh3cCziRyl/UHQCW84yZUlwMwkelM+VbIc0B3v/mkKxDw59KA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Johannes Weiner > Sent: Wednesday, November 13, 2024 9:12 PM > To: Sridhar, Kanchana P > Cc: Nhat Pham ; Yosry Ahmed > ; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; Huang, Ying ; > 21cnbao@gmail.com; akpm@linux-foundation.org; Feghali, Wajdi K > ; Gopal, Vinodh > Subject: Re: [PATCH v1] mm: zswap: Fix a potential memory leak in > zswap_decompress(). >=20 > On Thu, Nov 14, 2024 at 01:56:16AM +0000, Sridhar, Kanchana P wrote: > > So my question was, can we prevent the migration to a different cpu > > by relinquishing the mutex lock after this conditional >=20 > Holding the mutex doesn't prevent preemption/migration. Sure, however, is this also applicable to holding the mutex of a per-cpu structure obtained via raw_cpu_ptr()? Would holding the mutex prevent the acomp_ctx of the cpu prior to the migration (in the UAF scenario you described) from being deleted? If holding the per-cpu acomp_ctx's mutex isn't sufficient to prevent the UAF, I agree, we might need a way to prevent the acomp_ctx from being deleted, e.g. with refcounts as you've suggested, or to not use the acomp_ctx at all for the check, instead use a boolean. Thanks, Kanchana