linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "liwenyu01@bilibili.com" <liwenyu01@bilibili.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"wangyun@bilibili.com" <wangyun@bilibili.com>
Subject: 答复: [External]Re: [PATCH RFC] delayacct: add memory reclaim delay in get_page_from_freelist
Date: Tue, 5 Sep 2023 02:56:07 +0000	[thread overview]
Message-ID: <SH0PR01MB05875A39079E3DB81D47B472C1E9A@SH0PR01MB0587.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <20230902164454.30dda58820ced683849b45cb@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 2104 bytes --]


reclaim of the task in do_try_to_free_pages(). In systems with NUMA
> open, some tasks occasionally experience slower response times, but the
> total count of reclaim does not increase, using ftrace can show that
> node_reclaim has occurred.
>
> The memory reclaim occurring in get_page_from_freelist() is also due to
> heavy memory load. To get the impact of tasks in memory reclaim, this
> patch adds the statistics of the memory reclaim delay statistics for
> __node_reclaim().




>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -8010,6 +8010,7 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in
>
>         cond_resched();
>         psi_memstall_enter(&pflags);
> +       delayacct_freepages_start();
>         fs_reclaim_acquire(sc.gfp_mask);
>         /*
>          * We need to be able to allocate from the reserves for RECLAIM_UNMAP
> @@ -8032,6 +8033,7 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in
>         memalloc_noreclaim_restore(noreclaim_flag);
>         fs_reclaim_release(sc.gfp_mask);
>         psi_memstall_leave(&pflags);
> +       delayacct_freepages_end();
>
>         trace_mm_vmscan_node_reclaim_end(sc.nr_reclaimed);

__node_reclaim() calls shrink_node() which at some point will call
do_try_to_free_pages() (yes?), which calls delayacct_freepages_start().

So we're effectively nesting calls to delayacct_freepages_start(),
which isn't designed for that?


本?件??指定收件人使用并可能包含保密信息,若您?收到本?件,敬?通知?件人,并立即?除本?件及所有副本。您不得擅自?播、??、保存或复制此?件(含附件)。感?您的理解与配合。
This message may contain confidential information, and is intended only for the use of the addressee(s) named above. If you have received this message in error, please contact the sender immediately and delete all copies from your system. You are hereby notified that any dissemination, distribution, preservation or copying of this message and/or attachments is strictly prohibited. Thank you for your understanding and cooperation.

[-- Attachment #2: Type: text/html, Size: 5561 bytes --]

  reply	other threads:[~2023-09-05  2:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  9:54 liwenyu01
2023-08-31  7:26 ` liwenyu01
2023-09-02 23:44   ` Andrew Morton
2023-09-05  2:56     ` liwenyu01 [this message]
2023-09-05  5:32     ` liwenyu01
2023-09-06  0:53       ` Education Directorate
2023-09-07 11:52         ` liwenyu01

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SH0PR01MB05875A39079E3DB81D47B472C1E9A@SH0PR01MB0587.CHNPR01.prod.partner.outlook.cn \
    --to=liwenyu01@bilibili.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wangyun@bilibili.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox