From: Maxwell Bland <mbland@motorola.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"dennis@kernel.org" <dennis@kernel.org>,
"tj@kernel.org" <tj@kernel.org>, "cl@linux.com" <cl@linux.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"shikemeng@huaweicloud.com" <shikemeng@huaweicloud.com>,
"david@redhat.com" <david@redhat.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"anshuman.khandual@arm.com" <anshuman.khandual@arm.com>,
"willy@infradead.org" <willy@infradead.org>,
"ryan.roberts@arm.com" <ryan.roberts@arm.com>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
"pcc@google.com" <pcc@google.com>,
"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"gshan@redhat.com" <gshan@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"james.morse@arm.com" <james.morse@arm.com>,
Andrew Wheeler <awheeler@motorola.com>
Subject: RE: [PATCH] arm64: allow post-init vmalloc PXNTable
Date: Tue, 13 Feb 2024 19:35:27 +0000 [thread overview]
Message-ID: <SEZPR03MB67864221134F49E9BE3B1FB9B44F2@SEZPR03MB6786.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <SEZPR03MB67865557061A2494B1A1243CB44F2@SEZPR03MB6786.apcprd03.prod.outlook.com>
> -----Original Message-----
> From: Maxwell Bland On Tuesday, February 13, 2024 1:15 PM
> > From: Mark Rutland <mark.rutland@arm.com>
> > How does this work with other allocations of executable memory? e.g. modules,
> > BPF?
>
> It should work.
> - kernel/bpf/core.c uses bpf_jit_alloc_exec to create executable code regions,
> which is a wrapper for module_alloc. In the interpreted BPF case, we do not
> need to worry since the pages storing interpreted code are NX and can be
> marked PXNTable regardless.
Correction: I was wrong here. The _weak reference to bpf_jit_alloc_exec is overwritten in
arch/arm64/net/bpf_jit_comp.c to use a vmalloc call. This would need to be set back to
the generic BPF's use of "module_alloc". I will look into and correct this.
prev parent reply other threads:[~2024-02-13 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 16:05 Maxwell Bland
2024-02-13 16:58 ` Greg KH
2024-02-13 17:16 ` [External] " Maxwell Bland
2024-02-13 17:30 ` Greg KH
2024-02-13 20:18 ` Maxwell Bland
2024-02-13 17:48 ` Mark Rutland
2024-02-13 19:15 ` Maxwell Bland
2024-02-13 19:35 ` Maxwell Bland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SEZPR03MB67864221134F49E9BE3B1FB9B44F2@SEZPR03MB6786.apcprd03.prod.outlook.com \
--to=mbland@motorola.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=awheeler@motorola.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=pcc@google.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox